commit 2a87adc21b8177a94521b994e58c6f9d6bbb11a6
author cparsons <cparsons@google.com> Thu Apr 18 10:48:20 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Apr 18 10:49:26 2019 -0700
tree 9f5ccbf3026e6d221b89d87b109a6bfe169c9631
parent c7d430fe089c8de1918a7835148418af0163d77f

Classify native module legacyNamed parameters.

These parameters were marked as "keyword-specifiable because of legacy infrastructure limitations". Some such parameters are specified by keyword almost universally: these parameters are migrated to "keyword-specifiable by intention". Others are kept under "legacyNamed" to be deprecated with --experimental_restrict_named_params

Progress toward #5010

RELNOTES: None.
PiperOrigin-RevId: 244216657

src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkNativeModuleApi.java

diff --git a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkNativeModuleApi.java b/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkNativeModuleApi.java
index d430e8c..d61a25f 100644
--- a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkNativeModuleApi.java
+++ b/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkNativeModuleApi.java
@@ -59,21 +59,21 @@
             type = SkylarkList.class,
             generic1 = String.class,
             defaultValue = "[]",
-            legacyNamed = true,
+            named = true,
             doc = "The list of glob patterns to include."),
         @Param(
             name = "exclude",
             type = SkylarkList.class,
             generic1 = String.class,
             defaultValue = "[]",
-            legacyNamed = true,
+            named = true,
             doc = "The list of glob patterns to exclude."),
         // TODO(bazel-team): accept booleans as well as integers? (and eventually migrate?)
         @Param(
             name = "exclude_directories",
             type = Integer.class,
             defaultValue = "1",
-            legacyNamed = true,
+            named = true,
             doc = "A flag whether to exclude directories or not.")
       },
       useAst = true,
@@ -98,6 +98,7 @@
         @Param(
             name = "name",
             type = String.class,
+            // TODO(cparsons): This parameter should be positional-only.
             legacyNamed = true,
             doc = "The name of the target.")
       },
@@ -147,7 +148,7 @@
             name = "srcs",
             type = SkylarkList.class,
             generic1 = String.class,
-            legacyNamed = true,
+            named = true,
             doc = "The list of files to export."),
         // TODO(bazel-team): make it possible to express the precise type ListOf(LabelDesignator)
         @Param(
@@ -155,7 +156,7 @@
             type = SkylarkList.class,
             defaultValue = "None",
             noneable = true,
-            legacyNamed = true,
+            named = true,
             doc =
                 "A visibility declaration can to be specified. The files will be visible to the "
                     + "targets specified. If no visibility is specified, the files will be visible "
@@ -165,7 +166,7 @@
             type = SkylarkList.class,
             generic1 = String.class,
             noneable = true,
-            legacyNamed = true,
+            named = true,
             defaultValue = "None",
             doc = "Licenses to be specified.")
       },