| commit | 2fc1aa023072096e12fb89f7371ae81701e659b1 | [log] [tgz] |
|---|---|---|
| author | mschaller <mschaller@google.com> | Tue Mar 03 11:16:50 2020 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Mar 03 11:18:09 2020 -0800 |
| tree | 6d92e62188848cdc2143476672e527123c9c8e4e | |
| parent | 854bb903fe7621f95931506615be48198cbf9bd6 [diff] |
Delete bad action execution comment, write BES "exit code" warning comment Minor cleanups. RELNOTES: None. PiperOrigin-RevId: 298648964
diff --git a/src/main/java/com/google/devtools/build/lib/actions/ActionExecutedEvent.java b/src/main/java/com/google/devtools/build/lib/actions/ActionExecutedEvent.java index 895b3d01..ecc6c28 100644 --- a/src/main/java/com/google/devtools/build/lib/actions/ActionExecutedEvent.java +++ b/src/main/java/com/google/devtools/build/lib/actions/ActionExecutedEvent.java
@@ -167,6 +167,10 @@ .setType(action.getMnemonic()); if (exception != null && exception.getExitCode() != null) { + // TODO(b/150405553): This statement seems to be confused. The exit_code field of + // ActionExecuted is documented as "The exit code of the action, if it is available." + // However, the value returned by exception.getExitCode().getNumericExitCode() is intended as + // an exit code that this Bazel invocation might return to the user. actionBuilder.setExitCode(exception.getExitCode().getNumericExitCode()); } if (stdout != null) {
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java index 2789396..dffc60a 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java
@@ -1218,7 +1218,6 @@ } } - // Success in execution but failure in completion. reportActionExecution( eventHandler, primaryOutputPath,