commit 30c028762f7bfbbf3a7f1a14afcb4c2f482d5adb
author David Ostrovsky <david@ostrovsky.org> Wed Aug 12 12:26:36 2020 -0700
committer Tony Aiuto <aiuto@google.com> Wed Sep 02 16:07:17 2020 -0400
tree 5356816f9550121ee0d5a7a02a3451e05b2f3a79
parent 5072f6f2eb5e76ccb39e1e1b9298d5d519fb1434

Allow hyphen char in workspace name

Closes #11837.

Closes #11838.

PiperOrigin-RevId: 326286694

src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java b/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java
index 7198736..ab98b38 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java
@@ -49,8 +49,8 @@
 /** A collection of global Starlark build API functions that apply to WORKSPACE files. */
 public class WorkspaceGlobals implements WorkspaceGlobalsApi {
 
-  // Must start with a letter and can contain letters, numbers, and underscores
-  private static final Pattern LEGAL_WORKSPACE_NAME = Pattern.compile("^\\p{Alpha}\\w*$");
+  // Must start with a letter and can contain letters, numbers, underscores and hyphens.
+  private static final Pattern LEGAL_WORKSPACE_NAME = Pattern.compile("^\\p{Alpha}[\\w-]*$");
 
   private final boolean allowOverride;
   private final RuleFactory ruleFactory;