Google Git
Sign in
bazel / bazel / 33d43e68cfa15b42861ec85aa0666b9965525c69 / . / src / test / java / com / google / devtools / build / lib / rules / android / AndroidLibraryTest.java
blob: 6f9b4c12d398e49019a44c048d5749c468652cce [file] [log] [blame]
// Copyright 2017 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.rules.android;
import static com.google.common.base.Verify.verifyNotNull;
import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.Truth.assertWithMessage;
import static com.google.devtools.build.lib.actions.util.ActionsTestUtil.prettyArtifactNames;
import static com.google.devtools.build.lib.rules.java.JavaCompileActionTestHelper.getClasspath;
import static com.google.devtools.build.lib.rules.java.JavaCompileActionTestHelper.getCompileTimeDependencyArtifacts;
import static com.google.devtools.build.lib.rules.java.JavaCompileActionTestHelper.getDirectJars;
import static com.google.devtools.build.lib.rules.java.JavaCompileActionTestHelper.getJavacArguments;
import static com.google.devtools.build.lib.rules.java.JavaCompileActionTestHelper.getProcessorpath;
import static com.google.devtools.build.lib.rules.java.JavaCompileActionTestHelper.getStrictJavaDepsMode;
import com.google.common.base.Function;
import com.google.common.base.Joiner;
import com.google.common.base.Splitter;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.devtools.build.lib.actions.Action;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.util.ActionsTestUtil;
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
import com.google.devtools.build.lib.analysis.OutputGroupInfo;
import com.google.devtools.build.lib.analysis.actions.FileWriteAction;
import com.google.devtools.build.lib.analysis.actions.SpawnAction;
import com.google.devtools.build.lib.analysis.config.CoreOptionConverters.StrictDepsMode;
import com.google.devtools.build.lib.analysis.configuredtargets.FileConfiguredTarget;
import com.google.devtools.build.lib.analysis.configuredtargets.OutputFileConfiguredTarget;
import com.google.devtools.build.lib.analysis.configuredtargets.RuleConfiguredTarget;
import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.lib.cmdline.RepositoryName;
import com.google.devtools.build.lib.collect.nestedset.NestedSet;
import com.google.devtools.build.lib.rules.android.AndroidLibraryAarInfo.Aar;
import com.google.devtools.build.lib.rules.java.JavaCompilationArgsProvider;
import com.google.devtools.build.lib.rules.java.JavaCompilationInfoProvider;
import com.google.devtools.build.lib.rules.java.JavaCompileAction;
import com.google.devtools.build.lib.rules.java.JavaExportsProvider;
import com.google.devtools.build.lib.rules.java.JavaInfo;
import com.google.devtools.build.lib.rules.java.JavaRuleOutputJarsProvider;
import com.google.devtools.build.lib.rules.java.JavaSemantics;
import com.google.devtools.build.lib.skyframe.ConfiguredTargetAndData;
import com.google.devtools.build.lib.vfs.PathFragment;
import java.util.Arrays;
import java.util.List;
import java.util.Set;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests for {@link AndroidLibrary}. */
@RunWith(JUnit4.class)
public class AndroidLibraryTest extends AndroidBuildViewTestCase {
@Before
public void setupCcToolchain() throws Exception {
getAnalysisMock().ccSupport().setupCcToolchainConfigForCpu(mockToolsConfig, "armeabi-v7a");
}
@Test
public void testSimpleLibrary() throws Exception {
scratch.file("java/android/BUILD", "android_library(name = 'a', srcs = ['A.java'])");
getConfiguredTarget("//java/android:a");
}
@Test
public void testBaselineCoverageArtifacts() throws Exception {
useConfiguration("--collect_code_coverage");
ConfiguredTarget target =
scratchConfiguredTarget(
"java/a",
"a",
"android_library(",
" name='a',",
" srcs=['A.java'],",
" deps=[':b'],",
")",
"android_library(",
" name='b',",
" srcs=['B.java'],",
")");
assertThat(baselineCoverageArtifactBasenames(target)).containsExactly("A.java", "B.java");
}
// regression test for #3169099
@Test
public void testLibrarySrcs() throws Exception {
scratch.file("java/srcs/a.foo", "foo");
scratch.file(
"java/srcs/BUILD",
"android_library(",
" name = 'valid',",
" srcs = [",
" 'a.java',",
" 'b.srcjar',",
" ':gvalid',",
" ':gmix',",
" ],",
")",
"android_library(",
" name = 'invalid',",
" srcs = [",
" 'a.foo',",
" ':ginvalid',",
" ],",
")",
"android_library(",
" name = 'mix',",
" srcs = [",
" 'a.java',",
" 'a.foo',",
" ],",
")",
"genrule(name = 'gvalid', srcs = ['a.java'], outs = ['b.java'], cmd = '')",
"genrule(name = 'ginvalid', srcs = ['a.java'], outs = ['b.foo'], cmd = '')",
"genrule(name = 'gmix', srcs = ['a.java'], outs = ['c.java', 'c.foo'], cmd = '')");
assertSrcsValidityForRuleType("//java/srcs", "android_library", ".java or .srcjar");
}
// regression test for #3169095
@Test
public void testXmbInSrcsDoesNotThrow() throws Exception {
reporter.removeHandler(failFastHandler);
scratchConfiguredTarget("java/xmb", "a", "android_library(name = 'a', srcs = ['a.xmb'])");
}
@Test
public void testSlashInIdlImportRoot() throws Exception {
scratchConfiguredTarget(
"java/com/google/android",
"avocado",
"android_library(",
" name = 'avocado',",
" idl_parcelables = ['tropical/fruit/Avocado.aidl'],",
" idl_import_root = 'tropical/fruit',",
")");
}
@Test
public void testAndroidLibraryWithIdlImportAndNoIdls() throws Exception {
checkError(
"java/com/google/android",
"lib",
"Neither idl_srcs nor idl_parcelables were specified, "
+ "but 'idl_import_root' attribute was set",
"android_library(",
" name = 'lib',",
" srcs = ['Dummy.java'],",
" idl_import_root = 'src',",
")");
}
@Test
public void testAndroidLibraryWithIdlImportAndIdlSrcs() throws Exception {
scratchConfiguredTarget(
"java/com/google/android",
"lib",
"android_library(",
" name = 'lib',",
" idl_srcs = ['Dummy.aidl'],",
" idl_import_root = 'src',",
")");
}
@Test
public void testAndroidLibraryWithIdlImportAndIdlParcelables() throws Exception {
scratchConfiguredTarget(
"java/com/google/android",
"lib",
"android_library(",
" name = 'lib',",
" idl_parcelables = ['src/android/DummyParcelable.aidl'],",
" idl_import_root = 'src',",
")");
}
@Test
public void testAndroidLibraryWithIdlImportAndBothIdlTypes() throws Exception {
scratchConfiguredTarget(
"java/com/google/android",
"lib",
"android_library(",
" name = 'lib',",
" idl_srcs = ['src/android/Dummy.aidl'],",
" idl_parcelables = ['src/android/DummyParcelable.aidl'],",
" idl_import_root = 'src',",
")");
}
@Test
public void testAndroidLibraryWithIdlImportAndEmptyLists() throws Exception {
scratchConfiguredTarget(
"java/com/google/android",
"lib",
"android_library(",
" name = 'lib',",
" idl_srcs = [],",
" idl_parcelables = [],",
" idl_import_root = 'src',",
")");
}
@Test
public void testAndroidLibraryWithIdlPreprocessed() throws Exception {
scratchConfiguredTarget(
"java/com/google/android",
"lib",
"android_library(",
" name = 'lib',",
" idl_srcs = ['src/android/Dummy.aidl'],",
" idl_preprocessed = ['src/android/DummyParcelable.aidl'],",
")");
}
@Test
public void testCommandLineContainsTargetLabelAndRuleKind() throws Exception {
scratch.file("java/android/BUILD", "android_library(name = 'a', srcs = ['A.java'])");
JavaCompileAction javacAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/android:liba.jar");
String commandLine = Iterables.toString(getJavacArguments(javacAction));
assertThat(commandLine).contains("--target_label, //java/android:a");
}
@Test
public void testStrictAndroidDepsOff() throws Exception {
useConfiguration("--strict_java_deps=OFF");
scratch.file(
"java/android/strict/BUILD",
"android_library(",
" name = 'b',",
" srcs = ['B.java'],",
")");
Artifact artifact = getFileConfiguredTarget("//java/android/strict:libb.jar").getArtifact();
JavaCompileAction compileAction = (JavaCompileAction) getGeneratingAction(artifact);
assertThat(getStrictJavaDepsMode(compileAction)).isEqualTo(StrictDepsMode.OFF);
}
@Test
public void testStrictAndroidDepsOn() throws Exception {
scratch.file(
"java/android/strict/BUILD",
"android_library(",
" name = 'b',",
" srcs = ['B.java'],",
")");
Artifact artifact = getFileConfiguredTarget("//java/android/strict:libb.jar").getArtifact();
JavaCompileAction compileAction = (JavaCompileAction) getGeneratingAction(artifact);
assertThat(getStrictJavaDepsMode(compileAction)).isEqualTo(StrictDepsMode.ERROR);
}
@Test
public void testStrictAndroidDepsWarn() throws Exception {
useConfiguration("--strict_java_deps=WARN");
scratch.file(
"java/android/strict/BUILD",
"android_library(",
" name = 'b',",
" srcs = ['B.java'],",
")");
Artifact artifact = getFileConfiguredTarget("//java/android/strict:libb.jar").getArtifact();
JavaCompileAction compileAction = (JavaCompileAction) getGeneratingAction(artifact);
assertThat(getStrictJavaDepsMode(compileAction)).isEqualTo(StrictDepsMode.WARN);
}
@Test
public void testFixDepsToolEmpty() throws Exception {
scratch.file("java/android/BUILD", "android_library(name = 'b', srcs = ['B.java'])");
Artifact artifact = getFileConfiguredTarget("//java/android:libb.jar").getArtifact();
JavaCompileAction action = (JavaCompileAction) getGeneratingAction(artifact);
List<String> commandLine = getJavacArguments(action);
assertThat(commandLine).containsAtLeast("--experimental_fix_deps_tool", "add_dep").inOrder();
}
@Test
public void testFixDepsTool() throws Exception {
useConfiguration("--experimental_fix_deps_tool=auto_fixer");
scratch.file("java/android/BUILD", "android_library(name = 'b', srcs = ['B.java'])");
Artifact artifact = getFileConfiguredTarget("//java/android:libb.jar").getArtifact();
JavaCompileAction action = (JavaCompileAction) getGeneratingAction(artifact);
List<String> commandLine = getJavacArguments(action);
assertThat(commandLine).containsAtLeast("--experimental_fix_deps_tool", "auto_fixer").inOrder();
}
@Test
public void testJavaPluginProcessorPath() throws Exception {
scratch.file(
"java/test/BUILD",
"java_library(",
" name = 'plugin_dep',",
" srcs = [ 'ProcessorDep.java'],",
")",
"java_plugin(",
" name = 'plugin',",
" srcs = ['AnnotationProcessor.java'],",
" processor_class = 'com.google.process.stuff',",
" deps = [ ':plugin_dep' ],",
")",
"android_library(",
" name = 'to_be_processed',",
" plugins = [':plugin'],",
" srcs = ['ToBeProcessed.java'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/test:to_be_processed");
OutputFileConfiguredTarget output =
(OutputFileConfiguredTarget) getFileConfiguredTarget("//java/test:libto_be_processed.jar");
JavaCompileAction javacAction = (JavaCompileAction) getGeneratingAction(output.getArtifact());
assertThat(getProcessorNames(javacAction)).contains("com.google.process.stuff");
assertThat(getProcessorNames(javacAction)).hasSize(1);
assertThat(
ActionsTestUtil.baseArtifactNames(
getInputs(javacAction, getProcessorpath(javacAction))))
.containsExactly("libplugin.jar", "libplugin_dep.jar");
assertThat(
actionsTestUtil()
.predecessorClosureOf(getFilesToBuild(target), JavaSemantics.JAVA_SOURCE))
.isEqualTo("ToBeProcessed.java AnnotationProcessor.java ProcessorDep.java");
}
// Same test as above, enabling the plugin through the command line.
@Test
public void testPluginCommandLine() throws Exception {
scratch.file(
"java/test/BUILD",
"java_library(",
" name = 'plugin_dep',",
" srcs = [ 'ProcessorDep.java'],",
")",
"java_plugin(",
" name = 'plugin',",
" srcs = ['AnnotationProcessor.java'],",
" processor_class = 'com.google.process.stuff',",
" deps = [ ':plugin_dep' ],",
")",
"android_library(",
" name = 'to_be_processed',",
" srcs = ['ToBeProcessed.java'],",
")");
useConfiguration("--plugin=//java/test:plugin");
ConfiguredTarget target = getConfiguredTarget("//java/test:to_be_processed");
OutputFileConfiguredTarget output =
(OutputFileConfiguredTarget) getFileConfiguredTarget("//java/test:libto_be_processed.jar");
JavaCompileAction javacAction = (JavaCompileAction) getGeneratingAction(output.getArtifact());
assertThat(getProcessorNames(javacAction)).contains("com.google.process.stuff");
assertThat(getProcessorNames(javacAction)).hasSize(1);
assertThat(
ActionsTestUtil.baseArtifactNames(
getInputs(javacAction, getProcessorpath(javacAction))))
.containsExactly("libplugin.jar", "libplugin_dep.jar");
assertThat(
actionsTestUtil()
.predecessorClosureOf(getFilesToBuild(target), JavaSemantics.JAVA_SOURCE))
.isEqualTo("ToBeProcessed.java AnnotationProcessor.java ProcessorDep.java");
}
@Test
public void testInvalidPlugin() throws Exception {
checkError(
"java/test",
"lib",
// error:
getErrorMsgMisplacedRules(
"plugins",
"android_library",
"//java/test:lib",
"java_library",
"//java/test:not_a_plugin"),
// BUILD file:
"java_library(",
" name = 'not_a_plugin',",
" srcs = ['NotAPlugin.java'],",
")",
"android_library(",
" name = 'lib',",
" plugins = [':not_a_plugin'],",
" srcs = ['Lib.java'],",
")");
}
@Test
public void testDisallowDepsWithoutSrcsWarning() throws Exception {
useConfiguration("--experimental_allow_android_library_deps_without_srcs=true");
checkWarning(
"android/deps",
"b",
// message:
"android_library will be deprecating the use of deps to export targets implicitly",
// build file
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'b',",
" deps = [':a'],",
")");
}
@Test
public void testDisallowDepsWithoutSrcsError() throws Exception {
checkError(
"android/deps",
"b",
// message:
"android_library will be deprecating the use of deps to export targets implicitly",
// build file
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'b',",
" deps = [':a'],",
")");
}
@Test
public void testAlwaysAllowDepsWithoutSrcsIfLocalResources() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = glob(['res/**']),",
" deps = [':a'],",
")");
scratch.file(
"java/android/res/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
useConfiguration("--experimental_allow_android_library_deps_without_srcs=false");
getConfiguredTarget("//java/android:r");
assertNoEvents();
}
@Test
public void testTransitiveDependencyThroughExports() throws Exception {
scratch.file(
"java/test/BUILD",
"android_library(",
" name = 'somelib',",
" srcs = ['Lib.java'],",
" deps = [':somealias'],",
")",
"android_library(",
" name = 'somealias',",
" exports = [':somedep'],",
")",
"android_library(",
" name = 'somedep',",
" srcs = ['Dependency.java'],",
" deps = [ ':otherdep' ],",
")",
"android_library(",
" name = 'otherdep',",
" srcs = ['OtherDependency.java'],",
")");
ConfiguredTarget libTarget = getConfiguredTarget("//java/test:somelib");
assertThat(
actionsTestUtil()
.predecessorClosureAsCollection(
getFilesToBuild(libTarget), JavaSemantics.JAVA_SOURCE))
.containsExactly("Lib.java", "Dependency.java", "OtherDependency.java");
assertNoEvents();
}
@Test
public void testTransitiveStrictDeps() throws Exception {
scratch.file(
"java/peach/BUILD",
"android_library(",
" name='a',",
" exports=[':b'],",
")",
"android_library(",
" name='b',",
" srcs=['B.java'],",
" deps=[':c'],",
")",
"android_library(",
" name='c',",
" srcs=['C.java'],",
")");
useConfiguration("--strict_java_deps=ERROR");
ConfiguredTarget a = getConfiguredTarget("//java/peach:a");
Iterable<String> compileTimeJars =
ActionsTestUtil.baseArtifactNames(
JavaInfo.getProvider(JavaCompilationArgsProvider.class, a).getDirectCompileTimeJars());
assertThat(compileTimeJars).contains("libb-hjar.jar");
assertThat(compileTimeJars).doesNotContain("libc-hjar.jar");
assertNoEvents();
}
@Test
public void testEmitOutputDeps() throws Exception {
scratch.file(
"java/deps/BUILD",
"android_library(",
" name = 'a',",
" exports = [':b'],",
")",
"android_library(",
" name = 'b',",
" srcs = ['B.java'],",
")");
useConfiguration("--java_deps");
JavaCompileAction aAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/deps:liba.jar");
List<String> aOutputs = prettyArtifactNames(aAction.getOutputs());
assertThat(aOutputs).doesNotContain("java/deps/liba.jdeps");
JavaCompileAction bAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/deps:libb.jar");
List<String> bOutputs = prettyArtifactNames(bAction.getOutputs());
assertThat(bOutputs).contains("java/deps/libb.jdeps");
assertNoEvents();
}
@Test
public void testDependencyArtifactsWithExports() throws Exception {
scratch.file(
"java/classpath/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['A.java'],",
" deps = [",
" ':b',",
" ':c',",
" ],",
")",
"android_library(",
" name = 'b',",
" exports = [':d'],",
")",
"android_library(",
" name = 'c',",
" srcs = ['C.java'],",
" exports = [':e'],",
")",
"android_library(",
" name = 'd',",
" srcs = ['D.java'],",
")",
"android_library(",
" name = 'e',",
" srcs = ['E.java'],",
")");
JavaCompileAction aAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/classpath:liba.jar");
List<String> deps =
prettyArtifactNames(getInputs(aAction, getCompileTimeDependencyArtifacts(aAction)));
assertThat(deps)
.containsExactly(
"java/classpath/libc-hjar.jdeps",
"java/classpath/libd-hjar.jdeps",
"java/classpath/libe-hjar.jdeps");
assertNoEvents();
}
@Test
public void testSrcsLessExportsAreDisallowed() throws Exception {
checkError(
"java/deps",
"b",
"android_library will be deprecating the use of deps to export targets implicitly",
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'b',",
" deps = ['a'],",
")");
}
@Test
public void testExportsWithStrictJavaDepsFlag() throws Exception {
scratch.file(
"java/exports/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'b',",
" srcs = ['b.java'],",
" exports = ['a'],",
")",
"android_library(",
" name = 'c',",
" srcs = ['c.java'],",
" deps = [':b'],",
")");
useConfiguration("--strict_java_deps=WARN");
JavaCompileAction javacAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/exports:libc.jar");
assertThat(prettyArtifactNames(getInputs(javacAction, getDirectJars(javacAction))))
.containsExactly("java/exports/libb-hjar.jar", "java/exports/liba-hjar.jar");
assertNoEvents();
}
@Test
public void testExportsRunfiles() throws Exception {
scratch.file(
"java/exports/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
" data = ['data.txt'],",
")",
"android_library(",
" name = 'b',",
" srcs = ['b.java'],",
" exports = [':a'],",
")");
ConfiguredTarget bTarget = getConfiguredTarget("//java/exports:b");
assertThat(Arrays.asList("data.txt", "liba.jar", "libb.jar"))
.isEqualTo(ActionsTestUtil.baseArtifactNames(getDefaultRunfiles(bTarget).getArtifacts()));
assertNoEvents();
}
@Test
public void testTransitiveExports() throws Exception {
scratch.file(
"java/com/google/exports/BUILD",
"android_library(",
" name = 'dummy',",
" srcs = ['dummy.java'],",
" exports = [':dummy2'],",
")",
"android_library(",
" name = 'dummy2',",
" srcs = ['dummy2.java'],",
" exports = [':dummy3'],",
")",
"android_library(",
" name = 'dummy3',",
" srcs = ['dummy3.java'],",
" exports = [':dummy4'],",
")",
"android_library(",
" name = 'dummy4',",
" srcs = ['dummy4.java'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/com/google/exports:dummy");
List<Label> exports =
JavaInfo.getProvider(JavaExportsProvider.class, target).getTransitiveExports().toList();
assertThat(exports)
.containsExactly(
Label.parseAbsolute("//java/com/google/exports:dummy2", ImmutableMap.of()),
Label.parseAbsolute("//java/com/google/exports:dummy3", ImmutableMap.of()),
Label.parseAbsolute("//java/com/google/exports:dummy4", ImmutableMap.of()));
assertNoEvents();
}
@Test
public void testSimpleIdl() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'idl',",
" idl_srcs = ['a.aidl'],",
")");
getConfiguredTarget("//java/android:idl");
assertNoEvents();
}
@Test
public void testIdlSrcsFromAnotherPackageFails() throws Exception {
reporter.removeHandler(failFastHandler);
scratch.file("java/android/a/BUILD", "exports_files(['A.aidl'])");
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'idl',",
" idl_srcs = ['//java/android/a:A.aidl'],",
")");
getConfiguredTarget("//java/android:idl");
assertContainsEvent(
"do not import '//java/android/a:A.aidl' directly. You should either"
+ " move the file to this package or depend on an appropriate rule there");
}
@Test
public void testIdlClassJarAction() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'idl',",
" idl_srcs = [",
" 'a.aidl',",
" 'b.aidl',",
" 'c.aidl',",
" ],",
")");
ConfiguredTarget idlTarget = getConfiguredTarget("//java/android:idl");
NestedSet<Artifact> outputGroup =
getOutputGroup(idlTarget, AndroidIdlHelper.IDL_JARS_OUTPUT_GROUP);
SpawnAction classJarAction =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
actionsTestUtil().artifactClosureOf(outputGroup), "libidl-idl.jar");
SpawnAction sourceJarAction =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
actionsTestUtil().artifactClosureOf(outputGroup), "libidl-idl.srcjar");
assertThat(sourceJarAction).isSameInstanceAs(classJarAction);
PathFragment genfilesPath =
getTargetConfiguration()
.getGenfilesDirectory(RepositoryName.MAIN)
.getExecPath()
.getRelative("java/android/idl_aidl/java/android");
assertThat(classJarAction.getArguments())
.containsAtLeast(
genfilesPath.getRelative("a.java").getPathString(),
genfilesPath.getRelative("b.java").getPathString(),
genfilesPath.getRelative("c.java").getPathString());
}
@Test
public void testIdlOutputGroupTransitivity() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'lib',",
" idl_srcs = ['a.aidl'],",
" deps = [':dep'],",
")",
"android_library(",
" name = 'dep',",
" idl_srcs = ['b.aidl'],",
")");
ConfiguredTarget idlTarget = getConfiguredTarget("//java/android:lib");
NestedSet<Artifact> outputGroup =
getOutputGroup(idlTarget, AndroidIdlHelper.IDL_JARS_OUTPUT_GROUP);
List<String> asString = Lists.newArrayList();
for (Artifact artifact : outputGroup.toList()) {
asString.add(artifact.getRootRelativePathString());
}
assertThat(asString)
.containsAtLeast(
"java/android/libdep-idl.jar",
"java/android/libdep-idl.srcjar",
"java/android/liblib-idl.jar",
"java/android/liblib-idl.srcjar");
}
@Test
public void testNoJavaDir() throws Exception {
checkError(
"android/hello",
"idl",
// message:
"Cannot determine java/javatests root for import android/hello/Import.aidl",
// build file:
"android_library(",
" name = 'idl',",
" srcs = ['Import.java'],",
" idl_parcelables = ['Import.aidl'],",
")");
}
@Test
public void testExportedPluginsAreInherited() throws Exception {
scratch.file(
"java/test/BUILD",
"java_plugin(",
" name = 'plugin',",
" srcs = [ 'Plugin.java' ],",
" processor_class = 'com.google.process.stuff',",
")",
"android_library(",
" name = 'exporting_lib',",
" srcs = [ 'ExportingLib.java' ],",
" exported_plugins = [ ':plugin' ],",
")",
"android_library(",
" name = 'consuming_lib',",
" srcs = [ 'ConsumingLib.java' ],",
" deps = [ ':exporting_lib' ],",
")",
"android_library(",
" name = 'leaf_lib',",
" srcs = [ 'LeafLib.java' ],",
" deps = [ ':consuming_lib' ],",
")");
getConfiguredTarget("//java/test:consuming_lib");
getConfiguredTarget("//java/test:leaf_lib");
// libconsuming_lib should include the plugin, since it directly depends on exporting_lib
assertThat(getProcessorNames("//java/test:libconsuming_lib.jar"))
.containsExactly("com.google.process.stuff");
// but libleaf_lib should not, because its dependency is transitive.
assertThat(getProcessorNames("//java/test:libleaf_lib.jar")).isEmpty();
}
@Test
public void testAidlLibAddsProguardSpecs() throws Exception {
scratch.file(
"sdk/BUILD",
"android_sdk(",
" name = 'sdk',",
" aapt = 'aapt',",
" aapt2 = 'aapt2',",
" adb = 'adb',",
" aidl = 'aidl',",
" aidl_lib = ':aidl_lib',",
" android_jar = 'android.jar',",
" apksigner = 'apksigner',",
" dx = 'dx',",
" framework_aidl = 'framework_aidl',",
" main_dex_classes = 'main_dex_classes',",
" main_dex_list_creator = 'main_dex_list_creator',",
" proguard = 'proguard',",
" shrinked_android_jar = 'shrinked_android_jar',",
" zipalign = 'zipalign',",
" tags = ['__ANDROID_RULES_MIGRATION__'],",
")",
"java_library(",
" name = 'aidl_lib',",
" srcs = ['AidlLib.java'],",
" proguard_specs = ['aidl_lib.cfg'],",
")");
scratch.file(
"java/com/google/android/hello/BUILD",
"android_library(",
" name = 'library',",
" srcs = ['MainActivity.java'],",
" idl_srcs = ['IMyInterface.aidl'],",
")",
"android_library(",
" name = 'library_no_idl',",
" srcs = ['MainActivity.java'],",
")",
"android_binary(",
" name = 'binary',",
" deps = [':library'],",
" manifest = 'AndroidManifest.xml',",
" proguard_specs = ['proguard-spec.pro'],",
")",
"android_binary(",
" name = 'binary_no_idl',",
" deps = [':library_no_idl'],",
" manifest = 'AndroidManifest.xml',",
" proguard_specs = ['proguard-spec.pro'],",
")");
useConfiguration("--android_sdk=//sdk:sdk");
// Targets with AIDL-generated sources also get AIDL support lib Proguard specs
ConfiguredTarget binary = getConfiguredTarget("//java/com/google/android/hello:binary");
Action action =
actionsTestUtil().getActionForArtifactEndingWith(getFilesToBuild(binary), "_proguard.jar");
assertThat(
ActionsTestUtil.getFirstArtifactEndingWith(
action.getInputs(), "sdk/aidl_lib.cfg_valid"))
.isNotNull();
// Targets without AIDL-generated sources don't care
ConfiguredTarget binaryNoIdl =
getConfiguredTarget("//java/com/google/android/hello:binary_no_idl");
Action actionNoIdl =
actionsTestUtil()
.getActionForArtifactEndingWith(getFilesToBuild(binaryNoIdl), "_proguard.jar");
assertThat(
ActionsTestUtil.getFirstArtifactEndingWith(
actionNoIdl.getInputs(), "sdk/aidl_lib.cfg_valid"))
.isNull();
}
@Test
public void testResourcesMultipleDirectoriesFromPackage() throws Exception {
scratch.file(
"c/b/m/a/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" custom_package = 'com.google.android.apps.a',",
" resource_files = [",
" 'b_/res/values/strings.xml',",
" ],",
")");
scratch.file(
"c/b/m/a/b_/res/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
ConfiguredTarget resource = getConfiguredTarget("//c/b/m/a:r");
assertThat(getResourceCompilationInputFiles(resource))
.contains("c/b/m/a/b_/res/values/strings.xml");
}
@Test
public void testSimpleResources() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = glob(['res/**']),",
")");
scratch.file(
"java/android/res/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
ConfiguredTarget resource = getConfiguredTarget("//java/android:r");
assertThat(getResourceCompilationInputFiles(resource))
.contains("java/android/res/values/strings.xml");
List<String> args = getResourceMergingArgs(resource);
assertThat(getDependencyResourceLabels(args, "--primaryData"))
.containsExactly("//java/android:r");
}
@Test
public void testResourcesWithConfigurationQualifier() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = glob(['res/**']),",
")");
scratch.file(
"java/android/res/values-en/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
scratch.file(
"java/android/res/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
ConfiguredTarget resource = getConfiguredTarget("//java/android:r");
assertThat(getResourceCompilationInputFiles(resource))
.containsAtLeast(
"java/android/res/values/strings.xml", "java/android/res/values-en/strings.xml");
}
@Test
public void testResourcesInOtherPackage_exported() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['//java/other:res/values/strings.xml'],",
")");
scratch.file("java/other/BUILD", "exports_files(['res/values/strings.xml'])");
ConfiguredTarget resource = getConfiguredTarget("//java/android:r");
assertThat(getResourceCompilationInputFiles(resource))
.contains("java/other/res/values/strings.xml");
assertNoEvents();
}
@Test
public void testResourcesInOtherPackage_filegroup() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['//java/other:fg'],",
")");
scratch.file(
"java/other/BUILD",
"filegroup(",
" name = 'fg',",
" srcs = ['res/values/strings.xml'],",
")");
ConfiguredTarget resource = getConfiguredTarget("//java/android:r");
assertThat(getResourceCompilationInputFiles(resource))
.contains("java/other/res/values/strings.xml");
assertNoEvents();
}
// Regression test for b/11924769
@Test
public void testResourcesInOtherPackage_filegroupWithExternalSources() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = [':fg'],",
")",
"filegroup(",
" name = 'fg',",
" srcs = ['//java/other:res/values/strings.xml'],",
")");
scratch.file("java/other/BUILD", "exports_files(['res/values/strings.xml'])");
ConfiguredTarget resource = getConfiguredTarget("//java/android:r");
assertThat(getResourceCompilationInputFiles(resource))
.contains("java/other/res/values/strings.xml");
assertNoEvents();
}
// Regression test for b/11924769
@Test
public void testResourcesInOtherPackage_doubleFilegroup() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = [':fg'],",
")",
"filegroup(",
" name = 'fg',",
" srcs = ['//java/other:fg'],",
")");
scratch.file(
"java/other/BUILD",
"filegroup(",
" name = 'fg',",
" srcs = ['res/values/strings.xml'],",
")");
ConfiguredTarget resource = getConfiguredTarget("//java/android:r");
assertThat(getResourceCompilationInputFiles(resource))
.contains("java/other/res/values/strings.xml");
assertNoEvents();
}
@Test
public void testManifestMissingFails() throws Exception {
checkError(
"java/android",
"r",
"is required when resource_files or assets are defined.",
"filegroup(name = 'b')",
"android_library(",
" name = 'r',",
" resource_files = [':b'],",
")");
}
@Test
public void testResourcesDoesNotMatchDirectoryLayout_BadFile() throws Exception {
checkError(
"java/android",
"r",
"'java/android/res/somefile.xml' is not in the expected resource directory structure of"
+ " <resource directory>/{"
+ Joiner.on(',').join(AndroidResources.RESOURCE_DIRECTORY_TYPES)
+ "}",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = [",
" 'res/somefile.xml',",
" 'r/t/f/m/raw/fold',",
" ],",
")");
}
@Test
public void testResourcesDoesNotMatchDirectoryLayout_BadDirectory() throws Exception {
checkError(
"java/android",
"r",
"'java/android/res/other/somefile.xml' is not in the expected resource directory structure"
+ " of <resource directory>/{"
+ Joiner.on(',').join(AndroidResources.RESOURCE_DIRECTORY_TYPES)
+ "}",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = [",
" 'res/other/somefile.xml',",
" 'r/t/f/m/raw/fold',",
" ],",
")");
}
@Test
public void testResourcesNotUnderCommonDirectoryFails() throws Exception {
checkError(
"java/android",
"r",
"'java/android/r/t/f/m/raw/fold' (generated by '//java/android:r/t/f/m/raw/fold') is not"
+ " in the same directory 'res' (derived from java/android/res/raw/speed). All"
+ " resources must share a common directory.",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = [",
" 'res/raw/speed',",
" 'r/t/f/m/raw/fold',",
" ],",
")");
}
@Test
public void testAssetsDirAndNoAssetsFails() throws Exception {
checkError(
"cpp/android",
"r",
"'assets' and 'assets_dir' should be either both empty or both non-empty",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" assets_dir = 'assets',",
")");
}
@Test
public void testAssetsNotUnderAssetsDirFails() throws Exception {
checkError(
"java/android",
"r",
"'java/android/r/t/f/m' (generated by '//java/android:r/t/f/m') is not beneath 'assets'",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" assets_dir = 'assets',",
" assets = [",
" 'assets/valuable',",
" 'r/t/f/m',",
" ]",
")");
}
@Test
public void testAssetsAndNoAssetsDirFails() throws Exception {
scratch.file(
"java/android/assets/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
checkError(
"java/android",
"r",
"'assets' and 'assets_dir' should be either both empty or both non-empty",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" assets = glob(['assets/**']),",
")");
}
@Test
public void testFileLocation() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
")");
ConfiguredTarget foo = getConfiguredTarget("//java/android:r");
assertThat(
ActionsTestUtil.getFirstArtifactEndingWith(getFilesToBuild(foo), "r.srcjar").getRoot())
.isEqualTo(getTargetConfiguration().getBinDirectory(RepositoryName.MAIN));
}
// regression test for #3294893
@Test
public void testNoJavaPathFoundDoesNotThrow() throws Exception {
checkError(
"third_party/java_src/android/app",
"r",
"The location of your BUILD file determines the Java package used for Android resource "
+ "processing. A directory named \"java\" or \"javatests\" will be used as your Java "
+ "source root and the path of your BUILD file relative to the Java source root will "
+ "be used as the package for Android resource processing. The Java source root could "
+ "not be determined for \"third_party/java_src/android/app\". Move your BUILD file "
+ "under a java or javatests directory, or set the 'custom_package' attribute.",
"licenses(['notice'])",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
")");
}
@Test
public void testWithRenameManifestPackage() throws Exception {
scratch.file(
"a/r/BUILD",
"android_library(",
" name = 'r',",
" srcs = ['Foo.java'],",
" custom_package = 'com.google.android.bar',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
")");
ConfiguredTarget r = getConfiguredTarget("//a/r:r");
assertNoEvents();
assertContainsSublist(
getResourceMergingArgs(r), ImmutableList.of("--packageForR", "com.google.android.bar"));
}
@Test
public void testNeverlinkResources_AndroidResourcesInfo() throws Exception {
scratch.file(
"java/apps/android/BUILD",
"android_library(",
" name = 'foo',",
" manifest = 'AndroidManifest.xml',",
" deps = [",
" ':lib',",
" ':lib_neverlink',",
" ],",
")",
"android_library(",
" name = 'lib_neverlink',",
" neverlink = 1,",
" manifest = 'AndroidManifest.xml',",
" deps = [':bar'],",
")",
"android_library(",
" name = 'lib',",
" manifest = 'AndroidManifest.xml',",
" deps = [':bar'],",
")",
"android_library(",
" name = 'bar',",
" manifest = 'AndroidManifest.xml',",
")");
Function<ValidatedAndroidResources, Label> getLabel = ValidatedAndroidResources::getLabel;
ConfiguredTarget foo = getConfiguredTarget("//java/apps/android:foo");
assertThat(
Iterables.transform(
foo.get(AndroidResourcesInfo.PROVIDER).getTransitiveAndroidResources().toList(),
getLabel))
.containsExactly(
Label.parseAbsolute("//java/apps/android:lib", ImmutableMap.of()),
Label.parseAbsolute("//java/apps/android:bar", ImmutableMap.of()));
assertThat(
Iterables.transform(
foo.get(AndroidResourcesInfo.PROVIDER).getDirectAndroidResources().toList(),
getLabel))
.containsExactly(Label.parseAbsolute("//java/apps/android:foo", ImmutableMap.of()));
ConfiguredTarget lib = getConfiguredTarget("//java/apps/android:lib");
assertThat(
Iterables.transform(
lib.get(AndroidResourcesInfo.PROVIDER).getTransitiveAndroidResources().toList(),
getLabel))
.containsExactly(Label.parseAbsolute("//java/apps/android:bar", ImmutableMap.of()));
assertThat(
Iterables.transform(
lib.get(AndroidResourcesInfo.PROVIDER).getDirectAndroidResources().toList(),
getLabel))
.containsExactly(Label.parseAbsolute("//java/apps/android:lib", ImmutableMap.of()));
ConfiguredTarget libNeverlink = getConfiguredTarget("//java/apps/android:lib_neverlink");
assertThat(
libNeverlink
.get(AndroidResourcesInfo.PROVIDER)
.getTransitiveAndroidResources()
.toList())
.isEmpty();
assertThat(libNeverlink.get(AndroidResourcesInfo.PROVIDER).getDirectAndroidResources().toList())
.isEmpty();
}
@Test
public void testNeverlinkResources_compileAndRuntimeJars() throws Exception {
scratch.file(
"java/apps/android/BUILD",
"android_library(",
" name = 'foo',",
" manifest = 'AndroidManifest.xml',",
" exports = [",
" ':lib',",
" ':lib_neverlink',",
" ],",
")",
"android_library(",
" name = 'lib_neverlink',",
" neverlink = 1,",
" manifest = 'AndroidManifest.xml',",
")",
"android_library(",
" name = 'lib',",
" manifest = 'AndroidManifest.xml',",
")");
ConfiguredTarget foo = getConfiguredTarget("//java/apps/android:foo");
ConfiguredTarget lib = getConfiguredTarget("//java/apps/android:lib");
ConfiguredTarget libNeverlink = getConfiguredTarget("//java/apps/android:lib_neverlink");
NestedSet<Artifact> neverLinkFilesToBuild = getFilesToBuild(libNeverlink);
NestedSet<Artifact> libFilesToBuild = getFilesToBuild(lib);
JavaCompilationArgsProvider argsProvider =
JavaInfo.getProvider(JavaCompilationArgsProvider.class, foo);
assertThat(argsProvider.getDirectCompileTimeJars().toList())
.contains(
ActionsTestUtil.getFirstArtifactEndingWith(
actionsTestUtil().artifactClosureOf(neverLinkFilesToBuild),
"lib_neverlink_resources.jar"));
assertThat(argsProvider.getDirectCompileTimeJars().toList())
.contains(
ActionsTestUtil.getFirstArtifactEndingWith(
actionsTestUtil().artifactClosureOf(libFilesToBuild), "lib_resources.jar"));
assertThat(argsProvider.getRuntimeJars().toList())
.doesNotContain(
ActionsTestUtil.getFirstArtifactEndingWith(
actionsTestUtil().artifactClosureOf(neverLinkFilesToBuild),
"lib_neverlink_resources.jar"));
assertThat(argsProvider.getRuntimeJars().toList())
.contains(
ActionsTestUtil.getFirstArtifactEndingWith(
actionsTestUtil().artifactClosureOf(libFilesToBuild), "lib_resources.jar"));
}
@Test
public void testResourceMergeAndProcessParallel() throws Exception {
// Test that for android_library, we can divide the resource processing action into
// smaller actions.
scratch.file(
"java/android/app/foo/BUILD",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" resource_files = glob(['res/**']),",
")");
scratch.file(
"java/android/app/foo/res/values/strings.xml",
"<resources>",
"<string name='hello'>Aloha!</string>",
"<string name='goodbye'>Aloha!</string>",
"</resources>");
ConfiguredTarget target = getConfiguredTarget("//java/android/app/foo:r");
NestedSet<Artifact> filesToBuild = getFilesToBuild(target);
Set<Artifact> artifacts = actionsTestUtil().artifactClosureOf(filesToBuild);
ValidatedAndroidResources resources =
target.get(AndroidResourcesInfo.PROVIDER).getDirectAndroidResources().getSingleton();
SpawnAction resourceParserAction =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
artifacts, "/" + resources.getCompiledSymbols().getFilename());
SpawnAction resourceClassJarAction =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
artifacts, "/" + resources.getJavaClassJar().getFilename());
SpawnAction resourceSrcJarAction =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
artifacts, "/" + resources.getJavaSourceJar().getFilename());
assertThat(resourceParserAction.getMnemonic()).isEqualTo("AndroidResourceCompiler");
assertThat(resourceClassJarAction.getMnemonic()).isEqualTo("AndroidCompiledResourceMerger");
assertThat(resourceSrcJarAction.getMnemonic()).isEqualTo("AndroidResourceLink");
// Validator also generates an R.txt.
assertThat(resourceSrcJarAction.getOutputs()).contains(resources.getRTxt());
}
@Test
public void testGeneratedManifestPackage() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'l',",
" srcs = ['foo.java'],",
")",
"android_library(",
" name = 'l2',",
" custom_package = 'foo',",
" srcs = ['foo.java'],",
")");
scratch.file(
"third_party/android/BUILD",
"licenses(['notice'])",
"android_library(",
" name = 'l',",
" srcs = ['foo.java'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/android:l");
Artifact manifest = getBinArtifact("_generated/l/AndroidManifest.xml", target);
FileWriteAction action = (FileWriteAction) getGeneratingAction(manifest);
assertThat(action.getFileContents()).contains("package=\"android\"");
target = getConfiguredTarget("//java/android:l2");
manifest = getBinArtifact("_generated/l2/AndroidManifest.xml", target);
action = (FileWriteAction) getGeneratingAction(manifest);
assertThat(action.getFileContents()).contains("package=\"foo\"");
target = getConfiguredTarget("//third_party/android:l");
manifest = getBinArtifact("_generated/l/AndroidManifest.xml", target);
action = (FileWriteAction) getGeneratingAction(manifest);
assertThat(action.getFileContents()).contains("package=\"third_party.android\"");
}
@Test
public void testGeneratedIdlSrcs() throws Exception {
scratch.file(
"java/android/BUILD",
"genrule(",
" name = 'idl',",
" outs = ['MyInterface.aidl'],",
" cmd = 'touch $@',",
")",
"android_library(",
" name = 'lib',",
" idl_srcs = [':idl'],",
" idl_parcelables = ['MyParcelable.aidl'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/android:lib");
PathFragment genfilesJavaPath =
getTargetConfiguration()
.getGenfilesDirectory(RepositoryName.MAIN)
.getExecPath()
.getRelative("java");
SpawnAction action =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
actionsTestUtil().artifactClosureOf(getFilesToBuild(target)),
"MyInterface.java");
assertThat(action.getArguments())
.containsAtLeast("-Ijava", "-I" + genfilesJavaPath.getPathString());
}
@Test
public void testMultipleLibsSameIdls() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'idl1',",
" idl_srcs = ['MyInterface.aidl'],",
")",
"android_library(",
" name = 'idl2',",
" idl_srcs = ['MyInterface.aidl'],",
")");
getConfiguredTarget("//java/android:idl1");
getConfiguredTarget("//java/android:idl2");
}
@Test
public void testIdeInfoProvider() throws Exception {
scratch.file(
"java/android/BUILD",
"genrule(",
" name='genrule',",
" srcs=[],",
" outs=['assets/genrule.so'],",
" cmd='',",
")",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" idl_srcs = [ 'MyInterface.aidl' ],",
" resource_files = glob(['res/**']),",
" assets_dir = 'assets',",
" assets = glob(['assets/**']) + [':genrule']",
")");
scratch.file(
"java/android/res/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
scratch.file("java/android/assets/values/orc.txt", "Nabu nabu!");
ConfiguredTarget target = getConfiguredTarget("//java/android:r");
final AndroidIdeInfoProvider provider = target.get(AndroidIdeInfoProvider.PROVIDER);
Set<Artifact> artifactClosure = actionsTestUtil().artifactClosureOf(getFilesToBuild(target));
assertThat(provider.getManifest())
.isEqualTo(
ActionsTestUtil.getFirstArtifactEndingWith(
artifactClosure, "java/android/AndroidManifest.xml"));
ValidatedAndroidResources resources =
getConfiguredTarget("//java/android:r")
.get(AndroidResourcesInfo.PROVIDER)
.getDirectAndroidResources()
.getSingleton();
assertThat(provider.getGeneratedManifest()).isEqualTo(resources.getManifest());
}
@Test
public void testIdeInfoProviderOutsideJavaRoot() throws Exception {
String rootPath = "research/handwriting/java/com/google/research/handwriting/";
scratch.file(
rootPath + "BUILD",
"genrule(",
" name='genrule',",
" srcs=[],",
" outs=['assets/genrule.so'],",
" cmd='',",
")",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" idl_srcs = [ 'MyInterface.aidl' ],",
" resource_files = glob(['res/**']),",
" assets_dir = 'assets',",
" assets = glob(['assets/**']) + [':genrule']",
")");
scratch.file(
rootPath + "res/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
scratch.file(rootPath + "/assets/values/orc.txt", "Nabu nabu!");
ConfiguredTarget target =
getConfiguredTarget("//research/handwriting/java/com/google/research/handwriting:r");
final AndroidIdeInfoProvider provider = target.get(AndroidIdeInfoProvider.PROVIDER);
Set<Artifact> artifactClosure = actionsTestUtil().artifactClosureOf(getFilesToBuild(target));
assertThat(provider.getManifest())
.isEqualTo(
ActionsTestUtil.getFirstArtifactEndingWith(
artifactClosure, "handwriting/AndroidManifest.xml"));
ValidatedAndroidResources resources =
getConfiguredTarget("//research/handwriting/java/com/google/research/handwriting:r")
.get(AndroidResourcesInfo.PROVIDER)
.getDirectAndroidResources()
.getSingleton();
assertThat(provider.getGeneratedManifest()).isEqualTo(resources.getManifest());
}
@Test
public void testIdeInfoProviderGeneratedIdl() throws Exception {
scratch.file(
"java/android/BUILD",
"genrule(",
" name='genrule',",
" srcs=[],",
" outs=['assets/genrule.so'],",
" cmd='',",
")",
"genrule(",
" name = 'idl',",
" outs = ['MyGeneratedInterface.aidl'],",
" cmd = 'touch $@',",
")",
"android_library(",
" name = 'r',",
" manifest = 'AndroidManifest.xml',",
" idl_srcs = [ ':idl' ],",
" idl_parcelables = [ 'MyInterface.aidl' ],",
" resource_files = glob(['res/**']),",
" assets_dir = 'assets',",
" assets = glob(['assets/**']) + [':genrule']",
")");
scratch.file(
"java/android/res/values/strings.xml",
"<resources><string name = 'hello'>Hello Android!</string></resources>");
scratch.file("java/android/assets/values/orc.txt", "Nabu nabu!");
ConfiguredTarget target = getConfiguredTarget("//java/android:r");
final AndroidIdeInfoProvider provider = target.get(AndroidIdeInfoProvider.PROVIDER);
Set<Artifact> artifactClosure = actionsTestUtil().artifactClosureOf(getFilesToBuild(target));
assertThat(provider.getManifest())
.isEqualTo(
ActionsTestUtil.getFirstArtifactEndingWith(
artifactClosure, "java/android/AndroidManifest.xml"));
ValidatedAndroidResources resources =
getConfiguredTarget("//java/android:r")
.get(AndroidResourcesInfo.PROVIDER)
.getDirectAndroidResources()
.getSingleton();
assertThat(provider.getGeneratedManifest()).isEqualTo(resources.getManifest());
}
@Test
public void testAndroidLibraryWithMessagesDoNotCrash() throws Exception {
scratch.file(
"java/com/google/atest/BUILD",
"filegroup(",
" name = 'sources',",
" srcs = [",
" 'source.java',",
" 'message.xmb',",
" ],",
")",
"android_library(",
" name = 'alib',",
" srcs = [':sources'],",
")");
getConfiguredTarget("//java/com/google/atest:alib");
}
@Test
public void testMultipleDirectDependentResourceDirectories() throws Exception {
scratch.file(
"java/android/resources/d1/BUILD",
"android_library(",
" name = 'd1',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['d1-res/values/strings.xml'],",
" assets = ['assets-d1/some/random/file'],",
" assets_dir = 'assets-d1',",
" deps = ['//java/android/resources/d2:d2'],",
")");
scratch.file(
"java/android/resources/d2/BUILD",
"android_library(",
" name = 'd2',",
" manifest = 'AndroidManifest.xml',",
" assets = ['assets-d2/some/random/file'],",
" assets_dir = 'assets-d2',",
" resource_files = ['d2-res/values/strings.xml'],",
")");
ConfiguredTarget resource = getConfiguredTarget("//java/android/resources/d1:d1");
assertThat(getResourceCompilationInputFiles(resource))
.contains("java/android/resources/d1/d1-res/values/strings.xml");
List<String> args = getResourceMergingArgs(resource);
assertThat(getDependencyResourceLabels(args, "--primaryData"))
.containsExactly("//java/android/resources/d1:d1");
assertThat(getDependencyResourceLabels(args, "--directData"))
.containsExactly("//java/android/resources/d2:d2");
assertThat(args).doesNotContain("--data");
List<String> assetArgs = getGeneratingSpawnActionArgs(getDecoupledAssetArtifact(resource));
assertThat(getDependencyAssetDirs(assetArgs, "--directData"))
.contains("java/android/resources/d2/assets-d2");
assertNoEvents();
}
@Test
public void testTransitiveDependentResourceDirectories() throws Exception {
scratch.file(
"java/android/resources/d1/BUILD",
"android_library(",
" name = 'd1',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['d1-res/values/strings.xml'],",
" assets = ['assets-d1/some/random/file'],",
" assets_dir = 'assets-d1',",
" deps = ['//java/android/resources/d2:d2']",
")");
scratch.file(
"java/android/resources/d2/BUILD",
"android_library(",
" name = 'd2',",
" manifest = 'AndroidManifest.xml',",
" assets = ['assets-d2/some/random/file'],",
" assets_dir = 'assets-d2',",
" resource_files = ['d2-res/values/strings.xml'],",
" deps = ['//java/android/resources/d3:d3'],",
")");
scratch.file(
"java/android/resources/d3/BUILD",
"android_library(",
" name = 'd3',",
" manifest = 'AndroidManifest.xml',",
" assets = ['assets-d3/some/random/file'],",
" assets_dir = 'assets-d3',",
" resource_files = ['d3-res/values/strings.xml'],",
")");
ConfiguredTarget resource = getConfiguredTarget("//java/android/resources/d1:d1");
assertThat(getResourceCompilationInputFiles(resource))
.contains("java/android/resources/d1/d1-res/values/strings.xml");
List<String> args = getResourceMergingArgs(resource);
assertThat(getDependencyResourceLabels(args, "--primaryData"))
.containsExactly("//java/android/resources/d1:d1");
assertThat(getDependencyResourceLabels(args, "--directData"))
.containsExactly("//java/android/resources/d2:d2");
assertThat(getDependencyResourceLabels(args, "--data"))
.containsExactly("//java/android/resources/d3:d3");
List<String> assetArgs = getGeneratingSpawnActionArgs(getDecoupledAssetArtifact(resource));
assertThat(getDependencyAssetDirs(assetArgs, "--directData"))
.contains("java/android/resources/d2/assets-d2");
assertThat(getDependencyAssetDirs(assetArgs, "--data"))
.contains("java/android/resources/d3/assets-d3");
assertNoEvents();
}
@Test
public void rClassGeneration_withAnnotationFeature_addsFlag() throws Exception {
scratch.file(
"java/lib1/BUILD",
"android_library(",
" name = 'lib1',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
" features = ['annotate_r_fields_from_transitive_deps'],",
")");
List<String> lib1args =
getGeneratingSpawnActionArgs(getResourceArtifact(getConfiguredTarget("//java/lib1")));
assertThat(lib1args).contains("--annotate_r_fields_from_transitive_deps");
}
@Test
public void rClassGeneration_withoutAnnotationFeature_omitsFlag() throws Exception {
scratch.file(
"java/lib1/BUILD",
"android_library(",
" name = 'lib1',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
")");
List<String> lib1args =
getGeneratingSpawnActionArgs(getResourceArtifact(getConfiguredTarget("//java/lib1")));
assertThat(lib1args).doesNotContain("--annotate_r_fields_from_transitive_deps");
}
@Test
public void transitiveResourceDependencies_omitTransitiveResources() throws Exception {
scratch.file(
"java/lib1/BUILD",
"package(features=['android_resources_strict_deps'])",
"android_library(",
" name = 'lib1',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
" deps = ['//java/lib2'],",
")");
scratch.file(
"java/lib2/BUILD",
"android_library(",
" name = 'lib2',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
" deps = ['//java/lib3'],",
")");
scratch.file(
"java/lib3/BUILD",
"android_library(",
" name = 'lib3',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/lib1");
List<String> rClassArgs = getRClassGenerationArgs(target);
assertThat(getDependencyResourceLabels(rClassArgs, "--primaryData"))
.containsExactly("//java/lib1:lib1");
assertThat(getDependencyResourceLabels(rClassArgs, "--directData"))
.containsExactly("//java/lib2:lib2");
assertThat(rClassArgs).doesNotContain("--data");
assertNoEvents();
}
// Note that this is really testing the 'feature' mechanism of Bazel rather than this specific
// feature. But it's not well documented, so we're testing this specific use case.
@Test
public void transitiveResourceDependencies_includeTransitiveResources() throws Exception {
useConfiguration("--features=android_resources_strict_deps");
scratch.file(
"java/lib1/BUILD",
"android_library(",
" name = 'lib1',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
" deps = ['//java/lib2'],",
// disable feature, which was presumably set in a global blazerc (above).
" features=['-android_resources_strict_deps'],",
")");
scratch.file(
"java/lib2/BUILD",
"android_library(",
" name = 'lib2',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
" deps = ['//java/lib3'],",
")");
scratch.file(
"java/lib3/BUILD",
"android_library(",
" name = 'lib3',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/lib1");
List<String> args = getRClassGenerationArgs(target);
assertThat(getDependencyResourceLabels(args, "--data")).containsExactly("//java/lib3:lib3");
assertNoEvents();
}
@Test
public void testCustomJavacopts() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['A.java'],",
" javacopts = ['-g:lines,source'],",
")");
JavaCompileAction javacAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/android:liba.jar");
assertThat(getJavacArguments(javacAction)).contains("-g:lines,source");
}
// Regression test for b/23079127
@Test
public void testSrcjarStrictDeps() throws Exception {
scratch.file(
"java/strict/BUILD",
"android_library(",
" name='a',",
" srcs=['A.java'],",
" deps=[':b'],",
")",
"android_library(",
" name='b',",
" srcs=['b.srcjar'],",
" deps=[':c'],",
")",
"android_library(",
" name='c',",
" srcs=['C.java'],",
")");
JavaCompileAction javacAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/strict:liba.jar");
assertThat(prettyArtifactNames(getInputs(javacAction, getDirectJars(javacAction))))
.containsExactly("java/strict/libb-hjar.jar");
}
@Test
public void testDisallowPrecompiledJars() throws Exception {
checkError(
"java/precompiled",
"library",
// messages:
"does not produce any android_library srcs files (expected .java or .srcjar)",
// build file:
"android_library(",
" name = 'library',",
" srcs = [':jar'],",
")",
"filegroup(",
" name = 'jar',",
" srcs = ['lib.jar'],",
")");
}
@Test
public void hjarPredecessors() throws Exception {
scratch.file(
"java/test/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['A.java'],",
" deps = [':b'],",
")",
"android_library(",
" name = 'b',",
" srcs = ['B.java'],",
")");
useConfiguration("--java_header_compilation");
Action a = getGeneratingActionForLabel("//java/test:liba.jar");
List<String> inputs = prettyArtifactNames(a.getInputs());
assertThat(inputs).doesNotContain("java/test/libb.jdeps");
assertThat(inputs).contains("java/test/libb-hjar.jdeps");
}
@Test
public void resourcesFromRuntimeDepsAreIncluded() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'dummyParentLibrary',",
" deps = [':dummyLibraryOne',",
" ':dummyLibraryTwo'],",
" srcs = ['libraryParent.java'],",
")",
"android_library(",
" name = 'dummyLibraryOne',",
" exports_manifest = 1,",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/drawable/dummyResource1.png'],",
" srcs = ['libraryOne.java'],",
")",
"android_library(",
" name = 'dummyLibraryTwo',",
" exports_manifest = 1,",
" neverlink = 1,",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/drawable/dummyResource2.png'],",
" deps = ['dummyLibraryNested'],",
" srcs = ['libraryTwo.java'],",
")",
"android_library(",
" name = 'dummyLibraryNested',",
" exports_manifest = 1,",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/drawable/dummyResource1.png'],",
" srcs = ['libraryOne.java'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/android:dummyLibraryOne");
AndroidLibraryAarInfo provider = target.get(AndroidLibraryAarInfo.PROVIDER);
assertThat(provider).isNotNull();
target = getConfiguredTarget("//java/android:dummyLibraryTwo");
provider = target.get(AndroidLibraryAarInfo.PROVIDER);
assertThat(provider).isNull();
target = getConfiguredTarget("//java/android:dummyParentLibrary");
provider = target.get(AndroidLibraryAarInfo.PROVIDER);
assertThat(provider).isNotNull();
assertThat(provider.getTransitiveAars().toList()).hasSize(1);
}
@Test
public void aapt2ArtifactGenerationWhenSdkIsDefined() throws Exception {
scratch.file(
"sdk/BUILD",
"android_sdk(",
" name = 'sdk',",
" aapt = 'aapt',",
" aapt2 = 'aapt2',",
" adb = 'adb',",
" aidl = 'aidl',",
" android_jar = 'android.jar',",
" apksigner = 'apksigner',",
" dx = 'dx',",
" framework_aidl = 'framework_aidl',",
" main_dex_classes = 'main_dex_classes',",
" main_dex_list_creator = 'main_dex_list_creator',",
" proguard = 'proguard',",
" shrinked_android_jar = 'shrinked_android_jar',",
" zipalign = 'zipalign',",
" tags = ['__ANDROID_RULES_MIGRATION__'],",
")");
scratch.file(
"java/a/BUILD",
"android_library(",
" name = 'a', ",
" srcs = ['A.java'],",
" deps = [':b'],",
" manifest = 'a/AndroidManifest.xml',",
" resource_files = ['res/values/a.xml'],",
")",
"android_library(",
" name = 'b', ",
" srcs = ['B.java'],",
" manifest = 'b/AndroidManifest.xml',",
" resource_files = ['res/values/b.xml'],",
")");
useConfiguration("--android_sdk=//sdk:sdk");
ConfiguredTargetAndData a = getConfiguredTargetAndData("//java/a:a");
ConfiguredTargetAndData b = getConfiguredTargetAndDataDirectPrerequisite(a, "//java/a:b");
ConfiguredTargetAndData sdk = getConfiguredTargetAndDataDirectPrerequisite(a, "//sdk:sdk");
SpawnAction compileAction =
getGeneratingSpawnAction(
getImplicitOutputArtifact(
a.getConfiguredTarget(), AndroidRuleClasses.ANDROID_COMPILED_SYMBOLS));
assertThat(compileAction).isNotNull();
SpawnAction linkAction =
getGeneratingSpawnAction(
getImplicitOutputArtifact(
a.getConfiguredTarget(), AndroidRuleClasses.ANDROID_LIBRARY_APK));
assertThat(linkAction).isNotNull();
assertThat(linkAction.getInputs().toList())
.containsAtLeast(
sdk.getConfiguredTarget().get(AndroidSdkProvider.PROVIDER).getAndroidJar(),
getImplicitOutputArtifact(
a.getConfiguredTarget(), AndroidRuleClasses.ANDROID_COMPILED_SYMBOLS),
getImplicitOutputArtifact(
b.getConfiguredTarget(), AndroidRuleClasses.ANDROID_COMPILED_SYMBOLS));
assertThat(linkAction.getOutputs())
.containsAtLeast(
getImplicitOutputArtifact(a.getConfiguredTarget(), AndroidRuleClasses.ANDROID_R_TXT),
getImplicitOutputArtifact(
a.getConfiguredTarget(), AndroidRuleClasses.ANDROID_JAVA_SOURCE_JAR));
}
@Test
public void aapt2ArtifactGenerationSkippedWhenSdkIsNotDefined() throws Exception {
scratch.file(
"java/a/BUILD",
"android_library(",
" name = 'a', ",
" srcs = ['A.java'],",
" manifest = 'a/AndroidManifest.xml',",
" resource_files = ['res/values/a.xml'],",
")");
RuleConfiguredTarget a = (RuleConfiguredTarget) getConfiguredTarget("//java/a:a");
ActionsTestUtil.assertNoArtifactEndingWith(
a, getImplicitOutputPath(a, AndroidRuleClasses.ANDROID_COMPILED_SYMBOLS));
ActionsTestUtil.assertNoArtifactEndingWith(
a, getImplicitOutputPath(a, AndroidRuleClasses.ANDROID_RESOURCES_AAPT2_LIBRARY_APK));
}
@Test
public void compileDataBindingOutputWhenDataBindingEnabled() throws Exception {
scratch.file(
"sdk/BUILD",
"android_sdk(",
" name = 'sdk',",
" aapt = 'aapt',",
" aapt2 = 'aapt2',",
" adb = 'adb',",
" aidl = 'aidl',",
" android_jar = 'android.jar',",
" apksigner = 'apksigner',",
" dx = 'dx',",
" framework_aidl = 'framework_aidl',",
" main_dex_classes = 'main_dex_classes',",
" main_dex_list_creator = 'main_dex_list_creator',",
" proguard = 'proguard',",
" shrinked_android_jar = 'shrinked_android_jar',",
" zipalign = 'zipalign',",
" tags = ['__ANDROID_RULES_MIGRATION__'],",
")");
scratch.file(
"java/a/BUILD",
"android_library(",
" name = 'a', ",
" srcs = ['A.java'],",
" enable_data_binding = 1,",
" manifest = 'a/AndroidManifest.xml',",
" resource_files = ['res/values/a.xml']",
")");
useConfiguration("--android_sdk=//sdk:sdk");
ConfiguredTarget a = getConfiguredTarget("//java/a:a");
SpawnAction compileAction =
getGeneratingSpawnAction(
getImplicitOutputArtifact(a, AndroidRuleClasses.ANDROID_COMPILED_SYMBOLS));
assertThat(compileAction).isNotNull();
Iterable<String> args = paramFileArgsOrActionArgs(compileAction);
assertThat(args).contains("--dataBindingInfoOut");
}
@Test
public void testUseManifestFromResourceApk() throws Exception {
scratch.file(
"java/a/BUILD",
"android_library(",
" name = 'a', ",
" srcs = ['A.java'],",
" manifest = 'a/AndroidManifest.xml',",
" resource_files = ['res/values/a.xml'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/a:a");
AndroidLibraryAarInfo provider = target.get(AndroidLibraryAarInfo.PROVIDER);
assertThat(provider).isNotNull();
assertThat(provider.getAar().getManifest().getPath().toString()).contains("processed_manifest");
}
@Test
public void testAndroidLibrary_SrcsLessDepsHostConfigurationNoOverride() throws Exception {
scratch.file(
"java/srclessdeps/BUILD",
"android_library(",
" name = 'dep_for_foo',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'foo',",
" deps = [':dep_for_foo'],",
")",
"genrule(",
" name = 'some_genrule',",
" tools = [':foo'],",
" outs = ['some_outs'],",
" cmd = '$(location :foo) do_something $@',",
")");
useConfiguration("--experimental_allow_android_library_deps_without_srcs");
// genrule builds its tools using the host configuration.
ConfiguredTarget genruleTarget = getConfiguredTarget("//java/srclessdeps:some_genrule");
ConfiguredTarget target = getDirectPrerequisite(genruleTarget, "//java/srclessdeps:foo");
assertThat(
getConfiguration(target)
.getFragment(AndroidConfiguration.class)
.allowSrcsLessAndroidLibraryDeps(getRuleContext(target)))
.isTrue();
}
@Test
public void testAndroidLibraryValidatesProguardSpec() throws Exception {
scratch.file(
"java/com/google/android/hello/BUILD",
"android_library(",
" name = 'l2',",
" srcs = ['MoreMaps.java'],",
" proguard_specs = ['library_spec.cfg'],",
")",
"android_binary(",
" name = 'b',",
" srcs = ['HelloApp.java'],",
" manifest = 'AndroidManifest.xml',",
" deps = [':l2'],",
" proguard_specs = ['proguard-spec.pro'],",
")");
Set<Artifact> transitiveArtifacts =
actionsTestUtil()
.artifactClosureOf(
getFilesToBuild(getConfiguredTarget("//java/com/google/android/hello:b")));
Action action =
actionsTestUtil()
.getActionForArtifactEndingWith(transitiveArtifacts, "library_spec.cfg_valid");
assertWithMessage("proguard validate action was spawned for binary target.")
.that(
actionsTestUtil()
.getActionForArtifactEndingWith(transitiveArtifacts, "proguard-spec.pro_valid"))
.isNull();
assertWithMessage("Proguard validate action was not spawned.")
.that(prettyArtifactNames(action.getInputs()))
.contains("java/com/google/android/hello/library_spec.cfg");
}
@Test
public void testAndroidLibraryValidatesProguardSpecWithoutBinary() throws Exception {
scratch.file(
"java/com/google/android/hello/BUILD",
"android_library(",
" name = 'l2',",
" srcs = ['MoreMaps.java'],",
" proguard_specs = ['library_spec.cfg'],",
")",
"android_library(",
" name = 'l3',",
" srcs = ['MoreMaps.java'],",
" deps = [':l2'],",
")");
Action action =
actionsTestUtil()
.getActionForArtifactEndingWith(
getOutputGroup(
getConfiguredTarget("//java/com/google/android/hello:l2"),
OutputGroupInfo.HIDDEN_TOP_LEVEL),
"library_spec.cfg_valid");
assertWithMessage("Proguard validate action was not spawned.").that(action).isNotNull();
assertWithMessage("Proguard validate action was spawned without correct input.")
.that(prettyArtifactNames(action.getInputs()))
.contains("java/com/google/android/hello/library_spec.cfg");
Action transitiveAction =
actionsTestUtil()
.getActionForArtifactEndingWith(
getOutputGroup(
getConfiguredTarget("//java/com/google/android/hello:l3"),
OutputGroupInfo.HIDDEN_TOP_LEVEL),
"library_spec.cfg_valid");
assertWithMessage("Proguard validate action was not spawned.")
.that(transitiveAction)
.isNotNull();
assertWithMessage("Proguard validate action was spawned without correct input.")
.that(prettyArtifactNames(transitiveAction.getInputs()))
.contains("java/com/google/android/hello/library_spec.cfg");
}
@Test
public void testForwardedDeps() throws Exception {
scratch.file(
"java/fwdeps/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'b1',",
" exports = [':a'],",
")",
"android_library(",
" name = 'b2',",
" srcs = [],",
" exports = [':a'],",
")",
"android_library(",
" name = 'c1',",
" srcs = ['c1.java'],",
" deps = [':b1'],",
")",
"android_library(",
" name = 'c2',",
" srcs = ['c2.java'],",
" deps = [':b2'],",
")");
ConfiguredTarget c1Target = getConfiguredTarget("//java/fwdeps:c1");
ConfiguredTarget c2Target = getConfiguredTarget("//java/fwdeps:c2");
Iterable<String> c1Jars =
ActionsTestUtil.baseArtifactNames(
JavaInfo.getProvider(JavaCompilationInfoProvider.class, c1Target)
.getCompilationClasspath()
.getSet(Artifact.class));
Iterable<String> c2Jars =
ActionsTestUtil.baseArtifactNames(
JavaInfo.getProvider(JavaCompilationInfoProvider.class, c2Target)
.getCompilationClasspath()
.getSet(Artifact.class));
assertThat(c1Jars).containsExactly("liba-hjar.jar");
assertThat(c2Jars).containsExactly("liba-hjar.jar");
assertNoEvents();
}
@Test
public void testExportsAreIndirectNotDirect() throws Exception {
scratch.file(
"java/exports/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['a.java'],",
")",
"android_library(",
" name = 'b',",
" srcs = ['b.java'],",
" exports = ['a'],",
")",
"android_library(",
" name = 'c',",
" srcs = ['c.java'],",
" deps = [':b'],",
")");
ConfiguredTarget aTarget = getConfiguredTarget("//java/exports:a");
ConfiguredTarget bTarget = getConfiguredTarget("//java/exports:b");
ConfiguredTarget cTarget = getConfiguredTarget("//java/exports:c");
ImmutableList<Artifact> bClasspath =
JavaInfo.getProvider(JavaCompilationInfoProvider.class, bTarget)
.getCompilationClasspath()
.getSet(Artifact.class)
.toList();
ImmutableList<Artifact> cClasspath =
JavaInfo.getProvider(JavaCompilationInfoProvider.class, cTarget)
.getCompilationClasspath()
.getSet(Artifact.class)
.toList();
assertThat(bClasspath).isEmpty();
assertThat(cClasspath)
.containsAtLeastElementsIn(
JavaInfo.getProvider(JavaCompilationArgsProvider.class, aTarget)
.getDirectCompileTimeJars()
.toList());
assertThat(cClasspath)
.containsAtLeastElementsIn(
JavaInfo.getProvider(JavaCompilationArgsProvider.class, bTarget)
.getDirectCompileTimeJars()
.toList());
assertNoEvents();
}
@Test
public void testAndroidJavacoptsCanBeOverridden() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'a',",
" srcs = ['A.java'],",
" javacopts = ['-g:lines,source'],",
")");
JavaCompileAction javacAction =
(JavaCompileAction) getGeneratingActionForLabel("//java/android:liba.jar");
String commandLine = Iterables.toString(getJavacArguments(javacAction));
assertThat(commandLine).contains("-g:lines,source");
}
@Test
public void testAarGeneration_LocalResources() throws Exception {
scratch.file(
"java/android/aartest/BUILD",
"android_library(",
" name = 'aartest',",
" deps = ['dep'],",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
" assets = ['assets/some/random/file'],",
" assets_dir = 'assets',",
")",
"android_library(",
" name = 'dep',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['dep/res/values/strings.xml'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/android/aartest:aartest");
Artifact aar = getBinArtifact("aartest.aar", target);
SpawnAction action =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
actionsTestUtil().artifactClosureOf(aar), "aartest.aar");
assertThat(action).isNotNull();
assertThat(prettyArtifactNames(getNonToolInputs(action)))
.containsAtLeast(
"java/android/aartest/aartest_processed_manifest/AndroidManifest.xml",
"java/android/aartest/aartest_symbols/R.txt",
"java/android/aartest/res/values/strings.xml",
"java/android/aartest/assets/some/random/file",
"java/android/aartest/libaartest.jar");
}
@Test
public void testAarGeneration_NoResources() throws Exception {
scratch.file(
"java/android/aartest/BUILD",
"android_library(",
" name = 'aartest',",
" exports = ['dep'],",
")",
"android_library(",
" name = 'dep',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['dep/res/values/strings.xml'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/android/aartest:aartest");
Artifact aar = getBinArtifact("aartest.aar", target);
SpawnAction action =
(SpawnAction)
actionsTestUtil()
.getActionForArtifactEndingWith(
actionsTestUtil().artifactClosureOf(aar), "aartest.aar");
assertThat(action).isNotNull();
assertThat(prettyArtifactNames(getNonToolInputs(action)))
.containsAtLeast(
"java/android/aartest/aartest_processed_manifest/AndroidManifest.xml",
"java/android/aartest/aartest_symbols/R.txt",
"java/android/aartest/libaartest.jar");
}
@Test
public void testAarProvider_localResources() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'test',",
" inline_constants = 0,",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
" deps = [",
" ':t1',",
" ':t2',",
" ],",
")",
"android_library(",
" name = 't1',",
" inline_constants = 0,",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
")",
"android_library(",
" name = 't2',",
" inline_constants = 0,",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/android:test");
ConfiguredTarget t1Target = getConfiguredTarget("//java/android:t1");
ConfiguredTarget t2Target = getConfiguredTarget("//java/android:t2");
final AndroidLibraryAarInfo provider = target.get(AndroidLibraryAarInfo.PROVIDER);
final Aar test =
Aar.create(
getBinArtifact("test.aar", target),
getBinArtifact("test_processed_manifest/AndroidManifest.xml", target));
final Aar t1 =
Aar.create(
getBinArtifact("t1.aar", t1Target),
getBinArtifact("t1_processed_manifest/AndroidManifest.xml", t1Target));
final Aar t2 =
Aar.create(
getBinArtifact("t2.aar", t2Target),
getBinArtifact("t2_processed_manifest/AndroidManifest.xml", t2Target));
assertThat(provider.getAar()).isEqualTo(test);
assertThat(provider.getTransitiveAars().toList()).containsExactly(test, t1, t2);
}
@Test
public void testAarProvider_noResources() throws Exception {
scratch.file(
"java/android/BUILD",
"android_library(",
" name = 'test',",
" exports = [':transitive'],",
")",
"android_library(",
" name = 'transitive',",
" manifest = 'AndroidManifest.xml',",
" resource_files = ['res/values/strings.xml'],",
")");
ConfiguredTarget target = getConfiguredTarget("//java/android:test");
final AndroidLibraryAarInfo provider = target.get(AndroidLibraryAarInfo.PROVIDER);
ConfiguredTarget transitiveTarget = getConfiguredTarget("//java/android:transitive");
final Aar transitive =
Aar.create(
getBinArtifact("transitive.aar", transitiveTarget),
getBinArtifact("transitive_processed_manifest/AndroidManifest.xml", transitiveTarget));
assertThat(provider.getAar()).isNull();
assertThat(provider.getTransitiveAars().toList()).containsExactly(transitive);
}
@Test
public void nativeHeaderOutputs() throws Exception {
scratch.file(
"java/com/google/jni/BUILD", //
"android_library(",
" name = 'jni',",
" srcs = [",
" 'Foo.java',",
" 'Bar.java',",
" ],",
")");
FileConfiguredTarget target = getFileConfiguredTarget("//java/com/google/jni:libjni.jar");
JavaCompileAction action = (JavaCompileAction) getGeneratingAction(target.getArtifact());
String outputPath = outputPath(action, "java/com/google/jni/libjni-native-header.jar");
Iterable<String> result = getJavacArguments(action);
assertThat(Joiner.on(' ').join(result))
.contains(Joiner.on(' ').join("--native_header_output", outputPath));
Artifact nativeHeaderOutput =
JavaInfo.getProvider(
JavaRuleOutputJarsProvider.class, getConfiguredTarget("//java/com/google/jni"))
.getNativeHeaders();
assertThat(nativeHeaderOutput.getExecPathString()).isEqualTo(outputPath);
}
private static String outputPath(Action action, String suffix) {
System.err.println(action.getOutputs());
Artifact artifact = ActionsTestUtil.getFirstArtifactEndingWith(action.getOutputs(), suffix);
return verifyNotNull(artifact, suffix).getExecPath().getPathString();
}
@Test
public void skylarkJavaInfoToAndroidLibraryAttributes() throws Exception {
scratch.file(
"foo/extension.bzl",
"def _impl(ctx):",
" dep_params = ctx.attr.dep[JavaInfo]",
" return [dep_params]",
"my_rule = rule(",
" _impl,",
" attrs = {",
" 'dep': attr.label(),",
" },",
")");
scratch.file(
"foo/BUILD",
"load(':extension.bzl', 'my_rule')",
"android_library(",
" name = 'al_bottom_for_deps',",
" srcs = ['java/A.java'],",
")",
"android_library(",
" name = 'jl_bottom_for_exports',",
" srcs = ['java/A2.java'],",
")",
"my_rule(",
" name = 'mya',",
" dep = ':al_bottom_for_deps',",
")",
"my_rule(",
" name = 'myb',",
" dep = ':jl_bottom_for_exports',",
")",
"android_library(",
" name = 'lib_foo',",
" srcs = ['java/B.java'],",
" deps = [':mya'],",
" exports = [':myb'],",
")");
// Test that all bottom jars are on the runtime classpath of lib_android.
ConfiguredTarget target = getConfiguredTarget("//foo:lib_foo");
ImmutableList<Artifact> transitiveSrcJars =
OutputGroupInfo.get(target).getOutputGroup(JavaSemantics.SOURCE_JARS_OUTPUT_GROUP).toList();
assertThat(ActionsTestUtil.baseArtifactNames(transitiveSrcJars))
.containsExactly(
"libjl_bottom_for_exports-src.jar",
"libal_bottom_for_deps-src.jar",
"liblib_foo-src.jar");
}
@Test
public void testLocalResourcesFirstInJavaCompilationClasspath() throws Exception {
scratch.file(
"java/foo/BUILD",
"android_library(",
" name='dep',",
" srcs=['dep.java'], ",
" resource_files=['res/values/dep.xml'],",
" manifest='AndroidManifest.xml',",
")",
"android_library(",
" name='lib',",
" srcs=['lib.java'],",
" resource_files=['res/values/lib.xml'],",
" manifest='AndroidManifest.xml',",
" deps=[':dep']",
")");
JavaCompileAction javacAction =
(JavaCompileAction)
getGeneratingAction(getFileConfiguredTarget("//java/foo:liblib.jar").getArtifact());
assertThat(prettyArtifactNames(getInputs(javacAction, getDirectJars(javacAction))))
.containsExactly(
"java/foo/lib_resources.jar", "java/foo/dep_resources.jar", "java/foo/libdep-hjar.jar")
.inOrder();
assertThat(prettyArtifactNames(getInputs(javacAction, getClasspath(javacAction))))
.containsExactly(
"java/foo/lib_resources.jar", "java/foo/dep_resources.jar", "java/foo/libdep-hjar.jar")
.inOrder();
}
@Test
public void testAndroidCcLinkParamsProvider() throws Exception {
scratch.file(
"java/foo/BUILD",
"cc_library(",
" name='cc_dep',",
" srcs=['dep.cc'],",
" linkopts = ['-CC_DEP'],",
")",
"android_library(",
" name='lib',",
" srcs=['lib.java'],",
" deps=[':cc_dep']",
")");
ConfiguredTarget target = getConfiguredTarget("//java/foo:lib");
assertThat(
target
.get(AndroidCcLinkParamsProvider.PROVIDER)
.getLinkParams()
.getCcLinkingContext()
.getFlattenedUserLinkFlags())
.containsExactly("-CC_DEP")
.inOrder();
}
/** Returns command-line arguments used in the AndroidCompiledResourceMerger action. */
private List<String> getRClassGenerationArgs(ConfiguredTarget androidLibrary) throws Exception {
return getGeneratingSpawnActionArgs(
getValidatedAndroidResources(androidLibrary).getJavaClassJar());
}
private static ValidatedAndroidResources getValidatedAndroidResources(
ConfiguredTarget androidLibrary) {
return androidLibrary
.get(AndroidResourcesInfo.PROVIDER)
.getDirectAndroidResources()
.getSingleton();
}
/**
* Decodes arguments provided as {@link com.google.devtools.build.android.SerializedAndroidData}.
*/
private static ImmutableList<String> getDependencyResourceLabels(List<String> args, String flag) {
String value = getFlagValue(args, flag);
ImmutableList.Builder<String> result = ImmutableList.builder();
for (String dependency : Splitter.on(',').split(value)) {
assertThat(dependency).matches("([^;]*;){3}[^;]*");
result.add(dependency.split(";", -1)[2]);
}
return result.build();
}
/** Returns names of files being sent to the AndroidResourceCompiler action. */
private ImmutableList<String> getResourceCompilationInputFiles(ConfiguredTarget androidLibrary) {
SpawnAction action =
getGeneratingSpawnAction(
androidLibrary
.get(AndroidResourcesInfo.PROVIDER)
.getDirectAndroidResources()
.getSingleton()
.getCompiledSymbols());
return action.getInputs().toList().stream()
.map(Artifact::getRootRelativePathString)
.collect(ImmutableList.toImmutableList());
}
/** Returns command-line arguments used in the AndroidCompiledResourceMerger action. */
private List<String> getResourceMergingArgs(ConfiguredTarget androidLibrary) throws Exception {
return getGeneratingSpawnActionArgs(
androidLibrary
.get(AndroidResourcesInfo.PROVIDER)
.getDirectAndroidResources()
.getSingleton()
.getJavaClassJar());
}
/**
* Decodes arguments provided as {@link com.google.devtools.build.android.SerializedAndroidData}.
*/
private static List<String> getDependencyAssetDirs(List<String> actualArgs, String flag) {
String actualFlagValue = getFlagValue(actualArgs, flag);
ImmutableList.Builder<String> actualPaths = ImmutableList.builder();
for (String resourceDependency : Splitter.on(',').split(actualFlagValue)) {
assertThat(actualFlagValue).matches("[^;]*;[^;]*;[^;]*;.*");
actualPaths.add(resourceDependency.split(";", -1)[1].split("#"));
}
return actualPaths.build();
}
private static String getFlagValue(List<String> argv, String flag) {
assertThat(argv).contains(flag);
return argv.get(argv.indexOf(flag) + 1);
}
}