Starlarkify GoCcLinkParamsInfo provider and remove its native implementation PiperOrigin-RevId: 454840826 Change-Id: I9a149334ab90b3553b27c18325c97da1c901f2bc
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/GoogleLegacyStubs.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/GoogleLegacyStubs.java index 2fac7fb..bb4b8db 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/GoogleLegacyStubs.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/GoogleLegacyStubs.java
@@ -25,7 +25,6 @@ import com.google.devtools.build.lib.starlarkbuildapi.cpp.CcToolchainProviderApi; import com.google.devtools.build.lib.starlarkbuildapi.cpp.CompilationInfoApi; import com.google.devtools.build.lib.starlarkbuildapi.cpp.FeatureConfigurationApi; -import com.google.devtools.build.lib.starlarkbuildapi.cpp.GoCcLinkParamsInfoApi; import com.google.devtools.build.lib.starlarkbuildapi.cpp.GoWrapCcHelperApi; import com.google.devtools.build.lib.starlarkbuildapi.cpp.PyCcLinkParamsProviderApi; import com.google.devtools.build.lib.starlarkbuildapi.cpp.PyWrapCcHelperApi; @@ -199,14 +198,6 @@ return null; } - - @Override - public GoCcLinkParamsInfoApi getGoCcLinkParamsProvider( - StarlarkRuleContextApi<ConstraintValueInfoApi> ruleContext, - CcLinkingContextApi<FileApi> ccLinkingContext) { - return null; - } - @Override public Tuple createGoCompileActions( StarlarkRuleContextApi<ConstraintValueInfoApi> starlarkRuleContext,
diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/GoCcLinkParamsInfoApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/GoCcLinkParamsInfoApi.java deleted file mode 100644 index d5f6a5e..0000000 --- a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/GoCcLinkParamsInfoApi.java +++ /dev/null
@@ -1,55 +0,0 @@ -// Copyright 2019 The Bazel Authors. All rights reserved. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.devtools.build.lib.starlarkbuildapi.cpp; - -import com.google.devtools.build.docgen.annot.DocCategory; -import com.google.devtools.build.docgen.annot.StarlarkConstructor; -import com.google.devtools.build.lib.starlarkbuildapi.FileApi; -import com.google.devtools.build.lib.starlarkbuildapi.core.ProviderApi; -import com.google.devtools.build.lib.starlarkbuildapi.core.StructApi; -import net.starlark.java.annot.Param; -import net.starlark.java.annot.StarlarkBuiltin; -import net.starlark.java.annot.StarlarkMethod; -import net.starlark.java.eval.EvalException; - -/** A target that provides C++ libraries to be linked into Go targets. */ -@StarlarkBuiltin( - name = "GoCcLinkParamsInfo", - doc = "", - documented = false, - category = DocCategory.PROVIDER) -public interface GoCcLinkParamsInfoApi extends StructApi { - - /** Provider for GoContextInfo objects. */ - @StarlarkBuiltin(name = "Provider", doc = "", documented = false) - public interface Provider< - FileT extends FileApi, CcLinkingContextT extends CcLinkingContextApi<FileT>> - extends ProviderApi { - @StarlarkMethod( - name = "GoCcLinkParamsInfo", - doc = "The <code>GoCcLinkParamsInfo</code> constructor.", - parameters = { - @Param( - name = "linking_context", - doc = "The CC linking context.", - positional = false, - named = true), - }, - selfCall = true) - @StarlarkConstructor - public GoCcLinkParamsInfoApi createInfo(CcLinkingContextT ccLinkingContext) - throws EvalException; - } -}
diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/GoWrapCcHelperApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/GoWrapCcHelperApi.java index 5a8ade6..225ca49 100644 --- a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/GoWrapCcHelperApi.java +++ b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/GoWrapCcHelperApi.java
@@ -106,18 +106,6 @@ CcInfoT ccInfo); @StarlarkMethod( - name = "go_cc_link_params_provider", - doc = "", - documented = false, - parameters = { - @Param(name = "ctx", positional = false, named = true), - @Param(name = "linking_context", positional = false, named = true), - }) - public GoCcLinkParamsInfoApi getGoCcLinkParamsProvider( - StarlarkRuleContextT ruleContext, CcLinkingContextT ccLinkingContext) - throws EvalException, InterruptedException; - - @StarlarkMethod( name = "create_go_compile_actions", doc = "", documented = false,