commit 3d97eacd6abf1f86777f2c3fb195ab75e30ed6e2
author mschaller <mschaller@google.com> Mon Mar 30 11:44:14 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Mar 30 11:46:11 2020 -0700
tree 297ec908d19ea0edea81b044ded4d36ecbc004fd
parent 5eced211e7800c1837059c0557ce978d40bb88a8

Clean up failure_details.proto

This renames "UNSPECIFIED" enum values to "UNKNOWN" to catch up to the
latest best practices. ("unspecified" can be misleading in
forward-compatibility contexts)

RELNOTES: None.
PiperOrigin-RevId: 303787662

src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java

diff --git a/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java b/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java
index e8e6488..b95ece0 100644
--- a/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java
+++ b/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java
@@ -618,7 +618,7 @@
               FailureDetail.newBuilder()
                   .setMessage("interrupted")
                   .setInterrupted(
-                      Interrupted.newBuilder().setCode(Interrupted.Code.INTERRUPTED_UNSPECIFIED))
+                      Interrupted.newBuilder().setCode(Interrupted.Code.INTERRUPTED_UNKNOWN))
                   .build());
       commandId = ""; // The default value, the client will ignore it
     }

src/main/protobuf/failure_details.proto

diff --git a/src/main/protobuf/failure_details.proto b/src/main/protobuf/failure_details.proto
index 9882bd8..90475a9 100644
--- a/src/main/protobuf/failure_details.proto
+++ b/src/main/protobuf/failure_details.proto
@@ -98,7 +98,7 @@
 message Interrupted {
   enum Code {
     // Interrupted at an unspecified time.
-    INTERRUPTED_UNSPECIFIED = 0 [(metadata) = { exit_code: 8 }];
+    INTERRUPTED_UNKNOWN = 0 [(metadata) = { exit_code: 8 }];
 
     reserved 1; // For internal use
 

src/test/java/com/google/devtools/build/lib/server/GrpcServerTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/server/GrpcServerTest.java b/src/test/java/com/google/devtools/build/lib/server/GrpcServerTest.java
index 28045af..39a8b51 100644
--- a/src/test/java/com/google/devtools/build/lib/server/GrpcServerTest.java
+++ b/src/test/java/com/google/devtools/build/lib/server/GrpcServerTest.java
@@ -400,7 +400,7 @@
     assertThat(secondResponse.get().hasFailureDetail()).isTrue();
     assertThat(secondResponse.get().getFailureDetail().hasInterrupted()).isTrue();
     assertThat(secondResponse.get().getFailureDetail().getInterrupted().getCode())
-        .isEqualTo(Interrupted.Code.INTERRUPTED_UNSPECIFIED);
+        .isEqualTo(Interrupted.Code.INTERRUPTED_UNKNOWN);
   }
 
   @Test

src/test/java/com/google/devtools/build/lib/util/DetailedExitCodeTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/util/DetailedExitCodeTest.java b/src/test/java/com/google/devtools/build/lib/util/DetailedExitCodeTest.java
index 24411a7..449dcb2 100644
--- a/src/test/java/com/google/devtools/build/lib/util/DetailedExitCodeTest.java
+++ b/src/test/java/com/google/devtools/build/lib/util/DetailedExitCodeTest.java
@@ -33,7 +33,7 @@
                 FailureDetail.newBuilder()
                     .setMessage("interrupted")
                     .setInterrupted(
-                        Interrupted.newBuilder().setCode(Interrupted.Code.INTERRUPTED_UNSPECIFIED))
+                        Interrupted.newBuilder().setCode(Interrupted.Code.INTERRUPTED_UNKNOWN))
                     .build()))
         .hasExitCode(ExitCode.INTERRUPTED);
   }