commit 3eb42985b856421e9669e2e94c44b176bd7c5162
author aiuto <aiuto@google.com> Mon Nov 18 06:50:06 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Nov 18 06:51:56 2019 -0800
tree 0e69cada6d41cf68097a7ffcd81f8510942ebb60
parent b1d05be70776a172992c7b672a65080d2af5ca1f

Extend the interdependency rules between //experimental and other code
to also apply to //third_party/experimental.

See:[]
PiperOrigin-RevId: 281058640

src/main/java/com/google/devtools/build/lib/analysis/CommonPrerequisiteValidator.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/CommonPrerequisiteValidator.java b/src/main/java/com/google/devtools/build/lib/analysis/CommonPrerequisiteValidator.java
index 198cee2..ba9225d 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/CommonPrerequisiteValidator.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/CommonPrerequisiteValidator.java
@@ -256,7 +256,7 @@
   }
 
   /** Check that the dependency is not test-only, or the current rule is test-only. */
-  private static void validateDirectPrerequisiteForTestOnly(
+  private void validateDirectPrerequisiteForTestOnly(
       RuleContext.Builder context, ConfiguredTargetAndData prerequisite) {
     Rule rule = context.getRule();
 
@@ -267,7 +267,7 @@
     }
 
     Target prerequisiteTarget = prerequisite.getTarget();
-    String thisPackage = rule.getLabel().getPackageName();
+    PackageIdentifier thisPackage = rule.getLabel().getPackageIdentifier();
 
     if (isTestOnlyRule(prerequisiteTarget) && !isTestOnlyRule(rule)) {
       String message =
@@ -276,7 +276,7 @@
               + "' depends on testonly "
               + AliasProvider.describeTargetWithAliases(prerequisite, TargetMode.WITHOUT_KIND)
               + " and doesn't have testonly attribute set";
-      if (thisPackage.startsWith("experimental/")) {
+      if (packageUnderExperimental(thisPackage)) {
         context.ruleWarning(message);
       } else {
         context.ruleError(message);