commit 3ee91b4416e03239bf57ecec20c8f3e00b8a4e17
author janakr <janakr@google.com> Tue Feb 18 11:58:43 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Feb 18 12:00:42 2020 -0800
tree ea9ff1acf27b002af78d4f442f2172b14d291644
parent 04a8db78f3199d5b2fa20c4336e473911979f166

Don't crash if no cycle reporter can handle a found cycle. We can display a (non-ideal) version and file a bug report.

PiperOrigin-RevId: 295789287

src/main/java/com/google/devtools/build/skyframe/CyclesReporter.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/CyclesReporter.java b/src/main/java/com/google/devtools/build/skyframe/CyclesReporter.java
index 68ff579..0637dd6 100644
--- a/src/main/java/com/google/devtools/build/skyframe/CyclesReporter.java
+++ b/src/main/java/com/google/devtools/build/skyframe/CyclesReporter.java
@@ -15,6 +15,8 @@
 
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
+import com.google.devtools.build.lib.bugreport.BugReport;
+import com.google.devtools.build.lib.events.Event;
 import com.google.devtools.build.lib.events.ExtendedEventHandler;
 
 /**
@@ -83,8 +85,15 @@
         return;
       }
     }
-    throw new IllegalStateException(
-        printArbitraryCycle(topLevelKey, cycleInfo, alreadyReported) + "\n" + cycleReporters);
+
+    // No proper cycle reporter could be found. Blaze bug! Not fatal, though.
+    String rawCycle = printArbitraryCycle(topLevelKey, cycleInfo, alreadyReported);
+    eventHandler.handle(
+        Event.error(
+            "Cycle detected but could not be properly displayed due to an internal problem. Please"
+                + " file an issue. Raw display: "
+                + rawCycle));
+    BugReport.sendBugReport(new IllegalStateException(rawCycle + "\n" + cycleReporters));
   }
 
   private static String printArbitraryCycle(