| commit | 402d56e38fe50b459495f443a5273cb10f646ec7 | [log] [tgz] |
|---|---|---|
| author | juliexxia <juliexxia@google.com> | Thu Apr 18 09:41:27 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Apr 18 09:44:05 2019 -0700 |
| tree | b8357a19f4c8e4aa95baecdd38491be873a6669e | |
| parent | 0245e879f46693530a8726ea0670962a5f6c91ee [diff] |
Get rid of some obsolete TODOs RELNOTES: None. PiperOrigin-RevId: 244201940
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkTransition.java index 25ec1ed..47cdc18 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkTransition.java
@@ -275,7 +275,6 @@ return buildSettingTarget; } - // TODO(juliexxia): use an enum for "inputs"/"outputs" here and elsewhere in starlark transitions. private static ImmutableSet<Label> getRelevantStarlarkSettingsFromTransition( StarlarkTransition transition, Settings inputOrOutput) { List<String> toGet =
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java b/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java index 9202955..ad87ed4 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java
@@ -159,7 +159,6 @@ } parsedOptions.put(loadedFlag, value); } - // TODO(juliexxia): change this method to setStarlarkOptions nativeOptionsParser.setStarlarkOptions(parsedOptions.build()); }