commit 4c36d9e2804047c4ffa26b720bc58e317852d61d
author Googler <noreply@google.com> Fri Mar 13 10:23:24 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Mar 13 10:24:28 2020 -0700
tree cd0957bacf6b3da7ff783a3c8c6cab0280034b63
parent 7008bfe8fa1b847b60c6411720ad82c2fca95321

Create a NestedSet method isReady to determine whether the NestedSet requires blocking.

This tells us whether the contents require blocking without exposing the raw children.

PiperOrigin-RevId: 300780177

src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSet.java

diff --git a/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSet.java b/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSet.java
index 8f82698..04560d7 100644
--- a/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSet.java
+++ b/src/main/java/com/google/devtools/build/lib/collect/nestedset/NestedSet.java
@@ -298,6 +298,16 @@
     return children instanceof ListenableFuture;
   }
 
+  /**
+   * Returns true if the contents of this set are currently available in memory.
+   *
+   * <p>Only returns false if this set {@link #isFromStorage} and the contents are not fully
+   * deserialized.
+   */
+  public boolean isReady() {
+    return !isFromStorage() || ((ListenableFuture<Object[]>) children).isDone();
+  }
+
   /** Returns the single element; only call this if {@link #isSingleton} returns true. */
   public E getSingleton() {
     Preconditions.checkState(isSingleton());

src/test/java/com/google/devtools/build/lib/collect/nestedset/NestedSetImplTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/collect/nestedset/NestedSetImplTest.java b/src/test/java/com/google/devtools/build/lib/collect/nestedset/NestedSetImplTest.java
index 0752f9e..3d40e9c 100644
--- a/src/test/java/com/google/devtools/build/lib/collect/nestedset/NestedSetImplTest.java
+++ b/src/test/java/com/google/devtools/build/lib/collect/nestedset/NestedSetImplTest.java
@@ -324,4 +324,19 @@
     NestedSet<?> inMemoryNestedSet = NestedSetBuilder.create(Order.STABLE_ORDER, "a", "b");
     assertThat(inMemoryNestedSet.isFromStorage()).isFalse();
   }
+
+  @Test
+  public void isReady_inMemory() {
+    NestedSet<?> inMemoryNestedSet = NestedSetBuilder.create(Order.STABLE_ORDER, "a", "b");
+    assertThat(inMemoryNestedSet.isReady()).isTrue();
+  }
+
+  @Test
+  public void isReady_fromStorage() {
+    SettableFuture<Object[]> future = SettableFuture.create();
+    NestedSet<?> deserializingNestedSet = NestedSet.withFuture(Order.STABLE_ORDER, future);
+    assertThat(deserializingNestedSet.isReady()).isFalse();
+    future.set(new Object[] {"a", "b"});
+    assertThat(deserializingNestedSet.isReady()).isTrue();
+  }
 }