commit 4f0b710e2b935b4249e0bbf633f43628bbf93d7b
author ulfjack <ulfjack@google.com> Wed Nov 20 08:30:33 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Nov 20 08:32:51 2019 -0800
tree 14ef55e4a501e44c1f67b8fd690b257ccea71c1d
parent 227822b047afcaf218e572d26206838531f38a13

UI: report success if tests are flaky

Previously, Bazel reported failures if tests are flaky, even if the
overall status was a success.

Before:
INFO: Build completed, 1 test FAILED, 3 total actions

After:
INFO: Build completed successfully, 8 total actions
PiperOrigin-RevId: 281525913

src/main/java/com/google/devtools/build/lib/runtime/UiStateTracker.java

diff --git a/src/main/java/com/google/devtools/build/lib/runtime/UiStateTracker.java b/src/main/java/com/google/devtools/build/lib/runtime/UiStateTracker.java
index 9c8ef96..8bb7f9a 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/UiStateTracker.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/UiStateTracker.java
@@ -869,7 +869,8 @@
   public synchronized void testSummary(TestSummary summary) {
     completedTests++;
     mostRecentTest = summary;
-    if (summary.getStatus() != BlazeTestStatus.PASSED) {
+    if ((summary.getStatus() != BlazeTestStatus.PASSED)
+        && (summary.getStatus() != BlazeTestStatus.FLAKY)) {
       failedTests++;
     }
   }