commit 6b1f66cc3b101dfca291df28971e007b4cc9a1b8
author Jakob Buchgraber <buchgr@google.com> Mon Apr 15 06:42:51 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Apr 15 06:44:08 2019 -0700
tree 59d7ec59aaef386821c7a52ee69a3451e8ecb30f
parent 8fe5479de9f2821e48d122b25f87410a836fa19b

fix bazel_with_jdk_test to properly depend on JAVABASE

Progress towards #8033

Closes #8042.

PiperOrigin-RevId: 243606106

src/test/shell/bazel/BUILD

diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD
index 2ece60f..de4d628 100644
--- a/src/test/shell/bazel/BUILD
+++ b/src/test/shell/bazel/BUILD
@@ -641,12 +641,14 @@
     name = "bazel_with_jdk_test",
     size = "medium",
     srcs = ["bazel_with_jdk_test.sh"],
+    args = ["$(JAVABASE)"],
     data = [
         ":test-deps",
         "//src:bazel",
         "@bazel_tools//tools/bash/runfiles",
     ],
     tags = ["no_windows"],
+    toolchains = ["@bazel_tools//tools/jdk:current_java_runtime"],
 )
 
 sh_test(

src/test/shell/bazel/bazel_with_jdk_test.sh

diff --git a/src/test/shell/bazel/bazel_with_jdk_test.sh b/src/test/shell/bazel/bazel_with_jdk_test.sh
index 7fc5643..006a09b 100755
--- a/src/test/shell/bazel/bazel_with_jdk_test.sh
+++ b/src/test/shell/bazel/bazel_with_jdk_test.sh
@@ -64,6 +64,19 @@
   export MSYS2_ARG_CONV_EXCL="*"
 fi
 
+if "$is_windows"; then
+  EXE_EXT=".exe"
+else
+  EXE_EXT=""
+fi
+
+javabase="$1"
+if [[ $javabase = external/* ]]; then
+  javabase=${javabase#external/}
+fi
+javabase="$(rlocation "${javabase}/bin/java${EXE_EXT}")"
+javabase=${javabase%/bin/java${EXE_EXT}}
+
 function bazel() {
   $(rlocation io_bazel/src/bazel) --bazelrc=$TEST_TMPDIR/bazelrc "$@"
   return $?
@@ -82,7 +95,7 @@
   fgrep -v -- "--host_javabase" "$TEST_TMPDIR/bazelrc" > "$TEST_TMPDIR/bazelrc.new"
   mv "$TEST_TMPDIR/bazelrc.new" "$TEST_TMPDIR/bazelrc"
   # ... but ensure JAVA_HOME is set, so we can find a default --javabase
-  export JAVA_HOME="${bazel_javabase}"
+  export JAVA_HOME="${javabase}"
 }
 
 function test_bazel_uses_bundled_jdk() {