Convert flag --experimental_restrict_named_params to --incompatible_restrict_named_params This was always going to be an incompatible-style flag, but it was previously not fully implemented. Now it is. Progress toward #8147 and #5010. RELNOTES: Flag `--incompatible_restrict_named_params` is added. See https://github.com/bazelbuild/bazel/issues/8147 for details. PiperOrigin-RevId: 245428103
diff --git a/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java b/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java index 7b5c18a..bc9fbb1 100644 --- a/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java +++ b/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java
@@ -131,7 +131,6 @@ + "," + rand.nextDouble(), "--experimental_platforms_api=" + rand.nextBoolean(), - "--experimental_restrict_named_params=" + rand.nextBoolean(), "--experimental_starlark_config_transitions=" + rand.nextBoolean(), "--incompatible_bzl_disallow_load_after_statement=" + rand.nextBoolean(), "--incompatible_depset_is_not_iterable=" + rand.nextBoolean(), @@ -161,6 +160,7 @@ "--incompatible_objc_framework_cleanup=" + rand.nextBoolean(), "--incompatible_remap_main_repo=" + rand.nextBoolean(), "--incompatible_remove_native_maven_jar=" + rand.nextBoolean(), + "--incompatible_restrict_named_params=" + rand.nextBoolean(), "--incompatible_static_name_resolution_in_build_files=" + rand.nextBoolean(), "--incompatible_string_join_requires_strings=" + rand.nextBoolean(), "--internal_skylark_flag_test_canary=" + rand.nextBoolean(), @@ -183,7 +183,6 @@ .experimentalJavaCommonCreateProviderEnabledPackages( ImmutableList.of(String.valueOf(rand.nextDouble()), String.valueOf(rand.nextDouble()))) .experimentalPlatformsApi(rand.nextBoolean()) - .experimentalRestrictNamedParams(rand.nextBoolean()) .experimentalStarlarkConfigTransitions(rand.nextBoolean()) .incompatibleBzlDisallowLoadAfterStatement(rand.nextBoolean()) .incompatibleDepsetIsNotIterable(rand.nextBoolean()) @@ -213,6 +212,7 @@ .incompatibleObjcFrameworkCleanup(rand.nextBoolean()) .incompatibleRemapMainRepo(rand.nextBoolean()) .incompatibleRemoveNativeMavenJar(rand.nextBoolean()) + .incompatibleRestrictNamedParams(rand.nextBoolean()) .incompatibleStaticNameResolutionInBuildFiles(rand.nextBoolean()) .incompatibleStringJoinRequiresStrings(rand.nextBoolean()) .internalSkylarkFlagTestCanary(rand.nextBoolean())
diff --git a/src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java b/src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java index bf4cc44..7745179 100644 --- a/src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java +++ b/src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java
@@ -749,7 +749,7 @@ @Test public void testExperimentalStarlarkConfig() throws Exception { - new SkylarkTest("--experimental_restrict_named_params") + new SkylarkTest("--incompatible_restrict_named_params") .testIfErrorContains( "parameter 'elements' may not be specified by name, " + "for call to method join(elements) of 'string'",