Clean-up: Don't unnecessarily loop over map's entry set when all we need are the values. PiperOrigin-RevId: 291777645
diff --git a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java index 2807768..3678032 100644 --- a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java +++ b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
@@ -605,10 +605,10 @@ Map<SkyKey, Target> targetMap = new HashMap<>(); Set<SkyKey> depLabels = ImmutableSet.copyOf(Iterables.concat(keyToDepKeys.values())); - for (Map.Entry<SkyKey, Collection<Target>> entry : targetDepMap.entrySet()) { - for (Target target : entry.getValue()) { - targetMap.putIfAbsent(target.getLabel(), target); - toAddTo.add(target); + for (Collection<Target> depTargets : targetDepMap.values()) { + for (Target depTarget : depTargets) { + targetMap.putIfAbsent(depTarget.getLabel(), depTarget); + toAddTo.add(depTarget); } } reportUnsuccessfulOrMissingTargets(targetMap, depLabels, caller);