| commit | 723eca61fe3899ab94d4eadfe17bd212104d8bfb | [log] [tgz] |
|---|---|---|
| author | Benjamin Peterson <bp@benjamin.pe> | Mon Jul 22 17:24:10 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jul 22 17:25:12 2019 -0700 |
| tree | 8f5c96880a83b1e44fd06de193f29366f76900a3 | |
| parent | a5e40a5f3f69d9992f144a4b51b110f503759840 [diff] |
Always report when a package is done to the PackageProgressReceiver.
Previously, if a package was so broken that a even an errored PackageValue couldn't be created for it, it would hang around in the UI ("currently loading //some/broken/package") for the entire analysis-loading phase. This behavior was because PackageProgressReceiver didn't receive a done notification from PackageFunction in extreme error cases. The fix is to call PackageProgressReceiver.doneReadPackage even when exceptions happen during loading.
While we're here, save a level of indentation in PackageFunction.loadPackage() by moving the cache checking logic to the single caller.
Closes #8209.
PiperOrigin-RevId: 259439995
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.