| commit | 74ca288c0711deec4c308759e4db9d0aedcfe4bd | [log] [tgz] |
|---|---|---|
| author | Kevin Gessner <kgessner@etsy.com> | Wed Nov 04 23:58:52 2020 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Nov 04 23:59:56 2020 -0800 |
| tree | 2b8fee8633c02aaf0ffc0042a9292922e26e9c23 | |
| parent | cfb5b41d27d3d28e7bd9d5be1ad68ff69f5aa725 [diff] |
ensure the gRPC LoggingInterceptor does not throw exceptions where they cannot be handled This fixes a hang that I've struggled with for ages: when using `--build_event_json_file` to write a BEP file, enabling `--experimental_remote_grpc_log` causes the build to hang indefinitely after completion with a message of "Waiting for build events upload: JsonFormatFileTransport". The default `--build_event_json_file_path_conversion` ends up doing an RPC call when closing the BEP file. Unfortunately, this call happens after the gRPC log file has already been closed. That exception in the LoggingInterceptor is uncatchable -- it [causes the RPC call to hang indefinitely](https://github.com/grpc/grpc-java/pull/6107). Therefore, Bazel needs to handle and consume the exception so `onClose` always succeeds. Closes #12416. PiperOrigin-RevId: 340796218
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
