Extend the Starlark style guide guidance wrt macros to also cover variables. PiperOrigin-RevId: 317149780
diff --git a/site/docs/skylark/bzl-style.md b/site/docs/skylark/bzl-style.md index 4d023f8..52647ca 100644 --- a/site/docs/skylark/bzl-style.md +++ b/site/docs/skylark/bzl-style.md
@@ -30,10 +30,11 @@ becomes more and more frequent to do changes across many BUILD files in order to update a library or do a cleanup. -Do not create a macro just to avoid some amount of repetition in BUILD files. -The [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) principle -doesn't really apply here. The goal is not to make the file shorter; the goal is -to make your files easy to process, both by humans and tools. +**IMPORTANT:** Do not create a variable or macro just to avoid some amount of +repetition in BUILD files. Your BUILD file should be easily readable both by +developers and tools. The +[DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) principle doesn't +really apply here. ## General advice