| commit | 882afdff1dfeeff7ab87f17c80f723f1dcf3fd38 | [log] [tgz] |
|---|---|---|
| author | Googler <noreply@google.com> | Tue Jun 15 05:25:12 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jun 15 05:26:15 2021 -0700 |
| tree | 8b233ca4bfd6c7a88acc8831744e9c1163321fb7 | |
| parent | 83563589c33d247d42faa8f8dc7eb2e884c9b353 [diff] |
Ignore InstrumentedFilesInfo from base rule when also returned by aspect Currently, aspects should not return InstrumentedFilesInfo, since that may be returned by any rule target. Doing so introduces an inadvertent brittle assumption that the rule targets visited by an aspect do not provide InstrumentedFilesInfo. For example, if foo_library and foo_proto_library share an implementation so that foo_proto_library (which traverses proto_library targets) carelessly returns InstrumentedFilesInfo, this doesn't currently influence coverage behavior. But it will break as soon as proto_library starts returning InstrumentedFilesInfo. This brittleness will come into play when the default behavior for coverage is changed from "forward nothing" to "forward from all non-tool dependencies" (currently conditioned on the flag --experimental_forward_instrumented_files_info_by_default). Instead, ignore the InstrumentedFilesInfo from the base rule target if it's returned by an aspect. RELNOTES: None. PiperOrigin-RevId: 379467851
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
