commit 938db6db6501d75f3ad5bce4f6735ed86bf51f47
author mstaib <mstaib@google.com> Tue Apr 23 17:53:13 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Apr 23 17:54:44 2019 -0700
tree 2d80348c83ecfa5b26e062c46b6da7297561ac98
parent 6e2cfe9b23b635949e0f7cc9bd6df3ddbf0b6ade

Add TODO about trimming Starlark build configuration values.

Progress on #6524.

PiperOrigin-RevId: 244960345

src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java
index a8ac70f..ba4e6ac 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildOptions.java
@@ -901,6 +901,8 @@
      */
     public static ConfigurationComparer.Result compareFragments(
         OptionsDiffForReconstruction left, OptionsDiffForReconstruction right) {
+      // TODO: Add support for marking Starlark options as known default when trimming
+      // (sentinel object?)
       Preconditions.checkArgument(
           Arrays.equals(left.baseFingerprint, right.baseFingerprint),
           "Can't compare diffs with different bases: %s and %s",