Google Git
Sign in
bazel/bazel/94015e35cbf1985ef83712a9f15ef4bf62abf3ff
commit
94015e35cbf1985ef83712a9f15ef4bf62abf3ff
[log]
author
nharmata <nharmata@google.com>
Wed Apr 22 16:17:52 2020 -0700
committer
Copybara-Service <copybara-worker@google.com>
Wed Apr 22 16:19:03 2020 -0700
tree
9e2a420be53b5901c73e9b89c8656777c46321ae
parent
3262af87d3cbd282ded716f1ba7339e1a10d131e [diff]
Have SkyQuery tolerate the situation where a done node has a transitive rdep from a not-done node.

This situation can easily arise when `query` and `build` are interspersed. SkyQuery wasn't designed with this use-case in mind [1], but some Bazel users are doing this (see https://github.com/bazelbuild/bazel/issues/8582), so we can at least tolerate it. See added code comments and test for details.

This bug was diagnosed jointly by janakr@ and nharmata@ in https://github.com/bazelbuild/bazel/issues/8582#issuecomment-615021266 and https://github.com/bazelbuild/bazel/issues/8582#issuecomment-615026057.

[1] It was originally planned to be query-only. In fact, the more general issue here points to an inefficiency in the interspersed usage case. I explained in the code comment and added a TODO.

Fixes #8582

RELNOTES: None
PiperOrigin-RevId: 307925028
2 files changed
tree: 9e2a420be53b5901c73e9b89c8656777c46321ae
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEOWNERS
  15. combine_distfiles.py
  16. combine_distfiles_to_tar.sh
  17. compile.sh
  18. CONTRIBUTING.md
  19. CONTRIBUTORS
  20. distdir.bzl
  21. ISSUE_TEMPLATE.md
  22. LICENSE
  23. README.md
  24. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status