Remove ReverseDepsUtility#maybeCheckReverseDepNotPresent since it is dead code outside of the unit test.

PiperOrigin-RevId: 333392005

src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java b/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java
index 9112cbb..7041faf 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ReverseDepsUtility.java
@@ -83,34 +83,6 @@
     return !(entry.getReverseDepsRawForReverseDepsUtil() instanceof List);
   }
 
-  /**
-   * We only check if reverse deps is small and there are no delayed data to consolidate, since then
-   * presence or absence would not be known.
-   */
-  static void maybeCheckReverseDepNotPresent(InMemoryNodeEntry entry, SkyKey reverseDep) {
-    if (entry.getReverseDepsDataToConsolidateForReverseDepsUtil() != null) {
-      return;
-    }
-    if (isSingleReverseDep(entry)) {
-      Preconditions.checkState(
-          !entry.getReverseDepsRawForReverseDepsUtil().equals(reverseDep),
-          "Reverse dep %s already present in %s",
-          reverseDep,
-          entry);
-      return;
-    }
-    @SuppressWarnings("unchecked")
-    List<SkyKey> asList = (List<SkyKey>) entry.getReverseDepsRawForReverseDepsUtil();
-    if (asList.size() < MAYBE_CHECK_THRESHOLD) {
-      Preconditions.checkState(
-          !asList.contains(reverseDep),
-          "Reverse dep %s already present in %s for %s",
-          reverseDep,
-          asList,
-          entry);
-    }
-  }
-
   @SuppressWarnings("unchecked") // Cast to list.
   private static int getCurrentReverseDepSize(InMemoryNodeEntry entry) {
     return isSingleReverseDep(entry)

src/test/java/com/google/devtools/build/skyframe/ReverseDepsUtilityTest.java

diff --git a/src/test/java/com/google/devtools/build/skyframe/ReverseDepsUtilityTest.java b/src/test/java/com/google/devtools/build/skyframe/ReverseDepsUtilityTest.java
index 8aed682..0a5ee1a 100644
--- a/src/test/java/com/google/devtools/build/skyframe/ReverseDepsUtilityTest.java
+++ b/src/test/java/com/google/devtools/build/skyframe/ReverseDepsUtilityTest.java
@@ -134,24 +134,6 @@
     assertThat(ReverseDepsUtility.getReverseDeps(example)).containsExactly(fixedKey, key);
   }
 
-  @Test
-  public void testMaybeCheck() {
-    InMemoryNodeEntry example = new InMemoryNodeEntry();
-    for (int i = 0; i < numElements; i++) {
-      ReverseDepsUtility.addReverseDeps(example, Collections.singleton(Key.create(i)));
-      // This should always succeed, since the next element is still not present.
-      ReverseDepsUtility.maybeCheckReverseDepNotPresent(example, Key.create(i + 1));
-    }
-    if (numElements == 0 || numElements >= ReverseDepsUtility.MAYBE_CHECK_THRESHOLD) {
-      // This will not throw, because the numElements is 0 or above the threshold.
-      ReverseDepsUtility.maybeCheckReverseDepNotPresent(example, Key.create(0));
-    } else {
-      assertThrows(
-          IllegalStateException.class,
-          () -> ReverseDepsUtility.maybeCheckReverseDepNotPresent(example, Key.create(0)));
-    }
-  }
-
   private static class Key extends AbstractSkyKey<Integer> {
     private static final Interner<Key> interner = BlazeInterners.newWeakInterner();