commit 98592ae0d145939f6dd5343aacf3f708652bb6bf
author ulfjack <ulfjack@google.com> Wed Apr 17 07:31:15 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Apr 17 07:33:02 2019 -0700
tree 77a0edf34d2bb3fd8dfdcee211efe9d3cb5f8242
parent 3bbf9b9de1dec90fd15b7c0af2f20fb51ca2fbb9

ExperimentalEventHandler: avoid locking for no-op

The lock here has repeatedly shown up in contention profiles, and this
looks like a reasonable cleanup.

PiperOrigin-RevId: 243993366

src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java

diff --git a/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java b/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java
index 6a27cbb..cd5f068 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java
@@ -343,7 +343,12 @@
   public void handle(Event event) {
     if (!debugAllEvents
         && !showTimestamp
-        && (event.getKind() == EventKind.START || event.getKind() == EventKind.FINISH)) {
+        && (event.getKind() == EventKind.START
+            || event.getKind() == EventKind.FINISH
+            || event.getKind() == EventKind.PASS
+            || event.getKind() == EventKind.TIMEOUT
+            || event.getKind() == EventKind.DEPCHECKER)) {
+      // Keep this in sync with the list of no-op event kinds in handleLocked below.
       return;
     }
     handleLocked(event, /* isFollowUp= */ false);