commit 9ec37343da5d27dd4c388cd8aa3c012f16b107fe
author Yun Peng <pcloudy@google.com> Thu Jul 18 06:45:12 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Jul 18 06:46:12 2019 -0700
tree 8f4e62b39657a2ac0bcae8215794be7da100ba15
parent 3aaca3ac33bc8e23d883fe9748518e7d7af38424

Make deps transitive in windows_dll_library

If cc_binary A depends on windows_dll_library B, which depends on windows_dll_library C. A should transitively depends on windows_dll_library C.

Closes #8712.

PiperOrigin-RevId: 258760641

examples/windows/dll/windows_dll_library.bzl

diff --git a/examples/windows/dll/windows_dll_library.bzl b/examples/windows/dll/windows_dll_library.bzl
index 5e7f28b..ca514da 100644
--- a/examples/windows/dll/windows_dll_library.bzl
+++ b/examples/windows/dll/windows_dll_library.bzl
@@ -19,6 +19,7 @@
 def windows_dll_library(
         name,
         srcs = [],
+        deps = [],
         hdrs = [],
         visibility = None,
         **kwargs):
@@ -31,6 +32,7 @@
     cc_binary(
         name = dll_name,
         srcs = srcs + hdrs,
+        deps = deps,
         linkshared = 1,
         **kwargs
     )
@@ -55,7 +57,7 @@
         name = name,
         hdrs = hdrs,
         visibility = visibility,
-        deps = [
+        deps = deps + [
             ":" + import_target_name,
         ],
     )