commit a617a901265b62bfdd41f762e589ce12b67a3b08
author ulfjack <ulfjack@google.com> Wed Nov 20 00:39:25 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Nov 20 00:41:44 2019 -0800
tree 5673ed62f691e1e6b1957477f7d5f0b5dd105024
parent 83b70caca5952e75489b43cae21837c047a475af

Use a statically created Comparator

PiperOrigin-RevId: 281465757

src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java b/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
index 26b045a..fd8f574 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/SourceManifestAction.java
@@ -55,6 +55,9 @@
 
   private static final String GUID = "07459553-a3d0-4d37-9d78-18ed942470f4";
 
+  private static final Comparator<Map.Entry<PathFragment, Artifact>> ENTRY_COMPARATOR =
+      (path1, path2) -> path1.getKey().compareTo(path2.getKey());
+
   /**
    * Interface for defining manifest formatting and reporting specifics. Implementations must be
    * immutable.
@@ -168,18 +171,8 @@
    */
   private void writeFile(OutputStream out, Map<PathFragment, Artifact> output) throws IOException {
     Writer manifestFile = new BufferedWriter(new OutputStreamWriter(out, ISO_8859_1));
-
-    Comparator<Map.Entry<PathFragment, Artifact>> fragmentComparator =
-          new Comparator<Map.Entry<PathFragment, Artifact>>() {
-      @Override
-      public int compare(Map.Entry<PathFragment, Artifact> path1,
-                         Map.Entry<PathFragment, Artifact> path2) {
-        return path1.getKey().compareTo(path2.getKey());
-      }
-    };
-
     List<Map.Entry<PathFragment, Artifact>> sortedManifest = new ArrayList<>(output.entrySet());
-    Collections.sort(sortedManifest, fragmentComparator);
+    Collections.sort(sortedManifest, ENTRY_COMPARATOR);
 
     for (Map.Entry<PathFragment, Artifact> line : sortedManifest) {
       manifestWriter.writeEntry(manifestFile, line.getKey(), line.getValue());