Don't GC dirty nodes that change pruning would verify clean (https://github.com/bazelbuild/bazel/pull/29965) ### Description The dirty-node garbage collector (`--version_window_for_dirty_node_gc`, run after every build via `BuildTool`) deletes dirty nodes that were not part of the build. A dirty node whose direct deps all turned out unchanged would be verified clean by change pruning the next time it is requested, but still ended up being deleted simply for not being part of the current evaluation. `AbstractInMemoryMemoizingEvaluator.deleteDirty` now keeps any dirty node that change pruning would verify clean if the new `--experimental_keep_change_prunable_nodes_during_gc` is enabled. ### Motivation This is motivated by https://github.com/bazelbuild/bazel/issues/29956, but doesn't quite fix it by itself (see https://github.com/bazelbuild/bazel/pull/29946#issuecomment-4797081830 and `deleteDirtyDeletesNodeNeedingRebuildToPrune`). It does help any change-prunable `SkyValue` (see the new integration test `test_unrelated_glob_change_pruned`). ### Build API Changes No ### Checklist - [x] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). RELNOTES[NEW]: With the new `--experimental_keep_change_prunable_nodes_during_gc` flag, Skyframe will keep computed nodes that aren't requested by the current evaluation but whose dependencies would be verified clean after change pruning. Closes #29965. PiperOrigin-RevId: 966612698 Change-Id: Ib809d5f50cd6647897a660a27bc5d531e30f2374
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
