| commit | b2b0f3260ef27fa304ede7c91df1a23a48ec23be | [log] [tgz] |
|---|---|---|
| author | dchai <dchai@google.com> | Thu Dec 05 13:36:57 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Dec 05 13:37:53 2019 -0800 |
| tree | febfcf392c1ca7fb0b0354e04e91403779725e22 | |
| parent | 063c19df00873b4f8d4af91a3776575a00c8de0b [diff] |
Remove broken no-op code for supporting <public/>
This was intended for supporting <public id="0xdeadbeef"/>, but since other
parts of RPBB invoke aapt2 with --static-lib, aapt2 will reject these anyway.
Even if RPBB removed usage of --static-lib [1], this code is still wrong:
* RPBB removed the top 16 bits of resource IDs. An entry ID (aapt.pb.EntryId)
is the lower 16 bits of a 32-bit resource ID (0xPPTTEEEE).
* aapt.pb.Entry messages with PUBLIC visibility are not guaranteed to have
zero values. aapt2 can and does fold a declaration+definition:
<public name="foo" type="string" id="0x7f05537"/>
<string name="foo">asdf</string>
into a single Entry message if they occur in a single XML file.
[1] And it should.
PiperOrigin-RevId: 284041867
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
