commit c326a53e1d6e9e44bdd5429be86be1f75cbd0447
author steinman <steinman@google.com> Thu Nov 14 13:46:56 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Thu Nov 14 13:47:56 2019 -0800
tree 827420a93535e838748604668bc2d5f886992bdd
parent aef41933a456de3d677febfd03806d64fd936122

Add quotations around invalid dottedVersion value in error message.

This makes it easier to see what the invalid value was, especially in cases where it's a string with spaces.

RELNOTES: None
PiperOrigin-RevId: 280503104

src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java

diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java b/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
index 4380d96..de5041d 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/apple/DottedVersion.java
@@ -130,7 +130,7 @@
   private static final Pattern COMPONENT_PATTERN =
       Pattern.compile("(\\d+)([a-z0-9]*?)?(\\d+)?", Pattern.CASE_INSENSITIVE);
   private static final String ILLEGAL_VERSION =
-      "Dotted version components must all be of the form \\d+([a-z0-9]*?)?(\\d+)? but got %s";
+      "Dotted version components must all be of the form \\d+([a-z0-9]*?)?(\\d+)? but got '%s'";
   private static final String NO_ALPHA_SEQUENCE = null;
   private static final Component ZERO_COMPONENT = new Component(0, NO_ALPHA_SEQUENCE, 0, "0");