commit de6808488a5b97fd154fdb5dcdf28f030e60dbb8
author janakr <janakr@google.com> Tue Mar 24 14:44:15 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 24 14:45:40 2020 -0700
tree f99c2d1e71f63023edc6bd651835bb56606a5c5b
parent e24714dcdf5e5ab70fddd16e820a1fc3bc6b4b5c

Guard WalkableGraph#getDirectDeps debugging call: in a no-keep-going build, the nodes won't be in the graph /sadface. Thus the debugging added by https://github.com/bazelbuild/bazel/commit/aa8fac57ff9e3b505671b9a41a2b8ee1c7fd786b was pretty useless. Still hope it will trigger in a keep-going build.

We could add a method to get the deps of undone nodes, but probably not worth it just for this.

PiperOrigin-RevId: 302750695

src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
index 8a2b4e7..4564b33 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
@@ -770,6 +770,15 @@
         do {
           path.add(currentKey);
           foundDep = false;
+
+          Map<SkyKey, Exception> missingMap =
+              walkableGraph.getMissingAndExceptions(ImmutableList.of(currentKey));
+          if (missingMap.containsKey(currentKey) && missingMap.get(currentKey) == null) {
+            // This can happen in a no-keep-going build, where we don't write the bubbled-up error
+            // nodes to the graph.
+            break;
+          }
+
           for (SkyKey dep : walkableGraph.getDirectDeps(currentKey)) {
             if (cause.equals(walkableGraph.getException(dep))) {
               currentKey = dep;