commit | eb97f8647a6dcc4dd4705d156fca64f44226fe72 | [log] [tgz] |
---|---|---|
author | nharmata <nharmata@google.com> | Wed Mar 18 11:11:38 2020 -0700 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Mar 18 11:13:12 2020 -0700 |
tree | 0e955ee450bd5539d23a4d3347b1dd2d8ef9da3f | |
parent | 1932d0f460681820d10c6501a3b582e319d3d7a1 [diff] |
Have PackageFactory#afterDoneLoadingPackage call PackageValidator.validate before it calls Package.Builder.Helper#onLoadingComplete. This fixes a hypothetical bug where Package.Builder.Helper#onLoadingComplete implementations if rightfully assuming the Package had successfully been loaded when it fact it hadn't. While I'm here, now that this hypothetical bug has been fixed, I renamed #onLoadingComplete to #onLoadingCompleteAndSuccessful to emphasize that the assumption mentioned above is a legit one to make. RELNOTES: PiperOrigin-RevId: 301627063
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md