commit 924bee9a1d6df8bd933cac67ce27f9f09ab3cc1c
author Ian (Hee) Cha <heec@google.com> Tue Oct 10 01:16:42 2023 -0700
committer GitHub <noreply@github.com> Tue Oct 10 08:16:42 2023 +0000
tree cfc7ff8c2f59476157a22611098af5aec5c748de
parent 0017fb3a5ba2a25fe9128d08a1984333ba0543aa

[6.4.0] Flip --experimental_cc_implementation_deps (#19751)

This allows distributing libraries as source that use
`implementation_deps`.

Closes #19724.

Commit
https://github.com/bazelbuild/bazel/commit/05787f3f8bc3f3866ccb4d7650b331373a053640

PiperOrigin-RevId: 571105562
Change-Id: I268c5aa0fd83b220aa85dbeb6eef6a07f6b7d3f7

Co-authored-by: Thi Don <t@thi.im>

src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java

diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java
index dc34959..b3f18e3 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java
@@ -1108,7 +1108,7 @@
 
   @Option(
       name = "experimental_cc_implementation_deps",
-      defaultValue = "false",
+      defaultValue = "true",
       documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
       effectTags = {
         OptionEffectTag.LOADING_AND_ANALYSIS,

src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java
index 1aed4e8..d7d0793 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java
@@ -2064,7 +2064,7 @@
   }
 
   @Test
-  public void testImplementationDepsFailsWithoutFlag() throws Exception {
+  public void testImplementationDepsSucceedsWithoutFlag() throws Exception {
     if (!analysisMock.isThisBazel()) {
       return;
     }
@@ -2081,9 +2081,9 @@
         "    srcs = ['implementation_dep.cc'],",
         "    hdrs = ['implementation_dep.h'],",
         ")");
-    reporter.removeHandler(failFastHandler);
-    getConfiguredTarget("//foo:lib");
-    assertContainsEvent("requires --experimental_cc_implementation_deps");
+    assertThat(getConfiguredTarget("//foo:lib")).isNotNull();
+    ;
+    assertDoesNotContainEvent("requires --experimental_cc_implementation_deps");
   }
 
   @Test