| commit | 89d34ac23a8f46b3b89ac4730d7a20da375f5fae | [log] [tgz] |
|---|---|---|
| author | Googler <messa@google.com> | Tue Jan 03 11:18:56 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 03 11:20:30 2023 -0800 |
| tree | 91c94b7074ccde67bd0641c9cffb61ee4152c998 | |
| parent | a45301346f565ebeb07b18dc405d8d9f96eab507 [diff] |
Fix check for exec groups in DependencyResolver In `DependencyResolver`, if the aspects list passed to [`dependentNodeMap()`](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java#L197) is not empty, the `toolchainContexts` will contain only the exec groups of the main aspect (placed as the last aspect in aspects list) ([from AspectFunction](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java#L596)). Otherwise, `toolchainContexts` will contain the exec group of the target's rule ([from ConfiguredTargetFunction](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java#L587)). Therefore, [this check](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java#L349) needs to be updated so that if the aspects list is not empty and the current dependency is not a dependency of the main aspect, no need to check as the exec group will always not be in `toolchainContexts`. PiperOrigin-RevId: 499270890 Change-Id: Ibe657eb7f3ec3721e816cf4a9b4b86af58957730
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
