| commit | e6231d0520c4f87b431a2d64e1924105defe7a68 | [log] [tgz] |
|---|---|---|
| author | Fabian Meumertzheim <fabian@meumertzhe.im> | Tue Sep 02 17:30:41 2025 +0200 |
| committer | GitHub <noreply@github.com> | Tue Sep 02 15:30:41 2025 +0000 |
| tree | 0c6be4afb437e43eb5ead681c23f0ef27da76403 | |
| parent | 377860379c315957e7fe4e11f82c31eda338a060 [diff] |
[8.4.0] Fix runfiles directory staleness issues caused by symlinking the output manifest (#26868) `SymlinkTreeAction` is only executed for its side effect of updating the runfiles tree, but its up-to-dateness is tracked solely by the digest of its output, the manifest under the runfiles directory. If this manifest is a symlink to the input manifest and a previous build modified the runfiles directory while not updating the action cache entry for `SymlinkTreeAction`, this would cause Bazel to consider the action up-to-date even though the runfiles directory is stale. The fix consists of two parts: * Always copy the manifest instead of symlinking it, matching the behavior of the former `--noexperimental_inprocess_symlink_creation` flag. This fixes staleness issues when only using versions of Bazel with this fix. * Detect stale state left behind by older versions of Bazel by skipping action cache hits if the output manifest is a symlink. Since this situation is no longer created by fixed versions of Bazel, we could consider removing this logic in the future. Fixes #26818 Closes #26837. PiperOrigin-RevId: 801798862 Change-Id: I02c6d1b353981249a98df224efc4f46c5e4866d7 (cherry picked from commit 585e16c701a6eef9a0b96cce31cae56893f04278) Also includes: * a3eb3516b26ddaa2aa81d15a3cbfb6876a07d359 Fixes #26824 --------- Co-authored-by: Googler <tjgq@google.com>
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
