Damien Martin-Guillerez | f88f4d8 | 2015-09-25 13:56:55 +0000 | [diff] [blame] | 1 | // Copyright 2014 The Bazel Authors. All rights reserved. |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | package com.google.devtools.build.lib.skyframe; |
| 15 | |
tomlu | a155b53 | 2017-11-08 20:12:47 +0100 | [diff] [blame] | 16 | import com.google.common.base.Preconditions; |
Lukacs Berki | 6e91eb9 | 2015-09-21 09:12:37 +0000 | [diff] [blame] | 17 | import com.google.devtools.build.lib.cmdline.Label; |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 18 | import com.google.devtools.build.lib.collect.nestedset.NestedSet; |
| 19 | import com.google.devtools.build.lib.events.EventHandler; |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 20 | import com.google.devtools.build.lib.packages.AdvertisedProviderSet; |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 21 | import com.google.devtools.build.lib.packages.NoSuchPackageException; |
| 22 | import com.google.devtools.build.lib.packages.NoSuchTargetException; |
Eric Fellheimer | e27d063 | 2015-09-25 21:35:26 +0000 | [diff] [blame] | 23 | import com.google.devtools.build.lib.packages.NoSuchThingException; |
shreyax | 246f0aa | 2018-02-23 07:46:54 -0800 | [diff] [blame] | 24 | import com.google.devtools.build.lib.util.GroupedList; |
| 25 | import com.google.devtools.build.skyframe.SkyFunction; |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 26 | import com.google.devtools.build.skyframe.SkyKey; |
| 27 | import com.google.devtools.build.skyframe.SkyValue; |
| 28 | import com.google.devtools.build.skyframe.ValueOrException2; |
Eric Fellheimer | e27d063 | 2015-09-25 21:35:26 +0000 | [diff] [blame] | 29 | import java.util.Collection; |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 30 | import java.util.Comparator; |
shreyax | 246f0aa | 2018-02-23 07:46:54 -0800 | [diff] [blame] | 31 | import java.util.List; |
| 32 | import java.util.Map; |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 33 | import javax.annotation.Nullable; |
| 34 | |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 35 | /** |
| 36 | * This class is like {@link TransitiveTargetFunction}, but the values it returns do not contain |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 37 | * {@link NestedSet}s. It performs the side-effects of {@link TransitiveTargetFunction} (i.e., |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 38 | * ensuring that transitive targets and their packages have been loaded). It evaluates to a {@link |
| 39 | * TransitiveTraversalValue} that contains the first error message it encountered, and a set of |
| 40 | * names of providers if the target is a rule. |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 41 | */ |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 42 | public class TransitiveTraversalFunction |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 43 | extends TransitiveBaseTraversalFunction< |
| 44 | TransitiveTraversalFunction.DeterministicErrorMessageAccumulator> { |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 45 | |
| 46 | @Override |
ulfjack | dc73a1d | 2017-10-30 07:05:53 -0400 | [diff] [blame] | 47 | Label argumentFromKey(SkyKey key) { |
| 48 | return (Label) key.argument(); |
| 49 | } |
| 50 | |
| 51 | @Override |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 52 | SkyKey getKey(Label label) { |
| 53 | return TransitiveTraversalValue.key(label); |
| 54 | } |
| 55 | |
| 56 | @Override |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 57 | DeterministicErrorMessageAccumulator processTarget( |
| 58 | Label label, TargetAndErrorIfAny targetAndErrorIfAny) { |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 59 | NoSuchTargetException errorIfAny = targetAndErrorIfAny.getErrorLoadingTarget(); |
| 60 | String errorMessageIfAny = errorIfAny == null ? null : errorIfAny.getMessage(); |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 61 | return DeterministicErrorMessageAccumulator.create(errorMessageIfAny); |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 62 | } |
| 63 | |
| 64 | @Override |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 65 | void processDeps( |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 66 | DeterministicErrorMessageAccumulator accumulator, |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 67 | EventHandler eventHandler, |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 68 | TargetAndErrorIfAny targetAndErrorIfAny, |
jcater | cecb3a8 | 2018-05-01 14:37:48 -0700 | [diff] [blame] | 69 | Iterable<Map.Entry<SkyKey, ValueOrException2<NoSuchPackageException, NoSuchTargetException>>> |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 70 | depEntries) { |
jcater | cecb3a8 | 2018-05-01 14:37:48 -0700 | [diff] [blame] | 71 | for (Map.Entry<SkyKey, ValueOrException2<NoSuchPackageException, NoSuchTargetException>> entry : |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 72 | depEntries) { |
| 73 | TransitiveTraversalValue transitiveTraversalValue; |
| 74 | try { |
| 75 | transitiveTraversalValue = (TransitiveTraversalValue) entry.getValue().get(); |
| 76 | if (transitiveTraversalValue == null) { |
| 77 | continue; |
| 78 | } |
| 79 | } catch (NoSuchPackageException | NoSuchTargetException e) { |
| 80 | accumulator.maybeSet(e.getMessage()); |
| 81 | continue; |
| 82 | } |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 83 | String errorMessage = transitiveTraversalValue.getErrorMessage(); |
| 84 | if (errorMessage != null) { |
| 85 | accumulator.maybeSet(errorMessage); |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 86 | } |
| 87 | } |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 88 | } |
| 89 | |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 90 | @Nullable |
Googler | 7184b6f | 2017-05-16 05:25:49 +0200 | [diff] [blame] | 91 | @Override |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 92 | protected AdvertisedProviderSet getAdvertisedProviderSet( |
Googler | 7184b6f | 2017-05-16 05:25:49 +0200 | [diff] [blame] | 93 | Label toLabel, |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 94 | @Nullable ValueOrException2<NoSuchPackageException, NoSuchTargetException> toVal, |
Googler | 7184b6f | 2017-05-16 05:25:49 +0200 | [diff] [blame] | 95 | Environment env) { |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 96 | if (toVal == null) { |
| 97 | return null; |
| 98 | } |
Eric Fellheimer | e27d063 | 2015-09-25 21:35:26 +0000 | [diff] [blame] | 99 | try { |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 100 | return ((TransitiveTraversalValue) toVal.get()).getProviders(); |
Eric Fellheimer | e27d063 | 2015-09-25 21:35:26 +0000 | [diff] [blame] | 101 | } catch (NoSuchThingException e) { |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 102 | // Do nothing interesting. This error was handled when we computed the corresponding |
Eric Fellheimer | e27d063 | 2015-09-25 21:35:26 +0000 | [diff] [blame] | 103 | // TransitiveTargetValue. |
nharmata | f2b26ad | 2019-03-06 09:37:00 -0800 | [diff] [blame] | 104 | return null; |
Eric Fellheimer | e27d063 | 2015-09-25 21:35:26 +0000 | [diff] [blame] | 105 | } |
| 106 | } |
| 107 | |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 108 | @Override |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 109 | SkyValue computeSkyValue( |
| 110 | TargetAndErrorIfAny targetAndErrorIfAny, DeterministicErrorMessageAccumulator accumulator) { |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 111 | boolean targetLoadedSuccessfully = targetAndErrorIfAny.getErrorLoadingTarget() == null; |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 112 | String errorMessage = accumulator.getErrorMessage(); |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 113 | return targetLoadedSuccessfully |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 114 | ? TransitiveTraversalValue.forTarget(targetAndErrorIfAny.getTarget(), errorMessage) |
Googler | 7184b6f | 2017-05-16 05:25:49 +0200 | [diff] [blame] | 115 | : TransitiveTraversalValue.unsuccessfulTransitiveTraversal( |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 116 | errorMessage, targetAndErrorIfAny.getTarget()); |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 117 | } |
| 118 | |
Mark Schaller | 6b6d8a9 | 2015-10-23 01:00:28 +0000 | [diff] [blame] | 119 | @Override |
| 120 | TargetMarkerValue getTargetMarkerValue(SkyKey targetMarkerKey, Environment env) |
Janak Ramakrishnan | 3c0adb2 | 2016-08-15 21:54:55 +0000 | [diff] [blame] | 121 | throws NoSuchTargetException, NoSuchPackageException, InterruptedException { |
Mark Schaller | 6b6d8a9 | 2015-10-23 01:00:28 +0000 | [diff] [blame] | 122 | return TargetMarkerFunction.computeTargetMarkerValue(targetMarkerKey, env); |
| 123 | } |
| 124 | |
shreyax | 246f0aa | 2018-02-23 07:46:54 -0800 | [diff] [blame] | 125 | @Override |
| 126 | Collection<SkyKey> getLabelDepKeys( |
| 127 | SkyFunction.Environment env, TargetAndErrorIfAny targetAndErrorIfAny) |
| 128 | throws InterruptedException { |
| 129 | // As a performance optimization we may already know the deps we are about to request from |
| 130 | // last time #compute was called. By requesting these from the environment, we can avoid |
| 131 | // repeating the label visitation step. For TransitiveTraversalFunction#compute, the label deps |
| 132 | // dependency group is requested immediately after the package. |
| 133 | // |
| 134 | // IMPORTANT: No other package values should be requested inside |
| 135 | // TransitiveTraversalFunction#compute from this point forward. |
| 136 | Collection<SkyKey> oldDepKeys = getDepsAfterLastPackageDep(env, /*offset=*/ 1); |
| 137 | return oldDepKeys == null ? super.getLabelDepKeys(env, targetAndErrorIfAny) : oldDepKeys; |
| 138 | } |
| 139 | |
| 140 | @Override |
| 141 | Iterable<SkyKey> getStrictLabelAspectDepKeys( |
| 142 | SkyFunction.Environment env, |
| 143 | Map<SkyKey, ValueOrException2<NoSuchPackageException, NoSuchTargetException>> depMap, |
| 144 | TargetAndErrorIfAny targetAndErrorIfAny) |
| 145 | throws InterruptedException { |
| 146 | // As a performance optimization we may already know the deps we are about to request from |
| 147 | // last time #compute was called. By requesting these from the environment, we can avoid |
| 148 | // repeating the label visitation step. For TransitiveTraversalFunction#compute, the label |
| 149 | // aspect deps dependency group is requested two groups after the package. |
| 150 | Collection<SkyKey> oldAspectDepKeys = getDepsAfterLastPackageDep(env, /*offset=*/ 2); |
| 151 | return oldAspectDepKeys == null |
| 152 | ? super.getStrictLabelAspectDepKeys(env, depMap, targetAndErrorIfAny) |
| 153 | : oldAspectDepKeys; |
| 154 | } |
| 155 | |
| 156 | @Nullable |
| 157 | private static Collection<SkyKey> getDepsAfterLastPackageDep( |
| 158 | SkyFunction.Environment env, int offset) { |
| 159 | GroupedList<SkyKey> temporaryDirectDeps = env.getTemporaryDirectDeps(); |
| 160 | if (temporaryDirectDeps == null) { |
| 161 | return null; |
| 162 | } |
| 163 | int lastPackageDepIndex = getLastPackageValueIndex(temporaryDirectDeps); |
| 164 | if (lastPackageDepIndex == -1 |
| 165 | || temporaryDirectDeps.listSize() <= lastPackageDepIndex + offset) { |
| 166 | return null; |
| 167 | } |
| 168 | return temporaryDirectDeps.get(lastPackageDepIndex + offset); |
| 169 | } |
| 170 | |
| 171 | private static int getLastPackageValueIndex(GroupedList<SkyKey> directDeps) { |
| 172 | int directDepsNumGroups = directDeps.listSize(); |
| 173 | for (int i = directDepsNumGroups - 1; i >= 0; i--) { |
| 174 | List<SkyKey> depGroup = directDeps.get(i); |
| 175 | if (depGroup.size() == 1 && depGroup.get(0).functionName().equals(SkyFunctions.PACKAGE)) { |
| 176 | return i; |
| 177 | } |
| 178 | } |
| 179 | return -1; |
| 180 | } |
| 181 | |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 182 | /** |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 183 | * Keeps track of a deterministic error message encountered while traversing itself and its |
| 184 | * dependencies: either the error it was initialized with, or the shortest error it encounters, |
| 185 | * with ties broken alphabetically. |
| 186 | * |
| 187 | * <p>This preserves the behavior that the local target's error is the most important, and is |
| 188 | * cheap (constant-time) to compute the comparison between strings, unless they have the same |
| 189 | * length, which is unlikely. |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 190 | */ |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 191 | interface DeterministicErrorMessageAccumulator { |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 192 | @Nullable |
janakr | f091f9c | 2019-03-25 13:42:18 -0700 | [diff] [blame] | 193 | String getErrorMessage(); |
| 194 | |
| 195 | default void maybeSet(String errorMessage) {} |
| 196 | |
| 197 | static DeterministicErrorMessageAccumulator create(@Nullable String errorMessage) { |
| 198 | if (errorMessage != null) { |
| 199 | return () -> errorMessage; |
| 200 | } |
| 201 | return new UpdateableErrorMessageAccumulator(); |
| 202 | } |
| 203 | |
| 204 | class UpdateableErrorMessageAccumulator implements DeterministicErrorMessageAccumulator { |
| 205 | private static final Comparator<String> LENGTH_THEN_ALPHABETICAL = |
| 206 | Comparator.nullsLast( |
| 207 | Comparator.comparingInt(String::length).thenComparing(Comparator.naturalOrder())); |
| 208 | |
| 209 | @Nullable private String errorMessage; |
| 210 | |
| 211 | @Override |
| 212 | public void maybeSet(String errorMessage) { |
| 213 | Preconditions.checkNotNull(errorMessage); |
| 214 | if (LENGTH_THEN_ALPHABETICAL.compare(this.errorMessage, errorMessage) > 0) { |
| 215 | this.errorMessage = errorMessage; |
| 216 | } |
| 217 | } |
| 218 | |
| 219 | @Nullable |
| 220 | @Override |
| 221 | public String getErrorMessage() { |
| 222 | return errorMessage; |
| 223 | } |
Mark Schaller | 24ed98d | 2015-10-21 17:47:51 +0000 | [diff] [blame] | 224 | } |
Mark Schaller | 8ff5b3c | 2015-07-29 17:32:11 +0000 | [diff] [blame] | 225 | } |
| 226 | } |