Google Git
Sign in
bazel / bazel / 0ab46f0dd95f735056add4dd8a90a76944b81d00 / src / main / java / com / google / devtools / build / skyframe
  1. 2f8fa64 Refactors ParallelEvaluator to support eval-wide exceptions. by mschaller · 7 years ago
  2. ff4aa93 Don't use null EvaluationProgressReceiver in MemoizingEvaluator (it was only null in AbstractPackageLoader and tests). by janakr · 7 years ago
  3. ab0cdd5 Re-add WalkableGraph#isUpToDate and BuildDriver#alreadyEvaluated by Googler · 7 years ago
  4. 19e03d7 Remove synchronization from InMemoryNodeEntry#getValue{,MaybeWithMetadata} and #toValue. I saw significant contention from this method in some experiments, and the synchronization isn't needed, since we only call these methods on done nodes (as determined by #isDone), and a node that is observably done cannot racily change its value. by janakr · 7 years ago
  5. 57f228a Refactor WalkableGraph and BuildDriver interfaces by Googler · 7 years ago
  6. a0ea569f ParallelEvaluator: report events early for cache hits by ulfjack · 7 years ago
  7. 5670fb2 Simplify tagged event handling. by ulfjack · 7 years ago
  8. 5d63436 Add a static method GroupedList#numElements to allow to count the number of deps from a compressed GroupedList without uncompressing it. Also some minor GC improvements. by shreyax · 7 years ago
  9. 3b5b55b Allow InMemoryNodeEntry subclasses to change which reverse dep operation to store bare. by janakr · 7 years ago
  10. 34d02ef Clear interrupted bit in thread when throwing an interrupted exception that came from an AbstractParallelEvaluator evaluation. It's against the standard Java contract to throw but still have the thread's interrupted bit set. by janakr · 7 years ago
  11. 6b1b8a9 RELNOTES: --keep_incrementality_data flag allows Bazel servers to be run in memory-saving non-incremental mode independent of --batch and --discard_analysis_cache. by janakr · 7 years ago
  12. a155b53 Replace all usages of Blaze's Preconditions class with guava. by tomlu · 7 years ago
  13. 32d2edc Remove least important argument to 5+ arg Preconditions#checkState/checkNotNull. by tomlu · 7 years ago
  14. fce927f Make ErrorInfo#toString more informative. by janakr · 7 years ago
  15. a0e5b2f Don't require --keep_going to discard graph edges. It's unnecessary. by janakr · 7 years ago
  16. 61c48b5 Fixes EvaluationResult Builder by Googler · 7 years ago
  17. 4f7be0f Push NodeEntry#keepEdges down to InMemoryNodeEntry. It's not needed on the general interface. by janakr · 7 years ago
  18. 1cde872 Allow NodeEntry implementations to keep just deps, as opposed to all edges or no edges. Also add option to disable checks in MemoizingEvaluatorTest that don't make sense for implementations that don't keep track of dirty nodes. Also extract RecordingDifferencer to an interface. And add a test for the situation that a node changes during a build that it's not requested, and which fails, necessitating cleanup. by janakr · 7 years ago
  19. a0c391e Bubble errors up even in the case of keep_going builds that failed due to catastrophes. Our stricter behavior in the face of errors means that it is no longer possible for a done node to depend on a not-done node in this build. by janakr · 7 years ago
  20. c8dce99 Stop injecting WorkspaceStatusAction into the Skyframe graph as a precomputed value. Instead, manually check if the value has changed, and if it has, invalidate its consuming WorkspaceStatusValue node, forcing its re-evaluation, where it will pick up the new value. by janakr · 8 years ago
  21. 446f0ba Switch from using Iterable to Collection in the return type to be more explicit. by shreyax · 8 years ago
  22. 03e7018 Automatic code cleanup. by cushon · 8 years ago
  23. 3bcb9f6 More BUILD file refactorings. by philwo · 8 years ago
  24. e9e35aa Split the cycle between vfs and profiler. by philwo · 8 years ago
  25. 5e65c98 Change WalkableGraphFactory#prepareAndGet to take multiple SkyKeys as graph roots by Googler · 8 years ago
  26. cfe25a6 Introduce AbstractParallelEvaluator by mschaller · 8 years ago
  27. dfa86f48 Adding a ConstantVersion to Skyframe, to be used when only a single evaluation of the graph with a single constant version is expected by kush · 8 years ago
  28. 2f8b1e5 Add --toolchain_resolution_debug option to give more information about by John Cater · 8 years ago
  29. ee98301 Make SkyKey.argument a default method by ulfjack · 8 years ago
  30. 129c930 Make InMemoryGraph public. by janakr · 8 years ago
  31. 513288b Tolerate injected nodes having deps. by janakr · 8 years ago
  32. 9669b38 Automated rollback of commit 6e72f78e1c2e573787ec862e671f3b3b4c33dc96. by kush · 8 years ago
  33. be83f13 Now that SkyKey is an interface, accept Iterable<? extends SkyKey> by ulfjack · 8 years ago
  34. 52b4f68 Fix Postable forwarding and replay by ulfjack · 8 years ago
  35. 6e72f78 Small changes to skyframe package. by kush · 8 years ago
  36. bea67e9 A bunch of unrelated cleanups: by nharmata · 8 years ago
  37. da0a701 Propagate postable events further up by Klaus Aehlig · 8 years ago
  38. b3bcbd7 Also report stored posts further up in Skyframe by Klaus Aehlig · 8 years ago
  39. 31dbadf Avoid waste in registerNewlyDiscovered... when there aren't any by mschaller · 8 years ago
  40. ccc60e0 Add a EvaluationProgressReceiver#computing method. by nharmata · 8 years ago
  41. 5b354e6 Introduce CompoundEvaluationProgressReceiver for combining multiple EvaluationProgressReceivers. by nharmata · 8 years ago
  42. 8040b0b Introduce an EvaluationProgressReceiver implementation that does nothing. by nharmata · 8 years ago
  43. 1f75476 Clean up AbstractQueueVisitor's constructors. by janakr · 8 years ago
  44. bfdad90 Make SkyKey an interface, and start the migration of not creating SkyKey wrapper objects: for OwnedArtifacts, which are the most numerous during builds, and for Labels for TransitiveTraversalValues, which are the most numerous during queries. by janakr · 8 years ago
  45. 3fd4054 Allow graph implementations to filter out deps that are known to be done when change pruning. This can speed up change pruning. by janakr · 8 years ago
  46. 31654bd Drop loading-phase values if --discard_analysis_cache is true and we're not keeping incremental state. by janakr · 8 years ago
  47. ab10f47 Remove BuildingState, since it only has one field. Instead, keep the signaledDeps field directly in InMemoryNodeEntry. by Janak Ramakrishnan · 8 years ago
  48. cb8a97d Stop storing reverse deps to signal in BuildingState. Instead, re-use the reverseDepsToConsolidate field in InMemoryNodeEntry. As part of that, revamp our logic of how we store pending operations: store adds bare on initial evaluations, and checks bare on incremental evaluations and operations on done nodes. by Janak Ramakrishnan · 8 years ago
  49. a291e9b Tighten invariants around dirtiness checking. We should never need to create a child that's being checked by a parent (that was a legacy of when we delegated to enqueueChild), and such a child that is being checked should always be dirty or done, never fresh. by Janak Ramakrishnan · 8 years ago
  50. f9bbc95 Add some more debugging info in case of rdep inconsistencies in Skyframe -- the full list of rdep mods that are being performed on this entry, not just the current one that failed. by Janak Ramakrishnan · 8 years ago
  51. 4c3d925 In SkyFunctionEnvironment post progress-like events immediately by Klaus Aehlig · 8 years ago
  52. 777b30d Provide more reporting options to SkyFunctions by Klaus Aehlig · 8 years ago
  53. 76ca9c2 Inform progress receiver that node has been computed before any exception handling. by Janak Ramakrishnan · 8 years ago
  54. 7fd3f2c5 Add "CLEAN_UP" as a reason for retrieving a node. by Shreya Bhattarai · 8 years ago
  55. 8d2311d Refactor DirtyBuildingState to allow custom implementation on storing the by Googler · 8 years ago
  56. 09f42d5 Fix an issue with cached EventHandlers in SkyQueryEnvironment's resolver by Mark Schaller · 8 years ago
  57. 6e0efe1 Add some logging in case we fail an evaluation. This should be generally useful, but may also help identify Bazel as the culprit in the linked bug if we're lucky and the timestamps are clear. by Janak Ramakrishnan · 8 years ago
  58. cc1b9b3 Unsynchronize InMemoryNodeEntry#isDone. The buildingState variable's state changes are visibile to all other threads by volatility and we don't read the variable at any intermediate or inconsistent state (simply check against null or a constant). reverseDepsToSignal is also made volatile for subclasses that need volatile reads to it. by Shreya Bhattarai · 8 years ago
  59. 112840b Remove WalkableGraph#exists and allow WalkableGraph#getValue and WalkableGraph#getException to be given non-existent keys without crashing. Add WalkableGraph#isCycle to fill the gap in testing for the difference between non-existence and depending on a cycle. by Janak Ramakrishnan · 8 years ago
  60. 13dc56a Global cleanup change. by Googler · 8 years ago
  61. a16d9f1 Introduce BlazeInterners, a Blaze-specific wrapper around Guava's Interners that makes an appropriate call to Interners.InternerBuilder#concurrencyLevel. by Nathan Harmata · 8 years ago
  62. 3207f93 Cache all previously computed values in SkyQueryEnvironment#beforeEvaluateQuery if possible to save on latency for small queries. by Janak Ramakrishnan · 8 years ago
  63. 18d0a5d Re-use the precomputed universe key in WalkableGraphFactory#prepareAndGet. by Janak Ramakrishnan · 8 years ago
  64. 2dd4c18 Add method getCurrentlyAvailableNodes to QueryableGraph and Walkable Graph by Googler · 8 years ago
  65. 5f026f9 Rollback of commit e6191f7209ebf3f67480bc7aa9db5ac58beb2156. by Damien Martin-Guillerez · 8 years ago
  66. da68901 Fix unnecessary static imports of types by Liam Miller-Cushon · 8 years ago
  67. 2b8a3a4 Stop storing a set in GroupedListHelper to deduplicate SkyKey dep requests. Instead, deduplicate when the helper is actually added to a GroupedList. by Janak Ramakrishnan · 8 years ago
  68. 860b8d2 EvaluationProgressReceiver absorbs other progress trackers. by Chloe Calvarin · 9 years ago
  69. c4e2255 Fixed EvaluationProgressReceiver object names by Googler · 9 years ago
  70. 07f6fcf Introduce a Builder for ForkJoinQuiescingExecutor. by Nathan Harmata · 9 years ago
  71. 7a0b518 Allow reverse dependency lookups on Skyframe graph to throw InteruptedException by Googler · 9 years ago
  72. 1ac4568 Allow cycle detector to be injected into ParallelEvaluator, so that callers can use different cycle detection algorithms if they wish. by Janak Ramakrishnan · 9 years ago
  73. aa9107b Factor out cycle detection. by Janak Ramakrishnan · 9 years ago
  74. b449e3f Refactor ParallelEvaluator in preparation for making it more modular with respect to cycle checking. by Janak Ramakrishnan · 9 years ago
  75. 731c271 Avoid copying SkyKeys into a set and then into a map when retrieving them. Instead, just put them directly into a map. This avoids the memory churn and CPU cost of the set. by Janak Ramakrishnan · 9 years ago
  76. 3c0adb2 Allow Skyframe graph lookups and value retrievals to throw InterruptedException. by Janak Ramakrishnan · 9 years ago
  77. 2c5d517 Have AQV propagate the most severe error encountered by any of its tasks. Make sure that ParallelEvaluator treats SchedulerExceptions as less severe than other RuntimeExceptions (it already did, but add a comment emphasizing this). by Nathan Harmata · 9 years ago
  78. fb1d53d Fix bug in ParallelEvaluator when an error dep was not newly requested in a nokeep_going build because it finished building in between the time it was first requested and when we checked it for done-ness after the SkyFunction evaluation. by Janak Ramakrishnan · 9 years ago
  79. 33faf91 Get rid of InvalidatableGraph. This explicit concept is no longer needed. by Nathan Harmata · 9 years ago
  80. c55fe15 Delete NodeEntryField since it's now superfluous in the presence of the new QueryableGraph.Reason which conveys more information. Add a few more Reason enum values to make this refactor benign. by Nathan Harmata · 9 years ago
  81. 3b47b1f Augment the QueryableGraph#get[BatchWithFieldHints] method to take in parameters conveying the requesting node (if any), the requested node(s), as well as a reason for the skyframe graph lookup. Alternate graph implementations may be interested in this information. by Nathan Harmata · 9 years ago
  82. 5e9ac25 In keep-going mode, don't fail-fast on the evaluation of an individual SkyFunction if it throws an exception but still has missing deps. Instead, pretend it didn't throw, and restart it when its known deps are all done, presumably to throw the same exception. This removes a basic source of non-determinism. by Janak Ramakrishnan · 9 years ago
  83. 2553c84 Replace QueryableGraph#getBatch with #getBatchWithFieldHints. This allows alternate graph implementations to optimize how they construct node entries. by Janak Ramakrishnan · 9 years ago
  84. cc7712f Refactor QueryableGraph and ThinNodeQueryableGraph to be independent interfaces, in preparation for further changes. by Janak Ramakrishnan · 9 years ago
  85. 5dddb00 Refactor BuildingState to save memory. by Janak Ramakrishnan · 9 years ago
  86. 5093499 Re-use the InMemoryNodeEntry#directDeps field for temporary direct deps. by Janak Ramakrishnan · 9 years ago
  87. 870fb3f Filter out already-removed deps when removing a node from the rdeps of its last build's deps. This is only an issue with cycles, since there we try to maintain the invariant that a parent is not done before its children by removing its deps on its children before we construct its cycle value. by Janak Ramakrishnan · 9 years ago
  88. 583f9e9 Batch prefetch now also retrieves the deps from the node's previous run. by Eric Fellheimer · 9 years ago
  89. 772b5bb Minor documentation and visibility tweaks to InMemoryNodeEntry and InvalidatedNodeEntry. by Janak Ramakrishnan · 9 years ago
  90. bc8e1e7 Get rid of boolean field in InMemoryNodeEntry. After adding the lastEvaluated/lastChanged version fields, we lost memory alignment, so this boolean was costing us 8 bytes per instance. by Janak Ramakrishnan · 9 years ago
  91. 65ca4a2 Batchify child node lookups in Skyframe cycle detection. by Eric Fellheimer · 9 years ago
  92. a973b61 Minor change to add QueryableGraphBackedSkyFunctionEnvironment. by Janak Ramakrishnan · 9 years ago
  93. e97bba1 Minor improvement to cycle detection algorithm: Do not recurse into done nodes, where there is no work to do anyway. by Eric Fellheimer · 9 years ago
  94. 3c18cd0 Log how long Skyframe cycle checking takes. by Eric Fellheimer · 9 years ago
  95. 4352dd2 Remove ability of AbstractQueueVisitor to continue after an interrupt. That functionality was only used in tests. by Janak Ramakrishnan · 9 years ago
  96. 956b01e Use the precomputed skykey hash to short circuit equality comparison. by Shreya Bhattarai · 9 years ago
  97. 3724d92 Allow AQV users to inject arbitrary handling of classified errors. by Nathan Harmata · 9 years ago
  98. e9e9779 Assert batch existence of nodes in DirtyingNodeVisitor#visit. by Janak Ramakrishnan · 9 years ago
  99. b3cbe5f Fix bug in lazy removal of reverse deps -- there was one remaining case where we weren't checking to see if a reverse dep already existed when we declared a reverse dep. by Janak Ramakrishnan · 9 years ago
  100. f76c959 Remove reverse deps lazily, only when the node has finished building and we discover that it no longer has certain deps. by Janak Ramakrishnan · 9 years ago