| commit | 56897752c092569bba02da18b945033bcb42f2ad | [log] [tgz] |
|---|---|---|
| author | Googler <pcloudy@google.com> | Thu May 06 08:44:28 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu May 06 08:44:55 2021 -0700 |
| tree | 55468a55c7ec069333bba0c31d56fb233b37dc7a | |
| parent | c612c9581b9e740a49ed4c006edb93912c8ab205 [diff] |
Remove restriction on generate_pdb_file to be only used in dbg and fastbuild mode Users may want to build in opt mode and still want the pdb file to be a linking action output. See https://github.com/bazelbuild/rules_cc/issues/94#issuecomment-828254895 RELNOTES: None PiperOrigin-RevId: 372351216 Change-Id: I1b8a8709014deb4abdb13db387e185cd08f408d7
diff --git a/cc/private/toolchain/windows_cc_toolchain_config.bzl b/cc/private/toolchain/windows_cc_toolchain_config.bzl index f057b8d..cff3fa3 100644 --- a/cc/private/toolchain/windows_cc_toolchain_config.bzl +++ b/cc/private/toolchain/windows_cc_toolchain_config.bzl
@@ -666,10 +666,6 @@ generate_pdb_file_feature = feature( name = "generate_pdb_file", - requires = [ - feature_set(features = ["dbg"]), - feature_set(features = ["fastbuild"]), - ], ) output_execpath_flags_feature = feature(