Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1 | // Part of the Crubit project, under the Apache License v2.0 with LLVM |
| 2 | // Exceptions. See /LICENSE for license information. |
| 3 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
| 4 | |
Lukasz Anforowicz | aab8ad2 | 2021-12-19 20:29:26 +0000 | [diff] [blame] | 5 | use anyhow::{anyhow, bail, Result}; |
Marcel Hlopko | 884ae7f | 2021-08-18 13:58:22 +0000 | [diff] [blame] | 6 | use ffi_types::*; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 7 | use ir::*; |
| 8 | use itertools::Itertools; |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 9 | use proc_macro2::{Ident, Literal, TokenStream}; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 10 | use quote::format_ident; |
| 11 | use quote::quote; |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 12 | use std::collections::{BTreeSet, HashMap}; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 13 | use std::iter::Iterator; |
| 14 | use std::panic::catch_unwind; |
| 15 | use std::process; |
Marcel Hlopko | 65d05f0 | 2021-12-09 12:29:24 +0000 | [diff] [blame] | 16 | use token_stream_printer::{rs_tokens_to_formatted_string, tokens_to_string}; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 17 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 18 | /// FFI equivalent of `Bindings`. |
| 19 | #[repr(C)] |
| 20 | pub struct FfiBindings { |
| 21 | rs_api: FfiU8SliceBox, |
| 22 | rs_api_impl: FfiU8SliceBox, |
| 23 | } |
| 24 | |
| 25 | /// Deserializes IR from `json` and generates bindings source code. |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 26 | /// |
| 27 | /// This function panics on error. |
| 28 | /// |
| 29 | /// Ownership: |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 30 | /// * function doesn't take ownership of (in other words it borrows) the |
| 31 | /// param `json` |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 32 | /// * function passes ownership of the returned value to the caller |
| 33 | /// |
| 34 | /// Safety: |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 35 | /// * function expects that param `json` is a FfiU8Slice for a valid array of |
| 36 | /// bytes with the given size. |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 37 | /// * function expects that param `json` doesn't change during the call. |
| 38 | #[no_mangle] |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 39 | pub unsafe extern "C" fn GenerateBindingsImpl(json: FfiU8Slice) -> FfiBindings { |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 40 | catch_unwind(|| { |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 41 | // It is ok to abort here. |
| 42 | let Bindings { rs_api, rs_api_impl } = generate_bindings(json.as_slice()).unwrap(); |
| 43 | |
| 44 | FfiBindings { |
| 45 | rs_api: FfiU8SliceBox::from_boxed_slice(rs_api.into_bytes().into_boxed_slice()), |
| 46 | rs_api_impl: FfiU8SliceBox::from_boxed_slice( |
| 47 | rs_api_impl.into_bytes().into_boxed_slice(), |
| 48 | ), |
| 49 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 50 | }) |
| 51 | .unwrap_or_else(|_| process::abort()) |
| 52 | } |
| 53 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 54 | /// Source code for generated bindings. |
| 55 | struct Bindings { |
| 56 | // Rust source code. |
| 57 | rs_api: String, |
| 58 | // C++ source code. |
| 59 | rs_api_impl: String, |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 60 | } |
| 61 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 62 | fn generate_bindings(json: &[u8]) -> Result<Bindings> { |
| 63 | let ir = deserialize_ir(json)?; |
Marcel Hlopko | ca84ff4 | 2021-12-09 14:15:14 +0000 | [diff] [blame] | 64 | |
| 65 | // The code is formatted with a non-default rustfmt configuration. Prevent |
| 66 | // downstream workflows from reformatting with a different configuration. |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 67 | let rs_api = |
| 68 | format!("#![rustfmt::skip]\n{}", rs_tokens_to_formatted_string(generate_rs_api(&ir)?)?); |
| 69 | let rs_api_impl = tokens_to_string(generate_rs_api_impl(&ir)?)?; |
Marcel Hlopko | ca84ff4 | 2021-12-09 14:15:14 +0000 | [diff] [blame] | 70 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 71 | Ok(Bindings { rs_api, rs_api_impl }) |
| 72 | } |
| 73 | |
Devin Jeanpierre | 6d5e7cc | 2021-10-21 12:56:07 +0000 | [diff] [blame] | 74 | /// Rust source code with attached information about how to modify the parent |
| 75 | /// crate. |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 76 | /// |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 77 | /// For example, the snippet `vec![].into_raw_parts()` is not valid unless the |
| 78 | /// `vec_into_raw_parts` feature is enabled. So such a snippet should be |
| 79 | /// represented as: |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 80 | /// |
| 81 | /// ``` |
| 82 | /// RsSnippet { |
Devin Jeanpierre | 6d5e7cc | 2021-10-21 12:56:07 +0000 | [diff] [blame] | 83 | /// features: btree_set![make_ident("vec_into_raw_parts")], |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 84 | /// tokens: quote!{vec![].into_raw_parts()}, |
| 85 | /// } |
| 86 | /// ``` |
| 87 | struct RsSnippet { |
| 88 | /// Rust feature flags used by this snippet. |
| 89 | features: BTreeSet<Ident>, |
| 90 | /// The snippet itself, as a token stream. |
| 91 | tokens: TokenStream, |
| 92 | } |
| 93 | |
| 94 | impl From<TokenStream> for RsSnippet { |
| 95 | fn from(tokens: TokenStream) -> Self { |
| 96 | RsSnippet { features: BTreeSet::new(), tokens } |
| 97 | } |
| 98 | } |
| 99 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 100 | /// If we know the original C++ function is codegenned and already compatible |
| 101 | /// with `extern "C"` calling convention we skip creating/calling the C++ thunk |
| 102 | /// since we can call the original C++ directly. |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 103 | fn can_skip_cc_thunk(func: &Func) -> bool { |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 104 | // ## Inline functions |
| 105 | // |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 106 | // Inline functions may not be codegenned in the C++ library since Clang doesn't |
| 107 | // know if Rust calls the function or not. Therefore in order to make inline |
| 108 | // functions callable from Rust we need to generate a C++ file that defines |
| 109 | // a thunk that delegates to the original inline function. When compiled, |
| 110 | // Clang will emit code for this thunk and Rust code will call the |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 111 | // thunk when the user wants to call the original inline function. |
| 112 | // |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 113 | // This is not great runtime-performance-wise in regular builds (inline function |
| 114 | // will not be inlined, there will always be a function call), but it is |
| 115 | // correct. ThinLTO builds will be able to see through the thunk and inline |
| 116 | // code across the language boundary. For non-ThinLTO builds we plan to |
| 117 | // implement <internal link> which removes the runtime performance overhead. |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 118 | if func.is_inline { |
| 119 | return false; |
| 120 | } |
| 121 | // ## Virtual functions |
| 122 | // |
| 123 | // When calling virtual `A::Method()`, it's not necessarily the case that we'll |
| 124 | // specifically call the concrete `A::Method` impl. For example, if this is |
| 125 | // called on something whose dynamic type is some subclass `B` with an |
| 126 | // overridden `B::Method`, then we'll call that. |
| 127 | // |
| 128 | // We must reuse the C++ dynamic dispatching system. In this case, the easiest |
| 129 | // way to do it is by resorting to a C++ thunk, whose implementation will do |
| 130 | // the lookup. |
| 131 | // |
| 132 | // In terms of runtime performance, since this only occurs for virtual function |
| 133 | // calls, which are already slow, it may not be such a big deal. We can |
| 134 | // benchmark it later. :) |
| 135 | if let Some(meta) = &func.member_func_metadata { |
| 136 | if let Some(inst_meta) = &meta.instance_method_metadata { |
| 137 | if inst_meta.is_virtual { |
| 138 | return false; |
| 139 | } |
| 140 | } |
| 141 | } |
| 142 | |
| 143 | true |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 144 | } |
| 145 | |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 146 | /// Generates Rust source code for a given `Func`. |
| 147 | /// |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 148 | /// Returns the generated function or trait impl, and the thunk, as a tuple. |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 149 | fn generate_func(func: &Func, ir: &IR) -> Result<(RsSnippet, RsSnippet)> { |
Lukasz Anforowicz | 9bab835 | 2021-12-22 17:35:31 +0000 | [diff] [blame] | 150 | let empty_result = Ok((quote! {}.into(), quote! {}.into())); |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 151 | let mangled_name = &func.mangled_name; |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 152 | let thunk_ident = thunk_ident(func); |
Michael Forster | 409d941 | 2021-10-07 08:35:29 +0000 | [diff] [blame] | 153 | let doc_comment = generate_doc_comment(&func.doc_comment); |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 154 | let lifetime_to_name = HashMap::<LifetimeId, String>::from_iter( |
| 155 | func.lifetime_params.iter().map(|l| (l.id, l.name.clone())), |
| 156 | ); |
Lukasz Anforowicz | 4ad012b | 2021-12-15 18:13:40 +0000 | [diff] [blame] | 157 | let return_type_fragment = if func.return_type.rs_type.is_unit_type() { |
| 158 | quote! {} |
| 159 | } else { |
| 160 | let return_type_name = format_rs_type(&func.return_type.rs_type, ir, &lifetime_to_name)?; |
| 161 | quote! { -> #return_type_name } |
| 162 | }; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 163 | |
| 164 | let param_idents = |
| 165 | func.params.iter().map(|p| make_ident(&p.identifier.identifier)).collect_vec(); |
| 166 | |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 167 | let param_types = func |
| 168 | .params |
| 169 | .iter() |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 170 | .map(|p| format_rs_type(&p.type_.rs_type, ir, &lifetime_to_name)) |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 171 | .collect::<Result<Vec<_>>>()?; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 172 | |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 173 | let lifetimes = func |
| 174 | .lifetime_params |
| 175 | .iter() |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 176 | .map(|l| syn::Lifetime::new(&format!("'{}", l.name), proc_macro2::Span::call_site())); |
| 177 | let generic_params = format_generic_params(lifetimes); |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 178 | |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 179 | let record: Option<&Record> = |
| 180 | func.member_func_metadata.as_ref().map(|meta| meta.find_record(ir)).transpose()?; |
| 181 | |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 182 | let mut calls_thunk = true; |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 183 | let api_func = match &func.name { |
| 184 | UnqualifiedIdentifier::Identifier(id) => { |
| 185 | let ident = make_ident(&id.identifier); |
Lukasz Anforowicz | ee7669e | 2021-12-15 17:04:36 +0000 | [diff] [blame] | 186 | let fn_def = quote! { |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 187 | #doc_comment |
| 188 | #[inline(always)] |
Lukasz Anforowicz | 4ad012b | 2021-12-15 18:13:40 +0000 | [diff] [blame] | 189 | pub fn #ident #generic_params( #( #param_idents: #param_types ),* |
| 190 | ) #return_type_fragment { |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 191 | unsafe { crate::detail::#thunk_ident( #( #param_idents ),* ) } |
| 192 | } |
Lukasz Anforowicz | ee7669e | 2021-12-15 17:04:36 +0000 | [diff] [blame] | 193 | }; |
Lukasz Anforowicz | aab8ad2 | 2021-12-19 20:29:26 +0000 | [diff] [blame] | 194 | match &func.member_func_metadata { |
Lukasz Anforowicz | ee7669e | 2021-12-15 17:04:36 +0000 | [diff] [blame] | 195 | None => fn_def, |
Lukasz Anforowicz | aab8ad2 | 2021-12-19 20:29:26 +0000 | [diff] [blame] | 196 | Some(meta) => { |
| 197 | let type_name = make_ident(&meta.find_record(ir)?.identifier.identifier); |
Lukasz Anforowicz | ee7669e | 2021-12-15 17:04:36 +0000 | [diff] [blame] | 198 | quote! { impl #type_name { #fn_def } } |
| 199 | } |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 200 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 201 | } |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 202 | |
| 203 | UnqualifiedIdentifier::Destructor => { |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 204 | let record = record.ok_or_else(|| anyhow!("Destructors must be member functions."))?; |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 205 | let type_name = make_ident(&record.identifier.identifier); |
| 206 | match record.destructor.definition { |
| 207 | // TODO(b/202258760): Only omit destructor if `Copy` is specified. |
| 208 | SpecialMemberDefinition::Trivial => { |
Lukasz Anforowicz | 9bab835 | 2021-12-22 17:35:31 +0000 | [diff] [blame] | 209 | return empty_result; |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 210 | } |
| 211 | SpecialMemberDefinition::NontrivialMembers => { |
| 212 | calls_thunk = false; |
| 213 | quote! { |
| 214 | #doc_comment |
| 215 | impl Drop for #type_name { |
| 216 | #[inline(always)] |
| 217 | fn drop(&mut self) { |
| 218 | /* the destructors of the members can be invoked instead */ |
| 219 | } |
| 220 | } |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 221 | } |
| 222 | } |
Devin Jeanpierre | 7b62e95 | 2021-12-08 21:43:30 +0000 | [diff] [blame] | 223 | SpecialMemberDefinition::NontrivialUserDefined => { |
Devin Jeanpierre | f61ba6f | 2021-12-17 08:57:45 +0000 | [diff] [blame] | 224 | // Note: to avoid double-destruction of the fields, they are all wrapped in |
| 225 | // ManuallyDrop in this case. See `generate_record`. |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 226 | quote! { |
| 227 | #doc_comment |
| 228 | impl Drop for #type_name { |
| 229 | #[inline(always)] |
| 230 | fn drop(&mut self) { |
| 231 | unsafe { crate::detail::#thunk_ident(self) } |
| 232 | } |
| 233 | } |
| 234 | } |
| 235 | } |
| 236 | SpecialMemberDefinition::Deleted => { |
| 237 | bail!("Deleted destructors can't be called") // TODO(b/200066399): handle this? |
| 238 | } |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 239 | } |
| 240 | } |
| 241 | |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 242 | UnqualifiedIdentifier::Constructor => { |
| 243 | let record = record.ok_or_else(|| anyhow!("Constructors must be member functions."))?; |
Lukasz Anforowicz | 9bab835 | 2021-12-22 17:35:31 +0000 | [diff] [blame] | 244 | if !record.is_trivial_abi { |
| 245 | return empty_result; |
| 246 | } |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 247 | let type_name = make_ident(&record.identifier.identifier); |
| 248 | match func.params.len() { |
| 249 | 0 => bail!("Constructor should have at least 1 parameter (__this)"), |
| 250 | 1 => quote! { |
| 251 | #doc_comment |
| 252 | impl Default for #type_name { |
| 253 | #[inline(always)] |
| 254 | fn default() -> Self { |
| 255 | let mut tmp = std::mem::MaybeUninit::<Self>::uninit(); |
| 256 | unsafe { |
| 257 | crate::detail::#thunk_ident(tmp.as_mut_ptr()); |
| 258 | tmp.assume_init() |
| 259 | } |
| 260 | } |
| 261 | } |
| 262 | }, |
| 263 | _ => { |
| 264 | // TODO(b/208946210): Map some of these constructors to the From trait. |
| 265 | // TODO(b/200066396): Map other constructors (to the Clone trait?). |
Lukasz Anforowicz | 9bab835 | 2021-12-22 17:35:31 +0000 | [diff] [blame] | 266 | return empty_result; |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 267 | } |
| 268 | } |
| 269 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 270 | }; |
| 271 | |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 272 | let thunk = if calls_thunk { |
| 273 | let thunk_attr = if can_skip_cc_thunk(func) { |
| 274 | quote! {#[link_name = #mangled_name]} |
| 275 | } else { |
| 276 | quote! {} |
| 277 | }; |
| 278 | |
| 279 | quote! { |
| 280 | #thunk_attr |
Lukasz Anforowicz | 4ad012b | 2021-12-15 18:13:40 +0000 | [diff] [blame] | 281 | pub(crate) fn #thunk_ident #generic_params( #( #param_idents: #param_types ),* |
| 282 | ) #return_type_fragment ; |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 283 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 284 | } else { |
| 285 | quote! {} |
| 286 | }; |
| 287 | |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 288 | Ok((api_func.into(), thunk.into())) |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 289 | } |
| 290 | |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 291 | fn generate_doc_comment(comment: &Option<String>) -> TokenStream { |
| 292 | match comment { |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 293 | Some(text) => { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 294 | // token_stream_printer (and rustfmt) don't put a space between /// and the doc |
| 295 | // comment, let's add it here so our comments are pretty. |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 296 | let doc = format!(" {}", text.replace("\n", "\n ")); |
| 297 | quote! {#[doc=#doc]} |
| 298 | } |
| 299 | None => quote! {}, |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 300 | } |
| 301 | } |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 302 | |
| 303 | fn format_generic_params<T: quote::ToTokens>(params: impl IntoIterator<Item = T>) -> TokenStream { |
| 304 | let mut params = params.into_iter().peekable(); |
| 305 | if params.peek().is_none() { |
| 306 | quote! {} |
| 307 | } else { |
| 308 | quote! { < #( #params ),* > } |
| 309 | } |
| 310 | } |
| 311 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 312 | /// Generates Rust source code for a given `Record` and associated assertions as |
| 313 | /// a tuple. |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 314 | fn generate_record(record: &Record, ir: &IR) -> Result<(RsSnippet, RsSnippet)> { |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 315 | let ident = make_ident(&record.identifier.identifier); |
| 316 | let doc_comment = generate_doc_comment(&record.doc_comment); |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 317 | let field_idents = |
| 318 | record.fields.iter().map(|f| make_ident(&f.identifier.identifier)).collect_vec(); |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 319 | let field_doc_coments = |
| 320 | record.fields.iter().map(|f| generate_doc_comment(&f.doc_comment)).collect_vec(); |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 321 | let field_types = record |
| 322 | .fields |
| 323 | .iter() |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 324 | .map(|f| { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 325 | let mut formatted = format_rs_type(&f.type_.rs_type, ir, &HashMap::new())?; |
Devin Jeanpierre | 7b62e95 | 2021-12-08 21:43:30 +0000 | [diff] [blame] | 326 | if record.destructor.definition == SpecialMemberDefinition::NontrivialUserDefined { |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 327 | formatted = quote! { |
| 328 | std::mem::ManuallyDrop<#formatted> |
| 329 | }; |
| 330 | } |
| 331 | Ok(formatted) |
| 332 | }) |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 333 | .collect::<Result<Vec<_>>>()?; |
Googler | ec589eb | 2021-09-17 07:45:39 +0000 | [diff] [blame] | 334 | let field_accesses = record |
| 335 | .fields |
| 336 | .iter() |
| 337 | .map(|f| { |
| 338 | if f.access == AccessSpecifier::Public { |
| 339 | quote! { pub } |
| 340 | } else { |
| 341 | quote! {} |
| 342 | } |
| 343 | }) |
| 344 | .collect_vec(); |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 345 | let size = record.size; |
| 346 | let alignment = record.alignment; |
Googler | aaa0a53 | 2021-10-01 09:11:27 +0000 | [diff] [blame] | 347 | let field_assertions = |
| 348 | record.fields.iter().zip(field_idents.iter()).map(|(field, field_ident)| { |
| 349 | let offset = field.offset; |
| 350 | quote! { |
| 351 | // The IR contains the offset in bits, while offset_of!() |
| 352 | // returns the offset in bytes, so we need to convert. |
Googler | 209b10a | 2021-12-06 09:11:57 +0000 | [diff] [blame] | 353 | const _: () = assert!(offset_of!(#ident, #field_ident) * 8 == #offset); |
Googler | aaa0a53 | 2021-10-01 09:11:27 +0000 | [diff] [blame] | 354 | } |
| 355 | }); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 356 | let mut record_features = BTreeSet::new(); |
| 357 | let mut assertion_features = BTreeSet::new(); |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 358 | |
| 359 | // TODO(mboehme): For the time being, we're using unstable features to |
| 360 | // be able to use offset_of!() in static assertions. This is fine for a |
| 361 | // prototype, but longer-term we want to either get those features |
| 362 | // stabilized or find an alternative. For more details, see |
| 363 | // b/200120034#comment15 |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 364 | assertion_features.insert(make_ident("const_ptr_offset_from")); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 365 | |
| 366 | let derives = generate_copy_derives(record); |
Devin Jeanpierre | 9227d2c | 2021-10-06 12:26:05 +0000 | [diff] [blame] | 367 | let derives = if derives.is_empty() { |
| 368 | quote! {} |
| 369 | } else { |
| 370 | quote! {#[derive( #(#derives),* )]} |
| 371 | }; |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 372 | let unpin_impl; |
Devin Jeanpierre | e6e1665 | 2021-12-22 15:54:46 +0000 | [diff] [blame] | 373 | if record.is_unpin() { |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 374 | unpin_impl = quote! {}; |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 375 | } else { |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 376 | // negative_impls are necessary for universal initialization due to Rust's |
| 377 | // coherence rules: PhantomPinned isn't enough to prove to Rust that a |
| 378 | // blanket impl that requires Unpin doesn't apply. See http://<internal link>=h.f6jp8ifzgt3n |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 379 | record_features.insert(make_ident("negative_impls")); |
| 380 | unpin_impl = quote! { |
| 381 | __NEWLINE__ __NEWLINE__ |
| 382 | impl !Unpin for #ident {} |
| 383 | }; |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 384 | } |
| 385 | |
Googler | f479206 | 2021-10-20 07:21:21 +0000 | [diff] [blame] | 386 | let empty_struct_placeholder_field = if record.fields.is_empty() { |
| 387 | quote! { |
| 388 | /// Prevent empty C++ struct being zero-size in Rust. |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 389 | placeholder: std::mem::MaybeUninit<u8>, |
Googler | f479206 | 2021-10-20 07:21:21 +0000 | [diff] [blame] | 390 | } |
| 391 | } else { |
| 392 | quote! {} |
| 393 | }; |
| 394 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 395 | let record_tokens = quote! { |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 396 | #doc_comment |
Devin Jeanpierre | 9227d2c | 2021-10-06 12:26:05 +0000 | [diff] [blame] | 397 | #derives |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 398 | #[repr(C)] |
| 399 | pub struct #ident { |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 400 | #( #field_doc_coments #field_accesses #field_idents: #field_types, )* |
Googler | f479206 | 2021-10-20 07:21:21 +0000 | [diff] [blame] | 401 | #empty_struct_placeholder_field |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 402 | } |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 403 | |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 404 | #unpin_impl |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 405 | }; |
| 406 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 407 | let assertion_tokens = quote! { |
Googler | 209b10a | 2021-12-06 09:11:57 +0000 | [diff] [blame] | 408 | const _: () = assert!(std::mem::size_of::<#ident>() == #size); |
| 409 | const _: () = assert!(std::mem::align_of::<#ident>() == #alignment); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 410 | #( #field_assertions )* |
| 411 | }; |
| 412 | |
| 413 | Ok(( |
| 414 | RsSnippet { features: record_features, tokens: record_tokens }, |
| 415 | RsSnippet { features: assertion_features, tokens: assertion_tokens }, |
| 416 | )) |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 417 | } |
| 418 | |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 419 | fn generate_copy_derives(record: &Record) -> Vec<Ident> { |
| 420 | if record.is_trivial_abi |
| 421 | && record.copy_constructor.access == ir::AccessSpecifier::Public |
| 422 | && record.copy_constructor.definition == SpecialMemberDefinition::Trivial |
| 423 | { |
| 424 | // TODO(b/202258760): Make `Copy` inclusion configurable. |
| 425 | vec![make_ident("Clone"), make_ident("Copy")] |
| 426 | } else { |
| 427 | vec![] |
| 428 | } |
| 429 | } |
| 430 | |
Michael Forster | 523dbd4 | 2021-10-12 11:05:44 +0000 | [diff] [blame] | 431 | /// Generates Rust source code for a given `UnsupportedItem`. |
| 432 | fn generate_unsupported(item: &UnsupportedItem) -> Result<TokenStream> { |
Googler | 48a74dd | 2021-10-25 07:31:53 +0000 | [diff] [blame] | 433 | let location = if item.source_loc.filename.is_empty() { |
| 434 | "<unknown location>".to_string() |
| 435 | } else { |
| 436 | // TODO(forster): The "google3" prefix should probably come from a command line |
| 437 | // argument. |
| 438 | // TODO(forster): Consider linking to the symbol instead of to the line number |
| 439 | // to avoid wrong links while generated files have not caught up. |
| 440 | format!("google3/{};l={}", &item.source_loc.filename, &item.source_loc.line) |
| 441 | }; |
Michael Forster | 6a184ad | 2021-10-12 13:04:05 +0000 | [diff] [blame] | 442 | let message = format!( |
Googler | 48a74dd | 2021-10-25 07:31:53 +0000 | [diff] [blame] | 443 | "{}\nError while generating bindings for item '{}':\n{}", |
| 444 | &location, &item.name, &item.message |
Michael Forster | 6a184ad | 2021-10-12 13:04:05 +0000 | [diff] [blame] | 445 | ); |
Michael Forster | 523dbd4 | 2021-10-12 11:05:44 +0000 | [diff] [blame] | 446 | Ok(quote! { __COMMENT__ #message }) |
| 447 | } |
| 448 | |
Michael Forster | f1dce42 | 2021-10-13 09:50:16 +0000 | [diff] [blame] | 449 | /// Generates Rust source code for a given `Comment`. |
| 450 | fn generate_comment(comment: &Comment) -> Result<TokenStream> { |
| 451 | let text = &comment.text; |
| 452 | Ok(quote! { __COMMENT__ #text }) |
| 453 | } |
| 454 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 455 | fn generate_rs_api(ir: &IR) -> Result<TokenStream> { |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 456 | let mut items = vec![]; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 457 | let mut thunks = vec![]; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 458 | let mut assertions = vec![]; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 459 | |
Googler | 454f265 | 2021-12-06 12:53:12 +0000 | [diff] [blame] | 460 | // We import nullable pointers as an Option<&T> and assume that at the ABI |
| 461 | // level, None is represented as a zero pointer value whereas Some is |
| 462 | // represented as as non-zero pointer value. This seems like a pretty safe |
| 463 | // assumption to make, but to provide some safeguard, assert that |
| 464 | // `Option<&i32>` and `&i32` have the same size. |
| 465 | assertions.push(quote! { |
| 466 | const _: () = assert!(std::mem::size_of::<Option<&i32>>() == std::mem::size_of::<&i32>()); |
| 467 | }); |
| 468 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 469 | // TODO(jeanpierreda): Delete has_record, either in favor of using RsSnippet, or not |
| 470 | // having uses. See https://chat.google.com/room/AAAAnQmj8Qs/6QbkSvWcfhA |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 471 | let mut has_record = false; |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 472 | let mut features = BTreeSet::new(); |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 473 | |
Devin Jeanpierre | d6da700 | 2021-10-21 12:55:20 +0000 | [diff] [blame] | 474 | // For #![rustfmt::skip]. |
| 475 | features.insert(make_ident("custom_inner_attributes")); |
| 476 | |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 477 | for item in ir.items() { |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 478 | match item { |
| 479 | Item::Func(func) => { |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 480 | let (snippet, thunk) = generate_func(func, ir)?; |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 481 | features.extend(snippet.features); |
| 482 | features.extend(thunk.features); |
| 483 | items.push(snippet.tokens); |
| 484 | thunks.push(thunk.tokens); |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 485 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 486 | Item::Record(record) => { |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 487 | if !ir.is_in_current_target(record) { |
| 488 | continue; |
| 489 | } |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 490 | let (snippet, assertions_snippet) = generate_record(record, ir)?; |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 491 | features.extend(snippet.features); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 492 | features.extend(assertions_snippet.features); |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 493 | items.push(snippet.tokens); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 494 | assertions.push(assertions_snippet.tokens); |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 495 | has_record = true; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 496 | } |
Michael Forster | 523dbd4 | 2021-10-12 11:05:44 +0000 | [diff] [blame] | 497 | Item::UnsupportedItem(unsupported) => items.push(generate_unsupported(unsupported)?), |
Michael Forster | f1dce42 | 2021-10-13 09:50:16 +0000 | [diff] [blame] | 498 | Item::Comment(comment) => items.push(generate_comment(comment)?), |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 499 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 500 | } |
| 501 | |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 502 | let mod_detail = if thunks.is_empty() { |
| 503 | quote! {} |
| 504 | } else { |
| 505 | quote! { |
| 506 | mod detail { |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 507 | use super::*; |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 508 | extern "C" { |
| 509 | #( #thunks )* |
| 510 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 511 | } |
| 512 | } |
| 513 | }; |
| 514 | |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 515 | let imports = if has_record { |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 516 | quote! { |
Googler | aaa0a53 | 2021-10-01 09:11:27 +0000 | [diff] [blame] | 517 | use memoffset_unstable_const::offset_of; |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 518 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 519 | } else { |
| 520 | quote! {} |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 521 | }; |
| 522 | |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 523 | let features = if features.is_empty() { |
| 524 | quote! {} |
| 525 | } else { |
| 526 | quote! { |
| 527 | #![feature( #(#features),* )] |
| 528 | } |
| 529 | }; |
| 530 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 531 | Ok(quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 532 | #features __NEWLINE__ __NEWLINE__ |
| 533 | #imports __NEWLINE__ __NEWLINE__ |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 534 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 535 | #( #items __NEWLINE__ __NEWLINE__ )* |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 536 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 537 | #mod_detail __NEWLINE__ __NEWLINE__ |
| 538 | |
| 539 | #( #assertions __NEWLINE__ __NEWLINE__ )* |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 540 | }) |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 541 | } |
| 542 | |
| 543 | fn make_ident(ident: &str) -> Ident { |
| 544 | format_ident!("{}", ident) |
| 545 | } |
| 546 | |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 547 | fn format_rs_type( |
| 548 | ty: &ir::RsType, |
| 549 | ir: &IR, |
| 550 | lifetime_to_name: &HashMap<LifetimeId, String>, |
| 551 | ) -> Result<TokenStream> { |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 552 | enum TypeKind<'a> { |
| 553 | Pointer(TokenStream), |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 554 | Reference(TokenStream), |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 555 | Record(TokenStream), |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 556 | Unit, |
| 557 | Other(&'a str), |
| 558 | } |
| 559 | let kind = if let Some(ref name) = ty.name { |
| 560 | match name.as_str() { |
| 561 | "*mut" => TypeKind::Pointer(quote! {mut}), |
| 562 | "*const" => TypeKind::Pointer(quote! {const}), |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 563 | "&mut" => TypeKind::Reference(quote! {mut}), |
| 564 | "&" => TypeKind::Reference(quote! {}), |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 565 | "()" => TypeKind::Unit, |
| 566 | _ => TypeKind::Other(name), |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 567 | } |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 568 | } else { |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 569 | let record = ir.record_for_type(ty)?; |
| 570 | let ident = make_ident(record.identifier.identifier.as_str()); |
| 571 | let path: TokenStream = if ir.is_in_current_target(record) { |
| 572 | quote! {#ident} |
| 573 | } else { |
| 574 | let owning_crate = make_ident(record.owning_crate_name()?); |
| 575 | quote! {#owning_crate::#ident} |
| 576 | }; |
| 577 | TypeKind::Record(path) |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 578 | }; |
| 579 | match kind { |
| 580 | TypeKind::Pointer(mutability) => { |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 581 | if ty.type_args.len() != 1 { |
| 582 | bail!("Invalid pointer type (need exactly 1 type argument): {:?}", ty); |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 583 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 584 | let nested_type = format_rs_type(&ty.type_args[0], ir, lifetime_to_name)?; |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 585 | Ok(quote! {* #mutability #nested_type}) |
| 586 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 587 | TypeKind::Reference(mutability) => { |
| 588 | if ty.lifetime_args.len() != 1 || ty.type_args.len() != 1 { |
| 589 | bail!( |
| 590 | "Invalid reference type (need exactly 1 lifetime argument and 1 type argument): {:?}", |
| 591 | ty |
| 592 | ); |
| 593 | } |
| 594 | let nested_type = format_rs_type(&ty.type_args[0], ir, lifetime_to_name)?; |
| 595 | let lifetime_id = &ty.lifetime_args[0]; |
| 596 | let lifetime = syn::Lifetime::new( |
| 597 | &format!("'{}", lifetime_to_name.get(lifetime_id).unwrap()), |
| 598 | proc_macro2::Span::call_site(), |
| 599 | ); |
| 600 | Ok(quote! {& #lifetime #mutability #nested_type}) |
| 601 | } |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 602 | TypeKind::Record(path) => { |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 603 | if !ty.type_args.is_empty() { |
| 604 | bail!("Type arguments on records are not yet supported: {:?}", ty); |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 605 | } |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 606 | Ok(path) |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 607 | } |
| 608 | TypeKind::Unit => { |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 609 | if !ty.type_args.is_empty() { |
| 610 | bail!("Unit type must not have type arguments: {:?}", ty); |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 611 | } |
| 612 | Ok(quote! {()}) |
| 613 | } |
| 614 | TypeKind::Other(name) => { |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 615 | let ident = make_ident(name); |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 616 | let type_args = format_generic_params( |
| 617 | ty.type_args |
| 618 | .iter() |
| 619 | .map(|type_arg| format_rs_type(type_arg, ir, lifetime_to_name)) |
| 620 | .collect::<Result<Vec<_>>>()?, |
| 621 | ); |
Googler | 454f265 | 2021-12-06 12:53:12 +0000 | [diff] [blame] | 622 | Ok(quote! {#ident #type_args}) |
Googler | b0365ce | 2021-12-02 09:09:04 +0000 | [diff] [blame] | 623 | } |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 624 | } |
| 625 | } |
| 626 | |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 627 | fn format_cc_type(ty: &ir::CcType, ir: &IR) -> Result<TokenStream> { |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 628 | let const_fragment = if ty.is_const { |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 629 | quote! {const} |
| 630 | } else { |
| 631 | quote! {} |
| 632 | }; |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 633 | if let Some(ref name) = ty.name { |
| 634 | match name.as_str() { |
| 635 | "*" => { |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 636 | if ty.type_args.len() != 1 { |
| 637 | bail!("Invalid pointer type (need exactly 1 type argument): {:?}", ty); |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 638 | } |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 639 | assert_eq!(ty.type_args.len(), 1); |
| 640 | let nested_type = format_cc_type(&ty.type_args[0], ir)?; |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 641 | Ok(quote! {#nested_type * #const_fragment}) |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 642 | } |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 643 | ident => { |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 644 | if !ty.type_args.is_empty() { |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 645 | bail!("Type not yet supported: {:?}", ty); |
| 646 | } |
| 647 | let ident = make_ident(ident); |
| 648 | Ok(quote! {#ident #const_fragment}) |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 649 | } |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 650 | } |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 651 | } else { |
| 652 | let ident = make_ident(ir.record_for_type(ty)?.identifier.identifier.as_str()); |
| 653 | Ok(quote! {#ident}) |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 654 | } |
| 655 | } |
| 656 | |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 657 | fn cc_struct_layout_assertion(record: &Record, ir: &IR) -> TokenStream { |
| 658 | if !ir.is_in_current_target(record) { |
| 659 | return quote! {}; |
| 660 | } |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 661 | let record_ident = make_ident(&record.identifier.identifier); |
| 662 | let size = Literal::usize_unsuffixed(record.size); |
| 663 | let alignment = Literal::usize_unsuffixed(record.alignment); |
Lukasz Anforowicz | 7470471 | 2021-12-22 15:30:31 +0000 | [diff] [blame] | 664 | let field_assertions = |
| 665 | record.fields.iter().filter(|f| f.access == AccessSpecifier::Public).map(|field| { |
| 666 | let field_ident = make_ident(&field.identifier.identifier); |
| 667 | let offset = Literal::usize_unsuffixed(field.offset); |
| 668 | // The IR contains the offset in bits, while C++'s offsetof() |
| 669 | // returns the offset in bytes, so we need to convert. |
| 670 | quote! { |
| 671 | static_assert(offsetof(#record_ident, #field_ident) * 8 == #offset); |
| 672 | } |
| 673 | }); |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 674 | quote! { |
| 675 | static_assert(sizeof(#record_ident) == #size); |
| 676 | static_assert(alignof(#record_ident) == #alignment); |
| 677 | #( #field_assertions )* |
| 678 | } |
| 679 | } |
| 680 | |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 681 | fn thunk_ident(func: &Func) -> Ident { |
| 682 | format_ident!("__rust_thunk__{}", func.mangled_name) |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 683 | } |
| 684 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 685 | fn generate_rs_api_impl(ir: &IR) -> Result<TokenStream> { |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 686 | // This function uses quote! to generate C++ source code out of convenience. |
| 687 | // This is a bold idea so we have to continously evaluate if it still makes |
| 688 | // sense or the cost of working around differences in Rust and C++ tokens is |
| 689 | // greather than the value added. |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 690 | // |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 691 | // See rs_bindings_from_cc/ |
| 692 | // token_stream_printer.rs for a list of supported placeholders. |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 693 | let mut thunks = vec![]; |
Michael Forster | 7ef8073 | 2021-10-01 18:12:19 +0000 | [diff] [blame] | 694 | for func in ir.functions() { |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 695 | if can_skip_cc_thunk(&func) { |
| 696 | continue; |
| 697 | } |
| 698 | |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 699 | let thunk_ident = thunk_ident(func); |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 700 | let implementation_function = match &func.name { |
| 701 | UnqualifiedIdentifier::Identifier(id) => { |
Lukasz Anforowicz | aab8ad2 | 2021-12-19 20:29:26 +0000 | [diff] [blame] | 702 | let fn_ident = make_ident(&id.identifier); |
| 703 | let static_method_metadata = func |
| 704 | .member_func_metadata |
| 705 | .as_ref() |
| 706 | .filter(|meta| meta.instance_method_metadata.is_none()); |
| 707 | match static_method_metadata { |
| 708 | None => quote! {#fn_ident}, |
| 709 | Some(meta) => { |
| 710 | let record_ident = make_ident(&meta.find_record(ir)?.identifier.identifier); |
| 711 | quote! { #record_ident :: #fn_ident } |
| 712 | } |
| 713 | } |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 714 | } |
Devin Jeanpierre | cc6cf09 | 2021-12-16 04:31:14 +0000 | [diff] [blame] | 715 | // Use destroy_at to avoid needing to spell out the class name. Destructor identiifers |
| 716 | // use the name of the type itself, without namespace qualification, template |
| 717 | // parameters, or aliases. We do not need to use that naming scheme anywhere else in |
| 718 | // the bindings, and it can be difficult (impossible?) to spell in the general case. By |
| 719 | // using destroy_at, we avoid needing to determine or remember what the correct spelling |
| 720 | // is. |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 721 | UnqualifiedIdentifier::Constructor => { |
| 722 | if func.params.len() == 1 { |
Lukasz Anforowicz | 4457baf | 2021-12-23 17:24:04 +0000 | [diff] [blame^] | 723 | quote! { rs_api_impl_support::construct_at } |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 724 | } else { |
| 725 | // TODO(b/208946210): Map some of these constructors to the From trait. |
| 726 | // TODO(b/200066396): Map other constructors (to the Clone trait?). |
| 727 | continue; |
| 728 | } |
| 729 | } |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 730 | UnqualifiedIdentifier::Destructor => quote! {std::destroy_at}, |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 731 | }; |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 732 | let return_type_name = format_cc_type(&func.return_type.cc_type, ir)?; |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 733 | let return_stmt = if func.return_type.cc_type.is_void() { |
| 734 | quote! {} |
| 735 | } else { |
| 736 | quote! { return } |
| 737 | }; |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 738 | |
| 739 | let param_idents = |
| 740 | func.params.iter().map(|p| make_ident(&p.identifier.identifier)).collect_vec(); |
| 741 | |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 742 | let param_types = func |
| 743 | .params |
| 744 | .iter() |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 745 | .map(|p| format_cc_type(&p.type_.cc_type, ir)) |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 746 | .collect::<Result<Vec<_>>>()?; |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 747 | |
| 748 | thunks.push(quote! { |
| 749 | extern "C" #return_type_name #thunk_ident( #( #param_types #param_idents ),* ) { |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 750 | #return_stmt #implementation_function( #( #param_idents ),* ); |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 751 | } |
| 752 | }); |
| 753 | } |
| 754 | |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 755 | let layout_assertions = ir.records().map(|record| cc_struct_layout_assertion(record, ir)); |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 756 | |
Devin Jeanpierre | 231ef8d | 2021-10-27 10:50:44 +0000 | [diff] [blame] | 757 | let mut standard_headers = <BTreeSet<Ident>>::new(); |
| 758 | standard_headers.insert(make_ident("memory")); // ubiquitous. |
| 759 | if ir.records().next().is_some() { |
| 760 | standard_headers.insert(make_ident("cstddef")); |
| 761 | }; |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 762 | |
Lukasz Anforowicz | 4457baf | 2021-12-23 17:24:04 +0000 | [diff] [blame^] | 763 | let mut includes = |
| 764 | vec!["rs_bindings_from_cc/support/cxx20_backports.h"]; |
| 765 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 766 | // In order to generate C++ thunk in all the cases Clang needs to be able to |
| 767 | // access declarations from public headers of the C++ library. |
Lukasz Anforowicz | 4457baf | 2021-12-23 17:24:04 +0000 | [diff] [blame^] | 768 | includes.extend(ir.used_headers().map(|i| &i.name as &str)); |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 769 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 770 | Ok(quote! { |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 771 | #( __HASH_TOKEN__ include <#standard_headers> __NEWLINE__)* |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 772 | #( __HASH_TOKEN__ include #includes __NEWLINE__)* __NEWLINE__ |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 773 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 774 | #( #thunks )* __NEWLINE__ __NEWLINE__ |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 775 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 776 | #( #layout_assertions __NEWLINE__ __NEWLINE__ )* |
Marcel Hlopko | c6b726c | 2021-10-07 06:53:09 +0000 | [diff] [blame] | 777 | |
| 778 | // To satisfy http://cs/symbol:devtools.metadata.Presubmit.CheckTerminatingNewline check. |
| 779 | __NEWLINE__ |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 780 | }) |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 781 | } |
| 782 | |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 783 | #[cfg(test)] |
| 784 | mod tests { |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 785 | use super::*; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 786 | use anyhow::anyhow; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 787 | use ir_testing::{ir_from_cc, ir_from_cc_dependency, ir_func, ir_record}; |
| 788 | use token_stream_matchers::{ |
| 789 | assert_cc_matches, assert_cc_not_matches, assert_rs_matches, assert_rs_not_matches, |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 790 | }; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 791 | use token_stream_printer::tokens_to_string; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 792 | |
| 793 | #[test] |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 794 | // TODO(hlopko): Move this test to a more principled place where it can access |
| 795 | // `ir_testing`. |
| 796 | fn test_duplicate_decl_ids_err() { |
| 797 | let mut r1 = ir_record("R1"); |
Marcel Hlopko | 264b9ad | 2021-12-02 21:06:44 +0000 | [diff] [blame] | 798 | r1.id = DeclId(42); |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 799 | let mut r2 = ir_record("R2"); |
Marcel Hlopko | 264b9ad | 2021-12-02 21:06:44 +0000 | [diff] [blame] | 800 | r2.id = DeclId(42); |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 801 | let result = make_ir_from_items([r1.into(), r2.into()]); |
| 802 | assert!(result.is_err()); |
| 803 | assert!(result.unwrap_err().to_string().contains("Duplicate decl_id found in")); |
| 804 | } |
| 805 | |
| 806 | #[test] |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 807 | fn test_simple_function() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 808 | let ir = ir_from_cc("int Add(int a, int b);")?; |
| 809 | let rs_api = generate_rs_api(&ir)?; |
| 810 | assert_rs_matches!( |
| 811 | rs_api, |
| 812 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 813 | #[inline(always)] |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 814 | pub fn Add(a: i32, b: i32) -> i32 { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 815 | unsafe { crate::detail::__rust_thunk___Z3Addii(a, b) } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 816 | } |
| 817 | } |
| 818 | ); |
| 819 | assert_rs_matches!( |
| 820 | rs_api, |
| 821 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 822 | mod detail { |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 823 | use super::*; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 824 | extern "C" { |
| 825 | #[link_name = "_Z3Addii"] |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 826 | pub(crate) fn __rust_thunk___Z3Addii(a: i32, b: i32) -> i32; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 827 | } |
| 828 | } |
| 829 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 830 | ); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 831 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 832 | assert_cc_not_matches!(generate_rs_api_impl(&ir)?, quote! {__rust_thunk___Z3Addii}); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 833 | |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 834 | Ok(()) |
| 835 | } |
| 836 | |
| 837 | #[test] |
| 838 | fn test_inline_function() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 839 | let ir = ir_from_cc("inline int Add(int a, int b);")?; |
| 840 | let rs_api = generate_rs_api(&ir)?; |
| 841 | assert_rs_matches!( |
| 842 | rs_api, |
| 843 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 844 | #[inline(always)] |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 845 | pub fn Add(a: i32, b: i32) -> i32 { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 846 | unsafe { crate::detail::__rust_thunk___Z3Addii(a, b) } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 847 | } |
| 848 | } |
| 849 | ); |
| 850 | assert_rs_matches!( |
| 851 | rs_api, |
| 852 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 853 | mod detail { |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 854 | use super::*; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 855 | extern "C" { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 856 | pub(crate) fn __rust_thunk___Z3Addii(a: i32, b: i32) -> i32; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 857 | } |
| 858 | } |
| 859 | } |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 860 | ); |
| 861 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 862 | assert_cc_matches!( |
| 863 | generate_rs_api_impl(&ir)?, |
| 864 | quote! { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 865 | extern "C" int __rust_thunk___Z3Addii(int a, int b) { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 866 | return Add(a, b); |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 867 | } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 868 | } |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 869 | ); |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 870 | Ok(()) |
| 871 | } |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 872 | |
| 873 | #[test] |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 874 | fn test_simple_function_with_types_from_other_target() -> Result<()> { |
| 875 | let ir = ir_from_cc_dependency( |
| 876 | "inline ReturnStruct DoSomething(ParamStruct param);", |
| 877 | "struct ReturnStruct {}; struct ParamStruct {};", |
| 878 | )?; |
| 879 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 880 | let rs_api = generate_rs_api(&ir)?; |
| 881 | assert_rs_matches!( |
| 882 | rs_api, |
| 883 | quote! { |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 884 | #[inline(always)] |
| 885 | pub fn DoSomething(param: dependency::ParamStruct) |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 886 | -> dependency::ReturnStruct { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 887 | unsafe { crate::detail::__rust_thunk___Z11DoSomething11ParamStruct(param) } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 888 | } |
| 889 | } |
| 890 | ); |
| 891 | assert_rs_matches!( |
| 892 | rs_api, |
| 893 | quote! { |
| 894 | mod detail { |
| 895 | use super::*; |
| 896 | extern "C" { |
| 897 | pub(crate) fn __rust_thunk___Z11DoSomething11ParamStruct(param: dependency::ParamStruct) |
| 898 | -> dependency::ReturnStruct; |
| 899 | } |
| 900 | }} |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 901 | ); |
| 902 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 903 | assert_cc_matches!( |
| 904 | generate_rs_api_impl(&ir)?, |
| 905 | quote! { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 906 | extern "C" ReturnStruct __rust_thunk___Z11DoSomething11ParamStruct(ParamStruct param) { |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 907 | return DoSomething(param); |
| 908 | } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 909 | } |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 910 | ); |
| 911 | Ok(()) |
| 912 | } |
| 913 | |
| 914 | #[test] |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 915 | fn test_simple_struct() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 916 | let ir = ir_from_cc(&tokens_to_string(quote! { |
| 917 | struct SomeStruct { |
| 918 | int public_int; |
| 919 | protected: |
| 920 | int protected_int; |
| 921 | private: |
| 922 | int private_int; |
| 923 | }; |
| 924 | })?)?; |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 925 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 926 | let rs_api = generate_rs_api(&ir)?; |
| 927 | assert_rs_matches!( |
| 928 | rs_api, |
| 929 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 930 | #[derive(Clone, Copy)] |
| 931 | #[repr(C)] |
| 932 | pub struct SomeStruct { |
| 933 | pub public_int: i32, |
| 934 | protected_int: i32, |
| 935 | private_int: i32, |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 936 | } |
| 937 | } |
| 938 | ); |
| 939 | assert_rs_matches!( |
| 940 | rs_api, |
| 941 | quote! { |
Googler | 454f265 | 2021-12-06 12:53:12 +0000 | [diff] [blame] | 942 | const _: () = assert!(std::mem::size_of::<Option<&i32>>() == std::mem::size_of::<&i32>()); |
Googler | 209b10a | 2021-12-06 09:11:57 +0000 | [diff] [blame] | 943 | const _: () = assert!(std::mem::size_of::<SomeStruct>() == 12usize); |
| 944 | const _: () = assert!(std::mem::align_of::<SomeStruct>() == 4usize); |
| 945 | const _: () = assert!(offset_of!(SomeStruct, public_int) * 8 == 0usize); |
| 946 | const _: () = assert!(offset_of!(SomeStruct, protected_int) * 8 == 32usize); |
| 947 | const _: () = assert!(offset_of!(SomeStruct, private_int) * 8 == 64usize); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 948 | } |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 949 | ); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 950 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 951 | assert_cc_matches!( |
| 952 | rs_api_impl, |
| 953 | quote! { |
| 954 | extern "C" void __rust_thunk___ZN10SomeStructD1Ev(SomeStruct * __this) { |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 955 | std :: destroy_at (__this) ; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 956 | } |
| 957 | } |
| 958 | ); |
| 959 | assert_cc_matches!( |
| 960 | rs_api_impl, |
| 961 | quote! { |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 962 | static_assert(sizeof(SomeStruct) == 12); |
| 963 | static_assert(alignof(SomeStruct) == 4); |
| 964 | static_assert(offsetof(SomeStruct, public_int) * 8 == 0); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 965 | } |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 966 | ); |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 967 | Ok(()) |
| 968 | } |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 969 | |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 970 | #[test] |
Marcel Hlopko | dd1fcb1 | 2021-12-22 14:13:59 +0000 | [diff] [blame] | 971 | fn test_record_static_methods_qualify_call_in_thunk() -> Result<()> { |
| 972 | let ir = ir_from_cc(&tokens_to_string(quote! { |
| 973 | struct SomeStruct { |
| 974 | static inline int some_func() { return 42; } |
| 975 | }; |
| 976 | })?)?; |
| 977 | |
| 978 | assert_cc_matches!( |
| 979 | generate_rs_api_impl(&ir)?, |
| 980 | quote! { |
| 981 | extern "C" int __rust_thunk___ZN10SomeStruct9some_funcEv() { |
| 982 | return SomeStruct::some_func(); |
| 983 | } |
| 984 | } |
| 985 | ); |
| 986 | Ok(()) |
| 987 | } |
| 988 | |
| 989 | #[test] |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 990 | fn test_struct_from_other_target() -> Result<()> { |
| 991 | let ir = ir_from_cc_dependency("// intentionally empty", "struct SomeStruct {};")?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 992 | assert_rs_not_matches!(generate_rs_api(&ir)?, quote! { SomeStruct }); |
| 993 | assert_cc_not_matches!(generate_rs_api_impl(&ir)?, quote! { SomeStruct }); |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 994 | Ok(()) |
| 995 | } |
| 996 | |
| 997 | #[test] |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 998 | fn test_copy_derives() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 999 | let record = ir_record("S"); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1000 | assert_eq!(generate_copy_derives(&record), &["Clone", "Copy"]); |
| 1001 | } |
| 1002 | |
| 1003 | #[test] |
| 1004 | fn test_copy_derives_not_is_trivial_abi() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 1005 | let mut record = ir_record("S"); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1006 | record.is_trivial_abi = false; |
| 1007 | assert_eq!(generate_copy_derives(&record), &[""; 0]); |
| 1008 | } |
| 1009 | |
Devin Jeanpierre | e6e1665 | 2021-12-22 15:54:46 +0000 | [diff] [blame] | 1010 | /// A type can be unsafe to pass in mut references from C++, but still |
| 1011 | /// Clone+Copy when handled by value. |
| 1012 | #[test] |
| 1013 | fn test_copy_derives_not_is_mut_reference_safe() { |
| 1014 | let mut record = ir_record("S"); |
| 1015 | record.is_final = false; |
| 1016 | assert_eq!(generate_copy_derives(&record), &["Clone", "Copy"]); |
| 1017 | } |
| 1018 | |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1019 | #[test] |
| 1020 | fn test_copy_derives_ctor_nonpublic() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 1021 | let mut record = ir_record("S"); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1022 | for access in [ir::AccessSpecifier::Protected, ir::AccessSpecifier::Private] { |
| 1023 | record.copy_constructor.access = access; |
| 1024 | assert_eq!(generate_copy_derives(&record), &[""; 0]); |
| 1025 | } |
| 1026 | } |
| 1027 | |
| 1028 | #[test] |
| 1029 | fn test_copy_derives_ctor_deleted() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 1030 | let mut record = ir_record("S"); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1031 | record.copy_constructor.definition = ir::SpecialMemberDefinition::Deleted; |
| 1032 | assert_eq!(generate_copy_derives(&record), &[""; 0]); |
| 1033 | } |
| 1034 | |
| 1035 | #[test] |
Devin Jeanpierre | be2f33b | 2021-10-21 12:54:19 +0000 | [diff] [blame] | 1036 | fn test_copy_derives_ctor_nontrivial_members() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 1037 | let mut record = ir_record("S"); |
Devin Jeanpierre | be2f33b | 2021-10-21 12:54:19 +0000 | [diff] [blame] | 1038 | record.copy_constructor.definition = ir::SpecialMemberDefinition::NontrivialMembers; |
| 1039 | assert_eq!(generate_copy_derives(&record), &[""; 0]); |
| 1040 | } |
| 1041 | |
| 1042 | #[test] |
| 1043 | fn test_copy_derives_ctor_nontrivial_self() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 1044 | let mut record = ir_record("S"); |
Devin Jeanpierre | 7b62e95 | 2021-12-08 21:43:30 +0000 | [diff] [blame] | 1045 | record.copy_constructor.definition = ir::SpecialMemberDefinition::NontrivialUserDefined; |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1046 | assert_eq!(generate_copy_derives(&record), &[""; 0]); |
| 1047 | } |
| 1048 | |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 1049 | #[test] |
| 1050 | fn test_ptr_func() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1051 | let ir = ir_from_cc(&tokens_to_string(quote! { |
| 1052 | inline int* Deref(int*const* p); |
| 1053 | })?)?; |
Devin Jeanpierre | d6da700 | 2021-10-21 12:55:20 +0000 | [diff] [blame] | 1054 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1055 | let rs_api = generate_rs_api(&ir)?; |
| 1056 | assert_rs_matches!( |
| 1057 | rs_api, |
| 1058 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1059 | #[inline(always)] |
| 1060 | pub fn Deref(p: *const *mut i32) -> *mut i32 { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1061 | unsafe { crate::detail::__rust_thunk___Z5DerefPKPi(p) } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1062 | } |
| 1063 | } |
| 1064 | ); |
| 1065 | assert_rs_matches!( |
| 1066 | rs_api, |
| 1067 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1068 | mod detail { |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 1069 | use super::*; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1070 | extern "C" { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1071 | pub(crate) fn __rust_thunk___Z5DerefPKPi(p: *const *mut i32) -> *mut i32; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1072 | } |
| 1073 | } |
| 1074 | } |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 1075 | ); |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 1076 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1077 | assert_cc_matches!( |
| 1078 | generate_rs_api_impl(&ir)?, |
| 1079 | quote! { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1080 | extern "C" int* __rust_thunk___Z5DerefPKPi(int* const * p) { |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 1081 | return Deref(p); |
| 1082 | } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1083 | } |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 1084 | ); |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 1085 | Ok(()) |
| 1086 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1087 | |
| 1088 | #[test] |
| 1089 | fn test_item_order() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1090 | let ir = ir_from_cc( |
| 1091 | "int first_func(); |
| 1092 | struct FirstStruct {}; |
| 1093 | int second_func(); |
| 1094 | struct SecondStruct {};", |
| 1095 | )?; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1096 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1097 | let rs_api = rs_tokens_to_formatted_string(generate_rs_api(&ir)?)?; |
| 1098 | |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1099 | let idx = |s: &str| rs_api.find(s).ok_or(anyhow!("'{}' missing", s)); |
| 1100 | |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1101 | println!("{:?}", ir); |
| 1102 | |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1103 | let f1 = idx("fn first_func")?; |
| 1104 | let f2 = idx("fn second_func")?; |
| 1105 | let s1 = idx("struct FirstStruct")?; |
| 1106 | let s2 = idx("struct SecondStruct")?; |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1107 | let t1 = idx("fn __rust_thunk___Z10first_funcv")?; |
| 1108 | let t2 = idx("fn __rust_thunk___Z11second_funcv")?; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1109 | |
| 1110 | assert!(f1 < s1); |
| 1111 | assert!(s1 < f2); |
| 1112 | assert!(f2 < s2); |
| 1113 | assert!(s2 < t1); |
| 1114 | assert!(t1 < t2); |
| 1115 | |
| 1116 | Ok(()) |
| 1117 | } |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 1118 | |
| 1119 | #[test] |
Michael Forster | 409d941 | 2021-10-07 08:35:29 +0000 | [diff] [blame] | 1120 | fn test_doc_comment_func() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1121 | let ir = ir_from_cc( |
| 1122 | " |
| 1123 | // Doc Comment |
| 1124 | // with two lines |
| 1125 | int func();", |
| 1126 | )?; |
Michael Forster | 409d941 | 2021-10-07 08:35:29 +0000 | [diff] [blame] | 1127 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1128 | assert_rs_matches!( |
| 1129 | generate_rs_api(&ir)?, |
| 1130 | // leading space is intentional so there is a space between /// and the text of the |
| 1131 | // comment |
| 1132 | quote! { |
| 1133 | #[doc = " Doc Comment\n with two lines"] |
| 1134 | #[inline(always)] |
| 1135 | pub fn func |
| 1136 | } |
Michael Forster | 409d941 | 2021-10-07 08:35:29 +0000 | [diff] [blame] | 1137 | ); |
| 1138 | |
| 1139 | Ok(()) |
| 1140 | } |
| 1141 | |
| 1142 | #[test] |
| 1143 | fn test_doc_comment_record() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1144 | let ir = ir_from_cc( |
| 1145 | "// Doc Comment\n\ |
| 1146 | //\n\ |
| 1147 | // * with bullet\n\ |
| 1148 | struct SomeStruct {\n\ |
| 1149 | // Field doc\n\ |
| 1150 | int field;\ |
| 1151 | };", |
| 1152 | )?; |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 1153 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1154 | assert_rs_matches!( |
| 1155 | generate_rs_api(&ir)?, |
| 1156 | quote! { |
| 1157 | #[doc = " Doc Comment\n \n * with bullet"] |
| 1158 | #[derive(Clone, Copy)] |
| 1159 | #[repr(C)] |
| 1160 | pub struct SomeStruct { |
| 1161 | # [doc = " Field doc"] |
| 1162 | pub field: i32, |
| 1163 | } |
| 1164 | } |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 1165 | ); |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 1166 | Ok(()) |
| 1167 | } |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 1168 | |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 1169 | #[test] |
| 1170 | fn test_virtual_thunk() -> Result<()> { |
| 1171 | let ir = ir_from_cc("struct Polymorphic { virtual void Foo(); };")?; |
| 1172 | |
| 1173 | assert_cc_matches!( |
| 1174 | generate_rs_api_impl(&ir)?, |
| 1175 | quote! { |
| 1176 | extern "C" void __rust_thunk___ZN11Polymorphic3FooEv(Polymorphic * __this) |
| 1177 | } |
| 1178 | ); |
| 1179 | Ok(()) |
| 1180 | } |
| 1181 | |
Devin Jeanpierre | e6e1665 | 2021-12-22 15:54:46 +0000 | [diff] [blame] | 1182 | /// A trivially relocatable final struct is safe to use in Rust as normal, |
| 1183 | /// and is Unpin. |
| 1184 | #[test] |
| 1185 | fn test_no_negative_impl_unpin() -> Result<()> { |
| 1186 | let ir = ir_from_cc("struct Trivial final {};")?; |
| 1187 | let rs_api = generate_rs_api(&ir)?; |
| 1188 | assert_rs_not_matches!(rs_api, quote! {impl !Unpin}); |
| 1189 | Ok(()) |
| 1190 | } |
| 1191 | |
| 1192 | /// A non-final struct, even if it's trivial, is not usable by mut |
| 1193 | /// reference, and so is !Unpin. |
| 1194 | #[test] |
| 1195 | fn test_negative_impl_unpin_nonfinal() -> Result<()> { |
| 1196 | let ir = ir_from_cc("struct Nonfinal {};")?; |
| 1197 | let rs_api = generate_rs_api(&ir)?; |
| 1198 | assert_rs_matches!(rs_api, quote! {impl !Unpin for Nonfinal {}}); |
| 1199 | Ok(()) |
| 1200 | } |
| 1201 | |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 1202 | /// At the least, a trivial type should have no drop impl if or until we add |
| 1203 | /// empty drop impls. |
| 1204 | #[test] |
| 1205 | fn test_no_impl_drop() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1206 | let ir = ir_from_cc("struct Trivial {};")?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1207 | let rs_api = rs_tokens_to_formatted_string(generate_rs_api(&ir)?)?; |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 1208 | assert!(!rs_api.contains("impl Drop")); |
| 1209 | Ok(()) |
| 1210 | } |
| 1211 | |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 1212 | /// User-defined destructors *must* become Drop impls with ManuallyDrop |
| 1213 | /// fields |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 1214 | #[test] |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 1215 | fn test_impl_drop_user_defined_destructor() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1216 | let ir = ir_from_cc( |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 1217 | r#"struct UserDefinedDestructor { |
| 1218 | ~UserDefinedDestructor(); |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 1219 | int x; |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 1220 | };"#, |
| 1221 | )?; |
| 1222 | let rs_api = generate_rs_api(&ir)?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1223 | println!("{}", rs_api); |
| 1224 | assert_rs_matches!(rs_api, quote! {impl Drop}); |
| 1225 | assert_rs_not_matches!(rs_api, quote! {fn drop(&mut self) {}}); |
| 1226 | assert_rs_matches!(rs_api, quote! {pub x: std::mem::ManuallyDrop<i32>,}); |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 1227 | Ok(()) |
| 1228 | } |
| 1229 | |
| 1230 | /// nontrivial types without user-defined destructors must have an empty |
| 1231 | /// drop definition. |
| 1232 | #[test] |
| 1233 | fn test_impl_drop_nontrivial_member_destructor() -> Result<()> { |
| 1234 | // TODO(jeanpierreda): This would be cleaner if the UserDefinedDestructor code were |
| 1235 | // omitted. For example, we simulate it so that UserDefinedDestructor |
| 1236 | // comes from another library. |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1237 | let ir = ir_from_cc( |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 1238 | r#"struct UserDefinedDestructor { |
| 1239 | ~UserDefinedDestructor(); |
| 1240 | }; |
| 1241 | |
| 1242 | struct NontrivialMembers { |
| 1243 | UserDefinedDestructor udd; |
| 1244 | int x; |
| 1245 | };"#, |
| 1246 | )?; |
| 1247 | let rs_api = generate_rs_api(&ir)?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1248 | assert_rs_matches!(rs_api, quote! {fn drop(&mut self) {}}); |
| 1249 | assert_rs_matches!(rs_api, quote! {pub x: i32,}); |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 1250 | Ok(()) |
| 1251 | } |
| 1252 | |
| 1253 | /// Trivial types (at least those that are mapped to Copy rust types) do not |
| 1254 | /// get a Drop impl. |
| 1255 | #[test] |
| 1256 | fn test_impl_drop_trivial() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1257 | let ir = ir_from_cc( |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 1258 | r#"struct Trivial { |
| 1259 | ~Trivial() = default; |
| 1260 | int x; |
| 1261 | };"#, |
| 1262 | )?; |
| 1263 | let rs_api = generate_rs_api(&ir)?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1264 | assert_rs_not_matches!(rs_api, quote! {impl Drop}); |
| 1265 | assert_rs_matches!(rs_api, quote! {pub x: i32}); |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 1266 | Ok(()) |
| 1267 | } |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 1268 | |
| 1269 | #[test] |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 1270 | fn test_impl_default_explicitly_defaulted_constructor() -> Result<()> { |
| 1271 | let ir = ir_from_cc( |
| 1272 | r#"struct DefaultedConstructor { |
| 1273 | DefaultedConstructor() = default; |
| 1274 | };"#, |
| 1275 | )?; |
| 1276 | let rs_api = generate_rs_api(&ir)?; |
| 1277 | assert_rs_matches!( |
| 1278 | rs_api, |
| 1279 | quote! { |
| 1280 | impl Default for DefaultedConstructor { |
| 1281 | #[inline(always)] |
| 1282 | fn default() -> Self { |
| 1283 | let mut tmp = std::mem::MaybeUninit::<Self>::uninit(); |
| 1284 | unsafe { |
| 1285 | crate::detail::__rust_thunk___ZN20DefaultedConstructorC1Ev( |
| 1286 | tmp.as_mut_ptr()); |
| 1287 | tmp.assume_init() |
| 1288 | } |
| 1289 | } |
| 1290 | } |
| 1291 | } |
| 1292 | ); |
| 1293 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 1294 | assert_cc_matches!( |
| 1295 | rs_api_impl, |
| 1296 | quote! { |
| 1297 | extern "C" void __rust_thunk___ZN20DefaultedConstructorC1Ev( |
| 1298 | DefaultedConstructor* __this) { |
Lukasz Anforowicz | 4457baf | 2021-12-23 17:24:04 +0000 | [diff] [blame^] | 1299 | rs_api_impl_support::construct_at (__this) ; |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 1300 | } |
| 1301 | } |
| 1302 | ); |
| 1303 | Ok(()) |
| 1304 | } |
| 1305 | |
| 1306 | #[test] |
Lukasz Anforowicz | 9bab835 | 2021-12-22 17:35:31 +0000 | [diff] [blame] | 1307 | fn test_impl_default_non_trivial_struct() -> Result<()> { |
| 1308 | let ir = ir_from_cc( |
| 1309 | r#"struct NonTrivialStructWithConstructors { |
| 1310 | NonTrivialStructWithConstructors(); |
| 1311 | ~NonTrivialStructWithConstructors(); // Non-trivial |
| 1312 | };"#, |
| 1313 | )?; |
| 1314 | let rs_api = generate_rs_api(&ir)?; |
| 1315 | assert_rs_not_matches!(rs_api, quote! {impl Default}); |
| 1316 | Ok(()) |
| 1317 | } |
| 1318 | |
| 1319 | #[test] |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 1320 | fn test_thunk_ident_function() { |
| 1321 | let func = ir_func("foo"); |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1322 | assert_eq!(thunk_ident(&func), make_ident("__rust_thunk___Z3foov")); |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 1323 | } |
| 1324 | |
| 1325 | #[test] |
| 1326 | fn test_thunk_ident_special_names() { |
Marcel Hlopko | 4b13b96 | 2021-12-06 12:40:56 +0000 | [diff] [blame] | 1327 | let ir = ir_from_cc("struct Class {};").unwrap(); |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 1328 | |
Googler | 45ad275 | 2021-12-06 12:12:35 +0000 | [diff] [blame] | 1329 | let destructor = |
| 1330 | ir.functions().find(|f| f.name == UnqualifiedIdentifier::Destructor).unwrap(); |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1331 | assert_eq!(thunk_ident(&destructor), make_ident("__rust_thunk___ZN5ClassD1Ev")); |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 1332 | |
Googler | 45ad275 | 2021-12-06 12:12:35 +0000 | [diff] [blame] | 1333 | let constructor = |
| 1334 | ir.functions().find(|f| f.name == UnqualifiedIdentifier::Constructor).unwrap(); |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1335 | assert_eq!(thunk_ident(&constructor), make_ident("__rust_thunk___ZN5ClassC1Ev")); |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 1336 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1337 | |
| 1338 | #[test] |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1339 | fn test_elided_lifetimes() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1340 | let ir = ir_from_cc( |
| 1341 | r#"#pragma clang lifetime_elision |
| 1342 | struct S { |
| 1343 | int& f(int& i); |
| 1344 | };"#, |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1345 | )?; |
| 1346 | let rs_api = generate_rs_api(&ir)?; |
| 1347 | assert_rs_matches!( |
| 1348 | rs_api, |
| 1349 | quote! { |
| 1350 | pub fn f<'a, 'b>(__this: &'b mut S, i: &'a mut i32) -> &'b mut i32 { ... } |
| 1351 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1352 | ); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1353 | assert_rs_matches!( |
| 1354 | rs_api, |
| 1355 | quote! { |
| 1356 | pub(crate) fn __rust_thunk___ZN1S1fERi<'a, 'b>(__this: &'b mut S, i: &'a mut i32) |
| 1357 | -> &'b mut i32; |
| 1358 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1359 | ); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1360 | Ok(()) |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 1361 | } |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 1362 | |
| 1363 | #[test] |
| 1364 | fn test_format_generic_params() -> Result<()> { |
| 1365 | assert_rs_matches!(format_generic_params(std::iter::empty::<syn::Ident>()), quote! {}); |
| 1366 | |
| 1367 | let idents = ["T1", "T2"].iter().map(|s| make_ident(s)); |
| 1368 | assert_rs_matches!(format_generic_params(idents), quote! { < T1, T2 > }); |
| 1369 | |
| 1370 | let lifetimes = ["a", "b"] |
| 1371 | .iter() |
| 1372 | .map(|s| syn::Lifetime::new(&format!("'{}", s), proc_macro2::Span::call_site())); |
| 1373 | assert_rs_matches!(format_generic_params(lifetimes), quote! { < 'a, 'b > }); |
| 1374 | |
| 1375 | Ok(()) |
| 1376 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1377 | } |