| """Module providing migrate_legacy_fields function. |
| |
| migrate_legacy_fields takes parsed CROSSTOOL proto and migrates it (inplace) to |
| use only the features. |
| |
| Tracking issue: https://github.com/bazelbuild/bazel/issues/5187 |
| |
| Since C++ rules team is working on migrating CROSSTOOL from text proto into |
| Starlark, we advise CROSSTOOL owners to wait for the CROSSTOOL -> Starlark |
| migrator before they invest too much time into fixing their pipeline. Tracking |
| issue for the Starlark effort is |
| https://github.com/bazelbuild/bazel/issues/5380. |
| """ |
| |
| from third_party.com.github.bazelbuild.bazel.src.main.protobuf import crosstool_config_pb2 |
| |
| ALL_COMPILE_ACTIONS = [ |
| "assemble", "preprocess-assemble", "linkstamp-compile", "c-compile", |
| "c++-compile", "c++-header-parsing", "c++-module-compile", |
| "c++-module-codegen", "lto-backend", "clif-match" |
| ] |
| |
| ALL_CXX_COMPILE_ACTIONS = [ |
| action for action in ALL_COMPILE_ACTIONS if action != "c-compile" |
| ] |
| |
| ALL_LINK_ACTIONS = [ |
| "c++-link-executable", "c++-link-dynamic-library", |
| "c++-link-nodeps-dynamic-library" |
| ] |
| |
| # Map converting from LinkingMode to corresponding feature name |
| LINKING_MODE_TO_FEATURE_NAME = { |
| "FULLY_STATIC": "fully_static_link", |
| "MOSTLY_STATIC": "static_linking_mode", |
| "DYNAMIC": "dynamic_linking_mode", |
| "MOSTLY_STATIC_LIBRARIES": "static_linking_mode_nodeps_library", |
| } |
| |
| |
| def migrate_legacy_fields(crosstool): |
| """Migrates parsed crosstool (inplace) to not use legacy fields.""" |
| crosstool.ClearField("default_toolchain") |
| for toolchain in crosstool.toolchain: |
| # clear noop fields first |
| toolchain.ClearField("debian_extra_requires") |
| toolchain.ClearField("gcc_plugin_compiler_flag") |
| toolchain.ClearField("ar_flag") |
| toolchain.ClearField("ar_thin_archives_flag") |
| toolchain.ClearField("gcc_plugin_header_directory") |
| toolchain.ClearField("mao_plugin_header_directory") |
| toolchain.ClearField("supports_normalizing_ar") |
| toolchain.ClearField("supports_thin_archives") |
| toolchain.ClearField("supports_incremental_linker") |
| toolchain.ClearField("supports_dsym") |
| toolchain.ClearField("default_python_top") |
| toolchain.ClearField("default_python_version") |
| toolchain.ClearField("python_preload_swigdeps") |
| |
| _ = [_migrate_expand_if_all_available(f) for f in toolchain.feature] |
| _ = [_migrate_expand_if_all_available(ac) for ac in toolchain.action_config] |
| |
| # Create default_link_flags feature for linker_flag |
| flag_sets = _extract_legacy_link_flag_sets_for(toolchain) |
| if flag_sets: |
| if _contains_feature(toolchain, "default_link_flags"): |
| continue |
| feature = _prepend_feature(toolchain) |
| feature.name = "default_link_flags" |
| feature.enabled = True |
| _add_flag_sets(feature, flag_sets) |
| |
| # Create default_compile_flags feature for compiler_flag, cxx_flag |
| flag_sets = _extract_legacy_compile_flag_sets_for(toolchain) |
| if flag_sets and not _contains_feature(toolchain, "default_compile_flags"): |
| feature = _prepend_feature(toolchain) |
| feature.enabled = True |
| feature.name = "default_compile_flags" |
| _add_flag_sets(feature, flag_sets) |
| |
| toolchain.ClearField("compilation_mode_flags") |
| |
| # Unfiltered cxx flags have to have their own special feature. |
| # "unfiltered_compile_flags" is a well-known (by Bazel) feature name that is |
| # excluded from nocopts filtering. |
| if toolchain.unfiltered_cxx_flag: |
| # If there already is a feature named unfiltered_compile_flags, the |
| # crosstool is already migrated for unfiltered_compile_flags |
| if _contains_feature(toolchain, "unfiltered_compile_flags"): |
| for f in toolchain.feature: |
| if f.name == "unfiltered_compile_flags": |
| feature = f |
| break |
| else: |
| feature = toolchain.feature.add() |
| feature.name = "unfiltered_compile_flags" |
| feature.enabled = True |
| |
| _add_flag_sets( |
| feature, [[None, ALL_COMPILE_ACTIONS, toolchain.unfiltered_cxx_flag]]) |
| toolchain.ClearField("unfiltered_cxx_flag") |
| |
| |
| def _add_flag_sets(feature, flag_sets): |
| """Add flag sets into a feature.""" |
| for flag_set in flag_sets: |
| with_feature = flag_set[0] |
| actions = flag_set[1] |
| flags = flag_set[2] |
| flag_set = feature.flag_set.add() |
| if with_feature is not None: |
| flag_set.with_feature.add().feature[:] = [with_feature] |
| flag_set.action[:] = actions |
| flag_group = flag_set.flag_group.add() |
| flag_group.flag[:] = flags |
| return feature |
| |
| |
| def _extract_legacy_compile_flag_sets_for(toolchain): |
| """Get flag sets for default_compile_flags feature.""" |
| result = [] |
| if toolchain.compiler_flag: |
| result.append([None, ALL_COMPILE_ACTIONS, toolchain.compiler_flag]) |
| toolchain.ClearField("compiler_flag") |
| if toolchain.cxx_flag: |
| result.append([None, ALL_CXX_COMPILE_ACTIONS, toolchain.cxx_flag]) |
| toolchain.ClearField("cxx_flag") |
| |
| # Migrate compiler_flag/cxx_flag from compilation_mode_flags |
| for cmf in toolchain.compilation_mode_flags: |
| mode = crosstool_config_pb2.CompilationMode.Name(cmf.mode).lower() |
| # coverage mode has been a noop since a while |
| if mode == "coverage": |
| continue |
| |
| if (cmf.compiler_flag or |
| cmf.cxx_flag) and not _contains_feature(toolchain, mode): |
| feature = toolchain.feature.add() |
| feature.name = mode |
| |
| if cmf.compiler_flag: |
| result.append([mode, ALL_COMPILE_ACTIONS, cmf.compiler_flag]) |
| |
| if cmf.cxx_flag: |
| result.append([mode, ALL_CXX_COMPILE_ACTIONS, cmf.cxx_flag]) |
| |
| return result |
| |
| |
| def _extract_legacy_link_flag_sets_for(toolchain): |
| """Get flag sets for default_link_flags feature.""" |
| result = [] |
| |
| # Migrate linker_flag |
| if toolchain.linker_flag: |
| result.append([None, ALL_LINK_ACTIONS, toolchain.linker_flag]) |
| toolchain.ClearField("linker_flag") |
| |
| # Migrate linker_flags from compilation_mode_flags |
| for cmf in toolchain.compilation_mode_flags: |
| mode = crosstool_config_pb2.CompilationMode.Name(cmf.mode).lower() |
| # coverage mode has beed a noop since a while |
| if mode == "coverage": |
| continue |
| |
| if cmf.linker_flag and not _contains_feature(toolchain, mode): |
| feature = toolchain.feature.add() |
| feature.name = mode |
| |
| if cmf.linker_flag: |
| result.append([mode, ALL_LINK_ACTIONS, cmf.linker_flag]) |
| |
| # Migrate linker_flags from linking_mode_flags |
| for lmf in toolchain.linking_mode_flags: |
| mode = crosstool_config_pb2.LinkingMode.Name(lmf.mode) |
| mode = LINKING_MODE_TO_FEATURE_NAME.get(mode) |
| # if the feature is already there, we don't migrate, lmf is not used |
| if _contains_feature(toolchain, mode): |
| continue |
| |
| # dynamic_linking_mode is also a marker feature it has a meaning |
| # even when empty |
| if lmf.linker_flag or mode == "dynamic_linking_mode": |
| feature = toolchain.feature.add() |
| feature.name = mode |
| |
| if lmf.linker_flag: |
| result.append([mode, ALL_LINK_ACTIONS, lmf.linker_flag]) |
| toolchain.ClearField("linking_mode_flags") |
| |
| return result |
| |
| |
| def _prepend_feature(toolchain): |
| """Create a new feature and make it be the first in the toolchain.""" |
| features = toolchain.feature |
| toolchain.ClearField("feature") |
| new_feature = toolchain.feature.add() |
| toolchain.feature.extend(features) |
| return new_feature |
| |
| |
| def _contains_feature(toolchain, name): |
| """Returns True when toolchain contains a feature with a given name.""" |
| return any(feature.name == name for feature in toolchain.feature) |
| |
| |
| def _migrate_expand_if_all_available(message): |
| """Move expand_if_all_available fields to flag_groups.""" |
| for flag_set in message.flag_set: |
| if flag_set.expand_if_all_available: |
| for flag_group in flag_set.flag_group: |
| new_vars = ( |
| flag_group.expand_if_all_available[:] + |
| flag_set.expand_if_all_available[:]) |
| flag_group.expand_if_all_available[:] = new_vars |
| flag_set.ClearField("expand_if_all_available") |
