Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1 | // Part of the Crubit project, under the Apache License v2.0 with LLVM |
| 2 | // Exceptions. See /LICENSE for license information. |
| 3 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
| 4 | |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 5 | use anyhow::{anyhow, bail, ensure, Context, Result}; |
Marcel Hlopko | 884ae7f | 2021-08-18 13:58:22 +0000 | [diff] [blame] | 6 | use ffi_types::*; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 7 | use ir::*; |
| 8 | use itertools::Itertools; |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 9 | use proc_macro2::{Ident, Literal, TokenStream}; |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 10 | use quote::{format_ident, quote, ToTokens}; |
Devin Jeanpierre | 9886fb4 | 2022-04-01 04:31:20 -0700 | [diff] [blame] | 11 | use std::collections::{BTreeSet, HashSet}; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 12 | use std::iter::Iterator; |
| 13 | use std::panic::catch_unwind; |
| 14 | use std::process; |
Marcel Hlopko | 65d05f0 | 2021-12-09 12:29:24 +0000 | [diff] [blame] | 15 | use token_stream_printer::{rs_tokens_to_formatted_string, tokens_to_string}; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 16 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 17 | /// FFI equivalent of `Bindings`. |
| 18 | #[repr(C)] |
| 19 | pub struct FfiBindings { |
| 20 | rs_api: FfiU8SliceBox, |
| 21 | rs_api_impl: FfiU8SliceBox, |
| 22 | } |
| 23 | |
| 24 | /// Deserializes IR from `json` and generates bindings source code. |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 25 | /// |
| 26 | /// This function panics on error. |
| 27 | /// |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 28 | /// # Safety |
| 29 | /// |
| 30 | /// Expectations: |
| 31 | /// * function expects that param `json` is a FfiU8Slice for a valid array of |
| 32 | /// bytes with the given size. |
| 33 | /// * function expects that param `json` doesn't change during the call. |
| 34 | /// |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 35 | /// Ownership: |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 36 | /// * function doesn't take ownership of (in other words it borrows) the |
| 37 | /// param `json` |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 38 | /// * function passes ownership of the returned value to the caller |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 39 | #[no_mangle] |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 40 | pub unsafe extern "C" fn GenerateBindingsImpl(json: FfiU8Slice) -> FfiBindings { |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 41 | catch_unwind(|| { |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 42 | // It is ok to abort here. |
| 43 | let Bindings { rs_api, rs_api_impl } = generate_bindings(json.as_slice()).unwrap(); |
| 44 | |
| 45 | FfiBindings { |
| 46 | rs_api: FfiU8SliceBox::from_boxed_slice(rs_api.into_bytes().into_boxed_slice()), |
| 47 | rs_api_impl: FfiU8SliceBox::from_boxed_slice( |
| 48 | rs_api_impl.into_bytes().into_boxed_slice(), |
| 49 | ), |
| 50 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 51 | }) |
| 52 | .unwrap_or_else(|_| process::abort()) |
| 53 | } |
| 54 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 55 | /// Source code for generated bindings. |
| 56 | struct Bindings { |
| 57 | // Rust source code. |
| 58 | rs_api: String, |
| 59 | // C++ source code. |
| 60 | rs_api_impl: String, |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 61 | } |
| 62 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 63 | fn generate_bindings(json: &[u8]) -> Result<Bindings> { |
| 64 | let ir = deserialize_ir(json)?; |
Marcel Hlopko | ca84ff4 | 2021-12-09 14:15:14 +0000 | [diff] [blame] | 65 | |
| 66 | // The code is formatted with a non-default rustfmt configuration. Prevent |
Lukasz Anforowicz | 5b3f530 | 2022-02-07 01:04:47 +0000 | [diff] [blame] | 67 | // downstream workflows from reformatting with a different configuration by |
| 68 | // marking the output with `@generated`. See also |
| 69 | // https://rust-lang.github.io/rustfmt/?version=v1.4.38&search=#format_generated_files |
| 70 | // |
| 71 | // TODO(lukasza): It would be nice to include "by $argv[0]"" in the |
| 72 | // @generated comment below. OTOH, `std::env::current_exe()` in our |
| 73 | // current build environment returns a guid-like path... :-/ |
Lukasz Anforowicz | 72c4d22 | 2022-02-18 19:07:28 +0000 | [diff] [blame] | 74 | // |
| 75 | // TODO(lukasza): Try to remove `#![rustfmt:skip]` - in theory it shouldn't |
| 76 | // be needed when `@generated` comment/keyword is present... |
Lukasz Anforowicz | 5b3f530 | 2022-02-07 01:04:47 +0000 | [diff] [blame] | 77 | let rs_api = format!( |
Lukasz Anforowicz | 72c4d22 | 2022-02-18 19:07:28 +0000 | [diff] [blame] | 78 | "// Automatically @generated Rust bindings for C++ target\n\ |
| 79 | // {target}\n\ |
| 80 | #![rustfmt::skip]\n\ |
| 81 | {code}", |
Lukasz Anforowicz | 5b3f530 | 2022-02-07 01:04:47 +0000 | [diff] [blame] | 82 | target = ir.current_target().0, |
| 83 | code = rs_tokens_to_formatted_string(generate_rs_api(&ir)?)? |
| 84 | ); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 85 | let rs_api_impl = tokens_to_string(generate_rs_api_impl(&ir)?)?; |
Marcel Hlopko | ca84ff4 | 2021-12-09 14:15:14 +0000 | [diff] [blame] | 86 | |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 87 | Ok(Bindings { rs_api, rs_api_impl }) |
| 88 | } |
| 89 | |
Devin Jeanpierre | 6d5e7cc | 2021-10-21 12:56:07 +0000 | [diff] [blame] | 90 | /// Rust source code with attached information about how to modify the parent |
| 91 | /// crate. |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 92 | /// |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 93 | /// For example, the snippet `vec![].into_raw_parts()` is not valid unless the |
| 94 | /// `vec_into_raw_parts` feature is enabled. So such a snippet should be |
| 95 | /// represented as: |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 96 | /// |
| 97 | /// ``` |
| 98 | /// RsSnippet { |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 99 | /// features: btree_set![make_rs_ident("vec_into_raw_parts")], |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 100 | /// tokens: quote!{vec![].into_raw_parts()}, |
| 101 | /// } |
| 102 | /// ``` |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 103 | #[derive(Clone, Debug)] |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 104 | struct RsSnippet { |
| 105 | /// Rust feature flags used by this snippet. |
| 106 | features: BTreeSet<Ident>, |
| 107 | /// The snippet itself, as a token stream. |
| 108 | tokens: TokenStream, |
| 109 | } |
| 110 | |
| 111 | impl From<TokenStream> for RsSnippet { |
| 112 | fn from(tokens: TokenStream) -> Self { |
| 113 | RsSnippet { features: BTreeSet::new(), tokens } |
| 114 | } |
| 115 | } |
| 116 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 117 | /// If we know the original C++ function is codegenned and already compatible |
| 118 | /// with `extern "C"` calling convention we skip creating/calling the C++ thunk |
| 119 | /// since we can call the original C++ directly. |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 120 | fn can_skip_cc_thunk(func: &Func) -> bool { |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 121 | // ## Inline functions |
| 122 | // |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 123 | // Inline functions may not be codegenned in the C++ library since Clang doesn't |
| 124 | // know if Rust calls the function or not. Therefore in order to make inline |
| 125 | // functions callable from Rust we need to generate a C++ file that defines |
| 126 | // a thunk that delegates to the original inline function. When compiled, |
| 127 | // Clang will emit code for this thunk and Rust code will call the |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 128 | // thunk when the user wants to call the original inline function. |
| 129 | // |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 130 | // This is not great runtime-performance-wise in regular builds (inline function |
| 131 | // will not be inlined, there will always be a function call), but it is |
| 132 | // correct. ThinLTO builds will be able to see through the thunk and inline |
| 133 | // code across the language boundary. For non-ThinLTO builds we plan to |
| 134 | // implement <internal link> which removes the runtime performance overhead. |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 135 | if func.is_inline { |
| 136 | return false; |
| 137 | } |
| 138 | // ## Virtual functions |
| 139 | // |
| 140 | // When calling virtual `A::Method()`, it's not necessarily the case that we'll |
| 141 | // specifically call the concrete `A::Method` impl. For example, if this is |
| 142 | // called on something whose dynamic type is some subclass `B` with an |
| 143 | // overridden `B::Method`, then we'll call that. |
| 144 | // |
| 145 | // We must reuse the C++ dynamic dispatching system. In this case, the easiest |
| 146 | // way to do it is by resorting to a C++ thunk, whose implementation will do |
| 147 | // the lookup. |
| 148 | // |
| 149 | // In terms of runtime performance, since this only occurs for virtual function |
| 150 | // calls, which are already slow, it may not be such a big deal. We can |
| 151 | // benchmark it later. :) |
| 152 | if let Some(meta) = &func.member_func_metadata { |
| 153 | if let Some(inst_meta) = &meta.instance_method_metadata { |
| 154 | if inst_meta.is_virtual { |
| 155 | return false; |
| 156 | } |
| 157 | } |
| 158 | } |
Lukasz Anforowicz | 0b6a6ac | 2022-03-22 22:32:23 +0000 | [diff] [blame] | 159 | // ## Custom calling convention requires a thunk. |
| 160 | // |
| 161 | // The thunk has the "C" calling convention, and internally can call the |
| 162 | // C++ function using any of the calling conventions supported by the C++ |
| 163 | // compiler (which might not always match the set supported by Rust - e.g., |
| 164 | // abi.rs doesn't contain "swiftcall" from |
| 165 | // clang::FunctionType::getNameForCallConv) |
| 166 | if !func.has_c_calling_convention { |
| 167 | return false; |
| 168 | } |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 169 | |
| 170 | true |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 171 | } |
| 172 | |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 173 | /// Uniquely identifies a generated Rust function. |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 174 | #[derive(Clone, Debug, PartialEq, Eq, Hash)] |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 175 | struct FunctionId { |
| 176 | // If the function is on a trait impl, contains the name of the Self type for |
| 177 | // which the trait is being implemented. |
| 178 | self_type: Option<syn::Path>, |
| 179 | // Fully qualified path of the function. For functions in impl blocks, this |
| 180 | // includes the name of the type or trait on which the function is being |
| 181 | // implemented, e.g. `Default::default`. |
| 182 | function_path: syn::Path, |
| 183 | } |
| 184 | |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 185 | /// Returns the name of `func` in C++ syntax. |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 186 | fn cxx_function_name(func: &Func, ir: &IR) -> Result<String> { |
| 187 | let record: Option<&str> = func |
| 188 | .member_func_metadata |
| 189 | .as_ref() |
| 190 | .map(|meta| meta.find_record(ir)) |
| 191 | .transpose()? |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 192 | .map(|r| &*r.cc_name); |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 193 | |
| 194 | let func_name = match &func.name { |
| 195 | UnqualifiedIdentifier::Identifier(id) => id.identifier.clone(), |
Lukasz Anforowicz | 9c663ca | 2022-02-09 01:33:31 +0000 | [diff] [blame] | 196 | UnqualifiedIdentifier::Operator(op) => op.cc_name(), |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 197 | UnqualifiedIdentifier::Destructor => { |
| 198 | format!("~{}", record.expect("destructor must be associated with a record")) |
| 199 | } |
| 200 | UnqualifiedIdentifier::Constructor => { |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 201 | record.expect("constructor must be associated with a record").to_string() |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 202 | } |
| 203 | }; |
| 204 | |
| 205 | if let Some(record_name) = record { |
| 206 | Ok(format!("{}::{}", record_name, func_name)) |
| 207 | } else { |
| 208 | Ok(func_name) |
| 209 | } |
| 210 | } |
| 211 | |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 212 | fn make_unsupported_fn(func: &Func, ir: &IR, message: impl ToString) -> Result<UnsupportedItem> { |
| 213 | Ok(UnsupportedItem { |
| 214 | name: cxx_function_name(func, ir)?, |
| 215 | message: message.to_string(), |
| 216 | source_loc: func.source_loc.clone(), |
Rosica Dejanovska | d638cf5 | 2022-03-23 15:45:01 +0000 | [diff] [blame] | 217 | id: func.id, |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 218 | }) |
| 219 | } |
| 220 | |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 221 | /// The name of a trait, with extra entries for specially-understood traits and |
| 222 | /// families of traits. |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 223 | enum TraitName<'ir> { |
| 224 | /// The constructor trait for !Unpin types. e.g. |
| 225 | /// `CtorNew(RsTypeKind::Unit)` is the default constructor. |
| 226 | CtorNew(RsTypeKind<'ir>), |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 227 | /// An Unpin constructor trait, e.g. From or Clone. |
| 228 | UnpinConstructor(TokenStream), |
| 229 | /// Any other trait, e.g. Eq. |
| 230 | Other(TokenStream), |
| 231 | } |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 232 | impl<'ir> ToTokens for TraitName<'ir> { |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 233 | fn to_tokens(&self, tokens: &mut TokenStream) { |
| 234 | match self { |
| 235 | Self::UnpinConstructor(t) | Self::Other(t) => t.to_tokens(tokens), |
| 236 | Self::CtorNew(args) => quote! { ctor::CtorNew < #args > }.to_tokens(tokens), |
| 237 | } |
| 238 | } |
| 239 | } |
| 240 | |
| 241 | /// The kind of the `impl` block the function needs to be generated in. |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 242 | enum ImplKind<'ir> { |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 243 | /// Used for free functions for which we don't want the `impl` block. |
| 244 | None { is_unsafe: bool }, |
| 245 | /// Used for inherent methods for which we need an `impl SomeStruct { ... }` |
| 246 | /// block. |
| 247 | Struct { |
| 248 | /// For example, `SomeStruct`. Retrieved from |
| 249 | /// `func.member_func_metadata`. |
| 250 | record_name: Ident, |
| 251 | is_unsafe: bool, |
| 252 | /// Whether to format the first parameter as "self" (e.g. `__this: |
| 253 | /// &mut T` -> `&mut self`) |
| 254 | format_first_param_as_self: bool, |
| 255 | }, |
| 256 | /// Used for trait methods for which we need an `impl TraitName for |
| 257 | /// SomeStruct { ... }` block. |
| 258 | Trait { |
| 259 | /// For example, `SomeStruct`. |
| 260 | /// Note that `record_name` might *not* be from |
| 261 | /// `func.member_func_metadata`. |
| 262 | record_name: Ident, |
| 263 | /// For example, `quote!{ From<i32> }`. |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 264 | trait_name: TraitName<'ir>, |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 265 | |
| 266 | /// Where to declare lifetimes: `impl<'b>` VS `fn foo<'b>`. |
| 267 | declare_lifetimes: bool, |
| 268 | /// The generic params of trait `impl` (e.g. `<'b>`). These start |
| 269 | /// empty and only later are mutated into the correct value. |
| 270 | trait_generic_params: TokenStream, |
| 271 | /// Whether to format the first parameter as "self" (e.g. `__this: |
| 272 | /// &mut T` -> `&mut self`) |
| 273 | format_first_param_as_self: bool, |
| 274 | }, |
| 275 | } |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 276 | impl<'ir> ImplKind<'ir> { |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 277 | fn new_trait( |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 278 | trait_name: TraitName<'ir>, |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 279 | record_name: Ident, |
| 280 | format_first_param_as_self: bool, |
| 281 | ) -> Self { |
| 282 | ImplKind::Trait { |
| 283 | trait_name, |
| 284 | record_name, |
| 285 | declare_lifetimes: false, |
| 286 | trait_generic_params: quote! {}, |
| 287 | format_first_param_as_self, |
| 288 | } |
| 289 | } |
| 290 | fn new_generic_trait( |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 291 | trait_name: TraitName<'ir>, |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 292 | record_name: Ident, |
| 293 | format_first_param_as_self: bool, |
| 294 | ) -> Self { |
| 295 | ImplKind::Trait { |
| 296 | trait_name, |
| 297 | record_name, |
| 298 | declare_lifetimes: true, |
| 299 | trait_generic_params: quote! {}, |
| 300 | format_first_param_as_self, |
| 301 | } |
| 302 | } |
| 303 | fn format_first_param_as_self(&self) -> bool { |
| 304 | matches!( |
| 305 | self, |
| 306 | Self::Trait { format_first_param_as_self: true, .. } |
| 307 | | Self::Struct { format_first_param_as_self: true, .. } |
| 308 | ) |
| 309 | } |
| 310 | /// Returns whether the function is defined as `unsafe fn ...`. |
| 311 | fn is_unsafe(&self) -> bool { |
| 312 | matches!(self, Self::None { is_unsafe: true, .. } | Self::Struct { is_unsafe: true, .. }) |
| 313 | } |
| 314 | } |
| 315 | |
| 316 | /// Returns the shape of the generated Rust API for a given function definition. |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 317 | /// |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 318 | /// Returns: |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 319 | /// |
| 320 | /// * `Err(_)`: something went wrong importing this function. |
| 321 | /// * `Ok(None)`: the function imported as "nothing". (For example, a defaulted |
| 322 | /// destructor might be mapped to no `Drop` impl at all.) |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 323 | /// * `Ok((func_name, impl_kind))`: The function name and ImplKind. |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 324 | fn api_func_shape<'ir>( |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 325 | func: &Func, |
| 326 | ir: &IR, |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 327 | param_type_kinds: &[RsTypeKind<'ir>], |
| 328 | ) -> Result<Option<(Ident, ImplKind<'ir>)>> { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 329 | let maybe_record: Option<&Record> = |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 330 | func.member_func_metadata.as_ref().map(|meta| meta.find_record(ir)).transpose()?; |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 331 | let has_pointer_params = |
| 332 | param_type_kinds.iter().any(|p| matches!(p, RsTypeKind::Pointer { .. })); |
| 333 | let impl_kind: ImplKind; |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 334 | let func_name: syn::Ident; |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 335 | match &func.name { |
Lukasz Anforowicz | 9c663ca | 2022-02-09 01:33:31 +0000 | [diff] [blame] | 336 | UnqualifiedIdentifier::Operator(op) if op.name == "==" => { |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 337 | if param_type_kinds.len() != 2 { |
| 338 | bail!("Unexpected number of parameters in operator==: {:?}", func); |
| 339 | } |
| 340 | match (¶m_type_kinds[0], ¶m_type_kinds[1]) { |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 341 | ( |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 342 | RsTypeKind::Reference { referent: lhs, mutability: Mutability::Const, .. }, |
| 343 | RsTypeKind::Reference { referent: rhs, mutability: Mutability::Const, .. }, |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 344 | ) => match **lhs { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 345 | RsTypeKind::Record { record: lhs_record, .. } => { |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 346 | let lhs: Ident = make_rs_ident(&lhs_record.rs_name); |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 347 | func_name = make_rs_ident("eq"); |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 348 | // Not using `ImplKind::new_generic_trait`, because #rhs |
| 349 | // should be stripped of references + because `&'a self` |
| 350 | // needs to have its lifetime declared next to `fn`, not |
| 351 | // next to `impl`. |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 352 | impl_kind = ImplKind::new_trait( |
| 353 | TraitName::Other(quote! {PartialEq<#rhs>}), |
| 354 | lhs, |
| 355 | /* format_first_param_as_self= */ true, |
| 356 | ); |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 357 | } |
Marcel Hlopko | 14ee3c8 | 2022-02-09 09:46:23 +0000 | [diff] [blame] | 358 | _ => { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 359 | bail!("operator== where lhs doesn't refer to a record",); |
Marcel Hlopko | 14ee3c8 | 2022-02-09 09:46:23 +0000 | [diff] [blame] | 360 | } |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 361 | }, |
Marcel Hlopko | 14ee3c8 | 2022-02-09 09:46:23 +0000 | [diff] [blame] | 362 | _ => { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 363 | bail!("operator== where operands are not const references",); |
Marcel Hlopko | 14ee3c8 | 2022-02-09 09:46:23 +0000 | [diff] [blame] | 364 | } |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 365 | }; |
| 366 | } |
Lukasz Anforowicz | 9c663ca | 2022-02-09 01:33:31 +0000 | [diff] [blame] | 367 | UnqualifiedIdentifier::Operator(_) => { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 368 | bail!("Bindings for this kind of operator are not supported"); |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 369 | } |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 370 | UnqualifiedIdentifier::Identifier(id) => { |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 371 | func_name = make_rs_ident(&id.identifier); |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 372 | match maybe_record { |
| 373 | None => { |
Devin Jeanpierre | 7c3d8ed | 2022-03-29 03:02:04 -0700 | [diff] [blame] | 374 | impl_kind = ImplKind::None { is_unsafe: has_pointer_params }; |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 375 | } |
| 376 | Some(record) => { |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 377 | let format_first_param_as_self = if func.is_instance_method() { |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 378 | let first_param = param_type_kinds.first().ok_or_else(|| { |
| 379 | anyhow!("Missing `__this` parameter in an instance method: {:?}", func) |
| 380 | })?; |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 381 | first_param.is_ref_to(record) |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 382 | } else { |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 383 | false |
| 384 | }; |
Devin Jeanpierre | 6784e5e | 2022-03-29 02:59:01 -0700 | [diff] [blame] | 385 | impl_kind = ImplKind::Struct { |
| 386 | record_name: make_rs_ident(&record.rs_name), |
| 387 | format_first_param_as_self, |
Devin Jeanpierre | 7c3d8ed | 2022-03-29 03:02:04 -0700 | [diff] [blame] | 388 | is_unsafe: has_pointer_params, |
Devin Jeanpierre | 6784e5e | 2022-03-29 02:59:01 -0700 | [diff] [blame] | 389 | }; |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 390 | } |
| 391 | }; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 392 | } |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 393 | UnqualifiedIdentifier::Destructor => { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 394 | // Note: to avoid double-destruction of the fields, they are all wrapped in |
| 395 | // ManuallyDrop in this case. See `generate_record`. |
| 396 | let record = |
| 397 | maybe_record.ok_or_else(|| anyhow!("Destructors must be member functions."))?; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 398 | if !should_implement_drop(record) { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 399 | return Ok(None); |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 400 | } |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 401 | impl_kind = ImplKind::new_trait( |
| 402 | TraitName::Other(quote! {Drop}), |
Devin Jeanpierre | 6784e5e | 2022-03-29 02:59:01 -0700 | [diff] [blame] | 403 | make_rs_ident(&record.rs_name), |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 404 | /* format_first_param_as_self= */ true, |
| 405 | ); |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 406 | func_name = make_rs_ident("drop"); |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 407 | } |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 408 | UnqualifiedIdentifier::Constructor => { |
Lukasz Anforowicz | 71716b7 | 2022-01-26 17:05:05 +0000 | [diff] [blame] | 409 | let member_func_metadata = func |
| 410 | .member_func_metadata |
| 411 | .as_ref() |
| 412 | .ok_or_else(|| anyhow!("Constructors must be member functions."))?; |
| 413 | let record = maybe_record |
| 414 | .ok_or_else(|| anyhow!("Constructors must be associated with a record."))?; |
| 415 | let instance_method_metadata = |
| 416 | member_func_metadata |
| 417 | .instance_method_metadata |
| 418 | .as_ref() |
| 419 | .ok_or_else(|| anyhow!("Constructors must be instance methods."))?; |
Devin Jeanpierre | 7c3d8ed | 2022-03-29 03:02:04 -0700 | [diff] [blame] | 420 | if has_pointer_params { |
Lukasz Anforowicz | 55673c9 | 2022-01-27 19:37:26 +0000 | [diff] [blame] | 421 | // TODO(b/216648347): Allow this outside of traits (e.g. after supporting |
| 422 | // translating C++ constructors into static methods in Rust). |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 423 | bail!( |
Lukasz Anforowicz | eb19ac6 | 2022-02-05 00:10:16 +0000 | [diff] [blame] | 424 | "Unsafe constructors (e.g. with no elided or explicit lifetimes) \ |
| 425 | are intentionally not supported", |
| 426 | ); |
Lukasz Anforowicz | 55673c9 | 2022-01-27 19:37:26 +0000 | [diff] [blame] | 427 | } |
| 428 | |
Devin Jeanpierre | 6784e5e | 2022-03-29 02:59:01 -0700 | [diff] [blame] | 429 | let record_name = make_rs_ident(&record.rs_name); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 430 | if !record.is_unpin() { |
| 431 | func_name = make_rs_ident("ctor_new"); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 432 | |
| 433 | match func.params.len() { |
| 434 | 0 => bail!("Missing `__this` parameter in a constructor: {:?}", func), |
| 435 | 2 => { |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 436 | impl_kind = ImplKind::new_generic_trait( |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 437 | TraitName::CtorNew(param_type_kinds[1].clone()), |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 438 | record_name, |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 439 | /* format_first_param_as_self= */ false, |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 440 | ); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 441 | } |
| 442 | _ => { |
| 443 | // TODO(b/216648347): Support bindings for other constructors. |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 444 | bail!( |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 445 | "Only single-parameter constructors for T: !Unpin are supported for now", |
Marcel Hlopko | 14ee3c8 | 2022-02-09 09:46:23 +0000 | [diff] [blame] | 446 | ); |
Lukasz Anforowicz | 73326af | 2022-01-05 01:13:10 +0000 | [diff] [blame] | 447 | } |
| 448 | } |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 449 | } else { |
| 450 | match func.params.len() { |
| 451 | 0 => bail!("Missing `__this` parameter in a constructor: {:?}", func), |
| 452 | 1 => { |
| 453 | impl_kind = ImplKind::new_trait( |
| 454 | TraitName::UnpinConstructor(quote! {Default}), |
| 455 | record_name, |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 456 | /* format_first_param_as_self= */ false, |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 457 | ); |
| 458 | func_name = make_rs_ident("default"); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 459 | } |
| 460 | 2 => { |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 461 | if param_type_kinds[1].is_shared_ref_to(record) { |
| 462 | // Copy constructor |
| 463 | if should_derive_clone(record) { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 464 | return Ok(None); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 465 | } else { |
| 466 | impl_kind = ImplKind::new_trait( |
| 467 | TraitName::UnpinConstructor(quote! {Clone}), |
| 468 | record_name, |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 469 | /* format_first_param_as_self= */ true, |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 470 | ); |
| 471 | func_name = make_rs_ident("clone"); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 472 | } |
| 473 | } else if !instance_method_metadata.is_explicit_ctor { |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 474 | let param_type = ¶m_type_kinds[1]; |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 475 | impl_kind = ImplKind::new_generic_trait( |
| 476 | TraitName::UnpinConstructor(quote! {From< #param_type >}), |
| 477 | record_name, |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 478 | /* format_first_param_as_self= */ false, |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 479 | ); |
| 480 | func_name = make_rs_ident("from"); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 481 | } else { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 482 | bail!("Not yet supported type of constructor parameter",); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 483 | } |
| 484 | } |
| 485 | _ => { |
| 486 | // TODO(b/216648347): Support bindings for other constructors. |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 487 | bail!("More than 1 constructor parameter is not supported yet",); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 488 | } |
Lukasz Anforowicz | 73326af | 2022-01-05 01:13:10 +0000 | [diff] [blame] | 489 | } |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 490 | } |
| 491 | } |
| 492 | } |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 493 | Ok(Some((func_name, impl_kind))) |
| 494 | } |
| 495 | |
| 496 | /// Generates Rust source code for a given `Func`. |
| 497 | /// |
| 498 | /// Returns: |
| 499 | /// |
| 500 | /// * `Err(_)`: couldn't import the function, emit an `UnsupportedItem`. |
| 501 | /// * `Ok(None)`: the function imported as "nothing". (For example, a defaulted |
| 502 | /// destructor might be mapped to no `Drop` impl at all.) |
| 503 | /// * `Ok((rs_api, rs_thunk, function_id))`: The Rust function definition, |
| 504 | /// thunk FFI definition, and function ID. |
| 505 | fn generate_func(func: &Func, ir: &IR) -> Result<Option<(RsSnippet, RsSnippet, FunctionId)>> { |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 506 | let param_type_kinds = func |
| 507 | .params |
| 508 | .iter() |
| 509 | .map(|p| { |
| 510 | RsTypeKind::new(&p.type_.rs_type, ir).with_context(|| { |
| 511 | format!("Failed to process type of parameter {:?} on {:?}", p, func) |
| 512 | }) |
| 513 | }) |
| 514 | .collect::<Result<Vec<_>>>()?; |
| 515 | |
| 516 | let (func_name, mut impl_kind) = |
Devin Jeanpierre | 9886fb4 | 2022-04-01 04:31:20 -0700 | [diff] [blame] | 517 | if let Some(values) = api_func_shape(func, ir, ¶m_type_kinds)? { |
Devin Jeanpierre | 9c34da6 | 2022-03-31 04:57:16 -0700 | [diff] [blame] | 518 | values |
| 519 | } else { |
| 520 | return Ok(None); |
| 521 | }; |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 522 | |
Devin Jeanpierre | d9cecff | 2022-03-29 02:53:58 -0700 | [diff] [blame] | 523 | let return_type_fragment = RsTypeKind::new(&func.return_type.rs_type, ir) |
Devin Jeanpierre | 82e8e36 | 2022-04-05 11:04:55 -0700 | [diff] [blame] | 524 | .map(|t| t.format_as_return_type_fragment()) |
Devin Jeanpierre | d9cecff | 2022-03-29 02:53:58 -0700 | [diff] [blame] | 525 | .with_context(|| format!("Failed to format return type for {:?}", func))?; |
| 526 | let param_idents = |
| 527 | func.params.iter().map(|p| make_rs_ident(&p.identifier.identifier)).collect_vec(); |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 528 | let param_types: Vec<_> = param_type_kinds.iter().map(|t| t.to_token_stream()).collect(); |
Devin Jeanpierre | d9cecff | 2022-03-29 02:53:58 -0700 | [diff] [blame] | 529 | let thunk_ident = thunk_ident(func); |
| 530 | |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 531 | let api_func_def = { |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 532 | // Clone params, return type, etc - we may need to mutate them in the |
| 533 | // API func, but we want to retain the originals for the thunk. |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 534 | let mut return_type_fragment = return_type_fragment.clone(); |
| 535 | let mut thunk_args = param_idents.iter().map(|id| quote! { #id}).collect_vec(); |
| 536 | let mut api_params = param_idents |
| 537 | .iter() |
| 538 | .zip(param_types.iter()) |
| 539 | .map(|(ident, type_)| quote! { #ident : #type_ }) |
| 540 | .collect_vec(); |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 541 | let mut lifetimes = func.lifetime_params.iter().collect_vec(); |
Lukasz Anforowicz | f7bdd39 | 2022-01-21 00:33:39 +0000 | [diff] [blame] | 542 | let mut maybe_first_api_param = param_type_kinds.get(0); |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 543 | |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 544 | if let ImplKind::Trait { |
| 545 | trait_name: TraitName::UnpinConstructor(..) | TraitName::CtorNew(..), |
| 546 | .. |
| 547 | } = impl_kind |
| 548 | { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 549 | return_type_fragment = quote! { -> Self }; |
| 550 | |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 551 | // Drop `__this` parameter from the public Rust API. Presence of |
| 552 | // element #0 is indirectly verified by a `Constructor`-related |
| 553 | // `match` branch a little bit above. |
| 554 | api_params.remove(0); |
| 555 | thunk_args.remove(0); |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 556 | |
Lukasz Anforowicz | 326c4e4 | 2022-01-27 14:43:00 +0000 | [diff] [blame] | 557 | // Remove the lifetime associated with `__this`. |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 558 | ensure!( |
| 559 | func.return_type.rs_type.is_unit_type(), |
| 560 | "Unexpectedly non-void return type of a constructor: {:?}", |
| 561 | func |
| 562 | ); |
Lukasz Anforowicz | f7bdd39 | 2022-01-21 00:33:39 +0000 | [diff] [blame] | 563 | let maybe_first_lifetime = func.params[0].type_.rs_type.lifetime_args.first(); |
Lukasz Anforowicz | 55673c9 | 2022-01-27 19:37:26 +0000 | [diff] [blame] | 564 | let no_longer_needed_lifetime_id = maybe_first_lifetime |
| 565 | .ok_or_else(|| anyhow!("Missing lifetime on `__this` parameter: {:?}", func))?; |
| 566 | lifetimes.retain(|l| l.id != *no_longer_needed_lifetime_id); |
Lukasz Anforowicz | 55673c9 | 2022-01-27 19:37:26 +0000 | [diff] [blame] | 567 | if let Some(type_still_dependent_on_removed_lifetime) = param_type_kinds |
| 568 | .iter() |
| 569 | .skip(1) // Skipping `__this` |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 570 | .flat_map(|t| t.lifetimes()) |
| 571 | .find(|lifetime_id| *lifetime_id == *no_longer_needed_lifetime_id) |
Lukasz Anforowicz | 55673c9 | 2022-01-27 19:37:26 +0000 | [diff] [blame] | 572 | { |
| 573 | bail!( |
| 574 | "The lifetime of `__this` is unexpectedly also used by another \ |
| 575 | parameter {:?} in function {:?}", |
| 576 | type_still_dependent_on_removed_lifetime, |
| 577 | func.name |
| 578 | ); |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 579 | } |
| 580 | |
| 581 | // Rebind `maybe_first_api_param` to the next param after `__this`. |
Lukasz Anforowicz | f7bdd39 | 2022-01-21 00:33:39 +0000 | [diff] [blame] | 582 | maybe_first_api_param = param_type_kinds.get(1); |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 583 | } |
| 584 | |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 585 | if let ImplKind::Trait { trait_name: TraitName::CtorNew(..), .. } = impl_kind { |
| 586 | return_type_fragment = quote! { -> Self::CtorType }; |
| 587 | } |
| 588 | |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 589 | // Change `__this: &'a SomeStruct` into `&'a self` if needed. |
Devin Jeanpierre | d9a6e6c | 2022-03-29 02:55:41 -0700 | [diff] [blame] | 590 | if impl_kind.format_first_param_as_self() { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 591 | let first_api_param = maybe_first_api_param |
| 592 | .ok_or_else(|| anyhow!("No parameter to format as 'self': {:?}", func))?; |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 593 | let self_decl = first_api_param.format_as_self_param(func, ir).with_context(|| { |
| 594 | format!("Failed to format as `self` param: {:?}", first_api_param) |
| 595 | })?; |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 596 | // Presence of element #0 is verified by `ok_or_else` on |
| 597 | // `maybe_first_api_param` above. |
| 598 | api_params[0] = self_decl; |
| 599 | thunk_args[0] = quote! { self }; |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 600 | } |
| 601 | |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 602 | // TODO(b/200067242): the Pin-wrapping code doesn't know to wrap &mut |
| 603 | // MaybeUninit<T> in Pin if T is !Unpin. It should understand |
| 604 | // 'structural pinning', so that we do not need into_inner_unchecked() |
| 605 | // here. |
Devin Jeanpierre | 7bddfdb | 2022-03-14 11:04:40 +0000 | [diff] [blame] | 606 | let func_body = match &impl_kind { |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 607 | ImplKind::Trait { trait_name: TraitName::CtorNew(..), .. } => { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 608 | // TODO(b/226447239): check for copy here and instead use copies in that case? |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 609 | quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 610 | ctor::FnCtor::new(move |dest: rust_std::pin::Pin<&mut rust_std::mem::MaybeUninit<Self>>| { |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 611 | unsafe { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 612 | crate::detail::#thunk_ident(rust_std::pin::Pin::into_inner_unchecked(dest) #( , #thunk_args )*); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 613 | } |
| 614 | }) |
| 615 | } |
| 616 | } |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 617 | ImplKind::Trait { trait_name: TraitName::UnpinConstructor(..), .. } => { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 618 | // SAFETY: A user-defined constructor is not guaranteed to |
| 619 | // initialize all the fields. To make the `assume_init()` call |
| 620 | // below safe, the memory is zero-initialized first. This is a |
| 621 | // bit safer, because zero-initialized memory represents a valid |
| 622 | // value for the currently supported field types (this may |
| 623 | // change once the bindings generator starts supporting |
| 624 | // reference fields). TODO(b/213243309): Double-check if |
| 625 | // zero-initialization is desirable here. |
| 626 | quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 627 | let mut tmp = rust_std::mem::MaybeUninit::<Self>::zeroed(); |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 628 | unsafe { |
| 629 | crate::detail::#thunk_ident( &mut tmp #( , #thunk_args )* ); |
| 630 | tmp.assume_init() |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 631 | } |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 632 | } |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 633 | } |
Devin Jeanpierre | 7bddfdb | 2022-03-14 11:04:40 +0000 | [diff] [blame] | 634 | _ => { |
| 635 | let mut body = quote! { crate::detail::#thunk_ident( #( #thunk_args ),* ) }; |
| 636 | // Only need to wrap everything in an `unsafe { ... }` block if |
| 637 | // the *whole* api function is safe. |
Devin Jeanpierre | 7c3d8ed | 2022-03-29 03:02:04 -0700 | [diff] [blame] | 638 | if !impl_kind.is_unsafe() { |
Devin Jeanpierre | 7bddfdb | 2022-03-14 11:04:40 +0000 | [diff] [blame] | 639 | body = quote! { unsafe { #body } }; |
| 640 | } |
| 641 | body |
| 642 | } |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 643 | }; |
| 644 | |
Devin Jeanpierre | 7c3d8ed | 2022-03-29 03:02:04 -0700 | [diff] [blame] | 645 | let pub_ = match impl_kind { |
| 646 | ImplKind::None { .. } | ImplKind::Struct { .. } => quote! { pub }, |
| 647 | ImplKind::Trait { .. } => quote! {}, |
| 648 | }; |
| 649 | let unsafe_ = if impl_kind.is_unsafe() { |
| 650 | quote! { unsafe } |
| 651 | } else { |
| 652 | quote! {} |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 653 | }; |
| 654 | |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 655 | let lifetimes = lifetimes.into_iter().map(|l| format_lifetime_name(&l.name)); |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 656 | let fn_generic_params: TokenStream; |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 657 | if let ImplKind::Trait { declare_lifetimes: true, trait_generic_params, .. } = |
| 658 | &mut impl_kind |
| 659 | { |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 660 | *trait_generic_params = format_generic_params(lifetimes); |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 661 | fn_generic_params = quote! {} |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 662 | } else { |
| 663 | fn_generic_params = format_generic_params(lifetimes); |
| 664 | } |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 665 | |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 666 | quote! { |
| 667 | #[inline(always)] |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 668 | #pub_ #unsafe_ fn #func_name #fn_generic_params( |
| 669 | #( #api_params ),* ) #return_type_fragment { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 670 | #func_body |
| 671 | } |
Lukasz Anforowicz | 13cf749 | 2021-12-22 15:29:52 +0000 | [diff] [blame] | 672 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 673 | }; |
| 674 | |
Devin Jeanpierre | d9cecff | 2022-03-29 02:53:58 -0700 | [diff] [blame] | 675 | let doc_comment = generate_doc_comment(&func.doc_comment); |
| 676 | let mut features = BTreeSet::new(); |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 677 | let api_func: TokenStream; |
| 678 | let function_id: FunctionId; |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 679 | match impl_kind { |
Devin Jeanpierre | 7c3d8ed | 2022-03-29 03:02:04 -0700 | [diff] [blame] | 680 | ImplKind::None { .. } => { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 681 | api_func = quote! { #doc_comment #api_func_def }; |
| 682 | function_id = FunctionId { self_type: None, function_path: func_name.into() }; |
| 683 | } |
Devin Jeanpierre | 6784e5e | 2022-03-29 02:59:01 -0700 | [diff] [blame] | 684 | ImplKind::Struct { record_name, .. } => { |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 685 | api_func = quote! { impl #record_name { #doc_comment #api_func_def } }; |
| 686 | function_id = FunctionId { |
| 687 | self_type: None, |
| 688 | function_path: syn::parse2(quote! { #record_name :: #func_name })?, |
| 689 | }; |
| 690 | } |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 691 | ImplKind::Trait { trait_name, record_name, trait_generic_params, .. } => { |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 692 | let extra_items; |
| 693 | match trait_name { |
| 694 | TraitName::CtorNew(..) => { |
| 695 | // This feature seems destined for stabilization, and makes the code |
| 696 | // simpler. |
| 697 | features.insert(make_rs_ident("type_alias_impl_trait")); |
| 698 | extra_items = quote! {type CtorType = impl ctor::Ctor<Output = Self>;}; |
| 699 | } |
| 700 | _ => { |
| 701 | extra_items = quote! {}; |
| 702 | } |
| 703 | }; |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 704 | api_func = quote! { |
| 705 | #doc_comment |
| 706 | impl #trait_generic_params #trait_name for #record_name { |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 707 | #extra_items |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 708 | #api_func_def |
| 709 | } |
| 710 | }; |
Lukasz Anforowicz | ab65e29 | 2022-01-14 23:04:21 +0000 | [diff] [blame] | 711 | function_id = FunctionId { |
| 712 | self_type: Some(record_name.into()), |
| 713 | function_path: syn::parse2(quote! { #trait_name :: #func_name })?, |
| 714 | }; |
| 715 | } |
| 716 | } |
| 717 | |
Lukasz Anforowicz | 6d55363 | 2022-01-06 21:36:14 +0000 | [diff] [blame] | 718 | let thunk = { |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 719 | let thunk_attr = if can_skip_cc_thunk(func) { |
Devin Jeanpierre | d9cecff | 2022-03-29 02:53:58 -0700 | [diff] [blame] | 720 | let mangled_name = &func.mangled_name; |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 721 | quote! {#[link_name = #mangled_name]} |
| 722 | } else { |
| 723 | quote! {} |
| 724 | }; |
| 725 | |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 726 | // For constructors inject MaybeUninit into the type of `__this_` parameter. |
| 727 | let mut param_types = param_types; |
| 728 | if func.name == UnqualifiedIdentifier::Constructor { |
| 729 | if param_types.is_empty() || func.params.is_empty() { |
| 730 | bail!("Constructors should have at least one parameter (__this)"); |
| 731 | } |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 732 | param_types[0] = |
Devin Jeanpierre | 82e8e36 | 2022-04-05 11:04:55 -0700 | [diff] [blame] | 733 | param_type_kinds[0].format_mut_ref_as_uninitialized().with_context(|| { |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 734 | format!( |
| 735 | "Failed to format `__this` param for a constructor thunk: {:?}", |
| 736 | func.params[0] |
| 737 | ) |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 738 | })?; |
| 739 | } else if func.name == UnqualifiedIdentifier::Destructor { |
| 740 | if param_types.is_empty() || func.params.is_empty() { |
| 741 | bail!("Destructors should have at least one parameter (__this)"); |
| 742 | } |
Devin Jeanpierre | 82e8e36 | 2022-04-05 11:04:55 -0700 | [diff] [blame] | 743 | param_types[0] = param_type_kinds[0].format_ref_as_raw_ptr().with_context(|| { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 744 | format!( |
| 745 | "Failed to format `__this` param for a destructor thunk: {:?}", |
| 746 | func.params[0] |
| 747 | ) |
| 748 | })?; |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 749 | } |
| 750 | |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 751 | let lifetimes = func.lifetime_params.iter().map(|l| format_lifetime_name(&l.name)); |
| 752 | let generic_params = format_generic_params(lifetimes); |
| 753 | |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 754 | quote! { |
| 755 | #thunk_attr |
Lukasz Anforowicz | 4ad012b | 2021-12-15 18:13:40 +0000 | [diff] [blame] | 756 | pub(crate) fn #thunk_ident #generic_params( #( #param_idents: #param_types ),* |
| 757 | ) #return_type_fragment ; |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 758 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 759 | }; |
| 760 | |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 761 | Ok(Some((RsSnippet { features, tokens: api_func }, thunk.into(), function_id))) |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 762 | } |
| 763 | |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 764 | fn generate_doc_comment(comment: &Option<String>) -> TokenStream { |
| 765 | match comment { |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 766 | Some(text) => { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 767 | // token_stream_printer (and rustfmt) don't put a space between /// and the doc |
| 768 | // comment, let's add it here so our comments are pretty. |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 769 | let doc = format!(" {}", text.replace('\n', "\n ")); |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 770 | quote! {#[doc=#doc]} |
| 771 | } |
| 772 | None => quote! {}, |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 773 | } |
| 774 | } |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 775 | |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 776 | fn format_generic_params<T: ToTokens>(params: impl IntoIterator<Item = T>) -> TokenStream { |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 777 | let mut params = params.into_iter().peekable(); |
| 778 | if params.peek().is_none() { |
| 779 | quote! {} |
| 780 | } else { |
| 781 | quote! { < #( #params ),* > } |
| 782 | } |
| 783 | } |
| 784 | |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 785 | fn should_implement_drop(record: &Record) -> bool { |
| 786 | match record.destructor.definition { |
| 787 | // TODO(b/202258760): Only omit destructor if `Copy` is specified. |
| 788 | SpecialMemberDefinition::Trivial => false, |
| 789 | |
| 790 | // TODO(b/212690698): Avoid calling into the C++ destructor (e.g. let |
| 791 | // Rust drive `drop`-ing) to avoid (somewhat unergonomic) ManuallyDrop |
| 792 | // if we can ask Rust to preserve C++ field destruction order in |
| 793 | // NontrivialMembers case. |
| 794 | SpecialMemberDefinition::NontrivialMembers => true, |
| 795 | |
| 796 | // The `impl Drop` for NontrivialUserDefined needs to call into the |
| 797 | // user-defined destructor on C++ side. |
| 798 | SpecialMemberDefinition::NontrivialUserDefined => true, |
| 799 | |
| 800 | // TODO(b/213516512): Today the IR doesn't contain Func entries for |
| 801 | // deleted functions/destructors/etc. But, maybe we should generate |
| 802 | // `impl Drop` in this case? With `unreachable!`? With |
| 803 | // `std::mem::forget`? |
| 804 | SpecialMemberDefinition::Deleted => false, |
| 805 | } |
| 806 | } |
| 807 | |
| 808 | /// Returns whether fields of type `ty` need to be wrapped in `ManuallyDrop<T>` |
| 809 | /// to prevent the fields from being destructed twice (once by the C++ |
| 810 | /// destructor calkled from the `impl Drop` of the struct and once by `drop` on |
| 811 | /// the Rust side). |
| 812 | /// |
| 813 | /// A type is safe to destroy twice if it implements `Copy`. Fields of such |
| 814 | /// don't need to be wrapped in `ManuallyDrop<T>` even if the struct |
| 815 | /// containing the fields provides an `impl Drop` that calles into a C++ |
| 816 | /// destructor (in addition to dropping the fields on the Rust side). |
| 817 | /// |
| 818 | /// Note that it is not enough to just be `!needs_drop<T>()`: Rust only |
| 819 | /// guarantees that it is safe to use-after-destroy for `Copy` types. See |
| 820 | /// e.g. the documentation for |
| 821 | /// [`drop_in_place`](https://doc.rust-lang.org/std/ptr/fn.drop_in_place.html): |
| 822 | /// |
| 823 | /// > if `T` is not `Copy`, using the pointed-to value after calling |
| 824 | /// > `drop_in_place` can cause undefined behavior |
Teddy Katz | d2cd142 | 2022-04-04 09:41:33 -0700 | [diff] [blame] | 825 | /// |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 826 | /// For non-Copy union fields, failing to use `ManuallyDrop<T>` would |
| 827 | /// additionally cause a compile-time error until https://github.com/rust-lang/rust/issues/55149 is stabilized. |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 828 | fn needs_manually_drop(ty: &ir::RsType, ir: &IR) -> Result<bool> { |
| 829 | let ty_implements_copy = RsTypeKind::new(ty, ir)?.implements_copy(); |
| 830 | Ok(!ty_implements_copy) |
| 831 | } |
| 832 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 833 | /// Generates Rust source code for a given `Record` and associated assertions as |
| 834 | /// a tuple. |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 835 | fn generate_record(record: &Record, ir: &IR) -> Result<(RsSnippet, RsSnippet)> { |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 836 | let ident = make_rs_ident(&record.rs_name); |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 837 | let doc_comment = generate_doc_comment(&record.doc_comment); |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 838 | let field_idents = |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 839 | record.fields.iter().map(|f| make_rs_ident(&f.identifier.identifier)).collect_vec(); |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 840 | let field_doc_coments = |
| 841 | record.fields.iter().map(|f| generate_doc_comment(&f.doc_comment)).collect_vec(); |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 842 | |
| 843 | let mut field_copy_trait_assertions: Vec<TokenStream> = vec![]; |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 844 | let field_types = record |
| 845 | .fields |
| 846 | .iter() |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 847 | .enumerate() |
| 848 | .map(|(i, f)| { |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 849 | // [[no_unique_address]] fields are replaced by an unaligned block of memory |
| 850 | // which fills space up to the next field. |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 851 | // See: docs/struct_layout |
| 852 | if f.is_no_unique_address { |
| 853 | let next_offset = if let Some(next) = record.fields.get(i + 1) { |
| 854 | next.offset |
| 855 | } else { |
| 856 | record.size * 8 |
| 857 | }; |
| 858 | let width = Literal::usize_unsuffixed((next_offset - f.offset) / 8); |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 859 | return Ok(quote! {[rust_std::mem::MaybeUninit<u8>; #width]}); |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 860 | } |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 861 | let mut formatted = format_rs_type(&f.type_.rs_type, ir).with_context(|| { |
| 862 | format!("Failed to format type for field {:?} on record {:?}", f, record) |
| 863 | })?; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 864 | // TODO(b/212696226): Verify cases where ManuallyDrop<T> is skipped |
| 865 | // via static asserts in the generated code. |
Teddy Katz | d2cd142 | 2022-04-04 09:41:33 -0700 | [diff] [blame] | 866 | if should_implement_drop(record) || record.is_union { |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 867 | if needs_manually_drop(&f.type_.rs_type, ir)? { |
| 868 | // TODO(b/212690698): Avoid (somewhat unergonomic) ManuallyDrop |
| 869 | // if we can ask Rust to preserve field destruction order if the |
| 870 | // destructor is the SpecialMemberDefinition::NontrivialMembers |
| 871 | // case. |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 872 | formatted = quote! { rust_std::mem::ManuallyDrop<#formatted> } |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 873 | } else { |
| 874 | field_copy_trait_assertions.push(quote! { |
| 875 | const _: () = { assert_impl_all!(#formatted: Copy); }; |
| 876 | }); |
| 877 | } |
Lukasz Anforowicz | 6d55363 | 2022-01-06 21:36:14 +0000 | [diff] [blame] | 878 | }; |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 879 | Ok(formatted) |
| 880 | }) |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 881 | .collect::<Result<Vec<_>>>()?; |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 882 | |
Googler | ec589eb | 2021-09-17 07:45:39 +0000 | [diff] [blame] | 883 | let field_accesses = record |
| 884 | .fields |
| 885 | .iter() |
| 886 | .map(|f| { |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 887 | if f.access == AccessSpecifier::Public && !f.is_no_unique_address { |
Googler | ec589eb | 2021-09-17 07:45:39 +0000 | [diff] [blame] | 888 | quote! { pub } |
| 889 | } else { |
| 890 | quote! {} |
| 891 | } |
| 892 | }) |
| 893 | .collect_vec(); |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 894 | let size = record.size; |
| 895 | let alignment = record.alignment; |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 896 | let field_offset_assertions = |
Googler | aaa0a53 | 2021-10-01 09:11:27 +0000 | [diff] [blame] | 897 | record.fields.iter().zip(field_idents.iter()).map(|(field, field_ident)| { |
| 898 | let offset = field.offset; |
| 899 | quote! { |
| 900 | // The IR contains the offset in bits, while offset_of!() |
| 901 | // returns the offset in bytes, so we need to convert. |
Googler | 209b10a | 2021-12-06 09:11:57 +0000 | [diff] [blame] | 902 | const _: () = assert!(offset_of!(#ident, #field_ident) * 8 == #offset); |
Googler | aaa0a53 | 2021-10-01 09:11:27 +0000 | [diff] [blame] | 903 | } |
| 904 | }); |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 905 | // TODO(b/212696226): Generate `assert_impl_all!` or `assert_not_impl_all!` |
| 906 | // assertions about the `Copy` trait - this trait should be implemented |
| 907 | // iff `should_implement_drop(record)` is false. |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 908 | let mut record_features = BTreeSet::new(); |
| 909 | let mut assertion_features = BTreeSet::new(); |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 910 | |
| 911 | // TODO(mboehme): For the time being, we're using unstable features to |
| 912 | // be able to use offset_of!() in static assertions. This is fine for a |
| 913 | // prototype, but longer-term we want to either get those features |
| 914 | // stabilized or find an alternative. For more details, see |
| 915 | // b/200120034#comment15 |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 916 | assertion_features.insert(make_rs_ident("const_ptr_offset_from")); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 917 | |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 918 | let derives = generate_derives(record); |
Devin Jeanpierre | 9227d2c | 2021-10-06 12:26:05 +0000 | [diff] [blame] | 919 | let derives = if derives.is_empty() { |
| 920 | quote! {} |
| 921 | } else { |
| 922 | quote! {#[derive( #(#derives),* )]} |
| 923 | }; |
Teddy Katz | d2cd142 | 2022-04-04 09:41:33 -0700 | [diff] [blame] | 924 | let record_kind = if record.is_union { |
| 925 | quote! { union } |
| 926 | } else { |
| 927 | quote! { struct } |
| 928 | }; |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 929 | let unpin_impl = if record.is_unpin() { |
| 930 | quote! {} |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 931 | } else { |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 932 | // negative_impls are necessary for universal initialization due to Rust's |
| 933 | // coherence rules: PhantomPinned isn't enough to prove to Rust that a |
| 934 | // blanket impl that requires Unpin doesn't apply. See http://<internal link>=h.f6jp8ifzgt3n |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 935 | record_features.insert(make_rs_ident("negative_impls")); |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 936 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 937 | __NEWLINE__ __NEWLINE__ |
| 938 | impl !Unpin for #ident {} |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 939 | } |
| 940 | }; |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 941 | |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 942 | let mut repr_attributes = vec![quote! {C}]; |
| 943 | if record.override_alignment && record.alignment > 1 { |
| 944 | let alignment = Literal::usize_unsuffixed(record.alignment); |
| 945 | repr_attributes.push(quote! {align(#alignment)}); |
| 946 | } |
| 947 | |
| 948 | // Adjust the struct to also include base class subobjects. We use an opaque |
| 949 | // field because subobjects can live in the alignment of base class |
| 950 | // subobjects. |
| 951 | let base_subobjects_field = if let Some(base_size) = record.base_size { |
| 952 | let n = proc_macro2::Literal::usize_unsuffixed(base_size); |
| 953 | quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 954 | __base_class_subobjects: [rust_std::mem::MaybeUninit<u8>; #n], |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 955 | } |
| 956 | } else { |
| 957 | quote! {} |
| 958 | }; |
| 959 | |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 960 | let empty_struct_placeholder_field = |
| 961 | if record.fields.is_empty() && record.base_size.unwrap_or(0) == 0 { |
| 962 | quote! { |
| 963 | /// Prevent empty C++ struct being zero-size in Rust. |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 964 | placeholder: rust_std::mem::MaybeUninit<u8>, |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 965 | } |
| 966 | } else { |
| 967 | quote! {} |
| 968 | }; |
Googler | f479206 | 2021-10-20 07:21:21 +0000 | [diff] [blame] | 969 | |
Devin Jeanpierre | 58181ac | 2022-02-14 21:30:05 +0000 | [diff] [blame] | 970 | let no_unique_address_accessors = cc_struct_no_unique_address_impl(record, ir)?; |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 971 | let base_class_into = cc_struct_upcast_impl(record, ir)?; |
| 972 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 973 | let record_tokens = quote! { |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 974 | #doc_comment |
Devin Jeanpierre | 9227d2c | 2021-10-06 12:26:05 +0000 | [diff] [blame] | 975 | #derives |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 976 | #[repr(#( #repr_attributes ),*)] |
Teddy Katz | d2cd142 | 2022-04-04 09:41:33 -0700 | [diff] [blame] | 977 | pub #record_kind #ident { |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 978 | #base_subobjects_field |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 979 | #( #field_doc_coments #field_accesses #field_idents: #field_types, )* |
Googler | f479206 | 2021-10-20 07:21:21 +0000 | [diff] [blame] | 980 | #empty_struct_placeholder_field |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 981 | } |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 982 | |
Devin Jeanpierre | 58181ac | 2022-02-14 21:30:05 +0000 | [diff] [blame] | 983 | #no_unique_address_accessors |
| 984 | |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 985 | #base_class_into |
| 986 | |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 987 | #unpin_impl |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 988 | }; |
| 989 | |
Lukasz Anforowicz | 95938f8 | 2022-03-24 13:51:54 +0000 | [diff] [blame] | 990 | let record_trait_assertions = { |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 991 | let record_type_name = RsTypeKind::new_record(record, ir).to_token_stream(); |
Lukasz Anforowicz | 95938f8 | 2022-03-24 13:51:54 +0000 | [diff] [blame] | 992 | let mut assertions: Vec<TokenStream> = vec![]; |
| 993 | let mut add_assertion = |assert_impl_macro: TokenStream, trait_name: TokenStream| { |
| 994 | assertions.push(quote! { |
| 995 | const _: () = { #assert_impl_macro (#record_type_name: #trait_name); }; |
| 996 | }); |
| 997 | }; |
| 998 | if should_derive_clone(record) { |
| 999 | add_assertion(quote! { assert_impl_all! }, quote! { Clone }); |
| 1000 | } else { |
| 1001 | // Can't `assert_not_impl_all!` here, because `Clone` may be |
| 1002 | // implemented rather than derived. |
| 1003 | } |
| 1004 | let mut add_conditional_assertion = |should_impl_trait: bool, trait_name: TokenStream| { |
| 1005 | let assert_impl_macro = if should_impl_trait { |
| 1006 | quote! { assert_impl_all! } |
| 1007 | } else { |
| 1008 | quote! { assert_not_impl_all! } |
| 1009 | }; |
| 1010 | add_assertion(assert_impl_macro, trait_name); |
| 1011 | }; |
| 1012 | add_conditional_assertion(should_derive_copy(record), quote! { Copy }); |
| 1013 | add_conditional_assertion(should_implement_drop(record), quote! { Drop }); |
| 1014 | assertions |
| 1015 | }; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1016 | let assertion_tokens = quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 1017 | const _: () = assert!(rust_std::mem::size_of::<#ident>() == #size); |
| 1018 | const _: () = assert!(rust_std::mem::align_of::<#ident>() == #alignment); |
Lukasz Anforowicz | 95938f8 | 2022-03-24 13:51:54 +0000 | [diff] [blame] | 1019 | #( #record_trait_assertions )* |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 1020 | #( #field_offset_assertions )* |
| 1021 | #( #field_copy_trait_assertions )* |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1022 | }; |
| 1023 | |
| 1024 | Ok(( |
| 1025 | RsSnippet { features: record_features, tokens: record_tokens }, |
| 1026 | RsSnippet { features: assertion_features, tokens: assertion_tokens }, |
| 1027 | )) |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 1028 | } |
| 1029 | |
Lukasz Anforowicz | 2e41bb6 | 2022-01-11 18:23:07 +0000 | [diff] [blame] | 1030 | fn should_derive_clone(record: &Record) -> bool { |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 1031 | record.is_unpin() |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1032 | && record.copy_constructor.access == ir::AccessSpecifier::Public |
| 1033 | && record.copy_constructor.definition == SpecialMemberDefinition::Trivial |
Lukasz Anforowicz | 2e41bb6 | 2022-01-11 18:23:07 +0000 | [diff] [blame] | 1034 | } |
| 1035 | |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1036 | fn should_derive_copy(record: &Record) -> bool { |
| 1037 | // TODO(b/202258760): Make `Copy` inclusion configurable. |
| 1038 | should_derive_clone(record) |
| 1039 | } |
| 1040 | |
| 1041 | fn generate_derives(record: &Record) -> Vec<Ident> { |
| 1042 | let mut derives = vec![]; |
Lukasz Anforowicz | 2e41bb6 | 2022-01-11 18:23:07 +0000 | [diff] [blame] | 1043 | if should_derive_clone(record) { |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 1044 | derives.push(make_rs_ident("Clone")); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1045 | } |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1046 | if should_derive_copy(record) { |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 1047 | derives.push(make_rs_ident("Copy")); |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1048 | } |
| 1049 | derives |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 1050 | } |
| 1051 | |
Teddy Katz | 76fa42b | 2022-02-23 01:22:56 +0000 | [diff] [blame] | 1052 | fn generate_enum(enum_: &Enum, ir: &IR) -> Result<TokenStream> { |
| 1053 | let name = make_rs_ident(&enum_.identifier.identifier); |
Devin Jeanpierre | 9886fb4 | 2022-04-01 04:31:20 -0700 | [diff] [blame] | 1054 | let underlying_type = format_rs_type(&enum_.underlying_type.rs_type, ir)?; |
Teddy Katz | 76fa42b | 2022-02-23 01:22:56 +0000 | [diff] [blame] | 1055 | let enumerator_names = |
| 1056 | enum_.enumerators.iter().map(|enumerator| make_rs_ident(&enumerator.identifier.identifier)); |
| 1057 | let enumerator_values = enum_.enumerators.iter().map(|enumerator| enumerator.value); |
| 1058 | Ok(quote! { |
| 1059 | #[repr(transparent)] |
| 1060 | #[derive(Debug, PartialEq, Eq, Copy, Clone, Hash, PartialOrd, Ord)] |
| 1061 | pub struct #name(#underlying_type); |
| 1062 | impl #name { |
| 1063 | #(pub const #enumerator_names: #name = #name(#enumerator_values);)* |
| 1064 | } |
| 1065 | impl From<#underlying_type> for #name { |
| 1066 | fn from(value: #underlying_type) -> #name { |
| 1067 | #name(v) |
| 1068 | } |
| 1069 | } |
| 1070 | impl From<#name> for #underlying_type { |
| 1071 | fn from(value: #name) -> #underlying_type { |
| 1072 | v.0 |
| 1073 | } |
| 1074 | } |
| 1075 | }) |
| 1076 | } |
| 1077 | |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1078 | fn generate_type_alias(type_alias: &TypeAlias, ir: &IR) -> Result<TokenStream> { |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 1079 | let ident = make_rs_ident(&type_alias.identifier.identifier); |
Lukasz Anforowicz | c503af4 | 2022-03-04 23:18:15 +0000 | [diff] [blame] | 1080 | let doc_comment = generate_doc_comment(&type_alias.doc_comment); |
Devin Jeanpierre | 9886fb4 | 2022-04-01 04:31:20 -0700 | [diff] [blame] | 1081 | let underlying_type = format_rs_type(&type_alias.underlying_type.rs_type, ir) |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1082 | .with_context(|| format!("Failed to format underlying type for {:?}", type_alias))?; |
Lukasz Anforowicz | c503af4 | 2022-03-04 23:18:15 +0000 | [diff] [blame] | 1083 | Ok(quote! { |
| 1084 | #doc_comment |
| 1085 | pub type #ident = #underlying_type; |
| 1086 | }) |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1087 | } |
| 1088 | |
Michael Forster | 523dbd4 | 2021-10-12 11:05:44 +0000 | [diff] [blame] | 1089 | /// Generates Rust source code for a given `UnsupportedItem`. |
| 1090 | fn generate_unsupported(item: &UnsupportedItem) -> Result<TokenStream> { |
Googler | 48a74dd | 2021-10-25 07:31:53 +0000 | [diff] [blame] | 1091 | let location = if item.source_loc.filename.is_empty() { |
| 1092 | "<unknown location>".to_string() |
| 1093 | } else { |
| 1094 | // TODO(forster): The "google3" prefix should probably come from a command line |
| 1095 | // argument. |
| 1096 | // TODO(forster): Consider linking to the symbol instead of to the line number |
| 1097 | // to avoid wrong links while generated files have not caught up. |
| 1098 | format!("google3/{};l={}", &item.source_loc.filename, &item.source_loc.line) |
| 1099 | }; |
Michael Forster | 6a184ad | 2021-10-12 13:04:05 +0000 | [diff] [blame] | 1100 | let message = format!( |
Googler | 48a74dd | 2021-10-25 07:31:53 +0000 | [diff] [blame] | 1101 | "{}\nError while generating bindings for item '{}':\n{}", |
| 1102 | &location, &item.name, &item.message |
Michael Forster | 6a184ad | 2021-10-12 13:04:05 +0000 | [diff] [blame] | 1103 | ); |
Michael Forster | 523dbd4 | 2021-10-12 11:05:44 +0000 | [diff] [blame] | 1104 | Ok(quote! { __COMMENT__ #message }) |
| 1105 | } |
| 1106 | |
Michael Forster | f1dce42 | 2021-10-13 09:50:16 +0000 | [diff] [blame] | 1107 | /// Generates Rust source code for a given `Comment`. |
| 1108 | fn generate_comment(comment: &Comment) -> Result<TokenStream> { |
| 1109 | let text = &comment.text; |
| 1110 | Ok(quote! { __COMMENT__ #text }) |
| 1111 | } |
| 1112 | |
Rosica Dejanovska | 8da8f79 | 2022-03-29 02:02:22 -0700 | [diff] [blame] | 1113 | #[derive(Clone, Debug, Default)] |
| 1114 | struct GeneratedItem { |
| 1115 | item: TokenStream, |
| 1116 | thunks: TokenStream, |
| 1117 | assertions: TokenStream, |
| 1118 | features: BTreeSet<Ident>, |
| 1119 | has_record: bool, |
| 1120 | } |
| 1121 | |
| 1122 | fn generate_item( |
| 1123 | item: &Item, |
| 1124 | ir: &IR, |
| 1125 | overloaded_funcs: &HashSet<FunctionId>, |
| 1126 | ) -> Result<GeneratedItem> { |
| 1127 | let generated_item = match item { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 1128 | Item::Func(func) => match generate_func(func, ir) { |
| 1129 | Err(e) => GeneratedItem { |
| 1130 | item: generate_unsupported(&make_unsupported_fn(func, ir, format!("{e}"))?)?, |
| 1131 | ..Default::default() |
| 1132 | }, |
| 1133 | Ok(None) => GeneratedItem::default(), |
| 1134 | Ok(Some((api_func, thunk, function_id))) => { |
Rosica Dejanovska | 8da8f79 | 2022-03-29 02:02:22 -0700 | [diff] [blame] | 1135 | if overloaded_funcs.contains(&function_id) { |
| 1136 | GeneratedItem { |
| 1137 | item: generate_unsupported(&make_unsupported_fn( |
| 1138 | func, |
| 1139 | ir, |
| 1140 | "Cannot generate bindings for overloaded function", |
| 1141 | )?)?, |
| 1142 | ..Default::default() |
| 1143 | } |
| 1144 | } else { |
| 1145 | GeneratedItem { |
| 1146 | item: api_func.tokens, |
| 1147 | thunks: thunk.tokens, |
| 1148 | features: api_func.features.union(&thunk.features).cloned().collect(), |
| 1149 | ..Default::default() |
| 1150 | } |
| 1151 | } |
| 1152 | } |
| 1153 | }, |
| 1154 | Item::Record(record) => { |
| 1155 | if !ir.is_current_target(&record.owning_target) |
| 1156 | && !ir.is_stdlib_target(&record.owning_target) |
| 1157 | { |
| 1158 | GeneratedItem { ..Default::default() } |
| 1159 | } else { |
| 1160 | let (snippet, assertions_snippet) = generate_record(record, ir)?; |
| 1161 | GeneratedItem { |
| 1162 | item: snippet.tokens, |
| 1163 | assertions: assertions_snippet.tokens, |
| 1164 | features: snippet |
| 1165 | .features |
| 1166 | .union(&assertions_snippet.features) |
| 1167 | .cloned() |
| 1168 | .collect(), |
| 1169 | has_record: true, |
| 1170 | ..Default::default() |
| 1171 | } |
| 1172 | } |
| 1173 | } |
| 1174 | Item::Enum(enum_) => { |
| 1175 | if !ir.is_current_target(&enum_.owning_target) |
| 1176 | && !ir.is_stdlib_target(&enum_.owning_target) |
| 1177 | { |
| 1178 | GeneratedItem { ..Default::default() } |
| 1179 | } else { |
| 1180 | GeneratedItem { item: generate_enum(enum_, ir)?, ..Default::default() } |
| 1181 | } |
| 1182 | } |
| 1183 | Item::TypeAlias(type_alias) => { |
| 1184 | if !ir.is_current_target(&type_alias.owning_target) |
| 1185 | && !ir.is_stdlib_target(&type_alias.owning_target) |
| 1186 | { |
| 1187 | GeneratedItem { ..Default::default() } |
| 1188 | } else { |
| 1189 | GeneratedItem { item: generate_type_alias(type_alias, ir)?, ..Default::default() } |
| 1190 | } |
| 1191 | } |
| 1192 | Item::UnsupportedItem(unsupported) => { |
| 1193 | GeneratedItem { item: generate_unsupported(unsupported)?, ..Default::default() } |
| 1194 | } |
| 1195 | Item::Comment(comment) => { |
| 1196 | GeneratedItem { item: generate_comment(comment)?, ..Default::default() } |
| 1197 | } |
| 1198 | }; |
| 1199 | |
| 1200 | Ok(generated_item) |
| 1201 | } |
| 1202 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1203 | fn generate_rs_api(ir: &IR) -> Result<TokenStream> { |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1204 | let mut items = vec![]; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1205 | let mut thunks = vec![]; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1206 | let mut assertions = vec![]; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1207 | |
Googler | 454f265 | 2021-12-06 12:53:12 +0000 | [diff] [blame] | 1208 | // We import nullable pointers as an Option<&T> and assume that at the ABI |
| 1209 | // level, None is represented as a zero pointer value whereas Some is |
| 1210 | // represented as as non-zero pointer value. This seems like a pretty safe |
| 1211 | // assumption to make, but to provide some safeguard, assert that |
| 1212 | // `Option<&i32>` and `&i32` have the same size. |
| 1213 | assertions.push(quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 1214 | const _: () = assert!(rust_std::mem::size_of::<Option<&i32>>() == rust_std::mem::size_of::<&i32>()); |
Googler | 454f265 | 2021-12-06 12:53:12 +0000 | [diff] [blame] | 1215 | }); |
| 1216 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 1217 | // TODO(jeanpierreda): Delete has_record, either in favor of using RsSnippet, or not |
| 1218 | // having uses. See https://chat.google.com/room/AAAAnQmj8Qs/6QbkSvWcfhA |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 1219 | let mut has_record = false; |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 1220 | let mut features = BTreeSet::new(); |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1221 | |
Lukasz Anforowicz | 72c4d22 | 2022-02-18 19:07:28 +0000 | [diff] [blame] | 1222 | // For #![rustfmt::skip]. |
| 1223 | features.insert(make_rs_ident("custom_inner_attributes")); |
| 1224 | |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 1225 | // Identify all functions having overloads that we can't import (yet). |
| 1226 | // TODO(b/213280424): Implement support for overloaded functions. |
| 1227 | let mut seen_funcs = HashSet::new(); |
| 1228 | let mut overloaded_funcs = HashSet::new(); |
| 1229 | for func in ir.functions() { |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 1230 | if let Ok(Some((.., function_id))) = generate_func(func, ir) { |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 1231 | if !seen_funcs.insert(function_id.clone()) { |
| 1232 | overloaded_funcs.insert(function_id); |
| 1233 | } |
| 1234 | } |
| 1235 | } |
| 1236 | |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 1237 | for item in ir.items() { |
Rosica Dejanovska | 8da8f79 | 2022-03-29 02:02:22 -0700 | [diff] [blame] | 1238 | let generated = generate_item(item, ir, &overloaded_funcs)?; |
| 1239 | items.push(generated.item); |
Devin Jeanpierre | b5ba140 | 2022-03-29 07:29:24 -0700 | [diff] [blame] | 1240 | if !generated.thunks.is_empty() { |
Rosica Dejanovska | 8da8f79 | 2022-03-29 02:02:22 -0700 | [diff] [blame] | 1241 | thunks.push(generated.thunks); |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1242 | } |
Devin Jeanpierre | b5ba140 | 2022-03-29 07:29:24 -0700 | [diff] [blame] | 1243 | if !generated.assertions.is_empty() { |
Rosica Dejanovska | 8da8f79 | 2022-03-29 02:02:22 -0700 | [diff] [blame] | 1244 | assertions.push(generated.assertions); |
| 1245 | } |
| 1246 | features.extend(generated.features); |
| 1247 | has_record = has_record || generated.has_record; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1248 | } |
| 1249 | |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 1250 | let mod_detail = if thunks.is_empty() { |
| 1251 | quote! {} |
| 1252 | } else { |
| 1253 | quote! { |
| 1254 | mod detail { |
Googler | 5564714 | 2022-01-11 12:37:39 +0000 | [diff] [blame] | 1255 | #[allow(unused_imports)] |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 1256 | use super::*; |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 1257 | extern "C" { |
| 1258 | #( #thunks )* |
| 1259 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1260 | } |
| 1261 | } |
| 1262 | }; |
| 1263 | |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 1264 | // TODO(b/227790881): Replace usage of rust_std with ::std once the issue |
| 1265 | // is fixed. |
Devin Jeanpierre | ea700d3 | 2021-10-06 11:33:56 +0000 | [diff] [blame] | 1266 | let imports = if has_record { |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 1267 | quote! { |
Rosica Dejanovska | bbed201 | 2022-04-05 04:06:30 -0700 | [diff] [blame] | 1268 | use ::std as rust_std; |
Googler | aaa0a53 | 2021-10-01 09:11:27 +0000 | [diff] [blame] | 1269 | use memoffset_unstable_const::offset_of; |
Lukasz Anforowicz | fed64e6 | 2022-03-22 22:39:04 +0000 | [diff] [blame] | 1270 | use static_assertions::{assert_impl_all, assert_not_impl_all}; |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 1271 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 1272 | } else { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 1273 | quote! { |
Rosica Dejanovska | bbed201 | 2022-04-05 04:06:30 -0700 | [diff] [blame] | 1274 | use ::std as rust_std; |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 1275 | } |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 1276 | }; |
| 1277 | |
Devin Jeanpierre | 273eeae | 2021-10-06 13:29:35 +0000 | [diff] [blame] | 1278 | let features = if features.is_empty() { |
| 1279 | quote! {} |
| 1280 | } else { |
| 1281 | quote! { |
| 1282 | #![feature( #(#features),* )] |
| 1283 | } |
| 1284 | }; |
| 1285 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1286 | Ok(quote! { |
Googler | 5564714 | 2022-01-11 12:37:39 +0000 | [diff] [blame] | 1287 | #features __NEWLINE__ |
| 1288 | #![allow(non_camel_case_types)] __NEWLINE__ |
| 1289 | #![allow(non_snake_case)] __NEWLINE__ __NEWLINE__ |
| 1290 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1291 | #imports __NEWLINE__ __NEWLINE__ |
Googler | ec648ff | 2021-09-23 07:19:53 +0000 | [diff] [blame] | 1292 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1293 | #( #items __NEWLINE__ __NEWLINE__ )* |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 1294 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 1295 | #mod_detail __NEWLINE__ __NEWLINE__ |
| 1296 | |
| 1297 | #( #assertions __NEWLINE__ __NEWLINE__ )* |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1298 | }) |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1299 | } |
| 1300 | |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 1301 | /// Makes an 'Ident' to be used in the Rust source code. Escapes Rust keywords. |
| 1302 | fn make_rs_ident(ident: &str) -> Ident { |
| 1303 | // TODO(https://github.com/dtolnay/syn/pull/1098): Remove the hardcoded list once syn recognizes |
| 1304 | // 2018 and 2021 keywords. |
| 1305 | if ["async", "await", "try", "dyn"].contains(&ident) { |
| 1306 | return format_ident!("r#{}", ident); |
| 1307 | } |
| 1308 | match syn::parse_str::<syn::Ident>(ident) { |
| 1309 | Ok(_) => format_ident!("{}", ident), |
| 1310 | Err(_) => format_ident!("r#{}", ident), |
| 1311 | } |
| 1312 | } |
| 1313 | |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 1314 | /// Formats a C++ identifier. Does not escape C++ keywords. |
| 1315 | fn format_cc_ident(ident: &str) -> TokenStream { |
| 1316 | ident.parse().unwrap() |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 1317 | } |
| 1318 | |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1319 | /// Returns Some(crate_ident) if this is an imported crate. |
| 1320 | fn rs_imported_crate_name(owning_target: &BazelLabel, ir: &IR) -> Option<Ident> { |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1321 | if ir.is_current_target(owning_target) || ir.is_stdlib_target(owning_target) { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1322 | None |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1323 | } else { |
Devin Jeanpierre | 084ebbd | 2022-04-01 04:32:46 -0700 | [diff] [blame] | 1324 | let owning_crate_name = owning_target.target_name(); |
Marcel Hlopko | d906b89 | 2022-01-27 08:52:36 +0000 | [diff] [blame] | 1325 | // TODO(b/216587072): Remove this hacky escaping and use the import! macro once |
| 1326 | // available |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 1327 | let escaped_owning_crate_name = owning_crate_name.replace('-', "_"); |
Marcel Hlopko | d906b89 | 2022-01-27 08:52:36 +0000 | [diff] [blame] | 1328 | let owning_crate = make_rs_ident(&escaped_owning_crate_name); |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1329 | Some(owning_crate) |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1330 | } |
| 1331 | } |
| 1332 | |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 1333 | #[derive(Copy, Clone, Debug, Eq, PartialEq)] |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1334 | enum Mutability { |
| 1335 | Const, |
| 1336 | Mut, |
| 1337 | } |
| 1338 | |
| 1339 | impl Mutability { |
| 1340 | fn format_for_pointer(&self) -> TokenStream { |
| 1341 | match self { |
| 1342 | Mutability::Mut => quote! {mut}, |
| 1343 | Mutability::Const => quote! {const}, |
| 1344 | } |
| 1345 | } |
| 1346 | |
| 1347 | fn format_for_reference(&self) -> TokenStream { |
| 1348 | match self { |
| 1349 | Mutability::Mut => quote! {mut}, |
| 1350 | Mutability::Const => quote! {}, |
| 1351 | } |
| 1352 | } |
| 1353 | } |
| 1354 | |
| 1355 | // TODO(b/213947473): Instead of having a separate RsTypeKind here, consider |
| 1356 | // changing ir::RsType into a similar `enum`, with fields that contain |
Rosica Dejanovska | d638cf5 | 2022-03-23 15:45:01 +0000 | [diff] [blame] | 1357 | // references (e.g. &'ir Record`) instead of ItemIds. |
Devin Jeanpierre | 103cbb5 | 2022-04-06 12:55:16 -0700 | [diff] [blame^] | 1358 | #[derive(Clone, Debug)] |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1359 | enum RsTypeKind<'ir> { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1360 | Pointer { |
| 1361 | pointee: Box<RsTypeKind<'ir>>, |
| 1362 | mutability: Mutability, |
| 1363 | }, |
| 1364 | Reference { |
| 1365 | referent: Box<RsTypeKind<'ir>>, |
| 1366 | mutability: Mutability, |
| 1367 | lifetime: Lifetime, |
| 1368 | }, |
| 1369 | RvalueReference { |
| 1370 | referent: Box<RsTypeKind<'ir>>, |
| 1371 | mutability: Mutability, |
| 1372 | lifetime: Lifetime, |
| 1373 | }, |
| 1374 | FuncPtr { |
| 1375 | abi: &'ir str, |
| 1376 | return_type: Box<RsTypeKind<'ir>>, |
| 1377 | param_types: Vec<RsTypeKind<'ir>>, |
| 1378 | }, |
| 1379 | Record { |
| 1380 | record: &'ir Record, |
| 1381 | /// The imported crate this comes from, or None if the current crate. |
| 1382 | crate_ident: Option<Ident>, |
| 1383 | }, |
| 1384 | TypeAlias { |
| 1385 | type_alias: &'ir TypeAlias, |
| 1386 | underlying_type: Box<RsTypeKind<'ir>>, |
| 1387 | /// The imported crate this comes from, or None if the current crate. |
| 1388 | crate_ident: Option<Ident>, |
| 1389 | }, |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1390 | Unit, |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1391 | Other { |
| 1392 | name: &'ir str, |
| 1393 | type_args: Vec<RsTypeKind<'ir>>, |
| 1394 | }, |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1395 | } |
| 1396 | |
| 1397 | impl<'ir> RsTypeKind<'ir> { |
| 1398 | pub fn new(ty: &'ir ir::RsType, ir: &'ir IR) -> Result<Self> { |
| 1399 | // The lambdas deduplicate code needed by multiple `match` branches. |
| 1400 | let get_type_args = || -> Result<Vec<RsTypeKind<'ir>>> { |
| 1401 | ty.type_args.iter().map(|type_arg| RsTypeKind::<'ir>::new(type_arg, ir)).collect() |
| 1402 | }; |
| 1403 | let get_pointee = || -> Result<Box<RsTypeKind<'ir>>> { |
| 1404 | if ty.type_args.len() != 1 { |
| 1405 | bail!("Missing pointee/referent type (need exactly 1 type argument): {:?}", ty); |
| 1406 | } |
| 1407 | Ok(Box::new(get_type_args()?.remove(0))) |
| 1408 | }; |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1409 | let get_lifetime = || -> Result<Lifetime> { |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1410 | if ty.lifetime_args.len() != 1 { |
| 1411 | bail!("Missing reference lifetime (need exactly 1 lifetime argument): {:?}", ty); |
| 1412 | } |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1413 | let lifetime_id = ty.lifetime_args[0]; |
| 1414 | ir.get_lifetime(lifetime_id) |
| 1415 | .ok_or_else(|| anyhow!("no known lifetime with id {lifetime_id:?}")) |
| 1416 | .cloned() |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1417 | }; |
| 1418 | |
| 1419 | let result = match ty.name.as_deref() { |
| 1420 | None => { |
| 1421 | ensure!( |
| 1422 | ty.type_args.is_empty(), |
| 1423 | "Type arguments on records nor type aliases are not yet supported: {:?}", |
| 1424 | ty |
| 1425 | ); |
| 1426 | match ir.item_for_type(ty)? { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1427 | Item::Record(record) => RsTypeKind::new_record(record, ir), |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1428 | Item::TypeAlias(type_alias) => RsTypeKind::TypeAlias { |
| 1429 | type_alias, |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1430 | crate_ident: rs_imported_crate_name(&type_alias.owning_target, ir), |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1431 | underlying_type: Box::new(RsTypeKind::new( |
| 1432 | &type_alias.underlying_type.rs_type, |
| 1433 | ir, |
| 1434 | )?), |
| 1435 | }, |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1436 | other_item => bail!("Item does not define a type: {:?}", other_item), |
| 1437 | } |
| 1438 | } |
| 1439 | Some(name) => match name { |
| 1440 | "()" => { |
| 1441 | if !ty.type_args.is_empty() { |
| 1442 | bail!("Unit type must not have type arguments: {:?}", ty); |
| 1443 | } |
| 1444 | RsTypeKind::Unit |
| 1445 | } |
| 1446 | "*mut" => { |
| 1447 | RsTypeKind::Pointer { pointee: get_pointee()?, mutability: Mutability::Mut } |
| 1448 | } |
| 1449 | "*const" => { |
| 1450 | RsTypeKind::Pointer { pointee: get_pointee()?, mutability: Mutability::Const } |
| 1451 | } |
| 1452 | "&mut" => RsTypeKind::Reference { |
| 1453 | referent: get_pointee()?, |
| 1454 | mutability: Mutability::Mut, |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1455 | lifetime: get_lifetime()?, |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1456 | }, |
| 1457 | "&" => RsTypeKind::Reference { |
| 1458 | referent: get_pointee()?, |
| 1459 | mutability: Mutability::Const, |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1460 | lifetime: get_lifetime()?, |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1461 | }, |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 1462 | "#RvalueReference mut" => RsTypeKind::RvalueReference { |
| 1463 | referent: get_pointee()?, |
| 1464 | mutability: Mutability::Mut, |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1465 | lifetime: get_lifetime()?, |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 1466 | }, |
| 1467 | "#RvalueReference const" => RsTypeKind::RvalueReference { |
| 1468 | referent: get_pointee()?, |
| 1469 | mutability: Mutability::Const, |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1470 | lifetime: get_lifetime()?, |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 1471 | }, |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 1472 | name => { |
| 1473 | let mut type_args = get_type_args()?; |
| 1474 | match name.strip_prefix("#funcPtr ") { |
| 1475 | None => RsTypeKind::Other { name, type_args }, |
| 1476 | Some(abi) => { |
| 1477 | // TODO(b/217419782): Consider enforcing `'static` lifetime. |
| 1478 | ensure!(!type_args.is_empty(), "No return type in fn type: {:?}", ty); |
| 1479 | RsTypeKind::FuncPtr { |
| 1480 | abi, |
| 1481 | return_type: Box::new(type_args.remove(type_args.len() - 1)), |
| 1482 | param_types: type_args, |
| 1483 | } |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1484 | } |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 1485 | } |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1486 | } |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1487 | }, |
| 1488 | }; |
| 1489 | Ok(result) |
| 1490 | } |
| 1491 | |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1492 | pub fn new_record(record: &'ir Record, ir: &'ir IR) -> Self { |
| 1493 | RsTypeKind::Record { |
| 1494 | record, |
| 1495 | crate_ident: rs_imported_crate_name(&record.owning_target, ir), |
| 1496 | } |
| 1497 | } |
| 1498 | |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1499 | /// Returns true if the type is known to be `Unpin`, false otherwise. |
Devin Jeanpierre | f85ae59 | 2022-04-01 04:33:57 -0700 | [diff] [blame] | 1500 | pub fn is_unpin(&self) -> bool { |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1501 | match self { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1502 | RsTypeKind::Record { record, .. } => record.is_unpin(), |
Devin Jeanpierre | f85ae59 | 2022-04-01 04:33:57 -0700 | [diff] [blame] | 1503 | RsTypeKind::TypeAlias { underlying_type, .. } => underlying_type.is_unpin(), |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1504 | _ => true, |
| 1505 | } |
| 1506 | } |
| 1507 | |
Devin Jeanpierre | 82e8e36 | 2022-04-05 11:04:55 -0700 | [diff] [blame] | 1508 | pub fn format_as_return_type_fragment(&self) -> TokenStream { |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 1509 | match self { |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1510 | RsTypeKind::Unit => quote! {}, |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 1511 | other_type => { |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 1512 | quote! { -> #other_type } |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 1513 | } |
| 1514 | } |
| 1515 | } |
| 1516 | |
Lukasz Anforowicz | cde4b1b | 2022-02-03 21:20:55 +0000 | [diff] [blame] | 1517 | /// Formats this RsTypeKind as `&'a mut MaybeUninit<SomeStruct>`. This is |
| 1518 | /// used to format `__this` parameter in a constructor thunk. |
Devin Jeanpierre | 82e8e36 | 2022-04-05 11:04:55 -0700 | [diff] [blame] | 1519 | pub fn format_mut_ref_as_uninitialized(&self) -> Result<TokenStream> { |
Lukasz Anforowicz | cde4b1b | 2022-02-03 21:20:55 +0000 | [diff] [blame] | 1520 | match self { |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1521 | RsTypeKind::Reference { referent, lifetime, mutability: Mutability::Mut } => { |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1522 | let lifetime = format_lifetime_name(&lifetime.name); |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 1523 | Ok(quote! { & #lifetime mut rust_std::mem::MaybeUninit< #referent > }) |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1524 | } |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1525 | _ => bail!("Expected reference to format as MaybeUninit, got: {:?}", self), |
Lukasz Anforowicz | cde4b1b | 2022-02-03 21:20:55 +0000 | [diff] [blame] | 1526 | } |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1527 | } |
| 1528 | |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1529 | /// Formats a reference or pointer as a raw pointer. |
Devin Jeanpierre | 82e8e36 | 2022-04-05 11:04:55 -0700 | [diff] [blame] | 1530 | pub fn format_ref_as_raw_ptr(&self) -> Result<TokenStream> { |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1531 | match self { |
| 1532 | RsTypeKind::Reference { referent: pointee, mutability, .. } |
| 1533 | | RsTypeKind::Pointer { pointee, mutability } => { |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1534 | let mut_ = mutability.format_for_pointer(); |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 1535 | Ok(quote! { * #mut_ #pointee }) |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1536 | } |
| 1537 | _ => bail!("Expected reference to format as raw ptr, got: {:?}", self), |
| 1538 | } |
| 1539 | } |
| 1540 | |
| 1541 | /// Formats this RsTypeKind as the `self` parameter: usually, `&'a self` or |
| 1542 | /// `&'a mut self`. |
| 1543 | /// |
| 1544 | /// If this is !Unpin, however, it uses `self: Pin<&mut Self>` instead. |
Devin Jeanpierre | 9886fb4 | 2022-04-01 04:31:20 -0700 | [diff] [blame] | 1545 | pub fn format_as_self_param(&self, func: &Func, ir: &IR) -> Result<TokenStream> { |
Lukasz Anforowicz | 732ca64 | 2022-02-03 20:58:38 +0000 | [diff] [blame] | 1546 | if func.name == UnqualifiedIdentifier::Destructor { |
| 1547 | let record = func |
| 1548 | .member_func_metadata |
| 1549 | .as_ref() |
| 1550 | .ok_or_else(|| anyhow!("Destructors must be member functions: {:?}", func))? |
| 1551 | .find_record(ir)?; |
| 1552 | if self.is_mut_ptr_to(record) { |
| 1553 | // Even in C++ it is UB to retain `this` pointer and dereference it |
| 1554 | // after a destructor runs. Therefore it is safe to use `&self` or |
| 1555 | // `&mut self` in Rust even if IR represents `__this` as a Rust |
| 1556 | // pointer (e.g. when lifetime annotations are missing - lifetime |
| 1557 | // annotations are required to represent it as a Rust reference). |
| 1558 | return Ok(quote! { &mut self }); |
| 1559 | } |
Lukasz Anforowicz | 231a3bb | 2022-01-12 14:05:59 +0000 | [diff] [blame] | 1560 | } |
| 1561 | |
| 1562 | match self { |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1563 | RsTypeKind::Reference { referent, lifetime, mutability } => { |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1564 | let mut_ = mutability.format_for_reference(); |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1565 | let lifetime = format_lifetime_name(&lifetime.name); |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1566 | if mutability == &Mutability::Mut |
Devin Jeanpierre | f85ae59 | 2022-04-01 04:33:57 -0700 | [diff] [blame] | 1567 | && !referent.is_unpin() |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1568 | && func.name != UnqualifiedIdentifier::Destructor |
| 1569 | { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1570 | // TODO(b/200067242): Add a `use rust_std::pin::Pin` to the crate, and use |
| 1571 | // `Pin`. |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 1572 | Ok(quote! {self: rust_std::pin::Pin< & #lifetime #mut_ Self>}) |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 1573 | } else { |
| 1574 | Ok(quote! { & #lifetime #mut_ self }) |
| 1575 | } |
Lukasz Anforowicz | 231a3bb | 2022-01-12 14:05:59 +0000 | [diff] [blame] | 1576 | } |
Lukasz Anforowicz | 732ca64 | 2022-02-03 20:58:38 +0000 | [diff] [blame] | 1577 | _ => bail!("Unexpected type of `self` parameter: {:?}", self), |
Lukasz Anforowicz | 231a3bb | 2022-01-12 14:05:59 +0000 | [diff] [blame] | 1578 | } |
| 1579 | } |
| 1580 | |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 1581 | /// Returns whether the type represented by `self` implements the `Copy` |
| 1582 | /// trait. |
Lukasz Anforowicz | a94ab70 | 2022-01-14 22:40:25 +0000 | [diff] [blame] | 1583 | pub fn implements_copy(&self) -> bool { |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1584 | // TODO(b/212696226): Verify results of `implements_copy` via static |
| 1585 | // assertions in the generated Rust code (because incorrect results |
| 1586 | // can silently lead to unsafe behavior). |
| 1587 | match self { |
| 1588 | RsTypeKind::Unit => true, |
| 1589 | RsTypeKind::Pointer { .. } => true, |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 1590 | RsTypeKind::FuncPtr { .. } => true, |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1591 | RsTypeKind::Reference { mutability: Mutability::Const, .. } => true, |
| 1592 | RsTypeKind::Reference { mutability: Mutability::Mut, .. } => false, |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 1593 | RsTypeKind::RvalueReference { .. } => false, |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1594 | RsTypeKind::Record { record, .. } => should_derive_copy(record), |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1595 | RsTypeKind::TypeAlias { underlying_type, .. } => underlying_type.implements_copy(), |
Lukasz Anforowicz | d81bea9 | 2022-02-11 08:57:58 +0000 | [diff] [blame] | 1596 | RsTypeKind::Other { type_args, .. } => { |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 1597 | // All types that may appear here without `type_args` (e.g. |
| 1598 | // primitive types like `i32`) implement `Copy`. Generic types |
| 1599 | // that may be present here (e.g. Option<...>) are `Copy` if all |
| 1600 | // of their `type_args` are `Copy`. |
| 1601 | type_args.iter().all(|t| t.implements_copy()) |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 1602 | } |
| 1603 | } |
| 1604 | } |
Lukasz Anforowicz | a94ab70 | 2022-01-14 22:40:25 +0000 | [diff] [blame] | 1605 | |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 1606 | pub fn is_mut_ptr_to(&self, expected_record: &Record) -> bool { |
| 1607 | match self { |
| 1608 | RsTypeKind::Pointer { pointee, mutability: Mutability::Mut, .. } => { |
| 1609 | pointee.is_record(expected_record) |
| 1610 | } |
| 1611 | _ => false, |
| 1612 | } |
| 1613 | } |
| 1614 | |
| 1615 | pub fn is_ref_to(&self, expected_record: &Record) -> bool { |
| 1616 | match self { |
| 1617 | RsTypeKind::Reference { referent, .. } => referent.is_record(expected_record), |
| 1618 | _ => false, |
| 1619 | } |
| 1620 | } |
| 1621 | |
Lukasz Anforowicz | a94ab70 | 2022-01-14 22:40:25 +0000 | [diff] [blame] | 1622 | pub fn is_shared_ref_to(&self, expected_record: &Record) -> bool { |
| 1623 | match self { |
| 1624 | RsTypeKind::Reference { referent, mutability: Mutability::Const, .. } => { |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 1625 | referent.is_record(expected_record) |
Lukasz Anforowicz | a94ab70 | 2022-01-14 22:40:25 +0000 | [diff] [blame] | 1626 | } |
| 1627 | _ => false, |
| 1628 | } |
| 1629 | } |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 1630 | |
| 1631 | pub fn is_record(&self, expected_record: &Record) -> bool { |
| 1632 | match self { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1633 | RsTypeKind::Record { record: actual_record, .. } => { |
| 1634 | actual_record.id == expected_record.id |
| 1635 | } |
Lukasz Anforowicz | f956462 | 2022-01-28 14:31:04 +0000 | [diff] [blame] | 1636 | _ => false, |
| 1637 | } |
| 1638 | } |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 1639 | |
| 1640 | /// Iterates over `self` and all the nested types (e.g. pointees, generic |
| 1641 | /// type args, etc.) in DFS order. |
| 1642 | pub fn dfs_iter<'ty>(&'ty self) -> impl Iterator<Item = &'ty RsTypeKind<'ir>> + '_ { |
| 1643 | RsTypeKindIter::new(self) |
| 1644 | } |
| 1645 | |
| 1646 | /// Iterates over all `LifetimeId`s in `self` and in all the nested types. |
| 1647 | /// Note that the results might contain duplicate LifetimeId values (e.g. |
| 1648 | /// if the same LifetimeId is used in two `type_args`). |
| 1649 | pub fn lifetimes(&self) -> impl Iterator<Item = LifetimeId> + '_ { |
| 1650 | self.dfs_iter().filter_map(|t| match t { |
Devin Jeanpierre | d2b7a8f | 2022-04-01 04:37:16 -0700 | [diff] [blame] | 1651 | RsTypeKind::Reference { lifetime, .. } => Some(lifetime.id), |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 1652 | _ => None, |
| 1653 | }) |
| 1654 | } |
| 1655 | } |
| 1656 | |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 1657 | impl<'ir> ToTokens for RsTypeKind<'ir> { |
| 1658 | fn to_tokens(&self, tokens: &mut TokenStream) { |
| 1659 | self.to_token_stream().to_tokens(tokens) |
| 1660 | } |
| 1661 | |
| 1662 | fn to_token_stream(&self) -> TokenStream { |
| 1663 | match self { |
| 1664 | RsTypeKind::Pointer { pointee, mutability } => { |
| 1665 | let mutability = mutability.format_for_pointer(); |
| 1666 | quote! {* #mutability #pointee} |
| 1667 | } |
| 1668 | RsTypeKind::Reference { referent, mutability, lifetime } => { |
| 1669 | let mut_ = mutability.format_for_reference(); |
| 1670 | let lifetime = format_lifetime_name(&lifetime.name); |
| 1671 | let reference = quote! {& #lifetime #mut_ #referent}; |
| 1672 | if mutability == &Mutability::Mut && !referent.is_unpin() { |
| 1673 | // TODO(b/200067242): Add a `use rust_std::pin::Pin` to the crate, and use |
| 1674 | // `Pin`. This either requires deciding how to qualify pin at |
| 1675 | // RsTypeKind-creation time, or returning an RsSnippet from here (and not |
| 1676 | // implementing ToTokens, but instead some other interface.) |
| 1677 | quote! {rust_std::pin::Pin< #reference >} |
| 1678 | } else { |
| 1679 | reference |
| 1680 | } |
| 1681 | } |
| 1682 | RsTypeKind::RvalueReference { referent, mutability, lifetime } => { |
| 1683 | let lifetime = format_lifetime_name(&lifetime.name); |
| 1684 | // TODO(b/200067242): Add a `use ctor::RvalueReference` (etc.) to the crate. |
| 1685 | if mutability == &Mutability::Mut { |
| 1686 | quote! {ctor::RvalueReference<#lifetime, #referent>} |
| 1687 | } else { |
| 1688 | quote! {ctor::ConstRvalueReference<#lifetime, #referent>} |
| 1689 | } |
| 1690 | } |
| 1691 | RsTypeKind::FuncPtr { abi, return_type, param_types } => { |
| 1692 | let return_frag = return_type.format_as_return_type_fragment(); |
| 1693 | quote! { extern #abi fn( #( #param_types ),* ) #return_frag } |
| 1694 | } |
| 1695 | RsTypeKind::Record { record, crate_ident } => { |
| 1696 | let record_ident = make_rs_ident(&record.rs_name); |
| 1697 | let crate_ident = crate_ident.iter(); |
| 1698 | quote! {#(#crate_ident::)* #record_ident} |
| 1699 | } |
| 1700 | RsTypeKind::TypeAlias { type_alias, crate_ident, .. } => { |
| 1701 | let alias_ident = make_rs_ident(&type_alias.identifier.identifier); |
| 1702 | let crate_ident = crate_ident.iter(); |
| 1703 | quote! {#(#crate_ident::)* #alias_ident} |
| 1704 | } |
| 1705 | RsTypeKind::Unit => quote! {()}, |
| 1706 | RsTypeKind::Other { name, type_args } => { |
| 1707 | let ident = make_rs_ident(name); |
| 1708 | let generic_params = format_generic_params(type_args); |
| 1709 | quote! {#ident #generic_params} |
| 1710 | } |
| 1711 | } |
| 1712 | } |
| 1713 | } |
| 1714 | |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 1715 | struct RsTypeKindIter<'ty, 'ir> { |
| 1716 | todo: Vec<&'ty RsTypeKind<'ir>>, |
| 1717 | } |
| 1718 | |
| 1719 | impl<'ty, 'ir> RsTypeKindIter<'ty, 'ir> { |
| 1720 | pub fn new(ty: &'ty RsTypeKind<'ir>) -> Self { |
| 1721 | Self { todo: vec![ty] } |
| 1722 | } |
| 1723 | } |
| 1724 | |
| 1725 | impl<'ty, 'ir> Iterator for RsTypeKindIter<'ty, 'ir> { |
| 1726 | type Item = &'ty RsTypeKind<'ir>; |
| 1727 | |
| 1728 | fn next(&mut self) -> Option<Self::Item> { |
| 1729 | match self.todo.pop() { |
| 1730 | None => None, |
| 1731 | Some(curr) => { |
| 1732 | match curr { |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1733 | RsTypeKind::Unit | RsTypeKind::Record { .. } => (), |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 1734 | RsTypeKind::Pointer { pointee, .. } => self.todo.push(pointee), |
| 1735 | RsTypeKind::Reference { referent, .. } => self.todo.push(referent), |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 1736 | RsTypeKind::RvalueReference { referent, .. } => self.todo.push(referent), |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 1737 | RsTypeKind::TypeAlias { underlying_type: t, .. } => self.todo.push(t), |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 1738 | RsTypeKind::FuncPtr { return_type, param_types, .. } => { |
| 1739 | self.todo.push(return_type); |
| 1740 | self.todo.extend(param_types.iter().rev()); |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1741 | } |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 1742 | RsTypeKind::Other { type_args, .. } => self.todo.extend(type_args.iter().rev()), |
| 1743 | }; |
| 1744 | Some(curr) |
| 1745 | } |
| 1746 | } |
| 1747 | } |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1748 | } |
| 1749 | |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 1750 | fn format_lifetime_name(lifetime_name: &str) -> TokenStream { |
| 1751 | let lifetime = |
| 1752 | syn::Lifetime::new(&format!("'{}", lifetime_name), proc_macro2::Span::call_site()); |
| 1753 | quote! { #lifetime } |
| 1754 | } |
| 1755 | |
Devin Jeanpierre | 9886fb4 | 2022-04-01 04:31:20 -0700 | [diff] [blame] | 1756 | fn format_rs_type(ty: &ir::RsType, ir: &IR) -> Result<TokenStream> { |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1757 | RsTypeKind::new(ty, ir) |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 1758 | .map(|kind| kind.to_token_stream()) |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 1759 | .with_context(|| format!("Failed to format Rust type {:?}", ty)) |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 1760 | } |
| 1761 | |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1762 | fn cc_type_name_for_item(item: &ir::Item) -> Result<TokenStream> { |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1763 | Ok(match item { |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 1764 | Item::Record(record) => { |
| 1765 | let ident = format_cc_ident(&record.cc_name); |
| 1766 | quote! { class #ident } |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1767 | } |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 1768 | Item::TypeAlias(type_alias) => { |
| 1769 | let ident = format_cc_ident(&type_alias.identifier.identifier); |
| 1770 | quote! { #ident } |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1771 | } |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1772 | _ => bail!("Item does not define a type: {:?}", item), |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 1773 | }) |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1774 | } |
| 1775 | |
Lukasz Anforowicz | 71e9b59 | 2022-03-04 19:03:02 +0000 | [diff] [blame] | 1776 | // Maps a Rust ABI [1] into a Clang attribute. See also |
| 1777 | // `ConvertCcCallConvIntoRsApi` in importer.cc. |
| 1778 | // [1] |
| 1779 | // https://doc.rust-lang.org/reference/items/functions.html#extern-function-qualifier |
| 1780 | fn format_cc_call_conv_as_clang_attribute(rs_abi: &str) -> Result<TokenStream> { |
| 1781 | match rs_abi { |
| 1782 | "cdecl" => Ok(quote! {}), |
| 1783 | "fastcall" => Ok(quote! { __attribute__((fastcall)) }), |
| 1784 | "stdcall" => Ok(quote! { __attribute__((stdcall)) }), |
| 1785 | "thiscall" => Ok(quote! { __attribute__((thiscall)) }), |
| 1786 | "vectorcall" => Ok(quote! { __attribute__((vectorcall)) }), |
| 1787 | _ => bail!("Unsupported ABI: {}", rs_abi), |
| 1788 | } |
| 1789 | } |
| 1790 | |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 1791 | fn format_cc_type(ty: &ir::CcType, ir: &IR) -> Result<TokenStream> { |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 1792 | let const_fragment = if ty.is_const { |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 1793 | quote! {const} |
| 1794 | } else { |
| 1795 | quote! {} |
| 1796 | }; |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 1797 | if let Some(ref name) = ty.name { |
| 1798 | match name.as_str() { |
| 1799 | "*" => { |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 1800 | if ty.type_args.len() != 1 { |
| 1801 | bail!("Invalid pointer type (need exactly 1 type argument): {:?}", ty); |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 1802 | } |
Googler | ff7fc23 | 2021-12-02 09:43:00 +0000 | [diff] [blame] | 1803 | assert_eq!(ty.type_args.len(), 1); |
| 1804 | let nested_type = format_cc_type(&ty.type_args[0], ir)?; |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 1805 | Ok(quote! {#nested_type * #const_fragment}) |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 1806 | } |
Lukasz Anforowicz | 275fa92 | 2022-01-05 16:13:20 +0000 | [diff] [blame] | 1807 | "&" => { |
| 1808 | if ty.type_args.len() != 1 { |
| 1809 | bail!("Invalid reference type (need exactly 1 type argument): {:?}", ty); |
| 1810 | } |
| 1811 | let nested_type = format_cc_type(&ty.type_args[0], ir)?; |
| 1812 | Ok(quote! {#nested_type &}) |
| 1813 | } |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 1814 | "&&" => { |
| 1815 | if ty.type_args.len() != 1 { |
| 1816 | bail!("Invalid rvalue reference type (need exactly 1 type argument): {:?}", ty); |
| 1817 | } |
| 1818 | let nested_type = format_cc_type(&ty.type_args[0], ir)?; |
| 1819 | Ok(quote! {#nested_type &&}) |
| 1820 | } |
Lukasz Anforowicz | 71e9b59 | 2022-03-04 19:03:02 +0000 | [diff] [blame] | 1821 | cc_type_name => match cc_type_name.strip_prefix("#funcValue ") { |
| 1822 | None => { |
| 1823 | if !ty.type_args.is_empty() { |
| 1824 | bail!("Type not yet supported: {:?}", ty); |
| 1825 | } |
| 1826 | let idents = cc_type_name.split_whitespace().map(format_cc_ident); |
| 1827 | Ok(quote! {#( #idents )* #const_fragment}) |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1828 | } |
Lukasz Anforowicz | 71e9b59 | 2022-03-04 19:03:02 +0000 | [diff] [blame] | 1829 | Some(abi) => match ty.type_args.split_last() { |
| 1830 | None => bail!("funcValue type without a return type: {:?}", ty), |
| 1831 | Some((ret_type, param_types)) => { |
| 1832 | let ret_type = format_cc_type(ret_type, ir)?; |
| 1833 | let param_types = param_types |
| 1834 | .iter() |
| 1835 | .map(|t| format_cc_type(t, ir)) |
| 1836 | .collect::<Result<Vec<_>>>()?; |
| 1837 | let attr = format_cc_call_conv_as_clang_attribute(abi)?; |
| 1838 | // `type_identity_t` is used below to avoid having to |
| 1839 | // emit spiral-like syntax where some syntax elements of |
| 1840 | // an inner type (e.g. function type as below) can |
| 1841 | // surround syntax elements of an outer type (e.g. a |
| 1842 | // pointer type). Compare: `int (*foo)(int, int)` VS |
| 1843 | // `type_identity_t<int(int, int)>* foo`. |
| 1844 | Ok(quote! { rs_api_impl_support::type_identity_t< |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1845 | #ret_type ( #( #param_types ),* ) #attr |
| 1846 | > }) |
| 1847 | } |
| 1848 | }, |
| 1849 | }, |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 1850 | } |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 1851 | } else { |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1852 | let item = ir.item_for_type(ty)?; |
| 1853 | let type_name = cc_type_name_for_item(item)?; |
| 1854 | Ok(quote! {#const_fragment #type_name}) |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 1855 | } |
| 1856 | } |
| 1857 | |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 1858 | fn cc_struct_layout_assertion(record: &Record, ir: &IR) -> TokenStream { |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 1859 | if !ir.is_current_target(&record.owning_target) && !ir.is_stdlib_target(&record.owning_target) { |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 1860 | return quote! {}; |
| 1861 | } |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 1862 | let record_ident = format_cc_ident(&record.cc_name); |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 1863 | let size = Literal::usize_unsuffixed(record.size); |
| 1864 | let alignment = Literal::usize_unsuffixed(record.alignment); |
Lukasz Anforowicz | 7470471 | 2021-12-22 15:30:31 +0000 | [diff] [blame] | 1865 | let field_assertions = |
| 1866 | record.fields.iter().filter(|f| f.access == AccessSpecifier::Public).map(|field| { |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 1867 | let field_ident = format_cc_ident(&field.identifier.identifier); |
Lukasz Anforowicz | 7470471 | 2021-12-22 15:30:31 +0000 | [diff] [blame] | 1868 | let offset = Literal::usize_unsuffixed(field.offset); |
| 1869 | // The IR contains the offset in bits, while C++'s offsetof() |
| 1870 | // returns the offset in bytes, so we need to convert. |
| 1871 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 1872 | static_assert(offsetof(class #record_ident, #field_ident) * 8 == #offset); |
Lukasz Anforowicz | 7470471 | 2021-12-22 15:30:31 +0000 | [diff] [blame] | 1873 | } |
| 1874 | }); |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 1875 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 1876 | static_assert(sizeof(class #record_ident) == #size); |
| 1877 | static_assert(alignof(class #record_ident) == #alignment); |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 1878 | #( #field_assertions )* |
| 1879 | } |
| 1880 | } |
| 1881 | |
Devin Jeanpierre | 58181ac | 2022-02-14 21:30:05 +0000 | [diff] [blame] | 1882 | // Returns the accessor functions for no_unique_address member variables. |
| 1883 | fn cc_struct_no_unique_address_impl(record: &Record, ir: &IR) -> Result<TokenStream> { |
| 1884 | let mut fields = vec![]; |
| 1885 | let mut types = vec![]; |
| 1886 | for field in &record.fields { |
| 1887 | if field.access != AccessSpecifier::Public || !field.is_no_unique_address { |
| 1888 | continue; |
| 1889 | } |
| 1890 | fields.push(make_rs_ident(&field.identifier.identifier)); |
Devin Jeanpierre | fec5bfe | 2022-04-05 10:59:10 -0700 | [diff] [blame] | 1891 | types.push(format_rs_type(&field.type_.rs_type, ir).with_context(|| { |
| 1892 | format!("Failed to format type for field {:?} on record {:?}", field, record) |
| 1893 | })?) |
Devin Jeanpierre | 58181ac | 2022-02-14 21:30:05 +0000 | [diff] [blame] | 1894 | } |
| 1895 | |
| 1896 | if fields.is_empty() { |
| 1897 | return Ok(quote! {}); |
| 1898 | } |
| 1899 | |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 1900 | let ident = make_rs_ident(&record.rs_name); |
Devin Jeanpierre | 58181ac | 2022-02-14 21:30:05 +0000 | [diff] [blame] | 1901 | Ok(quote! { |
| 1902 | impl #ident { |
| 1903 | #( |
| 1904 | pub fn #fields(&self) -> &#types { |
| 1905 | unsafe {&* (&self.#fields as *const _ as *const #types)} |
| 1906 | } |
| 1907 | )* |
| 1908 | } |
| 1909 | }) |
| 1910 | } |
| 1911 | |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 1912 | /// Returns the implementation of base class conversions, for converting a type |
| 1913 | /// to its unambiguous public base classes. |
| 1914 | /// |
| 1915 | /// TODO(b/216195042): Implement this in terms of a supporting trait which casts |
| 1916 | /// raw pointers. Then, we would have blanket impls for reference, pinned mut |
| 1917 | /// reference, etc. conversion. The current version is just enough to test the |
| 1918 | /// logic in importer. |
| 1919 | // |
| 1920 | // TODO(b/216195042): Should this use, like, AsRef/AsMut (and some equivalent |
| 1921 | // for Pin)? |
| 1922 | fn cc_struct_upcast_impl(record: &Record, ir: &IR) -> Result<TokenStream> { |
| 1923 | let mut impls = Vec::with_capacity(record.unambiguous_public_bases.len()); |
| 1924 | for base in &record.unambiguous_public_bases { |
Lukasz Anforowicz | 4404725 | 2022-03-23 13:04:48 +0000 | [diff] [blame] | 1925 | let base_record: &Record = ir |
| 1926 | .find_decl(base.base_record_id) |
| 1927 | .with_context(|| format!("Can't find a base record of {:?}", record))?; |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 1928 | if let Some(offset) = base.offset { |
| 1929 | let offset = Literal::i64_unsuffixed(offset); |
| 1930 | // TODO(b/216195042): Correctly handle imported records, lifetimes. |
Lukasz Anforowicz | 4c3a2cc | 2022-03-11 00:24:49 +0000 | [diff] [blame] | 1931 | let base_name = make_rs_ident(&base_record.rs_name); |
| 1932 | let derived_name = make_rs_ident(&record.rs_name); |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 1933 | impls.push(quote! { |
| 1934 | impl<'a> From<&'a #derived_name> for &'a #base_name { |
| 1935 | fn from(x: &'a #derived_name) -> Self { |
| 1936 | unsafe { |
| 1937 | &*((x as *const _ as *const u8).offset(#offset) as *const #base_name) |
| 1938 | } |
| 1939 | } |
| 1940 | } |
| 1941 | }); |
| 1942 | } else { |
| 1943 | // TODO(b/216195042): determine offset dynamically / use a dynamic |
| 1944 | // cast. This requires a new C++ function to be |
| 1945 | // generated, so that we have something to call. |
| 1946 | } |
| 1947 | } |
| 1948 | |
| 1949 | Ok(quote! { |
| 1950 | #(#impls)* |
| 1951 | }) |
| 1952 | } |
| 1953 | |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1954 | fn thunk_ident(func: &Func) -> Ident { |
| 1955 | format_ident!("__rust_thunk__{}", func.mangled_name) |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 1956 | } |
| 1957 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 1958 | fn generate_rs_api_impl(ir: &IR) -> Result<TokenStream> { |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 1959 | // This function uses quote! to generate C++ source code out of convenience. |
| 1960 | // This is a bold idea so we have to continously evaluate if it still makes |
| 1961 | // sense or the cost of working around differences in Rust and C++ tokens is |
| 1962 | // greather than the value added. |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 1963 | // |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 1964 | // See rs_bindings_from_cc/ |
| 1965 | // token_stream_printer.rs for a list of supported placeholders. |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 1966 | let mut thunks = vec![]; |
Michael Forster | 7ef8073 | 2021-10-01 18:12:19 +0000 | [diff] [blame] | 1967 | for func in ir.functions() { |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 1968 | if can_skip_cc_thunk(func) { |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 1969 | continue; |
| 1970 | } |
| 1971 | |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 1972 | let thunk_ident = thunk_ident(func); |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 1973 | let implementation_function = match &func.name { |
Lukasz Anforowicz | 9c663ca | 2022-02-09 01:33:31 +0000 | [diff] [blame] | 1974 | UnqualifiedIdentifier::Operator(op) => { |
| 1975 | let name = syn::parse_str::<TokenStream>(&op.name)?; |
| 1976 | quote! { operator #name } |
| 1977 | } |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 1978 | UnqualifiedIdentifier::Identifier(id) => { |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 1979 | let fn_ident = format_cc_ident(&id.identifier); |
Lukasz Anforowicz | aab8ad2 | 2021-12-19 20:29:26 +0000 | [diff] [blame] | 1980 | let static_method_metadata = func |
| 1981 | .member_func_metadata |
| 1982 | .as_ref() |
| 1983 | .filter(|meta| meta.instance_method_metadata.is_none()); |
| 1984 | match static_method_metadata { |
| 1985 | None => quote! {#fn_ident}, |
| 1986 | Some(meta) => { |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 1987 | let record_ident = format_cc_ident(&meta.find_record(ir)?.cc_name); |
Lukasz Anforowicz | aab8ad2 | 2021-12-19 20:29:26 +0000 | [diff] [blame] | 1988 | quote! { #record_ident :: #fn_ident } |
| 1989 | } |
| 1990 | } |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 1991 | } |
Lukasz Anforowicz | 7b0042d | 2022-01-06 23:00:19 +0000 | [diff] [blame] | 1992 | // Use `destroy_at` to avoid needing to spell out the class name. Destructor identiifers |
Devin Jeanpierre | cc6cf09 | 2021-12-16 04:31:14 +0000 | [diff] [blame] | 1993 | // use the name of the type itself, without namespace qualification, template |
| 1994 | // parameters, or aliases. We do not need to use that naming scheme anywhere else in |
| 1995 | // the bindings, and it can be difficult (impossible?) to spell in the general case. By |
| 1996 | // using destroy_at, we avoid needing to determine or remember what the correct spelling |
Lukasz Anforowicz | 7b0042d | 2022-01-06 23:00:19 +0000 | [diff] [blame] | 1997 | // is. Similar arguments apply to `construct_at`. |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 1998 | UnqualifiedIdentifier::Constructor => { |
Lukasz Anforowicz | 7b0042d | 2022-01-06 23:00:19 +0000 | [diff] [blame] | 1999 | quote! { rs_api_impl_support::construct_at } |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 2000 | } |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 2001 | UnqualifiedIdentifier::Destructor => quote! {std::destroy_at}, |
Devin Jeanpierre | f2ec871 | 2021-10-13 20:47:16 +0000 | [diff] [blame] | 2002 | }; |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 2003 | let return_type_name = format_cc_type(&func.return_type.cc_type, ir)?; |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 2004 | let return_stmt = if func.return_type.cc_type.is_void() { |
| 2005 | quote! {} |
| 2006 | } else { |
| 2007 | quote! { return } |
| 2008 | }; |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2009 | |
| 2010 | let param_idents = |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 2011 | func.params.iter().map(|p| format_cc_ident(&p.identifier.identifier)).collect_vec(); |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2012 | |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 2013 | let param_types = func |
| 2014 | .params |
| 2015 | .iter() |
Marcel Hlopko | c0956cf | 2021-11-29 08:31:28 +0000 | [diff] [blame] | 2016 | .map(|p| format_cc_type(&p.type_.cc_type, ir)) |
Devin Jeanpierre | 09c6f45 | 2021-09-29 07:34:24 +0000 | [diff] [blame] | 2017 | .collect::<Result<Vec<_>>>()?; |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2018 | |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2019 | let needs_this_deref = match &func.member_func_metadata { |
| 2020 | None => false, |
| 2021 | Some(meta) => match &func.name { |
| 2022 | UnqualifiedIdentifier::Constructor | UnqualifiedIdentifier::Destructor => false, |
Marcel Hlopko | 14ee3c8 | 2022-02-09 09:46:23 +0000 | [diff] [blame] | 2023 | UnqualifiedIdentifier::Identifier(_) | UnqualifiedIdentifier::Operator(_) => { |
| 2024 | meta.instance_method_metadata.is_some() |
| 2025 | } |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2026 | }, |
| 2027 | }; |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2028 | |
| 2029 | let arg_expressions: Vec<_> = param_idents |
| 2030 | .iter() |
| 2031 | .map( |
| 2032 | // Forward references along. (If the parameter is a value, not a reference, this |
| 2033 | // will create an lvalue reference, and still do the right thing.) |
| 2034 | |ident| quote! {std::forward<decltype(#ident)>(#ident)}, |
| 2035 | ) |
| 2036 | .collect(); |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2037 | let (implementation_function, arg_expressions) = if !needs_this_deref { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2038 | (implementation_function, arg_expressions.clone()) |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2039 | } else { |
| 2040 | let this_param = func |
| 2041 | .params |
| 2042 | .first() |
| 2043 | .ok_or_else(|| anyhow!("Instance methods must have `__this` param."))?; |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 2044 | let this_arg = format_cc_ident(&this_param.identifier.identifier); |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2045 | ( |
| 2046 | quote! { #this_arg -> #implementation_function}, |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2047 | arg_expressions.iter().skip(1).cloned().collect_vec(), |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2048 | ) |
| 2049 | }; |
| 2050 | |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2051 | thunks.push(quote! { |
| 2052 | extern "C" #return_type_name #thunk_ident( #( #param_types #param_idents ),* ) { |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2053 | #return_stmt #implementation_function( #( #arg_expressions ),* ); |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2054 | } |
| 2055 | }); |
| 2056 | } |
| 2057 | |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2058 | let layout_assertions = ir.records().map(|record| cc_struct_layout_assertion(record, ir)); |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 2059 | |
Devin Jeanpierre | 231ef8d | 2021-10-27 10:50:44 +0000 | [diff] [blame] | 2060 | let mut standard_headers = <BTreeSet<Ident>>::new(); |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 2061 | standard_headers.insert(format_ident!("memory")); // ubiquitous. |
Devin Jeanpierre | 231ef8d | 2021-10-27 10:50:44 +0000 | [diff] [blame] | 2062 | if ir.records().next().is_some() { |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 2063 | standard_headers.insert(format_ident!("cstddef")); |
Devin Jeanpierre | 231ef8d | 2021-10-27 10:50:44 +0000 | [diff] [blame] | 2064 | }; |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 2065 | |
Devin Jeanpierre | 1b8f4a1 | 2022-03-22 21:29:42 +0000 | [diff] [blame] | 2066 | let mut includes = vec!["rs_bindings_from_cc/support/cxx20_backports.h"]; |
Lukasz Anforowicz | 4457baf | 2021-12-23 17:24:04 +0000 | [diff] [blame] | 2067 | |
Michael Forster | bee8448 | 2021-10-13 08:35:38 +0000 | [diff] [blame] | 2068 | // In order to generate C++ thunk in all the cases Clang needs to be able to |
| 2069 | // access declarations from public headers of the C++ library. |
Lukasz Anforowicz | 4457baf | 2021-12-23 17:24:04 +0000 | [diff] [blame] | 2070 | includes.extend(ir.used_headers().map(|i| &i.name as &str)); |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2071 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2072 | Ok(quote! { |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 2073 | #( __HASH_TOKEN__ include <#standard_headers> __NEWLINE__)* |
Devin Jeanpierre | 7c74f84 | 2022-02-03 07:08:06 +0000 | [diff] [blame] | 2074 | __NEWLINE__ |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2075 | #( __HASH_TOKEN__ include #includes __NEWLINE__)* __NEWLINE__ |
Marcel Hlopko | b8069ae | 2022-02-19 09:31:00 +0000 | [diff] [blame] | 2076 | __HASH_TOKEN__ pragma clang diagnostic push __NEWLINE__ |
| 2077 | // Disable Clang thread-safety-analysis warnings that would otherwise |
| 2078 | // complain about thunks that call mutex locking functions in an unpaired way. |
| 2079 | __HASH_TOKEN__ pragma clang diagnostic ignored "-Wthread-safety-analysis" __NEWLINE__ |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2080 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2081 | #( #thunks )* __NEWLINE__ __NEWLINE__ |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 2082 | |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2083 | #( #layout_assertions __NEWLINE__ __NEWLINE__ )* |
Marcel Hlopko | c6b726c | 2021-10-07 06:53:09 +0000 | [diff] [blame] | 2084 | |
Marcel Hlopko | b8069ae | 2022-02-19 09:31:00 +0000 | [diff] [blame] | 2085 | __NEWLINE__ |
| 2086 | __HASH_TOKEN__ pragma clang diagnostic pop __NEWLINE__ |
Marcel Hlopko | c6b726c | 2021-10-07 06:53:09 +0000 | [diff] [blame] | 2087 | // To satisfy http://cs/symbol:devtools.metadata.Presubmit.CheckTerminatingNewline check. |
| 2088 | __NEWLINE__ |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2089 | }) |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2090 | } |
| 2091 | |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 2092 | #[cfg(test)] |
| 2093 | mod tests { |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 2094 | use super::*; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 2095 | use anyhow::anyhow; |
Dmitri Gribenko | 67cbfd2 | 2022-03-24 13:39:34 +0000 | [diff] [blame] | 2096 | use ir_testing::{ir_from_cc, ir_from_cc_dependency, ir_record, retrieve_func}; |
Lukasz Anforowicz | 282bfd7 | 2022-03-22 22:38:17 +0000 | [diff] [blame] | 2097 | use static_assertions::{assert_impl_all, assert_not_impl_all}; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2098 | use token_stream_matchers::{ |
Lukasz Anforowicz | 71e9b59 | 2022-03-04 19:03:02 +0000 | [diff] [blame] | 2099 | assert_cc_matches, assert_cc_not_matches, assert_ir_matches, assert_rs_matches, |
| 2100 | assert_rs_not_matches, |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 2101 | }; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2102 | use token_stream_printer::tokens_to_string; |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 2103 | |
| 2104 | #[test] |
Marcel Hlopko | b8069ae | 2022-02-19 09:31:00 +0000 | [diff] [blame] | 2105 | fn test_disable_thread_safety_warnings() -> Result<()> { |
| 2106 | let ir = ir_from_cc("inline void foo() {}")?; |
| 2107 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2108 | assert_cc_matches!( |
| 2109 | rs_api_impl, |
| 2110 | quote! { |
| 2111 | ... |
| 2112 | __HASH_TOKEN__ pragma clang diagnostic push |
| 2113 | __HASH_TOKEN__ pragma clang diagnostic ignored "-Wthread-safety-analysis" |
| 2114 | ... |
| 2115 | |
| 2116 | __HASH_TOKEN__ pragma clang diagnostic pop |
| 2117 | ... |
| 2118 | } |
| 2119 | ); |
| 2120 | Ok(()) |
| 2121 | } |
| 2122 | |
| 2123 | #[test] |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 2124 | // TODO(hlopko): Move this test to a more principled place where it can access |
| 2125 | // `ir_testing`. |
| 2126 | fn test_duplicate_decl_ids_err() { |
| 2127 | let mut r1 = ir_record("R1"); |
Rosica Dejanovska | d638cf5 | 2022-03-23 15:45:01 +0000 | [diff] [blame] | 2128 | r1.id = ItemId(42); |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 2129 | let mut r2 = ir_record("R2"); |
Rosica Dejanovska | d638cf5 | 2022-03-23 15:45:01 +0000 | [diff] [blame] | 2130 | r2.id = ItemId(42); |
Marcel Hlopko | 3b9bf9e | 2021-11-29 08:25:14 +0000 | [diff] [blame] | 2131 | let result = make_ir_from_items([r1.into(), r2.into()]); |
| 2132 | assert!(result.is_err()); |
| 2133 | assert!(result.unwrap_err().to_string().contains("Duplicate decl_id found in")); |
| 2134 | } |
| 2135 | |
| 2136 | #[test] |
Marcel Hlopko | 45fba97 | 2021-08-23 19:52:20 +0000 | [diff] [blame] | 2137 | fn test_simple_function() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2138 | let ir = ir_from_cc("int Add(int a, int b);")?; |
| 2139 | let rs_api = generate_rs_api(&ir)?; |
| 2140 | assert_rs_matches!( |
| 2141 | rs_api, |
| 2142 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2143 | #[inline(always)] |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2144 | pub fn Add(a: i32, b: i32) -> i32 { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2145 | unsafe { crate::detail::__rust_thunk___Z3Addii(a, b) } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2146 | } |
| 2147 | } |
| 2148 | ); |
| 2149 | assert_rs_matches!( |
| 2150 | rs_api, |
| 2151 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2152 | mod detail { |
Googler | 5564714 | 2022-01-11 12:37:39 +0000 | [diff] [blame] | 2153 | #[allow(unused_imports)] |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 2154 | use super::*; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2155 | extern "C" { |
| 2156 | #[link_name = "_Z3Addii"] |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2157 | pub(crate) fn __rust_thunk___Z3Addii(a: i32, b: i32) -> i32; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2158 | } |
| 2159 | } |
| 2160 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 2161 | ); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2162 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2163 | assert_cc_not_matches!(generate_rs_api_impl(&ir)?, quote! {__rust_thunk___Z3Addii}); |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2164 | |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2165 | Ok(()) |
| 2166 | } |
| 2167 | |
| 2168 | #[test] |
| 2169 | fn test_inline_function() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2170 | let ir = ir_from_cc("inline int Add(int a, int b);")?; |
| 2171 | let rs_api = generate_rs_api(&ir)?; |
| 2172 | assert_rs_matches!( |
| 2173 | rs_api, |
| 2174 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2175 | #[inline(always)] |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2176 | pub fn Add(a: i32, b: i32) -> i32 { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2177 | unsafe { crate::detail::__rust_thunk___Z3Addii(a, b) } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2178 | } |
| 2179 | } |
| 2180 | ); |
| 2181 | assert_rs_matches!( |
| 2182 | rs_api, |
| 2183 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2184 | mod detail { |
Googler | 5564714 | 2022-01-11 12:37:39 +0000 | [diff] [blame] | 2185 | #[allow(unused_imports)] |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 2186 | use super::*; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2187 | extern "C" { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2188 | pub(crate) fn __rust_thunk___Z3Addii(a: i32, b: i32) -> i32; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2189 | } |
| 2190 | } |
| 2191 | } |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2192 | ); |
| 2193 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2194 | assert_cc_matches!( |
| 2195 | generate_rs_api_impl(&ir)?, |
| 2196 | quote! { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2197 | extern "C" int __rust_thunk___Z3Addii(int a, int b) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2198 | return Add(std::forward<decltype(a)>(a), std::forward<decltype(b)>(b)); |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2199 | } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2200 | } |
Marcel Hlopko | 3164eee | 2021-08-24 20:09:22 +0000 | [diff] [blame] | 2201 | ); |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 2202 | Ok(()) |
| 2203 | } |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 2204 | |
| 2205 | #[test] |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2206 | fn test_simple_function_with_types_from_other_target() -> Result<()> { |
| 2207 | let ir = ir_from_cc_dependency( |
| 2208 | "inline ReturnStruct DoSomething(ParamStruct param);", |
| 2209 | "struct ReturnStruct {}; struct ParamStruct {};", |
| 2210 | )?; |
| 2211 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2212 | let rs_api = generate_rs_api(&ir)?; |
| 2213 | assert_rs_matches!( |
| 2214 | rs_api, |
| 2215 | quote! { |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2216 | #[inline(always)] |
| 2217 | pub fn DoSomething(param: dependency::ParamStruct) |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2218 | -> dependency::ReturnStruct { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2219 | unsafe { crate::detail::__rust_thunk___Z11DoSomething11ParamStruct(param) } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2220 | } |
| 2221 | } |
| 2222 | ); |
| 2223 | assert_rs_matches!( |
| 2224 | rs_api, |
| 2225 | quote! { |
| 2226 | mod detail { |
Googler | 5564714 | 2022-01-11 12:37:39 +0000 | [diff] [blame] | 2227 | #[allow(unused_imports)] |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2228 | use super::*; |
| 2229 | extern "C" { |
| 2230 | pub(crate) fn __rust_thunk___Z11DoSomething11ParamStruct(param: dependency::ParamStruct) |
| 2231 | -> dependency::ReturnStruct; |
| 2232 | } |
| 2233 | }} |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2234 | ); |
| 2235 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2236 | assert_cc_matches!( |
| 2237 | generate_rs_api_impl(&ir)?, |
| 2238 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 2239 | extern "C" class ReturnStruct __rust_thunk___Z11DoSomething11ParamStruct(class ParamStruct param) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2240 | return DoSomething(std::forward<decltype(param)>(param)); |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2241 | } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2242 | } |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2243 | ); |
| 2244 | Ok(()) |
| 2245 | } |
| 2246 | |
| 2247 | #[test] |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 2248 | fn test_simple_struct() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2249 | let ir = ir_from_cc(&tokens_to_string(quote! { |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 2250 | struct SomeStruct final { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2251 | int public_int; |
| 2252 | protected: |
| 2253 | int protected_int; |
| 2254 | private: |
| 2255 | int private_int; |
| 2256 | }; |
| 2257 | })?)?; |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 2258 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2259 | let rs_api = generate_rs_api(&ir)?; |
| 2260 | assert_rs_matches!( |
| 2261 | rs_api, |
| 2262 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2263 | #[derive(Clone, Copy)] |
| 2264 | #[repr(C)] |
| 2265 | pub struct SomeStruct { |
| 2266 | pub public_int: i32, |
| 2267 | protected_int: i32, |
| 2268 | private_int: i32, |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2269 | } |
| 2270 | } |
| 2271 | ); |
| 2272 | assert_rs_matches!( |
| 2273 | rs_api, |
| 2274 | quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2275 | const _: () = assert!(rust_std::mem::size_of::<Option<&i32>>() == rust_std::mem::size_of::<&i32>()); |
| 2276 | const _: () = assert!(rust_std::mem::size_of::<SomeStruct>() == 12usize); |
| 2277 | const _: () = assert!(rust_std::mem::align_of::<SomeStruct>() == 4usize); |
Lukasz Anforowicz | 95938f8 | 2022-03-24 13:51:54 +0000 | [diff] [blame] | 2278 | const _: () = { assert_impl_all!(SomeStruct: Clone); }; |
| 2279 | const _: () = { assert_impl_all!(SomeStruct: Copy); }; |
| 2280 | const _: () = { assert_not_impl_all!(SomeStruct: Drop); }; |
Googler | 209b10a | 2021-12-06 09:11:57 +0000 | [diff] [blame] | 2281 | const _: () = assert!(offset_of!(SomeStruct, public_int) * 8 == 0usize); |
| 2282 | const _: () = assert!(offset_of!(SomeStruct, protected_int) * 8 == 32usize); |
| 2283 | const _: () = assert!(offset_of!(SomeStruct, private_int) * 8 == 64usize); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2284 | } |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 2285 | ); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2286 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2287 | assert_cc_matches!( |
| 2288 | rs_api_impl, |
| 2289 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 2290 | extern "C" void __rust_thunk___ZN10SomeStructD1Ev(class SomeStruct * __this) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2291 | std :: destroy_at (std::forward<decltype(__this)>(__this)) ; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2292 | } |
| 2293 | } |
| 2294 | ); |
| 2295 | assert_cc_matches!( |
| 2296 | rs_api_impl, |
| 2297 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 2298 | static_assert(sizeof(class SomeStruct) == 12); |
| 2299 | static_assert(alignof(class SomeStruct) == 4); |
| 2300 | static_assert(offsetof(class SomeStruct, public_int) * 8 == 0); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2301 | } |
Googler | 5ea8864 | 2021-09-29 08:05:59 +0000 | [diff] [blame] | 2302 | ); |
Marcel Hlopko | b4b2874 | 2021-09-15 12:45:20 +0000 | [diff] [blame] | 2303 | Ok(()) |
| 2304 | } |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 2305 | |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2306 | #[test] |
Lukasz Anforowicz | 275fa92 | 2022-01-05 16:13:20 +0000 | [diff] [blame] | 2307 | fn test_ref_to_struct_in_thunk_impls() -> Result<()> { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 2308 | let ir = ir_from_cc("struct S{}; inline void foo(class S& s) {} ")?; |
Lukasz Anforowicz | 275fa92 | 2022-01-05 16:13:20 +0000 | [diff] [blame] | 2309 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2310 | assert_cc_matches!( |
| 2311 | rs_api_impl, |
| 2312 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 2313 | extern "C" void __rust_thunk___Z3fooR1S(class S& s) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2314 | foo(std::forward<decltype(s)>(s)); |
Lukasz Anforowicz | 275fa92 | 2022-01-05 16:13:20 +0000 | [diff] [blame] | 2315 | } |
| 2316 | } |
| 2317 | ); |
| 2318 | Ok(()) |
| 2319 | } |
| 2320 | |
| 2321 | #[test] |
| 2322 | fn test_const_ref_to_struct_in_thunk_impls() -> Result<()> { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 2323 | let ir = ir_from_cc("struct S{}; inline void foo(const class S& s) {} ")?; |
Lukasz Anforowicz | 275fa92 | 2022-01-05 16:13:20 +0000 | [diff] [blame] | 2324 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2325 | assert_cc_matches!( |
| 2326 | rs_api_impl, |
| 2327 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 2328 | extern "C" void __rust_thunk___Z3fooRK1S(const class S& s) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2329 | foo(std::forward<decltype(s)>(s)); |
Lukasz Anforowicz | 275fa92 | 2022-01-05 16:13:20 +0000 | [diff] [blame] | 2330 | } |
| 2331 | } |
| 2332 | ); |
| 2333 | Ok(()) |
| 2334 | } |
| 2335 | |
| 2336 | #[test] |
Lukasz Anforowicz | 957cbf2 | 2022-01-05 16:14:05 +0000 | [diff] [blame] | 2337 | fn test_unsigned_int_in_thunk_impls() -> Result<()> { |
| 2338 | let ir = ir_from_cc("inline void foo(unsigned int i) {} ")?; |
| 2339 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2340 | assert_cc_matches!( |
| 2341 | rs_api_impl, |
| 2342 | quote! { |
| 2343 | extern "C" void __rust_thunk___Z3fooj(unsigned int i) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2344 | foo(std::forward<decltype(i)>(i)); |
Lukasz Anforowicz | 957cbf2 | 2022-01-05 16:14:05 +0000 | [diff] [blame] | 2345 | } |
| 2346 | } |
| 2347 | ); |
| 2348 | Ok(()) |
| 2349 | } |
| 2350 | |
| 2351 | #[test] |
Marcel Hlopko | dd1fcb1 | 2021-12-22 14:13:59 +0000 | [diff] [blame] | 2352 | fn test_record_static_methods_qualify_call_in_thunk() -> Result<()> { |
| 2353 | let ir = ir_from_cc(&tokens_to_string(quote! { |
| 2354 | struct SomeStruct { |
| 2355 | static inline int some_func() { return 42; } |
| 2356 | }; |
| 2357 | })?)?; |
| 2358 | |
| 2359 | assert_cc_matches!( |
| 2360 | generate_rs_api_impl(&ir)?, |
| 2361 | quote! { |
| 2362 | extern "C" int __rust_thunk___ZN10SomeStruct9some_funcEv() { |
| 2363 | return SomeStruct::some_func(); |
| 2364 | } |
| 2365 | } |
| 2366 | ); |
| 2367 | Ok(()) |
| 2368 | } |
| 2369 | |
| 2370 | #[test] |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2371 | fn test_record_instance_methods_deref_this_in_thunk() -> Result<()> { |
| 2372 | let ir = ir_from_cc(&tokens_to_string(quote! { |
| 2373 | struct SomeStruct { |
| 2374 | inline int some_func(int arg) const { return 42 + arg; } |
| 2375 | }; |
| 2376 | })?)?; |
| 2377 | |
| 2378 | assert_cc_matches!( |
| 2379 | generate_rs_api_impl(&ir)?, |
| 2380 | quote! { |
| 2381 | extern "C" int __rust_thunk___ZNK10SomeStruct9some_funcEi( |
| 2382 | const class SomeStruct* __this, int arg) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2383 | return __this->some_func(std::forward<decltype(arg)>(arg)); |
Lukasz Anforowicz | b3d89aa | 2022-01-12 14:35:52 +0000 | [diff] [blame] | 2384 | } |
| 2385 | } |
| 2386 | ); |
| 2387 | Ok(()) |
| 2388 | } |
| 2389 | |
| 2390 | #[test] |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2391 | fn test_struct_from_other_target() -> Result<()> { |
| 2392 | let ir = ir_from_cc_dependency("// intentionally empty", "struct SomeStruct {};")?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2393 | assert_rs_not_matches!(generate_rs_api(&ir)?, quote! { SomeStruct }); |
| 2394 | assert_cc_not_matches!(generate_rs_api_impl(&ir)?, quote! { SomeStruct }); |
Marcel Hlopko | a0f3866 | 2021-12-03 08:45:26 +0000 | [diff] [blame] | 2395 | Ok(()) |
| 2396 | } |
| 2397 | |
| 2398 | #[test] |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2399 | fn test_copy_derives() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 2400 | let record = ir_record("S"); |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 2401 | assert_eq!(generate_derives(&record), &["Clone", "Copy"]); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2402 | } |
| 2403 | |
| 2404 | #[test] |
| 2405 | fn test_copy_derives_not_is_trivial_abi() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 2406 | let mut record = ir_record("S"); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2407 | record.is_trivial_abi = false; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 2408 | assert_eq!(generate_derives(&record), &[""; 0]); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2409 | } |
| 2410 | |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 2411 | /// Even if it's trivially relocatable, !Unpin C++ type cannot be |
| 2412 | /// cloned/copied or otherwise used by value, because values would allow |
| 2413 | /// assignment into the Pin. |
| 2414 | /// |
| 2415 | /// All !Unpin C++ types, not just non trivially relocatable ones, are |
| 2416 | /// unsafe to assign in the Rust sense. |
Devin Jeanpierre | e6e1665 | 2021-12-22 15:54:46 +0000 | [diff] [blame] | 2417 | #[test] |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 2418 | fn test_copy_derives_not_final() { |
Devin Jeanpierre | e6e1665 | 2021-12-22 15:54:46 +0000 | [diff] [blame] | 2419 | let mut record = ir_record("S"); |
Teddy Katz | d2cd142 | 2022-04-04 09:41:33 -0700 | [diff] [blame] | 2420 | record.is_inheritable = true; |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 2421 | assert_eq!(generate_derives(&record), &[""; 0]); |
Devin Jeanpierre | e6e1665 | 2021-12-22 15:54:46 +0000 | [diff] [blame] | 2422 | } |
| 2423 | |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2424 | #[test] |
| 2425 | fn test_copy_derives_ctor_nonpublic() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 2426 | let mut record = ir_record("S"); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2427 | for access in [ir::AccessSpecifier::Protected, ir::AccessSpecifier::Private] { |
| 2428 | record.copy_constructor.access = access; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 2429 | assert_eq!(generate_derives(&record), &[""; 0]); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2430 | } |
| 2431 | } |
| 2432 | |
| 2433 | #[test] |
| 2434 | fn test_copy_derives_ctor_deleted() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 2435 | let mut record = ir_record("S"); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2436 | record.copy_constructor.definition = ir::SpecialMemberDefinition::Deleted; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 2437 | assert_eq!(generate_derives(&record), &[""; 0]); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2438 | } |
| 2439 | |
| 2440 | #[test] |
Devin Jeanpierre | be2f33b | 2021-10-21 12:54:19 +0000 | [diff] [blame] | 2441 | fn test_copy_derives_ctor_nontrivial_members() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 2442 | let mut record = ir_record("S"); |
Devin Jeanpierre | be2f33b | 2021-10-21 12:54:19 +0000 | [diff] [blame] | 2443 | record.copy_constructor.definition = ir::SpecialMemberDefinition::NontrivialMembers; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 2444 | assert_eq!(generate_derives(&record), &[""; 0]); |
Devin Jeanpierre | be2f33b | 2021-10-21 12:54:19 +0000 | [diff] [blame] | 2445 | } |
| 2446 | |
| 2447 | #[test] |
| 2448 | fn test_copy_derives_ctor_nontrivial_self() { |
Devin Jeanpierre | ccfefc8 | 2021-10-27 10:54:00 +0000 | [diff] [blame] | 2449 | let mut record = ir_record("S"); |
Devin Jeanpierre | 7b62e95 | 2021-12-08 21:43:30 +0000 | [diff] [blame] | 2450 | record.copy_constructor.definition = ir::SpecialMemberDefinition::NontrivialUserDefined; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 2451 | assert_eq!(generate_derives(&record), &[""; 0]); |
Devin Jeanpierre | 2ed14ec | 2021-10-06 11:32:19 +0000 | [diff] [blame] | 2452 | } |
| 2453 | |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 2454 | #[test] |
| 2455 | fn test_ptr_func() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2456 | let ir = ir_from_cc(&tokens_to_string(quote! { |
| 2457 | inline int* Deref(int*const* p); |
| 2458 | })?)?; |
Devin Jeanpierre | d6da700 | 2021-10-21 12:55:20 +0000 | [diff] [blame] | 2459 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2460 | let rs_api = generate_rs_api(&ir)?; |
| 2461 | assert_rs_matches!( |
| 2462 | rs_api, |
| 2463 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2464 | #[inline(always)] |
Lukasz Anforowicz | f7bdd39 | 2022-01-21 00:33:39 +0000 | [diff] [blame] | 2465 | pub unsafe fn Deref(p: *const *mut i32) -> *mut i32 { |
| 2466 | crate::detail::__rust_thunk___Z5DerefPKPi(p) |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2467 | } |
| 2468 | } |
| 2469 | ); |
| 2470 | assert_rs_matches!( |
| 2471 | rs_api, |
| 2472 | quote! { |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2473 | mod detail { |
Googler | 5564714 | 2022-01-11 12:37:39 +0000 | [diff] [blame] | 2474 | #[allow(unused_imports)] |
Devin Jeanpierre | d4dde0e | 2021-10-13 20:48:25 +0000 | [diff] [blame] | 2475 | use super::*; |
Michael Forster | db8101a | 2021-10-08 06:56:03 +0000 | [diff] [blame] | 2476 | extern "C" { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2477 | pub(crate) fn __rust_thunk___Z5DerefPKPi(p: *const *mut i32) -> *mut i32; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2478 | } |
| 2479 | } |
| 2480 | } |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 2481 | ); |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 2482 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2483 | assert_cc_matches!( |
| 2484 | generate_rs_api_impl(&ir)?, |
| 2485 | quote! { |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2486 | extern "C" int* __rust_thunk___Z5DerefPKPi(int* const * p) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2487 | return Deref(std::forward<decltype(p)>(p)); |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 2488 | } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2489 | } |
Devin Jeanpierre | 184f9ac | 2021-09-17 13:47:03 +0000 | [diff] [blame] | 2490 | ); |
Devin Jeanpierre | 7a7328e | 2021-09-17 07:10:08 +0000 | [diff] [blame] | 2491 | Ok(()) |
| 2492 | } |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 2493 | |
| 2494 | #[test] |
Googler | db11153 | 2022-01-05 06:12:13 +0000 | [diff] [blame] | 2495 | fn test_const_char_ptr_func() -> Result<()> { |
| 2496 | // This is a regression test: We used to include the "const" in the name |
| 2497 | // of the CcType, which caused a panic in the code generator |
| 2498 | // ('"const char" is not a valid Ident'). |
| 2499 | // It's therefore important that f() is inline so that we need to |
| 2500 | // generate a thunk for it (where we then process the CcType). |
| 2501 | let ir = ir_from_cc(&tokens_to_string(quote! { |
| 2502 | inline void f(const char *str); |
| 2503 | })?)?; |
| 2504 | |
| 2505 | let rs_api = generate_rs_api(&ir)?; |
| 2506 | assert_rs_matches!( |
| 2507 | rs_api, |
| 2508 | quote! { |
| 2509 | #[inline(always)] |
Lukasz Anforowicz | f7bdd39 | 2022-01-21 00:33:39 +0000 | [diff] [blame] | 2510 | pub unsafe fn f(str: *const i8) { |
| 2511 | crate::detail::__rust_thunk___Z1fPKc(str) |
Googler | db11153 | 2022-01-05 06:12:13 +0000 | [diff] [blame] | 2512 | } |
| 2513 | } |
| 2514 | ); |
| 2515 | assert_rs_matches!( |
| 2516 | rs_api, |
| 2517 | quote! { |
| 2518 | extern "C" { |
| 2519 | pub(crate) fn __rust_thunk___Z1fPKc(str: *const i8); |
| 2520 | } |
| 2521 | } |
| 2522 | ); |
| 2523 | |
| 2524 | assert_cc_matches!( |
| 2525 | generate_rs_api_impl(&ir)?, |
| 2526 | quote! { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 2527 | extern "C" void __rust_thunk___Z1fPKc(char const * str){ f(std::forward<decltype(str)>(str)) ; } |
Googler | db11153 | 2022-01-05 06:12:13 +0000 | [diff] [blame] | 2528 | } |
| 2529 | ); |
| 2530 | Ok(()) |
| 2531 | } |
| 2532 | |
| 2533 | #[test] |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 2534 | fn test_func_ptr_where_params_are_primitive_types() -> Result<()> { |
| 2535 | let ir = ir_from_cc(r#" int (*get_ptr_to_func())(float, double); "#)?; |
| 2536 | let rs_api = generate_rs_api(&ir)?; |
| 2537 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2538 | assert_rs_matches!( |
| 2539 | rs_api, |
| 2540 | quote! { |
| 2541 | #[inline(always)] |
| 2542 | pub fn get_ptr_to_func() -> Option<extern "C" fn (f32, f64) -> i32> { |
| 2543 | unsafe { crate::detail::__rust_thunk___Z15get_ptr_to_funcv() } |
| 2544 | } |
| 2545 | } |
| 2546 | ); |
| 2547 | assert_rs_matches!( |
| 2548 | rs_api, |
| 2549 | quote! { |
| 2550 | mod detail { |
| 2551 | #[allow(unused_imports)] |
| 2552 | use super::*; |
| 2553 | extern "C" { |
| 2554 | #[link_name = "_Z15get_ptr_to_funcv"] |
| 2555 | pub(crate) fn __rust_thunk___Z15get_ptr_to_funcv() |
| 2556 | -> Option<extern "C" fn(f32, f64) -> i32>; |
| 2557 | } |
| 2558 | } |
| 2559 | } |
| 2560 | ); |
| 2561 | // Verify that no C++ thunk got generated. |
| 2562 | assert_cc_not_matches!(rs_api_impl, quote! { __rust_thunk___Z15get_ptr_to_funcv }); |
| 2563 | |
| 2564 | // TODO(b/217419782): Add another test for more exotic calling conventions / |
| 2565 | // abis. |
| 2566 | |
| 2567 | // TODO(b/217419782): Add another test for pointer to a function that |
| 2568 | // takes/returns non-trivially-movable types by value. See also |
| 2569 | // <internal link> |
| 2570 | |
| 2571 | Ok(()) |
| 2572 | } |
| 2573 | |
| 2574 | #[test] |
Lukasz Anforowicz | 92c81c3 | 2022-03-04 19:03:56 +0000 | [diff] [blame] | 2575 | fn test_func_ref() -> Result<()> { |
| 2576 | let ir = ir_from_cc(r#" int (&get_ref_to_func())(float, double); "#)?; |
| 2577 | let rs_api = generate_rs_api(&ir)?; |
| 2578 | assert_rs_matches!( |
| 2579 | rs_api, |
| 2580 | quote! { |
| 2581 | #[inline(always)] |
| 2582 | pub fn get_ref_to_func() -> extern "C" fn (f32, f64) -> i32 { |
| 2583 | unsafe { crate::detail::__rust_thunk___Z15get_ref_to_funcv() } |
| 2584 | } |
| 2585 | } |
| 2586 | ); |
| 2587 | Ok(()) |
| 2588 | } |
| 2589 | |
| 2590 | #[test] |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 2591 | fn test_func_ptr_with_non_static_lifetime() -> Result<()> { |
| 2592 | let ir = ir_from_cc( |
| 2593 | r#" |
Googler | 53f6594 | 2022-02-23 11:23:30 +0000 | [diff] [blame] | 2594 | [[clang::annotate("lifetimes", "-> a")]] |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 2595 | int (*get_ptr_to_func())(float, double); "#, |
| 2596 | )?; |
| 2597 | let rs_api = generate_rs_api(&ir)?; |
| 2598 | assert_rs_matches!( |
| 2599 | rs_api, |
| 2600 | quote! { |
| 2601 | // Error while generating bindings for item 'get_ptr_to_func': |
| 2602 | // Return type is not supported: Function pointers with non-'static lifetimes are not supported: int (*)(float, double) |
| 2603 | } |
| 2604 | ); |
| 2605 | Ok(()) |
| 2606 | } |
| 2607 | |
| 2608 | #[test] |
| 2609 | fn test_func_ptr_where_params_are_raw_ptrs() -> Result<()> { |
| 2610 | let ir = ir_from_cc(r#" const int* (*get_ptr_to_func())(const int*); "#)?; |
| 2611 | let rs_api = generate_rs_api(&ir)?; |
| 2612 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2613 | assert_rs_matches!( |
| 2614 | rs_api, |
| 2615 | quote! { |
| 2616 | #[inline(always)] |
| 2617 | pub fn get_ptr_to_func() -> Option<extern "C" fn (*const i32) -> *const i32> { |
| 2618 | unsafe { crate::detail::__rust_thunk___Z15get_ptr_to_funcv() } |
| 2619 | } |
| 2620 | } |
| 2621 | ); |
| 2622 | assert_rs_matches!( |
| 2623 | rs_api, |
| 2624 | quote! { |
| 2625 | mod detail { |
| 2626 | #[allow(unused_imports)] |
| 2627 | use super::*; |
| 2628 | extern "C" { |
| 2629 | #[link_name = "_Z15get_ptr_to_funcv"] |
| 2630 | pub(crate) fn __rust_thunk___Z15get_ptr_to_funcv() |
| 2631 | -> Option<extern "C" fn(*const i32) -> *const i32>; |
| 2632 | } |
| 2633 | } |
| 2634 | } |
| 2635 | ); |
| 2636 | // Verify that no C++ thunk got generated. |
| 2637 | assert_cc_not_matches!(rs_api_impl, quote! { __rust_thunk___Z15get_ptr_to_funcv }); |
| 2638 | |
| 2639 | // TODO(b/217419782): Add another test where params (and the return |
| 2640 | // type) are references with lifetimes. Something like this: |
| 2641 | // #pragma clang lifetime_elision |
| 2642 | // const int& (*get_ptr_to_func())(const int&, const int&); "#)?; |
| 2643 | // 1) Need to investigate why this fails - seeing raw pointers in Rust |
| 2644 | // seems to indicate that no lifetimes are present at the `importer.cc` |
| 2645 | // level. Maybe lifetime elision doesn't support this scenario? Unclear |
Googler | 53f6594 | 2022-02-23 11:23:30 +0000 | [diff] [blame] | 2646 | // how to explicitly apply [[clang::annotate("lifetimes", "a, b -> a")]] |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 2647 | // to the _inner_ function. |
| 2648 | // 2) It is important to have 2 reference parameters, so see if the problem |
| 2649 | // of passing `lifetimes` by value would have been caught - see: |
| 2650 | // cl/428079010/depot/rs_bindings_from_cc/ |
| 2651 | // importer.cc?version=s6#823 |
| 2652 | |
| 2653 | // TODO(b/217419782): Decide what to do if the C++ pointer is *not* |
| 2654 | // annotated with a lifetime - emit `unsafe fn(...) -> ...` in that |
| 2655 | // case? |
| 2656 | |
| 2657 | Ok(()) |
| 2658 | } |
| 2659 | |
| 2660 | #[test] |
Lukasz Anforowicz | 71e9b59 | 2022-03-04 19:03:02 +0000 | [diff] [blame] | 2661 | fn test_func_ptr_with_custom_abi() -> Result<()> { |
| 2662 | let ir = ir_from_cc(r#" int (*get_ptr_to_func())(float, double) [[clang::vectorcall]]; "#)?; |
| 2663 | |
| 2664 | // Verify that the test input correctly represents what we intend to |
| 2665 | // test - we want [[clang::vectorcall]] to apply to the returned |
| 2666 | // function pointer, but *not* apply to the `get_ptr_to_func` function. |
Lukasz Anforowicz | 71e9b59 | 2022-03-04 19:03:02 +0000 | [diff] [blame] | 2667 | assert_ir_matches!( |
| 2668 | ir, |
| 2669 | quote! { |
| 2670 | Func(Func { |
| 2671 | name: "get_ptr_to_func", ... |
| 2672 | return_type: MappedType { |
| 2673 | rs_type: RsType { |
| 2674 | name: Some("Option"), ... |
| 2675 | type_args: [RsType { name: Some("#funcPtr vectorcall"), ... }], ... |
| 2676 | }, |
| 2677 | cc_type: CcType { |
| 2678 | name: Some("*"), ... |
| 2679 | type_args: [CcType { name: Some("#funcValue vectorcall"), ... }], ... |
| 2680 | }, |
Lukasz Anforowicz | 0b6a6ac | 2022-03-22 22:32:23 +0000 | [diff] [blame] | 2681 | }, ... |
| 2682 | has_c_calling_convention: true, ... |
Lukasz Anforowicz | 71e9b59 | 2022-03-04 19:03:02 +0000 | [diff] [blame] | 2683 | }), |
| 2684 | } |
| 2685 | ); |
| 2686 | |
| 2687 | // Check that the custom "vectorcall" ABI gets propagated into the |
| 2688 | // return type (i.e. into `extern "vectorcall" fn`). |
| 2689 | let rs_api = generate_rs_api(&ir)?; |
| 2690 | assert_rs_matches!( |
| 2691 | rs_api, |
| 2692 | quote! { |
| 2693 | #[inline(always)] |
| 2694 | pub fn get_ptr_to_func() -> Option<extern "vectorcall" fn (f32, f64) -> i32> { |
| 2695 | unsafe { crate::detail::__rust_thunk___Z15get_ptr_to_funcv() } |
| 2696 | } |
| 2697 | } |
| 2698 | ); |
| 2699 | |
| 2700 | // The usual `extern "C"` ABI should be used for "get_ptr_to_func". |
| 2701 | assert_rs_matches!( |
| 2702 | rs_api, |
| 2703 | quote! { |
| 2704 | mod detail { |
| 2705 | #[allow(unused_imports)] |
| 2706 | use super::*; |
| 2707 | extern "C" { |
| 2708 | #[link_name = "_Z15get_ptr_to_funcv"] |
| 2709 | pub(crate) fn __rust_thunk___Z15get_ptr_to_funcv() |
| 2710 | -> Option<extern "vectorcall" fn(f32, f64) -> i32>; |
| 2711 | } |
| 2712 | } |
| 2713 | } |
| 2714 | ); |
| 2715 | |
| 2716 | // Verify that no C++ thunk got generated. |
| 2717 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2718 | assert_cc_not_matches!(rs_api_impl, quote! { __rust_thunk___Z15get_ptr_to_funcv }); |
| 2719 | Ok(()) |
| 2720 | } |
| 2721 | |
| 2722 | #[test] |
| 2723 | fn test_func_ptr_thunk() -> Result<()> { |
| 2724 | // Using an `inline` keyword forces generation of a C++ thunk in |
| 2725 | // `rs_api_impl` (i.e. exercises `format_cc_type` and similar code). |
| 2726 | let ir = ir_from_cc( |
| 2727 | r#" |
| 2728 | int multiply(int x, int y); |
| 2729 | inline int (*inline_get_pointer_to_function())(int, int) { |
| 2730 | return multiply; |
| 2731 | } |
| 2732 | "#, |
| 2733 | )?; |
| 2734 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2735 | assert_cc_matches!( |
| 2736 | rs_api_impl, |
| 2737 | quote! { |
| 2738 | extern "C" rs_api_impl_support::type_identity_t<int(int , int)>* |
| 2739 | __rust_thunk___Z30inline_get_pointer_to_functionv() { |
| 2740 | return inline_get_pointer_to_function(); |
| 2741 | } |
| 2742 | } |
| 2743 | ); |
| 2744 | Ok(()) |
| 2745 | } |
| 2746 | |
| 2747 | #[test] |
Lukasz Anforowicz | 0b6a6ac | 2022-03-22 22:32:23 +0000 | [diff] [blame] | 2748 | fn test_func_ptr_with_custom_abi_thunk() -> Result<()> { |
| 2749 | // Using an `inline` keyword forces generation of a C++ thunk in |
| 2750 | // `rs_api_impl` (i.e. exercises `format_cc_type`, |
| 2751 | // `format_cc_call_conv_as_clang_attribute` and similar code). |
| 2752 | let ir = ir_from_cc( |
| 2753 | r#" |
| 2754 | inline int (*inline_get_ptr_to_func())(float, double) [[clang::vectorcall]]; |
| 2755 | "#, |
| 2756 | )?; |
| 2757 | |
| 2758 | // Verify that the test input correctly represents what we intend to |
| 2759 | // test - we want [[clang::vectorcall]] to apply to the returned |
| 2760 | // function pointer, but *not* apply to the `get_ptr_to_func` function. |
| 2761 | assert_ir_matches!( |
| 2762 | ir, |
| 2763 | quote! { |
| 2764 | Func(Func { |
| 2765 | name: "inline_get_ptr_to_func", ... |
| 2766 | return_type: MappedType { |
| 2767 | rs_type: RsType { |
| 2768 | name: Some("Option"), ... |
| 2769 | type_args: [RsType { name: Some("#funcPtr vectorcall"), ... }], ... |
| 2770 | }, |
| 2771 | cc_type: CcType { |
| 2772 | name: Some("*"), ... |
| 2773 | type_args: [CcType { name: Some("#funcValue vectorcall"), ... }], ... |
| 2774 | }, |
| 2775 | }, ... |
| 2776 | has_c_calling_convention: true, ... |
| 2777 | }), |
| 2778 | } |
| 2779 | ); |
| 2780 | |
| 2781 | // This test is quite similar to `test_func_ptr_thunk` - the main |
| 2782 | // difference is verification of the `__attribute__((vectorcall))` in |
| 2783 | // the expected signature of the generated thunk below. |
| 2784 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 2785 | assert_cc_matches!( |
| 2786 | rs_api_impl, |
| 2787 | quote! { |
| 2788 | extern "C" rs_api_impl_support::type_identity_t< |
| 2789 | int(float , double) __attribute__((vectorcall)) |
| 2790 | >* __rust_thunk___Z22inline_get_ptr_to_funcv() { |
| 2791 | return inline_get_ptr_to_func(); |
| 2792 | } |
| 2793 | } |
| 2794 | ); |
| 2795 | Ok(()) |
| 2796 | } |
| 2797 | |
| 2798 | #[test] |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 2799 | fn test_item_order() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2800 | let ir = ir_from_cc( |
| 2801 | "int first_func(); |
| 2802 | struct FirstStruct {}; |
| 2803 | int second_func(); |
| 2804 | struct SecondStruct {};", |
| 2805 | )?; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 2806 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 2807 | let rs_api = rs_tokens_to_formatted_string(generate_rs_api(&ir)?)?; |
| 2808 | |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 2809 | let idx = |s: &str| rs_api.find(s).ok_or_else(|| anyhow!("'{}' missing", s)); |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 2810 | |
| 2811 | let f1 = idx("fn first_func")?; |
| 2812 | let f2 = idx("fn second_func")?; |
| 2813 | let s1 = idx("struct FirstStruct")?; |
| 2814 | let s2 = idx("struct SecondStruct")?; |
Googler | a675ae0 | 2021-12-07 08:04:59 +0000 | [diff] [blame] | 2815 | let t1 = idx("fn __rust_thunk___Z10first_funcv")?; |
| 2816 | let t2 = idx("fn __rust_thunk___Z11second_funcv")?; |
Michael Forster | ed64202 | 2021-10-04 09:48:25 +0000 | [diff] [blame] | 2817 | |
| 2818 | assert!(f1 < s1); |
| 2819 | assert!(s1 < f2); |
| 2820 | assert!(f2 < s2); |
| 2821 | assert!(s2 < t1); |
| 2822 | assert!(t1 < t2); |
| 2823 | |
| 2824 | Ok(()) |
| 2825 | } |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 2826 | |
| 2827 | #[test] |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2828 | fn test_base_class_subobject_layout() -> Result<()> { |
| 2829 | let ir = ir_from_cc( |
| 2830 | r#" |
| 2831 | // We use a class here to force `Derived::z` to live inside the tail padding of `Base`. |
| 2832 | // On the Itanium ABI, this would not happen if `Base` were a POD type. |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 2833 | class Base {__INT64_TYPE__ x; char y;}; |
| 2834 | struct Derived final : Base {__INT16_TYPE__ z;}; |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2835 | "#, |
| 2836 | )?; |
| 2837 | let rs_api = generate_rs_api(&ir)?; |
| 2838 | assert_rs_matches!( |
| 2839 | rs_api, |
| 2840 | quote! { |
| 2841 | #[repr(C, align(8))] |
| 2842 | pub struct Derived { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2843 | __base_class_subobjects: [rust_std::mem::MaybeUninit<u8>; 10], |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2844 | pub z: i16, |
| 2845 | } |
| 2846 | } |
| 2847 | ); |
| 2848 | Ok(()) |
| 2849 | } |
| 2850 | |
| 2851 | /// The same as test_base_class_subobject_layout, but with multiple |
| 2852 | /// inheritance. |
| 2853 | #[test] |
| 2854 | fn test_base_class_multiple_inheritance_subobject_layout() -> Result<()> { |
| 2855 | let ir = ir_from_cc( |
| 2856 | r#" |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 2857 | class Base1 {__INT64_TYPE__ x;}; |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2858 | class Base2 {char y;}; |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 2859 | struct Derived final : Base1, Base2 {__INT16_TYPE__ z;}; |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2860 | "#, |
| 2861 | )?; |
| 2862 | let rs_api = generate_rs_api(&ir)?; |
| 2863 | assert_rs_matches!( |
| 2864 | rs_api, |
| 2865 | quote! { |
| 2866 | #[repr(C, align(8))] |
| 2867 | pub struct Derived { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2868 | __base_class_subobjects: [rust_std::mem::MaybeUninit<u8>; 10], |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2869 | pub z: i16, |
| 2870 | } |
| 2871 | } |
| 2872 | ); |
| 2873 | Ok(()) |
| 2874 | } |
| 2875 | |
| 2876 | /// The same as test_base_class_subobject_layout, but with a chain of |
| 2877 | /// inheritance. |
| 2878 | #[test] |
| 2879 | fn test_base_class_deep_inheritance_subobject_layout() -> Result<()> { |
| 2880 | let ir = ir_from_cc( |
| 2881 | r#" |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 2882 | class Base1 {__INT64_TYPE__ x;}; |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2883 | class Base2 : Base1 {char y;}; |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 2884 | struct Derived final : Base2 {__INT16_TYPE__ z;}; |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2885 | "#, |
| 2886 | )?; |
| 2887 | let rs_api = generate_rs_api(&ir)?; |
| 2888 | assert_rs_matches!( |
| 2889 | rs_api, |
| 2890 | quote! { |
| 2891 | #[repr(C, align(8))] |
| 2892 | pub struct Derived { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2893 | __base_class_subobjects: [rust_std::mem::MaybeUninit<u8>; 10], |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2894 | pub z: i16, |
| 2895 | } |
| 2896 | } |
| 2897 | ); |
| 2898 | Ok(()) |
| 2899 | } |
| 2900 | |
| 2901 | /// For derived classes with no data members, we can't use the offset of the |
| 2902 | /// first member to determine the size of the base class subobjects. |
| 2903 | #[test] |
| 2904 | fn test_base_class_subobject_fieldless_layout() -> Result<()> { |
| 2905 | let ir = ir_from_cc( |
| 2906 | r#" |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 2907 | class Base {__INT64_TYPE__ x; char y;}; |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2908 | struct Derived final : Base {}; |
| 2909 | "#, |
| 2910 | )?; |
| 2911 | let rs_api = generate_rs_api(&ir)?; |
| 2912 | assert_rs_matches!( |
| 2913 | rs_api, |
| 2914 | quote! { |
| 2915 | #[repr(C, align(8))] |
| 2916 | pub struct Derived { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2917 | __base_class_subobjects: [rust_std::mem::MaybeUninit<u8>; 9], |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2918 | } |
| 2919 | } |
| 2920 | ); |
| 2921 | Ok(()) |
| 2922 | } |
| 2923 | |
| 2924 | #[test] |
| 2925 | fn test_base_class_subobject_empty_fieldless() -> Result<()> { |
| 2926 | let ir = ir_from_cc( |
| 2927 | r#" |
| 2928 | class Base {}; |
| 2929 | struct Derived final : Base {}; |
| 2930 | "#, |
| 2931 | )?; |
| 2932 | let rs_api = generate_rs_api(&ir)?; |
| 2933 | assert_rs_matches!( |
| 2934 | rs_api, |
| 2935 | quote! { |
| 2936 | #[repr(C)] |
| 2937 | pub struct Derived { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2938 | __base_class_subobjects: [rust_std::mem::MaybeUninit<u8>; 0], |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2939 | /// Prevent empty C++ struct being zero-size in Rust. |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2940 | placeholder: rust_std::mem::MaybeUninit<u8>, |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2941 | } |
| 2942 | } |
| 2943 | ); |
| 2944 | Ok(()) |
| 2945 | } |
| 2946 | |
| 2947 | #[test] |
| 2948 | fn test_base_class_subobject_empty() -> Result<()> { |
| 2949 | let ir = ir_from_cc( |
| 2950 | r#" |
| 2951 | class Base {}; |
| 2952 | struct Derived final : Base {}; |
| 2953 | "#, |
| 2954 | )?; |
| 2955 | let rs_api = generate_rs_api(&ir)?; |
| 2956 | assert_rs_matches!( |
| 2957 | rs_api, |
| 2958 | quote! { |
| 2959 | #[repr(C)] |
| 2960 | pub struct Derived { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2961 | __base_class_subobjects: [rust_std::mem::MaybeUninit<u8>; 0], |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2962 | /// Prevent empty C++ struct being zero-size in Rust. |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2963 | placeholder: rust_std::mem::MaybeUninit<u8>, |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 2964 | } |
| 2965 | } |
| 2966 | ); |
| 2967 | Ok(()) |
| 2968 | } |
| 2969 | |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 2970 | /// When a field is [[no_unique_address]], it occupies the space up to the |
| 2971 | /// next field. |
| 2972 | #[test] |
| 2973 | fn test_no_unique_address() -> Result<()> { |
| 2974 | let ir = ir_from_cc( |
| 2975 | r#" |
| 2976 | class Field1 {__INT64_TYPE__ x;}; |
| 2977 | class Field2 {char y;}; |
| 2978 | struct Struct final { |
| 2979 | [[no_unique_address]] Field1 field1; |
| 2980 | [[no_unique_address]] Field2 field2; |
| 2981 | __INT16_TYPE__ z; |
| 2982 | }; |
| 2983 | "#, |
| 2984 | )?; |
| 2985 | let rs_api = generate_rs_api(&ir)?; |
| 2986 | assert_rs_matches!( |
| 2987 | rs_api, |
| 2988 | quote! { |
| 2989 | #[derive(Clone, Copy)] |
| 2990 | #[repr(C, align(8))] |
| 2991 | pub struct Struct { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 2992 | field1: [rust_std::mem::MaybeUninit<u8>; 8], |
| 2993 | field2: [rust_std::mem::MaybeUninit<u8>; 2], |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 2994 | pub z: i16, |
| 2995 | } |
Devin Jeanpierre | 58181ac | 2022-02-14 21:30:05 +0000 | [diff] [blame] | 2996 | |
| 2997 | impl Struct { |
| 2998 | pub fn field1(&self) -> &Field1 { |
| 2999 | unsafe {&* (&self.field1 as *const _ as *const Field1)} |
| 3000 | } |
| 3001 | pub fn field2(&self) -> &Field2 { |
| 3002 | unsafe {&* (&self.field2 as *const _ as *const Field2)} |
| 3003 | } |
| 3004 | } |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 3005 | } |
| 3006 | ); |
| 3007 | Ok(()) |
| 3008 | } |
| 3009 | |
| 3010 | /// When a [[no_unique_address]] field is the last one, it occupies the rest |
| 3011 | /// of the object. |
| 3012 | #[test] |
| 3013 | fn test_no_unique_address_last_field() -> Result<()> { |
| 3014 | let ir = ir_from_cc( |
| 3015 | r#" |
| 3016 | class Field1 {__INT64_TYPE__ x;}; |
| 3017 | class Field2 {char y;}; |
| 3018 | struct Struct final { |
| 3019 | [[no_unique_address]] Field1 field1; |
| 3020 | [[no_unique_address]] Field2 field2; |
| 3021 | }; |
| 3022 | "#, |
| 3023 | )?; |
| 3024 | let rs_api = generate_rs_api(&ir)?; |
| 3025 | assert_rs_matches!( |
| 3026 | rs_api, |
| 3027 | quote! { |
| 3028 | #[derive(Clone, Copy)] |
| 3029 | #[repr(C, align(8))] |
| 3030 | pub struct Struct { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3031 | field1: [rust_std::mem::MaybeUninit<u8>; 8], |
| 3032 | field2: [rust_std::mem::MaybeUninit<u8>; 8], |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 3033 | } |
| 3034 | } |
| 3035 | ); |
| 3036 | Ok(()) |
| 3037 | } |
| 3038 | |
| 3039 | #[test] |
| 3040 | fn test_no_unique_address_empty() -> Result<()> { |
| 3041 | let ir = ir_from_cc( |
| 3042 | r#" |
| 3043 | class Field {}; |
| 3044 | struct Struct final { |
| 3045 | [[no_unique_address]] Field field; |
| 3046 | int x; |
| 3047 | }; |
| 3048 | "#, |
| 3049 | )?; |
| 3050 | let rs_api = generate_rs_api(&ir)?; |
| 3051 | assert_rs_matches!( |
| 3052 | rs_api, |
| 3053 | quote! { |
| 3054 | #[repr(C, align(4))] |
| 3055 | pub struct Struct { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3056 | field: [rust_std::mem::MaybeUninit<u8>; 0], |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 3057 | pub x: i32, |
| 3058 | } |
| 3059 | } |
| 3060 | ); |
| 3061 | Ok(()) |
| 3062 | } |
| 3063 | |
| 3064 | #[test] |
| 3065 | fn test_base_class_subobject_empty_last_field() -> Result<()> { |
| 3066 | let ir = ir_from_cc( |
| 3067 | r#" |
| 3068 | class Field {}; |
| 3069 | struct Struct final { |
| 3070 | [[no_unique_address]] Field field; |
| 3071 | }; |
| 3072 | "#, |
| 3073 | )?; |
| 3074 | let rs_api = generate_rs_api(&ir)?; |
| 3075 | assert_rs_matches!( |
| 3076 | rs_api, |
| 3077 | quote! { |
| 3078 | #[repr(C)] |
| 3079 | pub struct Struct { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3080 | field: [rust_std::mem::MaybeUninit<u8>; 1], |
Devin Jeanpierre | b69bcae | 2022-02-03 09:45:50 +0000 | [diff] [blame] | 3081 | } |
| 3082 | } |
| 3083 | ); |
| 3084 | Ok(()) |
| 3085 | } |
| 3086 | |
Devin Jeanpierre | c80e624 | 2022-02-03 01:56:40 +0000 | [diff] [blame] | 3087 | #[test] |
Teddy Katz | 76fa42b | 2022-02-23 01:22:56 +0000 | [diff] [blame] | 3088 | fn test_generate_enum_basic() -> Result<()> { |
| 3089 | let ir = ir_from_cc("enum Color { kRed = 5, kBlue };")?; |
| 3090 | let rs_api = generate_rs_api(&ir)?; |
| 3091 | assert_rs_matches!( |
| 3092 | rs_api, |
| 3093 | quote! { |
| 3094 | #[repr(transparent)] |
| 3095 | #[derive(Debug, PartialEq, Eq, Copy, Clone, Hash, PartialOrd, Ord)] |
| 3096 | pub struct Color(u32); |
| 3097 | impl Color { |
| 3098 | pub const kRed: Color = Color(5); |
| 3099 | pub const kBlue: Color = Color(6); |
| 3100 | } |
| 3101 | impl From<u32> for Color { |
| 3102 | fn from(value: u32) -> Color { |
| 3103 | Color(v) |
| 3104 | } |
| 3105 | } |
| 3106 | impl From<Color> for u32 { |
| 3107 | fn from(value: Color) -> u32 { |
| 3108 | v.0 |
| 3109 | } |
| 3110 | } |
| 3111 | } |
| 3112 | ); |
| 3113 | Ok(()) |
| 3114 | } |
| 3115 | |
| 3116 | #[test] |
| 3117 | fn test_generate_scoped_enum_basic() -> Result<()> { |
| 3118 | let ir = ir_from_cc("enum class Color { kRed = -5, kBlue };")?; |
| 3119 | let rs_api = generate_rs_api(&ir)?; |
| 3120 | assert_rs_matches!( |
| 3121 | rs_api, |
| 3122 | quote! { |
| 3123 | #[repr(transparent)] |
| 3124 | #[derive(Debug, PartialEq, Eq, Copy, Clone, Hash, PartialOrd, Ord)] |
| 3125 | pub struct Color(i32); |
| 3126 | impl Color { |
| 3127 | pub const kRed: Color = Color(-5); |
| 3128 | pub const kBlue: Color = Color(-4); |
| 3129 | } |
| 3130 | impl From<i32> for Color { |
| 3131 | fn from(value: i32) -> Color { |
| 3132 | Color(v) |
| 3133 | } |
| 3134 | } |
| 3135 | impl From<Color> for i32 { |
| 3136 | fn from(value: Color) -> i32 { |
| 3137 | v.0 |
| 3138 | } |
| 3139 | } |
| 3140 | } |
| 3141 | ); |
| 3142 | Ok(()) |
| 3143 | } |
| 3144 | |
| 3145 | #[test] |
| 3146 | fn test_generate_enum_with_64_bit_signed_vals() -> Result<()> { |
| 3147 | let ir = ir_from_cc( |
| 3148 | "enum Color : long { kViolet = -9223372036854775807 - 1LL, kRed = -5, kBlue, kGreen = 3, kMagenta = 9223372036854775807 };", |
| 3149 | )?; |
| 3150 | let rs_api = generate_rs_api(&ir)?; |
| 3151 | assert_rs_matches!( |
| 3152 | rs_api, |
| 3153 | quote! { |
| 3154 | #[repr(transparent)] |
| 3155 | #[derive(Debug, PartialEq, Eq, Copy, Clone, Hash, PartialOrd, Ord)] |
| 3156 | pub struct Color(i64); |
| 3157 | impl Color { |
| 3158 | pub const kViolet: Color = Color(-9223372036854775808); |
| 3159 | pub const kRed: Color = Color(-5); |
| 3160 | pub const kBlue: Color = Color(-4); |
| 3161 | pub const kGreen: Color = Color(3); |
| 3162 | pub const kMagenta: Color = Color(9223372036854775807); |
| 3163 | } |
| 3164 | impl From<i64> for Color { |
| 3165 | fn from(value: i64) -> Color { |
| 3166 | Color(v) |
| 3167 | } |
| 3168 | } |
| 3169 | impl From<Color> for i64 { |
| 3170 | fn from(value: Color) -> i64 { |
| 3171 | v.0 |
| 3172 | } |
| 3173 | } |
| 3174 | } |
| 3175 | ); |
| 3176 | Ok(()) |
| 3177 | } |
| 3178 | |
| 3179 | #[test] |
| 3180 | fn test_generate_enum_with_64_bit_unsigned_vals() -> Result<()> { |
| 3181 | let ir = ir_from_cc( |
| 3182 | "enum Color: unsigned long { kRed, kBlue, kLimeGreen = 18446744073709551615 };", |
| 3183 | )?; |
| 3184 | let rs_api = generate_rs_api(&ir)?; |
| 3185 | assert_rs_matches!( |
| 3186 | rs_api, |
| 3187 | quote! { |
| 3188 | #[repr(transparent)] |
| 3189 | #[derive(Debug, PartialEq, Eq, Copy, Clone, Hash, PartialOrd, Ord)] |
| 3190 | pub struct Color(u64); |
| 3191 | impl Color { |
| 3192 | pub const kRed: Color = Color(0); |
| 3193 | pub const kBlue: Color = Color(1); |
| 3194 | pub const kLimeGreen: Color = Color(18446744073709551615); |
| 3195 | } |
| 3196 | impl From<u64> for Color { |
| 3197 | fn from(value: u64) -> Color { |
| 3198 | Color(v) |
| 3199 | } |
| 3200 | } |
| 3201 | impl From<Color> for u64 { |
| 3202 | fn from(value: Color) -> u64 { |
| 3203 | v.0 |
| 3204 | } |
| 3205 | } |
| 3206 | } |
| 3207 | ); |
| 3208 | Ok(()) |
| 3209 | } |
| 3210 | |
| 3211 | #[test] |
| 3212 | fn test_generate_enum_with_32_bit_signed_vals() -> Result<()> { |
| 3213 | let ir = ir_from_cc( |
| 3214 | "enum Color { kViolet = -2147483647 - 1, kRed = -5, kBlue, kGreen = 3, kMagenta = 2147483647 };", |
| 3215 | )?; |
| 3216 | let rs_api = generate_rs_api(&ir)?; |
| 3217 | assert_rs_matches!( |
| 3218 | rs_api, |
| 3219 | quote! { |
| 3220 | #[repr(transparent)] |
| 3221 | #[derive(Debug, PartialEq, Eq, Copy, Clone, Hash, PartialOrd, Ord)] |
| 3222 | pub struct Color(i32); |
| 3223 | impl Color { |
| 3224 | pub const kViolet: Color = Color(-2147483648); |
| 3225 | pub const kRed: Color = Color(-5); |
| 3226 | pub const kBlue: Color = Color(-4); |
| 3227 | pub const kGreen: Color = Color(3); |
| 3228 | pub const kMagenta: Color = Color(2147483647); |
| 3229 | } |
| 3230 | impl From<i32> for Color { |
| 3231 | fn from(value: i32) -> Color { |
| 3232 | Color(v) |
| 3233 | } |
| 3234 | } |
| 3235 | impl From<Color> for i32 { |
| 3236 | fn from(value: Color) -> i32 { |
| 3237 | v.0 |
| 3238 | } |
| 3239 | } |
| 3240 | } |
| 3241 | ); |
| 3242 | Ok(()) |
| 3243 | } |
| 3244 | |
| 3245 | #[test] |
| 3246 | fn test_generate_enum_with_32_bit_unsigned_vals() -> Result<()> { |
| 3247 | let ir = ir_from_cc("enum Color: unsigned int { kRed, kBlue, kLimeGreen = 4294967295 };")?; |
| 3248 | let rs_api = generate_rs_api(&ir)?; |
| 3249 | assert_rs_matches!( |
| 3250 | rs_api, |
| 3251 | quote! { |
| 3252 | #[repr(transparent)] |
| 3253 | #[derive(Debug, PartialEq, Eq, Copy, Clone, Hash, PartialOrd, Ord)] |
| 3254 | pub struct Color(u32); |
| 3255 | impl Color { |
| 3256 | pub const kRed: Color = Color(0); |
| 3257 | pub const kBlue: Color = Color(1); |
| 3258 | pub const kLimeGreen: Color = Color(4294967295); |
| 3259 | } |
| 3260 | impl From<u32> for Color { |
| 3261 | fn from(value: u32) -> Color { |
| 3262 | Color(v) |
| 3263 | } |
| 3264 | } |
| 3265 | impl From<Color> for u32 { |
| 3266 | fn from(value: Color) -> u32 { |
| 3267 | v.0 |
| 3268 | } |
| 3269 | } |
| 3270 | } |
| 3271 | ); |
| 3272 | Ok(()) |
| 3273 | } |
| 3274 | |
| 3275 | #[test] |
Michael Forster | 409d941 | 2021-10-07 08:35:29 +0000 | [diff] [blame] | 3276 | fn test_doc_comment_func() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 3277 | let ir = ir_from_cc( |
| 3278 | " |
| 3279 | // Doc Comment |
| 3280 | // with two lines |
| 3281 | int func();", |
| 3282 | )?; |
Michael Forster | 409d941 | 2021-10-07 08:35:29 +0000 | [diff] [blame] | 3283 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 3284 | assert_rs_matches!( |
| 3285 | generate_rs_api(&ir)?, |
| 3286 | // leading space is intentional so there is a space between /// and the text of the |
| 3287 | // comment |
| 3288 | quote! { |
| 3289 | #[doc = " Doc Comment\n with two lines"] |
| 3290 | #[inline(always)] |
| 3291 | pub fn func |
| 3292 | } |
Michael Forster | 409d941 | 2021-10-07 08:35:29 +0000 | [diff] [blame] | 3293 | ); |
| 3294 | |
| 3295 | Ok(()) |
| 3296 | } |
| 3297 | |
| 3298 | #[test] |
| 3299 | fn test_doc_comment_record() -> Result<()> { |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 3300 | let ir = ir_from_cc( |
| 3301 | "// Doc Comment\n\ |
| 3302 | //\n\ |
| 3303 | // * with bullet\n\ |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 3304 | struct SomeStruct final {\n\ |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 3305 | // Field doc\n\ |
| 3306 | int field;\ |
| 3307 | };", |
| 3308 | )?; |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 3309 | |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 3310 | assert_rs_matches!( |
| 3311 | generate_rs_api(&ir)?, |
| 3312 | quote! { |
| 3313 | #[doc = " Doc Comment\n \n * with bullet"] |
| 3314 | #[derive(Clone, Copy)] |
| 3315 | #[repr(C)] |
| 3316 | pub struct SomeStruct { |
| 3317 | # [doc = " Field doc"] |
| 3318 | pub field: i32, |
| 3319 | } |
| 3320 | } |
Michael Forster | cc5941a | 2021-10-07 07:12:24 +0000 | [diff] [blame] | 3321 | ); |
Michael Forster | 028800b | 2021-10-05 12:39:59 +0000 | [diff] [blame] | 3322 | Ok(()) |
| 3323 | } |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 3324 | |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 3325 | #[test] |
Teddy Katz | d2cd142 | 2022-04-04 09:41:33 -0700 | [diff] [blame] | 3326 | fn test_basic_union() -> Result<()> { |
| 3327 | let ir = ir_from_cc( |
| 3328 | r#" |
| 3329 | union SomeUnion { |
| 3330 | int some_field; |
| 3331 | long long some_bigger_field; |
| 3332 | }; |
| 3333 | "#, |
| 3334 | )?; |
| 3335 | let rs_api = generate_rs_api(&ir)?; |
| 3336 | |
| 3337 | assert_rs_matches!( |
| 3338 | rs_api, |
| 3339 | quote! { |
| 3340 | #[derive(Clone, Copy)] |
| 3341 | #[repr(C)] |
| 3342 | pub union SomeUnion { |
| 3343 | pub some_field: i32, |
| 3344 | pub some_bigger_field: i64, |
| 3345 | } |
| 3346 | } |
| 3347 | ); |
| 3348 | Ok(()) |
| 3349 | } |
| 3350 | |
| 3351 | #[test] |
| 3352 | fn test_union_with_private_fields() -> Result<()> { |
| 3353 | let ir = ir_from_cc( |
| 3354 | r#" |
| 3355 | union SomeUnionWithPrivateFields { |
| 3356 | public: |
| 3357 | int public_field; |
| 3358 | private: |
| 3359 | long long private_field; |
| 3360 | }; |
| 3361 | "#, |
| 3362 | )?; |
| 3363 | let rs_api = generate_rs_api(&ir)?; |
| 3364 | |
| 3365 | assert_rs_matches!( |
| 3366 | rs_api, |
| 3367 | quote! { |
| 3368 | #[derive(Clone, Copy)] |
| 3369 | #[repr(C)] |
| 3370 | pub union SomeUnionWithPrivateFields { |
| 3371 | pub public_field: i32, |
| 3372 | private_field: i64, |
| 3373 | } |
| 3374 | } |
| 3375 | ); |
| 3376 | |
| 3377 | assert_rs_matches!( |
| 3378 | rs_api, |
| 3379 | quote! { |
| 3380 | const _: () = assert!(rust_std::mem::size_of::<SomeUnionWithPrivateFields>() == 8usize); |
| 3381 | const _: () = assert!(rust_std::mem::align_of::<SomeUnionWithPrivateFields>() == 8usize); |
| 3382 | const _: () = { |
| 3383 | assert_impl_all!(SomeUnionWithPrivateFields: Clone); |
| 3384 | }; |
| 3385 | const _: () = { |
| 3386 | assert_impl_all!(SomeUnionWithPrivateFields: Copy); |
| 3387 | }; |
| 3388 | const _: () = { |
| 3389 | assert_not_impl_all!(SomeUnionWithPrivateFields: Drop); |
| 3390 | }; |
| 3391 | const _: () = assert!(offset_of!(SomeUnionWithPrivateFields, public_field) * 8 == 0usize); |
| 3392 | const _: () = assert!(offset_of!(SomeUnionWithPrivateFields, private_field) * 8 == 0usize); |
| 3393 | } |
| 3394 | ); |
| 3395 | Ok(()) |
| 3396 | } |
| 3397 | |
| 3398 | #[test] |
| 3399 | fn test_empty_union() -> Result<()> { |
| 3400 | let ir = ir_from_cc( |
| 3401 | r#" |
| 3402 | union EmptyUnion {}; |
| 3403 | "#, |
| 3404 | )?; |
| 3405 | let rs_api = generate_rs_api(&ir)?; |
| 3406 | |
| 3407 | assert_rs_matches!( |
| 3408 | rs_api, |
| 3409 | quote! { |
| 3410 | #[derive(Clone, Copy)] |
| 3411 | #[repr(C)] |
| 3412 | pub union EmptyUnion { |
| 3413 | /// Prevent empty C++ struct being zero-size in Rust. |
| 3414 | placeholder: rust_std::mem::MaybeUninit<u8>, |
| 3415 | } |
| 3416 | } |
| 3417 | ); |
| 3418 | |
| 3419 | assert_rs_matches!( |
| 3420 | rs_api, |
| 3421 | quote! { |
| 3422 | const _: () = assert!(rust_std::mem::size_of::<EmptyUnion>() == 1usize); |
| 3423 | const _: () = assert!(rust_std::mem::align_of::<EmptyUnion>() == 1usize); |
| 3424 | } |
| 3425 | ); |
| 3426 | |
| 3427 | Ok(()) |
| 3428 | } |
| 3429 | |
| 3430 | #[test] |
| 3431 | fn test_union_field_with_nontrivial_destructor() -> Result<()> { |
| 3432 | let ir = ir_from_cc( |
| 3433 | r#" |
| 3434 | struct NontrivialStruct { ~NontrivialStruct(); }; |
| 3435 | union UnionWithNontrivialField { |
| 3436 | int trivial_field; |
| 3437 | NontrivialStruct nontrivial_field; |
| 3438 | }; |
| 3439 | "#, |
| 3440 | )?; |
| 3441 | let rs_api = generate_rs_api(&ir)?; |
| 3442 | |
| 3443 | assert_rs_matches!( |
| 3444 | rs_api, |
| 3445 | quote! { |
| 3446 | #[derive(Clone, Copy)] |
| 3447 | #[repr(C)] |
| 3448 | pub union UnionWithNontrivialField { |
| 3449 | pub trivial_field: i32, |
| 3450 | pub nontrivial_field: rust_std::mem::ManuallyDrop<NontrivialStruct>, |
| 3451 | } |
| 3452 | } |
| 3453 | ); |
| 3454 | |
| 3455 | assert_rs_matches!( |
| 3456 | rs_api, |
| 3457 | quote! { |
| 3458 | const _: () = assert!(rust_std::mem::size_of::<UnionWithNontrivialField>() == 4usize); |
| 3459 | const _: () = assert!(rust_std::mem::align_of::<UnionWithNontrivialField>() == 4usize); |
| 3460 | } |
| 3461 | ); |
| 3462 | Ok(()) |
| 3463 | } |
| 3464 | |
| 3465 | #[test] |
| 3466 | fn test_union_with_constructors() -> Result<()> { |
| 3467 | let ir = ir_from_cc( |
| 3468 | r#" |
| 3469 | #pragma clang lifetime_elision |
| 3470 | union UnionWithDefaultConstructors { |
| 3471 | int a; |
| 3472 | }; |
| 3473 | "#, |
| 3474 | )?; |
| 3475 | let rs_api = generate_rs_api(&ir)?; |
| 3476 | |
| 3477 | assert_rs_matches!( |
| 3478 | rs_api, |
| 3479 | quote! { |
| 3480 | #[derive(Clone, Copy)] |
| 3481 | #[repr(C)] |
| 3482 | pub union UnionWithDefaultConstructors { |
| 3483 | pub a: i32, |
| 3484 | } |
| 3485 | } |
| 3486 | ); |
| 3487 | |
| 3488 | assert_rs_matches!( |
| 3489 | rs_api, |
| 3490 | quote! { |
| 3491 | impl Default for UnionWithDefaultConstructors { |
| 3492 | #[inline(always)] |
| 3493 | fn default() -> Self { |
| 3494 | let mut tmp = rust_std::mem::MaybeUninit::<Self>::zeroed(); |
| 3495 | unsafe { |
| 3496 | crate::detail::__rust_thunk___ZN28UnionWithDefaultConstructorsC1Ev(&mut tmp); |
| 3497 | tmp.assume_init() |
| 3498 | } |
| 3499 | } |
| 3500 | } |
| 3501 | } |
| 3502 | ); |
| 3503 | |
| 3504 | assert_rs_matches!( |
| 3505 | rs_api, |
| 3506 | quote! { |
| 3507 | impl<'b> From<ctor::RvalueReference<'b, UnionWithDefaultConstructors>> for UnionWithDefaultConstructors { |
| 3508 | #[inline(always)] |
| 3509 | fn from(__param_0: ctor::RvalueReference<'b, UnionWithDefaultConstructors>) -> Self { |
| 3510 | let mut tmp = rust_std::mem::MaybeUninit::<Self>::zeroed(); |
| 3511 | unsafe { |
| 3512 | crate::detail::__rust_thunk___ZN28UnionWithDefaultConstructorsC1EOS_(&mut tmp, __param_0); |
| 3513 | tmp.assume_init() |
| 3514 | } |
| 3515 | } |
| 3516 | } |
| 3517 | } |
| 3518 | ); |
| 3519 | |
| 3520 | Ok(()) |
| 3521 | } |
| 3522 | |
| 3523 | #[test] |
Devin Jeanpierre | 5677702 | 2022-02-03 01:57:15 +0000 | [diff] [blame] | 3524 | fn test_unambiguous_public_bases() -> Result<()> { |
| 3525 | let ir = ir_from_cc_dependency( |
| 3526 | " |
| 3527 | struct VirtualBase {}; |
| 3528 | struct PrivateBase {}; |
| 3529 | struct ProtectedBase {}; |
| 3530 | struct UnambiguousPublicBase {}; |
| 3531 | struct AmbiguousPublicBase {}; |
| 3532 | struct MultipleInheritance : UnambiguousPublicBase, AmbiguousPublicBase {}; |
| 3533 | struct Derived : private PrivateBase, protected ProtectedBase, MultipleInheritance, AmbiguousPublicBase, virtual VirtualBase {}; |
| 3534 | ", |
| 3535 | "", |
| 3536 | )?; |
| 3537 | let rs_api = generate_rs_api(&ir)?; |
| 3538 | // TODO(b/216195042): virtual bases. |
| 3539 | assert_rs_not_matches!(rs_api, quote! { From<&'a Derived> for &'a VirtualBase }); |
| 3540 | assert_rs_matches!(rs_api, quote! { From<&'a Derived> for &'a UnambiguousPublicBase }); |
| 3541 | assert_rs_matches!(rs_api, quote! { From<&'a Derived> for &'a MultipleInheritance }); |
| 3542 | assert_rs_not_matches!(rs_api, quote! {From<&'a Derived> for &'a PrivateBase}); |
| 3543 | assert_rs_not_matches!(rs_api, quote! {From<&'a Derived> for &'a ProtectedBase}); |
| 3544 | assert_rs_not_matches!(rs_api, quote! {From<&'a Derived> for &'a AmbiguousPublicBase}); |
| 3545 | Ok(()) |
| 3546 | } |
| 3547 | |
| 3548 | /// Contrary to intuitions: a base class conversion is ambiguous even if the |
| 3549 | /// ambiguity is from a private base class cast that you can't even |
| 3550 | /// perform. |
| 3551 | /// |
| 3552 | /// Explanation (courtesy James Dennett): |
| 3553 | /// |
| 3554 | /// > Once upon a time, there was a rule in C++ that changing all access |
| 3555 | /// > specifiers to "public" would not change the meaning of code. |
| 3556 | /// > That's no longer true, but some of its effects can still be seen. |
| 3557 | /// |
| 3558 | /// So, we need to be sure to not allow casting to privately-ambiguous |
| 3559 | /// bases. |
| 3560 | #[test] |
| 3561 | fn test_unambiguous_public_bases_private_ambiguity() -> Result<()> { |
| 3562 | let ir = ir_from_cc_dependency( |
| 3563 | " |
| 3564 | struct Base {}; |
| 3565 | struct Intermediate : public Base {}; |
| 3566 | struct Derived : Base, private Intermediate {}; |
| 3567 | ", |
| 3568 | "", |
| 3569 | )?; |
| 3570 | let rs_api = generate_rs_api(&ir)?; |
| 3571 | assert_rs_not_matches!(rs_api, quote! { From<&'a Derived> for &'a Base }); |
| 3572 | Ok(()) |
| 3573 | } |
| 3574 | |
| 3575 | #[test] |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 3576 | fn test_virtual_thunk() -> Result<()> { |
| 3577 | let ir = ir_from_cc("struct Polymorphic { virtual void Foo(); };")?; |
| 3578 | |
| 3579 | assert_cc_matches!( |
| 3580 | generate_rs_api_impl(&ir)?, |
| 3581 | quote! { |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 3582 | extern "C" void __rust_thunk___ZN11Polymorphic3FooEv(class Polymorphic * __this) |
Devin Jeanpierre | 96839c1 | 2021-12-14 00:27:38 +0000 | [diff] [blame] | 3583 | } |
| 3584 | ); |
| 3585 | Ok(()) |
| 3586 | } |
| 3587 | |
Lukasz Anforowicz | 0b6a6ac | 2022-03-22 22:32:23 +0000 | [diff] [blame] | 3588 | #[test] |
| 3589 | fn test_custom_abi_thunk() -> Result<()> { |
| 3590 | let ir = ir_from_cc( |
| 3591 | r#" |
| 3592 | float f_vectorcall_calling_convention(float p1, float p2) [[clang::vectorcall]]; |
| 3593 | double f_c_calling_convention(double p1, double p2); |
| 3594 | "#, |
| 3595 | )?; |
| 3596 | let rs_api = generate_rs_api(&ir)?; |
| 3597 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 3598 | assert_rs_matches!( |
| 3599 | rs_api, |
| 3600 | quote! { |
| 3601 | #[inline(always)] |
| 3602 | pub fn f_vectorcall_calling_convention(p1: f32, p2: f32) -> f32 { |
| 3603 | unsafe { |
| 3604 | crate::detail::__rust_thunk___Z31f_vectorcall_calling_conventionff(p1, p2) |
| 3605 | } |
| 3606 | } |
| 3607 | } |
| 3608 | ); |
| 3609 | assert_rs_matches!( |
| 3610 | rs_api, |
| 3611 | quote! { |
| 3612 | #[inline(always)] |
| 3613 | pub fn f_c_calling_convention(p1: f64, p2: f64) -> f64 { |
| 3614 | unsafe { crate::detail::__rust_thunk___Z22f_c_calling_conventiondd(p1, p2) } |
| 3615 | } |
| 3616 | } |
| 3617 | ); |
| 3618 | // `link_name` (i.e. no thunk) for `f_c_calling_convention`. No |
| 3619 | // `link_name` (i.e. indicates presence of a thunk) for |
| 3620 | // `f_vectorcall_calling_convention`. |
| 3621 | assert_rs_matches!( |
| 3622 | rs_api, |
| 3623 | quote! { |
| 3624 | mod detail { |
| 3625 | #[allow(unused_imports)] |
| 3626 | use super::*; |
| 3627 | extern "C" { |
| 3628 | pub(crate) fn __rust_thunk___Z31f_vectorcall_calling_conventionff( |
| 3629 | p1: f32, p2: f32) -> f32; |
| 3630 | #[link_name = "_Z22f_c_calling_conventiondd"] |
| 3631 | pub(crate) fn __rust_thunk___Z22f_c_calling_conventiondd( |
| 3632 | p1: f64, p2: f64) -> f64; |
| 3633 | } |
| 3634 | } |
| 3635 | } |
| 3636 | ); |
| 3637 | // C++ thunk needed for `f_vectorcall_calling_convention`. |
| 3638 | assert_cc_matches!( |
| 3639 | rs_api_impl, |
| 3640 | quote! { |
| 3641 | extern "C" float __rust_thunk___Z31f_vectorcall_calling_conventionff( |
| 3642 | float p1, float p2) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 3643 | return f_vectorcall_calling_convention (std::forward<decltype(p1)>(p1), std::forward<decltype(p2)>(p2)); |
Lukasz Anforowicz | 0b6a6ac | 2022-03-22 22:32:23 +0000 | [diff] [blame] | 3644 | } |
| 3645 | } |
| 3646 | ); |
| 3647 | // No C++ thunk expected for `f_c_calling_convention`. |
| 3648 | assert_cc_not_matches!(rs_api_impl, quote! { f_c_calling_convention }); |
| 3649 | Ok(()) |
| 3650 | } |
| 3651 | |
Devin Jeanpierre | e6e1665 | 2021-12-22 15:54:46 +0000 | [diff] [blame] | 3652 | /// A trivially relocatable final struct is safe to use in Rust as normal, |
| 3653 | /// and is Unpin. |
| 3654 | #[test] |
| 3655 | fn test_no_negative_impl_unpin() -> Result<()> { |
| 3656 | let ir = ir_from_cc("struct Trivial final {};")?; |
| 3657 | let rs_api = generate_rs_api(&ir)?; |
| 3658 | assert_rs_not_matches!(rs_api, quote! {impl !Unpin}); |
| 3659 | Ok(()) |
| 3660 | } |
| 3661 | |
| 3662 | /// A non-final struct, even if it's trivial, is not usable by mut |
| 3663 | /// reference, and so is !Unpin. |
| 3664 | #[test] |
| 3665 | fn test_negative_impl_unpin_nonfinal() -> Result<()> { |
| 3666 | let ir = ir_from_cc("struct Nonfinal {};")?; |
| 3667 | let rs_api = generate_rs_api(&ir)?; |
| 3668 | assert_rs_matches!(rs_api, quote! {impl !Unpin for Nonfinal {}}); |
| 3669 | Ok(()) |
| 3670 | } |
| 3671 | |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 3672 | /// At the least, a trivial type should have no drop impl if or until we add |
| 3673 | /// empty drop impls. |
| 3674 | #[test] |
| 3675 | fn test_no_impl_drop() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 3676 | let ir = ir_from_cc("struct Trivial {};")?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 3677 | let rs_api = rs_tokens_to_formatted_string(generate_rs_api(&ir)?)?; |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 3678 | assert!(!rs_api.contains("impl Drop")); |
| 3679 | Ok(()) |
| 3680 | } |
| 3681 | |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3682 | /// User-defined destructors *must* become Drop impls with ManuallyDrop |
| 3683 | /// fields |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 3684 | #[test] |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3685 | fn test_impl_drop_user_defined_destructor() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 3686 | let ir = ir_from_cc( |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 3687 | r#" struct NontrivialStruct { ~NontrivialStruct(); }; |
| 3688 | struct UserDefinedDestructor { |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 3689 | ~UserDefinedDestructor(); |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3690 | int x; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 3691 | NontrivialStruct nts; |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 3692 | };"#, |
| 3693 | )?; |
| 3694 | let rs_api = generate_rs_api(&ir)?; |
Lukasz Anforowicz | 6d55363 | 2022-01-06 21:36:14 +0000 | [diff] [blame] | 3695 | assert_rs_matches!( |
| 3696 | rs_api, |
| 3697 | quote! { |
| 3698 | impl Drop for UserDefinedDestructor { |
| 3699 | #[inline(always)] |
| 3700 | fn drop(&mut self) { |
| 3701 | unsafe { crate::detail::__rust_thunk___ZN21UserDefinedDestructorD1Ev(self) } |
| 3702 | } |
| 3703 | } |
| 3704 | } |
| 3705 | ); |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 3706 | assert_rs_matches!(rs_api, quote! {pub x: i32,}); |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3707 | assert_rs_matches!( |
| 3708 | rs_api, |
| 3709 | quote! {pub nts: rust_std::mem::ManuallyDrop<NontrivialStruct>,} |
| 3710 | ); |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3711 | Ok(()) |
| 3712 | } |
| 3713 | |
Lukasz Anforowicz | 6d55363 | 2022-01-06 21:36:14 +0000 | [diff] [blame] | 3714 | /// nontrivial types without user-defined destructors should invoke |
| 3715 | /// the C++ destructor to preserve the order of field destructions. |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3716 | #[test] |
| 3717 | fn test_impl_drop_nontrivial_member_destructor() -> Result<()> { |
| 3718 | // TODO(jeanpierreda): This would be cleaner if the UserDefinedDestructor code were |
| 3719 | // omitted. For example, we simulate it so that UserDefinedDestructor |
| 3720 | // comes from another library. |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 3721 | let ir = ir_from_cc( |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 3722 | r#"struct UserDefinedDestructor final { |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3723 | ~UserDefinedDestructor(); |
| 3724 | }; |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 3725 | struct TrivialStruct final { int i; }; |
| 3726 | struct NontrivialMembers final { |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3727 | UserDefinedDestructor udd; |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 3728 | TrivialStruct ts; |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3729 | int x; |
| 3730 | };"#, |
| 3731 | )?; |
| 3732 | let rs_api = generate_rs_api(&ir)?; |
Lukasz Anforowicz | 6d55363 | 2022-01-06 21:36:14 +0000 | [diff] [blame] | 3733 | assert_rs_matches!( |
| 3734 | rs_api, |
| 3735 | quote! { |
| 3736 | impl Drop for NontrivialMembers { |
| 3737 | #[inline(always)] |
| 3738 | fn drop(&mut self) { |
| 3739 | unsafe { crate::detail::__rust_thunk___ZN17NontrivialMembersD1Ev(self) } |
| 3740 | } |
| 3741 | } |
| 3742 | } |
| 3743 | ); |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 3744 | assert_rs_matches!(rs_api, quote! {pub x: i32,}); |
| 3745 | assert_rs_matches!(rs_api, quote! {pub ts: TrivialStruct,}); |
Lukasz Anforowicz | 6d55363 | 2022-01-06 21:36:14 +0000 | [diff] [blame] | 3746 | assert_rs_matches!( |
| 3747 | rs_api, |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3748 | quote! {pub udd: rust_std::mem::ManuallyDrop<UserDefinedDestructor>,} |
Lukasz Anforowicz | 6d55363 | 2022-01-06 21:36:14 +0000 | [diff] [blame] | 3749 | ); |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3750 | Ok(()) |
| 3751 | } |
| 3752 | |
| 3753 | /// Trivial types (at least those that are mapped to Copy rust types) do not |
| 3754 | /// get a Drop impl. |
| 3755 | #[test] |
| 3756 | fn test_impl_drop_trivial() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 3757 | let ir = ir_from_cc( |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 3758 | r#"struct Trivial final { |
Devin Jeanpierre | 7e9a1de | 2021-12-03 08:04:22 +0000 | [diff] [blame] | 3759 | ~Trivial() = default; |
| 3760 | int x; |
| 3761 | };"#, |
| 3762 | )?; |
| 3763 | let rs_api = generate_rs_api(&ir)?; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 3764 | assert_rs_not_matches!(rs_api, quote! {impl Drop}); |
| 3765 | assert_rs_matches!(rs_api, quote! {pub x: i32}); |
Lukasz Anforowicz | 2f07416 | 2022-01-06 22:50:51 +0000 | [diff] [blame] | 3766 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 3767 | // TODO(b/213326125): Avoid generating thunk impls that are never called. |
| 3768 | // (The test assertion below should be reversed once this bug is fixed.) |
| 3769 | assert_cc_matches!(rs_api_impl, quote! { std::destroy_at }); |
Devin Jeanpierre | 91de701 | 2021-10-21 12:53:51 +0000 | [diff] [blame] | 3770 | Ok(()) |
| 3771 | } |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 3772 | |
| 3773 | #[test] |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 3774 | fn test_impl_default_explicitly_defaulted_constructor() -> Result<()> { |
| 3775 | let ir = ir_from_cc( |
Lukasz Anforowicz | 9555127 | 2022-01-20 00:02:24 +0000 | [diff] [blame] | 3776 | r#"#pragma clang lifetime_elision |
| 3777 | struct DefaultedConstructor final { |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 3778 | DefaultedConstructor() = default; |
| 3779 | };"#, |
| 3780 | )?; |
| 3781 | let rs_api = generate_rs_api(&ir)?; |
| 3782 | assert_rs_matches!( |
| 3783 | rs_api, |
| 3784 | quote! { |
| 3785 | impl Default for DefaultedConstructor { |
| 3786 | #[inline(always)] |
| 3787 | fn default() -> Self { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3788 | let mut tmp = rust_std::mem::MaybeUninit::<Self>::zeroed(); |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 3789 | unsafe { |
Lukasz Anforowicz | 40c2eb8 | 2022-01-11 18:22:31 +0000 | [diff] [blame] | 3790 | crate::detail::__rust_thunk___ZN20DefaultedConstructorC1Ev(&mut tmp); |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 3791 | tmp.assume_init() |
| 3792 | } |
| 3793 | } |
| 3794 | } |
| 3795 | } |
| 3796 | ); |
| 3797 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 3798 | assert_cc_matches!( |
| 3799 | rs_api_impl, |
| 3800 | quote! { |
| 3801 | extern "C" void __rust_thunk___ZN20DefaultedConstructorC1Ev( |
Googler | 972d358 | 2022-01-11 10:17:22 +0000 | [diff] [blame] | 3802 | class DefaultedConstructor* __this) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 3803 | rs_api_impl_support::construct_at (std::forward<decltype(__this)>(__this)) ; |
Lukasz Anforowicz | e643ec9 | 2021-12-22 15:45:15 +0000 | [diff] [blame] | 3804 | } |
| 3805 | } |
| 3806 | ); |
| 3807 | Ok(()) |
| 3808 | } |
| 3809 | |
| 3810 | #[test] |
Lukasz Anforowicz | 326c4e4 | 2022-01-27 14:43:00 +0000 | [diff] [blame] | 3811 | fn test_impl_clone_that_propagates_lifetime() -> Result<()> { |
| 3812 | // This test covers the case where a single lifetime applies to 1) |
| 3813 | // the `__this` parameter and 2) other constructor parameters. For |
| 3814 | // example, maybe the newly constructed object needs to have the |
| 3815 | // same lifetime as the constructor's parameter. (This might require |
| 3816 | // annotating the whole C++ struct with a lifetime, so maybe the |
| 3817 | // example below is not fully realistic/accurate...). |
| 3818 | let mut ir = ir_from_cc( |
| 3819 | r#"#pragma clang lifetime_elision |
| 3820 | struct Foo final { |
Googler | 53f6594 | 2022-02-23 11:23:30 +0000 | [diff] [blame] | 3821 | [[clang::annotate("lifetimes", "a: a")]] |
Lukasz Anforowicz | 326c4e4 | 2022-01-27 14:43:00 +0000 | [diff] [blame] | 3822 | Foo(const int& i); |
| 3823 | };"#, |
| 3824 | )?; |
| 3825 | let ctor: &mut Func = ir |
| 3826 | .items_mut() |
| 3827 | .filter_map(|item| match item { |
| 3828 | Item::Func(func) => Some(func), |
| 3829 | _ => None, |
| 3830 | }) |
| 3831 | .find(|f| { |
| 3832 | matches!(&f.name, UnqualifiedIdentifier::Constructor) |
| 3833 | && f.params.get(1).map(|p| p.identifier.identifier == "i").unwrap_or_default() |
| 3834 | }) |
| 3835 | .unwrap(); |
| 3836 | { |
| 3837 | // Double-check that the test scenario set up above uses the same lifetime |
| 3838 | // for both of the constructor's parameters: `__this` and `i`. |
| 3839 | assert_eq!(ctor.params.len(), 2); |
| 3840 | let this_lifetime: LifetimeId = |
| 3841 | *ctor.params[0].type_.rs_type.lifetime_args.first().unwrap(); |
| 3842 | let i_lifetime: LifetimeId = |
| 3843 | *ctor.params[1].type_.rs_type.lifetime_args.first_mut().unwrap(); |
| 3844 | assert_eq!(i_lifetime, this_lifetime); |
| 3845 | } |
| 3846 | |
| 3847 | // Before cl/423346348 the generated Rust code would incorrectly look |
| 3848 | // like this (note the mismatched 'a and 'b lifetimes): |
| 3849 | // fn from<'b>(i: &'a i32) -> Self |
| 3850 | // After this CL, this scenario will result in an explicit error. |
Devin Jeanpierre | d7b4810 | 2022-03-31 04:15:03 -0700 | [diff] [blame] | 3851 | let rs_api = generate_rs_api(&ir)?; |
| 3852 | assert_rs_not_matches!(rs_api, quote! {impl From}); |
| 3853 | let rs_api_str = tokens_to_string(rs_api)?; |
| 3854 | assert!(rs_api_str.contains( |
| 3855 | "// The lifetime of `__this` is unexpectedly also used by another parameter" |
| 3856 | )); |
Lukasz Anforowicz | 326c4e4 | 2022-01-27 14:43:00 +0000 | [diff] [blame] | 3857 | Ok(()) |
| 3858 | } |
| 3859 | |
| 3860 | #[test] |
Lukasz Anforowicz | 9bab835 | 2021-12-22 17:35:31 +0000 | [diff] [blame] | 3861 | fn test_impl_default_non_trivial_struct() -> Result<()> { |
| 3862 | let ir = ir_from_cc( |
Lukasz Anforowicz | 71716b7 | 2022-01-26 17:05:05 +0000 | [diff] [blame] | 3863 | r#"#pragma clang lifetime_elision |
| 3864 | struct NonTrivialStructWithConstructors final { |
Lukasz Anforowicz | 9bab835 | 2021-12-22 17:35:31 +0000 | [diff] [blame] | 3865 | NonTrivialStructWithConstructors(); |
| 3866 | ~NonTrivialStructWithConstructors(); // Non-trivial |
| 3867 | };"#, |
| 3868 | )?; |
| 3869 | let rs_api = generate_rs_api(&ir)?; |
| 3870 | assert_rs_not_matches!(rs_api, quote! {impl Default}); |
| 3871 | Ok(()) |
| 3872 | } |
| 3873 | |
| 3874 | #[test] |
Lukasz Anforowicz | 71716b7 | 2022-01-26 17:05:05 +0000 | [diff] [blame] | 3875 | fn test_impl_from_for_explicit_conversion_constructor() -> Result<()> { |
| 3876 | let ir = ir_from_cc( |
| 3877 | r#"#pragma clang lifetime_elision |
| 3878 | struct SomeStruct final { |
| 3879 | explicit SomeStruct(int i); |
| 3880 | };"#, |
| 3881 | )?; |
| 3882 | let rs_api = generate_rs_api(&ir)?; |
| 3883 | // As discussed in b/214020567 for now we only generate `From::from` bindings |
| 3884 | // for *implicit* C++ conversion constructors. |
| 3885 | assert_rs_not_matches!(rs_api, quote! {impl From}); |
| 3886 | Ok(()) |
| 3887 | } |
| 3888 | |
| 3889 | #[test] |
| 3890 | fn test_impl_from_for_implicit_conversion_constructor() -> Result<()> { |
| 3891 | let ir = ir_from_cc( |
| 3892 | r#"#pragma clang lifetime_elision |
| 3893 | struct SomeStruct final { |
| 3894 | SomeStruct(int i); // implicit - no `explicit` keyword |
| 3895 | };"#, |
| 3896 | )?; |
| 3897 | let rs_api = generate_rs_api(&ir)?; |
| 3898 | // As discussed in b/214020567 we generate `From::from` bindings for |
| 3899 | // *implicit* C++ conversion constructors. |
| 3900 | assert_rs_matches!( |
| 3901 | rs_api, |
| 3902 | quote! { |
| 3903 | impl From<i32> for SomeStruct { |
| 3904 | #[inline(always)] |
| 3905 | fn from(i: i32) -> Self { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3906 | let mut tmp = rust_std::mem::MaybeUninit::<Self>::zeroed(); |
Lukasz Anforowicz | 71716b7 | 2022-01-26 17:05:05 +0000 | [diff] [blame] | 3907 | unsafe { |
| 3908 | crate::detail::__rust_thunk___ZN10SomeStructC1Ei(&mut tmp, i); |
| 3909 | tmp.assume_init() |
| 3910 | } |
| 3911 | } |
| 3912 | } |
| 3913 | } |
| 3914 | ); |
| 3915 | Ok(()) |
| 3916 | } |
| 3917 | |
| 3918 | #[test] |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 3919 | fn test_impl_from_for_implicit_conversion_from_reference() -> Result<()> { |
| 3920 | let ir = ir_from_cc( |
| 3921 | r#"#pragma clang lifetime_elision |
| 3922 | struct SomeOtherStruct final { int i; }; |
| 3923 | struct StructUnderTest final { |
| 3924 | StructUnderTest(const SomeOtherStruct& other); // implicit - no `explicit` keyword |
| 3925 | };"#, |
| 3926 | )?; |
| 3927 | let rs_api = generate_rs_api(&ir)?; |
| 3928 | // This is a regression test for b/223800038: We want to ensure that the |
| 3929 | // code says `impl<'b>` (instead of incorrectly declaring that lifetime |
| 3930 | // in `fn from<'b>`). |
| 3931 | assert_rs_matches!( |
| 3932 | rs_api, |
| 3933 | quote! { |
| 3934 | impl<'b> From<&'b SomeOtherStruct> for StructUnderTest { |
| 3935 | #[inline(always)] |
| 3936 | fn from(other: &'b SomeOtherStruct) -> Self { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 3937 | let mut tmp = rust_std::mem::MaybeUninit::<Self>::zeroed(); |
Lukasz Anforowicz | 5e62378 | 2022-03-14 16:52:23 +0000 | [diff] [blame] | 3938 | unsafe { |
| 3939 | crate::detail::__rust_thunk___ZN15StructUnderTestC1ERK15SomeOtherStruct( |
| 3940 | &mut tmp, other); |
| 3941 | tmp.assume_init() |
| 3942 | } |
| 3943 | } |
| 3944 | } |
| 3945 | }, |
| 3946 | ); |
| 3947 | Ok(()) |
| 3948 | } |
| 3949 | |
| 3950 | #[test] |
Lukasz Anforowicz | 732ca64 | 2022-02-03 20:58:38 +0000 | [diff] [blame] | 3951 | fn test_impl_eq_for_member_function() -> Result<()> { |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 3952 | let ir = ir_from_cc( |
| 3953 | r#"#pragma clang lifetime_elision |
| 3954 | struct SomeStruct final { |
| 3955 | inline bool operator==(const SomeStruct& other) const { |
| 3956 | return i == other.i; |
| 3957 | } |
| 3958 | int i; |
| 3959 | };"#, |
| 3960 | )?; |
| 3961 | let rs_api = generate_rs_api(&ir)?; |
| 3962 | assert_rs_matches!( |
| 3963 | rs_api, |
| 3964 | quote! { |
| 3965 | impl PartialEq<SomeStruct> for SomeStruct { |
| 3966 | #[inline(always)] |
| 3967 | fn eq<'a, 'b>(&'a self, other: &'b SomeStruct) -> bool { |
| 3968 | unsafe { crate::detail::__rust_thunk___ZNK10SomeStructeqERKS_(self, other) } |
| 3969 | } |
| 3970 | } |
| 3971 | } |
| 3972 | ); |
| 3973 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 3974 | assert_cc_matches!( |
| 3975 | rs_api_impl, |
| 3976 | quote! { |
| 3977 | extern "C" bool __rust_thunk___ZNK10SomeStructeqERKS_( |
| 3978 | const class SomeStruct* __this, const class SomeStruct& other) { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 3979 | return __this->operator==(std::forward<decltype(other)>(other)); |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 3980 | } |
| 3981 | } |
| 3982 | ); |
| 3983 | Ok(()) |
| 3984 | } |
| 3985 | |
| 3986 | #[test] |
Lukasz Anforowicz | 732ca64 | 2022-02-03 20:58:38 +0000 | [diff] [blame] | 3987 | fn test_impl_eq_for_free_function() -> Result<()> { |
| 3988 | let ir = ir_from_cc( |
| 3989 | r#"#pragma clang lifetime_elision |
| 3990 | struct SomeStruct final { int i; }; |
| 3991 | bool operator==(const SomeStruct& lhs, const SomeStruct& rhs) { |
| 3992 | return lhs.i == rhs.i; |
| 3993 | }"#, |
| 3994 | )?; |
| 3995 | let rs_api = generate_rs_api(&ir)?; |
| 3996 | assert_rs_matches!( |
| 3997 | rs_api, |
| 3998 | quote! { |
| 3999 | impl PartialEq<SomeStruct> for SomeStruct { |
| 4000 | #[inline(always)] |
| 4001 | fn eq<'a, 'b>(&'a self, rhs: &'b SomeStruct) -> bool { |
| 4002 | unsafe { crate::detail::__rust_thunk___ZeqRK10SomeStructS1_(self, rhs) } |
| 4003 | } |
| 4004 | } |
| 4005 | } |
| 4006 | ); |
| 4007 | Ok(()) |
| 4008 | } |
| 4009 | |
| 4010 | #[test] |
Lukasz Anforowicz | fae90a1 | 2022-02-03 20:58:15 +0000 | [diff] [blame] | 4011 | fn test_impl_eq_non_const_member_function() -> Result<()> { |
| 4012 | let ir = ir_from_cc( |
| 4013 | r#"#pragma clang lifetime_elision |
| 4014 | struct SomeStruct final { |
| 4015 | bool operator==(const SomeStruct& other) /* no `const` here */; |
| 4016 | };"#, |
| 4017 | )?; |
| 4018 | let rs_api = generate_rs_api(&ir)?; |
| 4019 | assert_rs_not_matches!(rs_api, quote! {impl PartialEq}); |
| 4020 | Ok(()) |
| 4021 | } |
| 4022 | |
| 4023 | #[test] |
| 4024 | fn test_impl_eq_rhs_by_value() -> Result<()> { |
| 4025 | let ir = ir_from_cc( |
| 4026 | r#"#pragma clang lifetime_elision |
| 4027 | struct SomeStruct final { |
| 4028 | bool operator==(SomeStruct other) const; |
| 4029 | };"#, |
| 4030 | )?; |
| 4031 | let rs_api = generate_rs_api(&ir)?; |
| 4032 | assert_rs_not_matches!(rs_api, quote! {impl PartialEq}); |
| 4033 | Ok(()) |
| 4034 | } |
| 4035 | |
| 4036 | #[test] |
Dmitri Gribenko | 67cbfd2 | 2022-03-24 13:39:34 +0000 | [diff] [blame] | 4037 | fn test_thunk_ident_function() -> Result<()> { |
| 4038 | let ir = ir_from_cc("inline int foo() {}")?; |
| 4039 | let func = retrieve_func(&ir, "foo"); |
| 4040 | assert_eq!(thunk_ident(func), make_rs_ident("__rust_thunk___Z3foov")); |
| 4041 | Ok(()) |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 4042 | } |
| 4043 | |
| 4044 | #[test] |
| 4045 | fn test_thunk_ident_special_names() { |
Marcel Hlopko | 4b13b96 | 2021-12-06 12:40:56 +0000 | [diff] [blame] | 4046 | let ir = ir_from_cc("struct Class {};").unwrap(); |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 4047 | |
Googler | 45ad275 | 2021-12-06 12:12:35 +0000 | [diff] [blame] | 4048 | let destructor = |
| 4049 | ir.functions().find(|f| f.name == UnqualifiedIdentifier::Destructor).unwrap(); |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 4050 | assert_eq!(thunk_ident(destructor), make_rs_ident("__rust_thunk___ZN5ClassD1Ev")); |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 4051 | |
Lukasz Anforowicz | 49b5bbc | 2022-02-04 23:40:10 +0000 | [diff] [blame] | 4052 | let default_constructor = ir |
| 4053 | .functions() |
| 4054 | .find(|f| f.name == UnqualifiedIdentifier::Constructor && f.params.len() == 1) |
| 4055 | .unwrap(); |
Lukasz Anforowicz | dd9ae0f | 2022-02-17 15:52:53 +0000 | [diff] [blame] | 4056 | assert_eq!(thunk_ident(default_constructor), make_rs_ident("__rust_thunk___ZN5ClassC1Ev")); |
Devin Jeanpierre | 45cb116 | 2021-10-27 10:54:28 +0000 | [diff] [blame] | 4057 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 4058 | |
| 4059 | #[test] |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 4060 | fn test_elided_lifetimes() -> Result<()> { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 4061 | let ir = ir_from_cc( |
| 4062 | r#"#pragma clang lifetime_elision |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 4063 | struct S final { |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 4064 | int& f(int& i); |
| 4065 | };"#, |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 4066 | )?; |
| 4067 | let rs_api = generate_rs_api(&ir)?; |
| 4068 | assert_rs_matches!( |
| 4069 | rs_api, |
| 4070 | quote! { |
Lukasz Anforowicz | 231a3bb | 2022-01-12 14:05:59 +0000 | [diff] [blame] | 4071 | pub fn f<'a, 'b>(&'a mut self, i: &'b mut i32) -> &'a mut i32 { ... } |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 4072 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 4073 | ); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 4074 | assert_rs_matches!( |
| 4075 | rs_api, |
| 4076 | quote! { |
Googler | 6804a01 | 2022-01-05 07:04:36 +0000 | [diff] [blame] | 4077 | pub(crate) fn __rust_thunk___ZN1S1fERi<'a, 'b>(__this: &'a mut S, i: &'b mut i32) |
| 4078 | -> &'a mut i32; |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 4079 | } |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 4080 | ); |
Marcel Hlopko | 8954775 | 2021-12-10 09:39:41 +0000 | [diff] [blame] | 4081 | Ok(()) |
Googler | 7cced42 | 2021-12-06 11:58:39 +0000 | [diff] [blame] | 4082 | } |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 4083 | |
| 4084 | #[test] |
Googler | 386e594 | 2022-02-24 08:53:29 +0000 | [diff] [blame] | 4085 | fn test_annotated_lifetimes() -> Result<()> { |
| 4086 | let ir = ir_from_cc( |
| 4087 | r#"[[clang::annotate("lifetimes", "a, a -> a")]] |
| 4088 | int& f(int& i1, int& i2); |
| 4089 | "#, |
| 4090 | )?; |
| 4091 | let rs_api = generate_rs_api(&ir)?; |
| 4092 | assert_rs_matches!( |
| 4093 | rs_api, |
| 4094 | quote! { |
| 4095 | pub fn f<'a>(i1: &'a mut i32, i2: &'a mut i32) -> &'a mut i32 { ... } |
| 4096 | } |
| 4097 | ); |
| 4098 | assert_rs_matches!( |
| 4099 | rs_api, |
| 4100 | quote! { |
| 4101 | pub(crate) fn __rust_thunk___Z1fRiS_<'a>(i1: &'a mut i32, i2: &'a mut i32) |
| 4102 | -> &'a mut i32; |
| 4103 | } |
| 4104 | ); |
| 4105 | Ok(()) |
| 4106 | } |
| 4107 | |
| 4108 | #[test] |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 4109 | fn test_format_generic_params() -> Result<()> { |
| 4110 | assert_rs_matches!(format_generic_params(std::iter::empty::<syn::Ident>()), quote! {}); |
| 4111 | |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 4112 | let idents = ["T1", "T2"].iter().map(|s| make_rs_ident(s)); |
Lukasz Anforowicz | daff040 | 2021-12-23 00:37:50 +0000 | [diff] [blame] | 4113 | assert_rs_matches!(format_generic_params(idents), quote! { < T1, T2 > }); |
| 4114 | |
| 4115 | let lifetimes = ["a", "b"] |
| 4116 | .iter() |
| 4117 | .map(|s| syn::Lifetime::new(&format!("'{}", s), proc_macro2::Span::call_site())); |
| 4118 | assert_rs_matches!(format_generic_params(lifetimes), quote! { < 'a, 'b > }); |
| 4119 | |
| 4120 | Ok(()) |
| 4121 | } |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 4122 | |
| 4123 | #[test] |
| 4124 | fn test_overloaded_functions() -> Result<()> { |
| 4125 | // TODO(b/213280424): We don't support creating bindings for overloaded |
| 4126 | // functions yet, except in the case of overloaded constructors with a |
| 4127 | // single parameter. |
| 4128 | let ir = ir_from_cc( |
Lukasz Anforowicz | 55673c9 | 2022-01-27 19:37:26 +0000 | [diff] [blame] | 4129 | r#" #pragma clang lifetime_elision |
| 4130 | void f(); |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 4131 | void f(int i); |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 4132 | struct S1 final { |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 4133 | void f(); |
| 4134 | void f(int i); |
| 4135 | }; |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 4136 | struct S2 final { |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 4137 | void f(); |
| 4138 | }; |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 4139 | struct S3 final { |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 4140 | S3(int i); |
| 4141 | S3(double d); |
| 4142 | }; |
| 4143 | "#, |
| 4144 | )?; |
| 4145 | let rs_api = generate_rs_api(&ir)?; |
| 4146 | let rs_api_str = tokens_to_string(rs_api.clone())?; |
| 4147 | |
| 4148 | // Cannot overload free functions. |
| 4149 | assert!(rs_api_str.contains("Error while generating bindings for item 'f'")); |
| 4150 | assert_rs_not_matches!(rs_api, quote! {pub fn f()}); |
| 4151 | assert_rs_not_matches!(rs_api, quote! {pub fn f(i: i32)}); |
| 4152 | |
| 4153 | // Cannot overload member functions. |
| 4154 | assert!(rs_api_str.contains("Error while generating bindings for item 'S1::f'")); |
| 4155 | assert_rs_not_matches!(rs_api, quote! {pub fn f(... S1 ...)}); |
| 4156 | |
| 4157 | // But we can import member functions that have the same name as a free |
| 4158 | // function. |
Lukasz Anforowicz | 55673c9 | 2022-01-27 19:37:26 +0000 | [diff] [blame] | 4159 | assert_rs_matches!(rs_api, quote! {pub fn f<'a>(&'a mut self)}); |
Googler | d03d05b | 2022-01-07 10:10:57 +0000 | [diff] [blame] | 4160 | |
| 4161 | // We can also import overloaded single-parameter constructors. |
| 4162 | assert_rs_matches!(rs_api, quote! {impl From<i32> for S3}); |
| 4163 | assert_rs_matches!(rs_api, quote! {impl From<f64> for S3}); |
| 4164 | Ok(()) |
| 4165 | } |
Googler | dcca7f7 | 2022-01-10 12:30:43 +0000 | [diff] [blame] | 4166 | |
| 4167 | #[test] |
| 4168 | fn test_type_alias() -> Result<()> { |
| 4169 | let ir = ir_from_cc( |
| 4170 | r#" |
Lukasz Anforowicz | c503af4 | 2022-03-04 23:18:15 +0000 | [diff] [blame] | 4171 | // MyTypedefDecl doc comment |
Googler | dcca7f7 | 2022-01-10 12:30:43 +0000 | [diff] [blame] | 4172 | typedef int MyTypedefDecl; |
Lukasz Anforowicz | c503af4 | 2022-03-04 23:18:15 +0000 | [diff] [blame] | 4173 | |
Googler | dcca7f7 | 2022-01-10 12:30:43 +0000 | [diff] [blame] | 4174 | using MyTypeAliasDecl = int; |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 4175 | using MyTypeAliasDecl_Alias = MyTypeAliasDecl; |
| 4176 | |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 4177 | struct S final {}; |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 4178 | using S_Alias = S; |
| 4179 | using S_Alias_Alias = S_Alias; |
| 4180 | |
| 4181 | inline void f(MyTypedefDecl t) {} |
Googler | dcca7f7 | 2022-01-10 12:30:43 +0000 | [diff] [blame] | 4182 | "#, |
| 4183 | )?; |
| 4184 | let rs_api = generate_rs_api(&ir)?; |
Lukasz Anforowicz | c503af4 | 2022-03-04 23:18:15 +0000 | [diff] [blame] | 4185 | assert_rs_matches!( |
| 4186 | rs_api, |
| 4187 | quote! { |
| 4188 | #[doc = " MyTypedefDecl doc comment"] |
| 4189 | pub type MyTypedefDecl = i32; |
| 4190 | } |
| 4191 | ); |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 4192 | assert_rs_matches!(rs_api, quote! { pub type MyTypeAliasDecl = i32; }); |
| 4193 | assert_rs_matches!(rs_api, quote! { pub type MyTypeAliasDecl_Alias = MyTypeAliasDecl; }); |
| 4194 | assert_rs_matches!(rs_api, quote! { pub type S_Alias = S; }); |
| 4195 | assert_rs_matches!(rs_api, quote! { pub type S_Alias_Alias = S_Alias; }); |
| 4196 | assert_rs_matches!(rs_api, quote! { pub fn f(t: MyTypedefDecl) }); |
| 4197 | assert_cc_matches!( |
| 4198 | generate_rs_api_impl(&ir)?, |
| 4199 | quote! { |
Devin Jeanpierre | deea789 | 2022-03-29 02:13:31 -0700 | [diff] [blame] | 4200 | extern "C" void __rust_thunk___Z1fi(MyTypedefDecl t){ f (std::forward<decltype(t)>(t)) ; } |
Googler | 6a0a525 | 2022-01-11 14:08:09 +0000 | [diff] [blame] | 4201 | } |
| 4202 | ); |
Googler | dcca7f7 | 2022-01-10 12:30:43 +0000 | [diff] [blame] | 4203 | Ok(()) |
| 4204 | } |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4205 | |
| 4206 | #[test] |
| 4207 | fn test_rs_type_kind_implements_copy() -> Result<()> { |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4208 | let template = r#" LIFETIMES |
Devin Jeanpierre | 88343c7 | 2022-01-15 01:10:23 +0000 | [diff] [blame] | 4209 | struct [[clang::trivial_abi]] TrivialStruct final { int i; }; |
| 4210 | struct [[clang::trivial_abi]] UserDefinedCopyConstructor final { |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4211 | UserDefinedCopyConstructor(const UserDefinedCopyConstructor&); |
| 4212 | }; |
| 4213 | using IntAlias = int; |
| 4214 | using TrivialAlias = TrivialStruct; |
| 4215 | using NonTrivialAlias = UserDefinedCopyConstructor; |
| 4216 | void func(PARAM_TYPE some_param); |
| 4217 | "#; |
| 4218 | assert_impl_all!(i32: Copy); |
| 4219 | assert_impl_all!(&i32: Copy); |
| 4220 | assert_not_impl_all!(&mut i32: Copy); |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4221 | assert_impl_all!(Option<&i32>: Copy); |
| 4222 | assert_not_impl_all!(Option<&mut i32>: Copy); |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4223 | assert_impl_all!(*const i32: Copy); |
| 4224 | assert_impl_all!(*mut i32: Copy); |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4225 | struct Test { |
| 4226 | // Test inputs: |
| 4227 | cc: &'static str, |
| 4228 | lifetimes: bool, |
| 4229 | // Expected test outputs: |
| 4230 | rs: &'static str, |
| 4231 | is_copy: bool, |
| 4232 | } |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4233 | let tests = vec![ |
| 4234 | // Validity of the next few tests is verified via |
| 4235 | // `assert_[not_]impl_all!` static assertions above. |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4236 | Test { cc: "int", lifetimes: true, rs: "i32", is_copy: true }, |
| 4237 | Test { cc: "const int&", lifetimes: true, rs: "&'a i32", is_copy: true }, |
| 4238 | Test { cc: "int&", lifetimes: true, rs: "&'a mut i32", is_copy: false }, |
| 4239 | Test { cc: "const int*", lifetimes: true, rs: "Option<&'a i32>", is_copy: true }, |
| 4240 | Test { cc: "int*", lifetimes: true, rs: "Option<&'a mut i32>", is_copy: false }, |
| 4241 | Test { cc: "const int*", lifetimes: false, rs: "*const i32", is_copy: true }, |
| 4242 | Test { cc: "int*", lifetimes: false, rs: "*mut i32", is_copy: true }, |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4243 | // Tests below have been thought-through and verified "manually". |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4244 | // TrivialStruct is expected to derive Copy. |
| 4245 | Test { cc: "TrivialStruct", lifetimes: true, rs: "TrivialStruct", is_copy: true }, |
| 4246 | Test { |
| 4247 | cc: "UserDefinedCopyConstructor", |
| 4248 | lifetimes: true, |
| 4249 | rs: "UserDefinedCopyConstructor", |
| 4250 | is_copy: false, |
| 4251 | }, |
| 4252 | Test { cc: "IntAlias", lifetimes: true, rs: "IntAlias", is_copy: true }, |
| 4253 | Test { cc: "TrivialAlias", lifetimes: true, rs: "TrivialAlias", is_copy: true }, |
| 4254 | Test { cc: "NonTrivialAlias", lifetimes: true, rs: "NonTrivialAlias", is_copy: false }, |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4255 | ]; |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4256 | for test in tests.iter() { |
| 4257 | let test_name = format!("cc='{}', lifetimes={}", test.cc, test.lifetimes); |
| 4258 | let cc_input = template.replace("PARAM_TYPE", test.cc).replace( |
| 4259 | "LIFETIMES", |
| 4260 | if test.lifetimes { "#pragma clang lifetime_elision" } else { "" }, |
| 4261 | ); |
| 4262 | let ir = ir_from_cc(&cc_input)?; |
Lukasz Anforowicz | 9c663ca | 2022-02-09 01:33:31 +0000 | [diff] [blame] | 4263 | let f = retrieve_func(&ir, "func"); |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4264 | let t = RsTypeKind::new(&f.params[0].type_.rs_type, &ir)?; |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4265 | |
Devin Jeanpierre | 92ca261 | 2022-04-06 11:35:13 -0700 | [diff] [blame] | 4266 | let fmt = tokens_to_string(t.to_token_stream())?; |
Lukasz Anforowicz | 20651e3 | 2022-02-10 14:52:15 +0000 | [diff] [blame] | 4267 | assert_eq!(test.rs, fmt, "Testing: {}", test_name); |
| 4268 | |
| 4269 | assert_eq!(test.is_copy, t.implements_copy(), "Testing: {}", test_name); |
Lukasz Anforowicz | e57215c | 2022-01-12 14:54:16 +0000 | [diff] [blame] | 4270 | } |
| 4271 | Ok(()) |
| 4272 | } |
Lukasz Anforowicz | a94ab70 | 2022-01-14 22:40:25 +0000 | [diff] [blame] | 4273 | |
| 4274 | #[test] |
| 4275 | fn test_rs_type_kind_is_shared_ref_to_with_lifetimes() -> Result<()> { |
| 4276 | let ir = ir_from_cc( |
| 4277 | "#pragma clang lifetime_elision |
| 4278 | struct SomeStruct {}; |
| 4279 | void foo(const SomeStruct& foo_param); |
| 4280 | void bar(SomeStruct& bar_param);", |
| 4281 | )?; |
| 4282 | let record = ir.records().next().unwrap(); |
Lukasz Anforowicz | 9c663ca | 2022-02-09 01:33:31 +0000 | [diff] [blame] | 4283 | let foo_func = retrieve_func(&ir, "foo"); |
| 4284 | let bar_func = retrieve_func(&ir, "bar"); |
Lukasz Anforowicz | a94ab70 | 2022-01-14 22:40:25 +0000 | [diff] [blame] | 4285 | |
| 4286 | // const-ref + lifetimes in C++ ===> shared-ref in Rust |
| 4287 | assert_eq!(foo_func.params.len(), 1); |
| 4288 | let foo_param = &foo_func.params[0]; |
| 4289 | assert_eq!(&foo_param.identifier.identifier, "foo_param"); |
| 4290 | let foo_type = RsTypeKind::new(&foo_param.type_.rs_type, &ir)?; |
| 4291 | assert!(foo_type.is_shared_ref_to(record)); |
| 4292 | assert!(matches!(foo_type, RsTypeKind::Reference { mutability: Mutability::Const, .. })); |
| 4293 | |
| 4294 | // non-const-ref + lifetimes in C++ ===> mutable-ref in Rust |
| 4295 | assert_eq!(bar_func.params.len(), 1); |
| 4296 | let bar_param = &bar_func.params[0]; |
| 4297 | assert_eq!(&bar_param.identifier.identifier, "bar_param"); |
| 4298 | let bar_type = RsTypeKind::new(&bar_param.type_.rs_type, &ir)?; |
| 4299 | assert!(!bar_type.is_shared_ref_to(record)); |
| 4300 | assert!(matches!(bar_type, RsTypeKind::Reference { mutability: Mutability::Mut, .. })); |
| 4301 | |
| 4302 | Ok(()) |
| 4303 | } |
| 4304 | |
| 4305 | #[test] |
| 4306 | fn test_rs_type_kind_is_shared_ref_to_without_lifetimes() -> Result<()> { |
| 4307 | let ir = ir_from_cc( |
| 4308 | "struct SomeStruct {}; |
| 4309 | void foo(const SomeStruct& foo_param);", |
| 4310 | )?; |
| 4311 | let record = ir.records().next().unwrap(); |
Lukasz Anforowicz | 9c663ca | 2022-02-09 01:33:31 +0000 | [diff] [blame] | 4312 | let foo_func = retrieve_func(&ir, "foo"); |
Lukasz Anforowicz | a94ab70 | 2022-01-14 22:40:25 +0000 | [diff] [blame] | 4313 | |
| 4314 | // const-ref + *no* lifetimes in C++ ===> const-pointer in Rust |
| 4315 | assert_eq!(foo_func.params.len(), 1); |
| 4316 | let foo_param = &foo_func.params[0]; |
| 4317 | assert_eq!(&foo_param.identifier.identifier, "foo_param"); |
| 4318 | let foo_type = RsTypeKind::new(&foo_param.type_.rs_type, &ir)?; |
| 4319 | assert!(!foo_type.is_shared_ref_to(record)); |
| 4320 | assert!(matches!(foo_type, RsTypeKind::Pointer { mutability: Mutability::Const, .. })); |
| 4321 | |
| 4322 | Ok(()) |
| 4323 | } |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 4324 | |
| 4325 | #[test] |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 4326 | fn test_rs_type_kind_dfs_iter_ordering() { |
| 4327 | // Set up a test input representing: A<B<C>, D<E>>. |
| 4328 | let a = { |
| 4329 | let b = { |
| 4330 | let c = RsTypeKind::Other { name: "C", type_args: vec![] }; |
| 4331 | RsTypeKind::Other { name: "B", type_args: vec![c] } |
| 4332 | }; |
| 4333 | let d = { |
| 4334 | let e = RsTypeKind::Other { name: "E", type_args: vec![] }; |
| 4335 | RsTypeKind::Other { name: "D", type_args: vec![e] } |
| 4336 | }; |
| 4337 | RsTypeKind::Other { name: "A", type_args: vec![b, d] } |
| 4338 | }; |
| 4339 | let dfs_names = a |
| 4340 | .dfs_iter() |
| 4341 | .map(|t| match t { |
| 4342 | RsTypeKind::Other { name, .. } => *name, |
| 4343 | _ => unreachable!("Only 'other' types are used in this test"), |
| 4344 | }) |
| 4345 | .collect_vec(); |
| 4346 | assert_eq!(vec!["A", "B", "C", "D", "E"], dfs_names); |
| 4347 | } |
| 4348 | |
| 4349 | #[test] |
Lukasz Anforowicz | cf230fd | 2022-02-18 19:20:39 +0000 | [diff] [blame] | 4350 | fn test_rs_type_kind_dfs_iter_ordering_for_func_ptr() { |
| 4351 | // Set up a test input representing: fn(A, B) -> C |
| 4352 | let f = { |
| 4353 | let a = RsTypeKind::Other { name: "A", type_args: vec![] }; |
| 4354 | let b = RsTypeKind::Other { name: "B", type_args: vec![] }; |
| 4355 | let c = RsTypeKind::Other { name: "C", type_args: vec![] }; |
| 4356 | RsTypeKind::FuncPtr { abi: "blah", param_types: vec![a, b], return_type: Box::new(c) } |
| 4357 | }; |
| 4358 | let dfs_names = f |
| 4359 | .dfs_iter() |
| 4360 | .map(|t| match t { |
| 4361 | RsTypeKind::FuncPtr { .. } => "fn", |
| 4362 | RsTypeKind::Other { name, .. } => *name, |
| 4363 | _ => unreachable!("Only FuncPtr and Other kinds are used in this test"), |
| 4364 | }) |
| 4365 | .collect_vec(); |
| 4366 | assert_eq!(vec!["fn", "A", "B", "C"], dfs_names); |
| 4367 | } |
| 4368 | |
| 4369 | #[test] |
Lukasz Anforowicz | 90bdb96 | 2022-02-14 21:07:45 +0000 | [diff] [blame] | 4370 | fn test_rs_type_kind_lifetimes() -> Result<()> { |
| 4371 | let ir = ir_from_cc( |
| 4372 | r#" |
| 4373 | #pragma clang lifetime_elision |
| 4374 | using TypeAlias = int&; |
| 4375 | struct SomeStruct {}; |
| 4376 | void foo(int a, int& b, int* c, int** d, TypeAlias e, SomeStruct f); "#, |
| 4377 | )?; |
| 4378 | let f = retrieve_func(&ir, "foo"); |
| 4379 | let ret = RsTypeKind::new(&f.return_type.rs_type, &ir)?; |
| 4380 | let a = RsTypeKind::new(&f.params[0].type_.rs_type, &ir)?; |
| 4381 | let b = RsTypeKind::new(&f.params[1].type_.rs_type, &ir)?; |
| 4382 | let c = RsTypeKind::new(&f.params[2].type_.rs_type, &ir)?; |
| 4383 | let d = RsTypeKind::new(&f.params[3].type_.rs_type, &ir)?; |
| 4384 | let e = RsTypeKind::new(&f.params[4].type_.rs_type, &ir)?; |
| 4385 | let f = RsTypeKind::new(&f.params[5].type_.rs_type, &ir)?; |
| 4386 | |
| 4387 | assert_eq!(0, ret.lifetimes().count()); // No lifetimes on `void`. |
| 4388 | assert_eq!(0, a.lifetimes().count()); // No lifetimes on `int`. |
| 4389 | assert_eq!(1, b.lifetimes().count()); // `&'a i32` has a single lifetime. |
| 4390 | assert_eq!(1, c.lifetimes().count()); // `Option<&'b i32>` has a single lifetime. |
| 4391 | assert_eq!(2, d.lifetimes().count()); // `&'c Option<&'d i32>` has two lifetimes. |
| 4392 | assert_eq!(1, e.lifetimes().count()); // Lifetime of underlying type should show through. |
| 4393 | assert_eq!(0, f.lifetimes().count()); // No lifetimes on structs (yet). |
| 4394 | Ok(()) |
| 4395 | } |
| 4396 | |
| 4397 | #[test] |
| 4398 | fn test_rs_type_kind_lifetimes_raw_ptr() -> Result<()> { |
| 4399 | let ir = ir_from_cc("void foo(int* a);")?; |
| 4400 | let f = retrieve_func(&ir, "foo"); |
| 4401 | let a = RsTypeKind::new(&f.params[0].type_.rs_type, &ir)?; |
| 4402 | assert_eq!(0, a.lifetimes().count()); // No lifetimes on `int*`. |
| 4403 | Ok(()) |
| 4404 | } |
| 4405 | |
| 4406 | #[test] |
Marcel Hlopko | eaae9b7 | 2022-01-21 15:54:11 +0000 | [diff] [blame] | 4407 | fn test_rust_keywords_are_escaped_in_rs_api_file() -> Result<()> { |
| 4408 | let ir = ir_from_cc("struct type { int dyn; };")?; |
| 4409 | let rs_api = generate_rs_api(&ir)?; |
| 4410 | assert_rs_matches!(rs_api, quote! { struct r#type { ... r#dyn: i32 ... } }); |
| 4411 | Ok(()) |
| 4412 | } |
| 4413 | |
| 4414 | #[test] |
| 4415 | fn test_rust_keywords_are_not_escaped_in_rs_api_impl_file() -> Result<()> { |
| 4416 | let ir = ir_from_cc("struct type { int dyn; };")?; |
| 4417 | let rs_api_impl = generate_rs_api_impl(&ir)?; |
| 4418 | assert_cc_matches!(rs_api_impl, quote! { static_assert(offsetof(class type, dyn) ... ) }); |
| 4419 | Ok(()) |
| 4420 | } |
Marcel Hlopko | 14ee3c8 | 2022-02-09 09:46:23 +0000 | [diff] [blame] | 4421 | |
| 4422 | #[test] |
| 4423 | fn test_no_aligned_attr() { |
| 4424 | let ir = ir_from_cc("struct SomeStruct {};").unwrap(); |
| 4425 | let rs_api = generate_rs_api(&ir).unwrap(); |
| 4426 | |
| 4427 | assert_rs_matches! {rs_api, quote! { |
| 4428 | #[repr(C)] |
| 4429 | pub struct SomeStruct { ... } |
| 4430 | }}; |
| 4431 | } |
| 4432 | |
| 4433 | #[test] |
| 4434 | fn test_aligned_attr() { |
| 4435 | let ir = ir_from_cc("struct SomeStruct {} __attribute__((aligned(64)));").unwrap(); |
| 4436 | let rs_api = generate_rs_api(&ir).unwrap(); |
| 4437 | |
| 4438 | assert_rs_matches! {rs_api, quote! { |
| 4439 | #[repr(C, align(64))] |
| 4440 | pub struct SomeStruct { ... } |
| 4441 | } |
| 4442 | }; |
| 4443 | } |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 4444 | |
| 4445 | /// !Unpin references should not be pinned. |
| 4446 | #[test] |
| 4447 | fn test_nonunpin_ref_param() -> Result<()> { |
| 4448 | let rs_api_impl = generate_rs_api(&ir_from_cc( |
| 4449 | r#" |
| 4450 | #pragma clang lifetime_elision |
| 4451 | struct S {~S();}; |
| 4452 | void Function(const S& s); |
| 4453 | "#, |
| 4454 | )?)?; |
| 4455 | assert_rs_matches!( |
| 4456 | rs_api_impl, |
| 4457 | quote! { |
| 4458 | fn Function<'a>(s: &'a S) { ... } |
| 4459 | } |
| 4460 | ); |
| 4461 | Ok(()) |
| 4462 | } |
| 4463 | |
| 4464 | /// !Unpin mut references must be pinned. |
| 4465 | #[test] |
| 4466 | fn test_nonunpin_mut_param() -> Result<()> { |
| 4467 | let rs_api_impl = generate_rs_api(&ir_from_cc( |
| 4468 | r#" |
| 4469 | #pragma clang lifetime_elision |
| 4470 | struct S {~S();}; |
| 4471 | void Function(S& s); |
| 4472 | "#, |
| 4473 | )?)?; |
| 4474 | assert_rs_matches!( |
| 4475 | rs_api_impl, |
| 4476 | quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 4477 | fn Function<'a>(s: rust_std::pin::Pin<&'a mut S>) { ... } |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 4478 | } |
| 4479 | ); |
| 4480 | Ok(()) |
| 4481 | } |
| 4482 | |
| 4483 | /// !Unpin &self should not be pinned. |
| 4484 | #[test] |
| 4485 | fn test_nonunpin_ref_self() -> Result<()> { |
| 4486 | let rs_api_impl = generate_rs_api(&ir_from_cc( |
| 4487 | r#" |
| 4488 | #pragma clang lifetime_elision |
| 4489 | struct S { |
| 4490 | ~S(); |
| 4491 | void Function() const; |
| 4492 | }; |
| 4493 | "#, |
| 4494 | )?)?; |
| 4495 | assert_rs_matches!( |
| 4496 | rs_api_impl, |
| 4497 | quote! { |
| 4498 | fn Function<'a>(&'a self) { ... } |
| 4499 | } |
| 4500 | ); |
| 4501 | Ok(()) |
| 4502 | } |
| 4503 | |
| 4504 | /// !Unpin &mut self must be pinned. |
| 4505 | #[test] |
| 4506 | fn test_nonunpin_mut_self() -> Result<()> { |
| 4507 | let rs_api_impl = generate_rs_api(&ir_from_cc( |
| 4508 | r#" |
| 4509 | #pragma clang lifetime_elision |
| 4510 | struct S { |
| 4511 | ~S(); |
| 4512 | void Function(); |
| 4513 | }; |
| 4514 | "#, |
| 4515 | )?)?; |
| 4516 | assert_rs_matches!( |
| 4517 | rs_api_impl, |
| 4518 | quote! { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 4519 | fn Function<'a>(self: rust_std::pin::Pin<&'a mut Self>) { ... } |
Devin Jeanpierre | 149950d | 2022-02-22 21:02:02 +0000 | [diff] [blame] | 4520 | } |
| 4521 | ); |
| 4522 | Ok(()) |
| 4523 | } |
| 4524 | |
| 4525 | /// Drop::drop must not use self : Pin<...>. |
| 4526 | #[test] |
| 4527 | fn test_nonunpin_drop() -> Result<()> { |
| 4528 | let rs_api_impl = generate_rs_api(&ir_from_cc( |
| 4529 | r#" |
| 4530 | struct S {~S();}; |
| 4531 | "#, |
| 4532 | )?)?; |
| 4533 | assert_rs_matches!( |
| 4534 | rs_api_impl, |
| 4535 | quote! { |
| 4536 | fn drop(&mut self) { ... } |
| 4537 | } |
| 4538 | ); |
| 4539 | Ok(()) |
| 4540 | } |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 4541 | |
| 4542 | #[test] |
| 4543 | fn test_nonunpin_one_arg_constructor() -> Result<()> { |
| 4544 | let ir = ir_from_cc( |
| 4545 | r#"#pragma clang lifetime_elision |
| 4546 | // This type must be `!Unpin`. |
| 4547 | struct HasConstructor {explicit HasConstructor(unsigned char input) {}};"#, |
| 4548 | )?; |
| 4549 | let rs_api = generate_rs_api(&ir)?; |
| 4550 | assert_rs_matches!(rs_api, quote! {impl !Unpin for HasConstructor {} }); |
| 4551 | assert_rs_matches!( |
| 4552 | rs_api, |
| 4553 | quote! { |
| 4554 | impl ctor::CtorNew<u8> for HasConstructor { |
| 4555 | type CtorType = impl ctor::Ctor<Output = Self>; |
| 4556 | |
| 4557 | #[inline (always)] |
| 4558 | fn ctor_new(input: u8) -> Self::CtorType { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 4559 | ctor::FnCtor::new(move |dest: rust_std::pin::Pin<&mut rust_std::mem::MaybeUninit<Self>>| { |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 4560 | unsafe { |
Rosica Dejanovska | accf00b | 2022-04-01 13:28:04 -0700 | [diff] [blame] | 4561 | crate::detail::__rust_thunk___ZN14HasConstructorC1Eh(rust_std::pin::Pin::into_inner_unchecked(dest), input); |
Devin Jeanpierre | 6f60737 | 2022-03-22 21:34:38 +0000 | [diff] [blame] | 4562 | } |
| 4563 | }) |
| 4564 | } |
| 4565 | } |
| 4566 | } |
| 4567 | ); |
| 4568 | Ok(()) |
| 4569 | } |
Marcel Hlopko | 42abfc8 | 2021-08-09 07:03:17 +0000 | [diff] [blame] | 4570 | } |